From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754936Ab2FSUHc (ORCPT ); Tue, 19 Jun 2012 16:07:32 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:42068 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754902Ab2FSUHb convert rfc822-to-8bit (ORCPT ); Tue, 19 Jun 2012 16:07:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <201204072316.q37NGv8d019280@farm-0023.internal.tilera.com> <201204072319.q37NJlNp019384@farm-0023.internal.tilera.com> Date: Tue, 19 Jun 2012 13:07:30 -0700 X-Google-Sender-Auth: T9hdaZd3oEXczCcWJKjlyvTduSg Message-ID: Subject: Re: [PATCH 3/3] arch/tile: tilegx PCI root complex support From: Yinghai Lu To: Geert Uytterhoeven Cc: Chris Metcalf , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Jesse Barnes , "Michael S. Tsirkin" , Myron Stowe , Arnd Bergmann , Jiri Kosina , Joe Perches , David Howells Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2012 at 12:50 PM, Geert Uytterhoeven wrote: > Hi Chris, > > On Sat, Apr 7, 2012 at 11:10 PM, Chris Metcalf wrote: >> This change implements PCIe root complex support for tilegx using >> the kernel support layer for accessing the TRIO hardware shim. > >> --- /dev/null >> +++ b/arch/tile/kernel/pci_gx.c > >> +               bus = pci_scan_bus(0, controller->ops, controller); >> +               controller->root_bus = bus; >> +               controller->last_busno = bus->subordinate; > > As of commit 3527ed81ca01bbaf09df952e68528377a9cd092f > ("PCI: remove secondary/subordinate in struct pci_bus") in linux-next, the > "subordinate" field no longer exists: > > http://kisskb.ellerman.id.au/kisskb/buildresult/6546355/ > arch/tile/kernel/pci_gx.c:852:31: error: 'struct pci_bus' has no > member named 'subordinate' > make[3]: *** [arch/tile/kernel/pci_gx.o] Error 1 could changed to be contoller->last_busno = bus->busn.end; Thanks Yinghai