All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	srikar@linux.vnet.ibm.com, Thomas Gleixner <tglx@linutronix.de>,
	"linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:sched/urgent] sched: Check sched_domain before computing group power
Date: Thu, 21 Nov 2013 14:03:13 -0800	[thread overview]
Message-ID: <CAE9FiQUCPvzeiCSan34aV6hfrDHdV=sfHug0tMaAgpOMbum7jw@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQUHQ7jQfpxi+s7yeef17-+ApGjU2X1iRnm=azJ0+BFWZw@mail.gmail.com>

On Thu, Nov 21, 2013 at 9:22 AM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Thu, Nov 21, 2013 at 7:03 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>>>
>>> This one seems fix NULL reference in compute_group_power.
>>>
>>> but get following on current Linus tree plus tip/sched/urgent.
>>>
>>> divide error: 0000 [#1]  SMP
>>> [   28.190477] Modules linked in:
>>> [   28.192012] CPU: 11 PID: 484 Comm: kworker/u324:0 Not tainted
>>> 3.12.0-yh-10487-g4b94e59-dirty #2044
>>> [   28.210488] Hardware name: Oracle Corporation  Sun Fire
>>> [   28.229877] task: ffff88ff25205140 ti: ffff88ff2520a000 task.ti:
>>> ffff88ff2520a000
>>> [   28.236139] RIP: 0010:[<ffffffff810d9ff4>]  [<ffffffff810d9ff4>]
>>> find_busiest_group+0x2b4/0x8a0
>>
>> Hurmph.. what kind of hardware is that? and is there anything funny you
>> do to make it do this?
>
> intel nehanem-ex or westmere-ex 8 sockets system.
>
> I tried without my local patches, the problem is still there.

original one in linus's tree:

[    8.952728] NMI watchdog: enabled on all CPUs, permanently consumes
one hw-PMU counter.
[    8.965697] BUG: unable to handle kernel NULL pointer dereference
at 0000000000000010
[    8.969495] IP: [<ffffffff810d7b53>] update_group_power+0x1d3/0x250
[    8.987159] PGD 0
[    8.989280] Oops: 0000 [#1] SMP
[    8.991686] Modules linked in:
[    8.993803] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
3.12.0-yh-02845-g527d151 #2048
[    9.009175] Hardware name: Oracle Corporation  Sun Fire X4800 M2 /
   , BIOS 15013200    04/19/2012
[    9.028433] task: ffff883f24e28000 ti: ffff883f24e24000 task.ti:
ffff883f24e24000
[    9.033249] RIP: 0010:[<ffffffff810d7b53>]  [<ffffffff810d7b53>]
update_group_power+0x1d3/0x250
[    9.051193] RSP: 0000:ffff883f24e25d68  EFLAGS: 00010283
[    9.068162] RAX: 0000000000000001 RBX: 0000000000000000 RCX: 0000000000000000
[    9.071838] RDX: 0000000000000000 RSI: 00000000000000a0 RDI: 00000000000000a0
[    9.090260] RBP: ffff883f24e25d98 R08: ffff88ffc4891020 R09: 0000000000000000
[    9.107870] R10: ffff88ffc4890818 R11: 0000000000000001 R12: 00000000001d40c0
[    9.111527] R13: ffff88ffc4891018 R14: ffff88ffc4891000 R15: 0000000000000000
[    9.131279] FS:  0000000000000000(0000) GS:ffff883f7d600000(0000)
knlGS:0000000000000000
[    9.148870] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[    9.151914] CR2: 0000000000000010 CR3: 0000000002c14000 CR4: 00000000000007f0
[    9.168645] Stack:
[    9.169871]  ffff883f24e25d88 ffff88ffc4891000 ffff88ffc4870000
0000000000000001
[    9.188660]  0000000000000001 ffff883f23b0d400 ffff883f24e25e58
ffffffff810ce094
[    9.193232]  ffff883f24e25dd8 0000000000000246 0000000000000003
ffffffff000000a0
[    9.210992] Call Trace:
[    9.212524]  [<ffffffff810ce094>] build_sched_domains+0x6f4/0x980
[    9.229900]  [<ffffffff83042a2b>] sched_init_smp+0x95/0x146
[    9.233236]  [<ffffffff83023023>] kernel_init_freeable+0x148/0x259
[    9.250019]  [<ffffffff82121bce>] ? kernel_init+0xe/0x130
[    9.253356]  [<ffffffff82121bc0>] ? rest_init+0xd0/0xd0
[    9.268882]  [<ffffffff82121bce>] kernel_init+0xe/0x130
[    9.271661]  [<ffffffff8215176c>] ret_from_fork+0x7c/0xb0
[    9.288882]  [<ffffffff82121bc0>] ? rest_init+0xd0/0xd0
[    9.292476] Code: ff 31 db b8 ff ff ff ff 4d 8d 6e 18 eb 31 66 2e
0f 1f 84 00 00 00 00 00 48 63 d0 48 8b 14 d5 40 c4 e2 82 49 8b 94 14
08 09 00 00 <48> 8b 52 10 48 8b 52 10 8b 4a 08 8b 52 04 49 01 cf 48 01
d3 83
[    9.335669] RIP  [<ffffffff810d7b53>] update_group_power+0x1d3/0x250
[    9.348090]  RSP <ffff883f24e25d68>
[    9.350240] CR2: 0000000000000010
[    9.351803] ---[ end trace a21cca9ad6b48d40 ]---
[    9.367839] Kernel panic - not syncing: Attempted to kill init!
exitcode=0x00000009
[    9.367839]

  reply	other threads:[~2013-11-21 22:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 18:05 [tip:sched/core] sched/fair: Fix group power_orig computation tip-bot for Peter Zijlstra
2013-09-12 23:21 ` Michael Neuling
2013-11-12 10:55 ` Srikar Dronamraju
2013-11-12 11:57   ` Peter Zijlstra
2013-11-12 16:41     ` [PATCH v2] sched: Check sched_domain before computing group power Srikar Dronamraju
2013-11-12 17:03       ` Peter Zijlstra
2013-11-12 17:15         ` Srikar Dronamraju
2013-11-12 17:55           ` Peter Zijlstra
2013-11-13  5:55             ` Srikar Dronamraju
     [not found]       ` <CAM4v1pNMn=5oZDiX3fUp9uPkZTPJgk=vEKEjevzvpwn=PjTzXg@mail.gmail.com>
2013-11-13 11:23         ` Srikar Dronamraju
2013-11-14  6:06           ` Preeti U Murthy
2013-11-14  8:30             ` Peter Zijlstra
2013-11-14  9:12               ` Preeti U Murthy
2013-11-13 15:17       ` Peter Zijlstra
2013-11-14 10:50         ` Srikar Dronamraju
2013-11-14 11:15           ` Peter Zijlstra
2013-11-19 19:15         ` [tip:sched/urgent] " tip-bot for Srikar Dronamraju
2013-11-19 23:36           ` Yinghai Lu
2013-11-21 15:03             ` Peter Zijlstra
2013-11-21 17:22               ` Yinghai Lu
2013-11-21 22:03                 ` Yinghai Lu [this message]
2013-11-28  3:02                   ` David Rientjes
2013-11-28  7:07                     ` Yinghai Lu
2013-11-28  9:38                       ` Peter Zijlstra
2013-11-28 20:23                         ` Yinghai Lu
2013-12-06  6:24                       ` Yinghai Lu
2013-12-10 10:58                         ` Peter Zijlstra
2013-12-10 21:26                           ` Yinghai Lu
2013-11-22 12:07                 ` Peter Zijlstra
2013-11-23  5:00                   ` Yinghai Lu
2013-11-23 18:53                     ` Peter Zijlstra
2013-11-28  2:57           ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE9FiQUCPvzeiCSan34aV6hfrDHdV=sfHug0tMaAgpOMbum7jw@mail.gmail.com' \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.