From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: Re: [Bisected] [-next-20130204] usb/hcd: irq 18: nobody cared Date: Mon, 11 Feb 2013 16:08:38 -0800 Message-ID: References: <1360466060.3703.15.camel@thor.lan> <1360506199.3461.5.camel@thor.lan> <1360587768.3454.2.camel@thor.lan> <20130211224142.GA9782@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-ia0-f170.google.com ([209.85.210.170]:48464 "EHLO mail-ia0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760679Ab3BLAIj (ORCPT ); Mon, 11 Feb 2013 19:08:39 -0500 In-Reply-To: <20130211224142.GA9782@google.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , Peter Hurley , Alan Stern , Lan Tianyu , Greg Kroah-Hartman , Jiri Kosina , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org On Mon, Feb 11, 2013 at 2:41 PM, Bjorn Helgaas wrote: > [+cc linux-acpi, linux-pci] > > The _PRT describes motherboard interrupt wiring, which has nothing to > do with PCI bus numbers. Our current drivers/acpi/pci_irq.c caches > the PCI bus number along with the _PRT, and I think that's a mistake. > > The bus number binding means acpi_pci_irq_add_prt() has to happen > after enumerating everything below a bridge, and it will prevent us > from doing any bus number reassignment for hotplug. > > I think we should remove the bus numbers from the cached _PRT (or > maybe even remove the _PRT caching completely). When we enable a PCI > device's IRQ, we should search up the PCI device tree looking for a > _PRT associated with each node, and applying normal PCI bridge > swizzling when we don't find a _PRT. I think this can be done without > using PCI bus numbers at all. > Agreed, will give it try to remove the _PRT caching completely. Thanks Yinghai