From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds
Date: Thu, 25 Jul 2013 06:25:06 -0700
Message-ID: <CAE9FiQVOKv-EBPFoVUi5HBPmDDrjmc9nuww68Tm865fkCJeWkA@mail.gmail.com>
References: <26431283.HJCKsss0rt@vostro.rjw.lan>
	<3215120.cRBBS5jciE@vostro.rjw.lan>
	<CAE9FiQURY5WFFJekPHV_s0HPi8uhKzSDOLSXHAkyLPf1=i8oAw@mail.gmail.com>
	<6958813.eThhpoh5QO@vostro.rjw.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from mail-oa0-f47.google.com ([209.85.219.47]:59352 "EHLO
	mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755825Ab3GYNZH (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Thu, 25 Jul 2013 09:25:07 -0400
In-Reply-To: <6958813.eThhpoh5QO@vostro.rjw.lan>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, LKML <linux-kernel@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, Jiang Liu <liuj97@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>

On Wed, Jul 24, 2013 at 5:58 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Tuesday, July 23, 2013 07:20:53 PM Yinghai Lu wrote:
>> On Tue, Jul 23, 2013 at 2:39 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> [...]
>
>> [  102.631369] pci_host_bridge pci0000:00: freeing pci_host_bridge info
>
> By the way this looks fishy:
>
>> [  102.633091] ACPI: Device does not support D3cold
>> [  102.633915] ACPI: Device does not support D3cold
>> [  102.635221] ACPI: Device does not support D3cold
>> [  102.636103] ACPI: Device does not support D3cold
>> [  102.636902] ACPI: Device does not support D3cold
>> [  102.637685] ACPI: Device does not support D3cold
>> [  102.638467] ACPI: Device does not support D3cold
>> [  102.639631] ACPI: Device does not support D3cold
>> [  102.640472] ACPI: Device does not support D3cold
>> [  102.641310] ACPI: Device does not support D3cold
>> [  102.642105] ACPI: Device does not support D3cold
>> [  102.642928] ACPI: Device does not support D3cold
>> [  102.643725] ACPI: Device does not support D3cold
>> [  102.644544] ACPI: Device does not support D3cold
>> [  102.645344] ACPI: Device does not support D3cold
>> [  102.646126] ACPI: Device does not support D3cold
>> [  102.646902] ACPI: Device does not support D3cold
>> [  102.647677] ACPI: Device does not support D3cold
>> [  102.648485] ACPI: Device does not support D3cold
>> [  102.649269] ACPI: Device does not support D3cold
>> [  102.650065] ACPI: Device does not support D3cold
>> [  102.650822] ACPI: Device does not support D3cold
>> [  102.652483] ACPI: Device does not support D3cold
>> [  102.654157] ACPI: Device does not support D3cold
>> [  102.655803] ACPI: Device does not support D3cold
>> [  102.657419] ACPI: Device does not support D3cold
>> [  102.658528] ACPI: Device does not support D3cold
>> [  102.659255] ACPI: Device does not support D3cold
>> [  102.659973] ACPI: Device does not support D3cold
>> [  102.661807] ACPI: Device does not support D3cold
>> [  102.661925] ACPI: Device does not support D3cold
>> [  102.662047] ACPI: Device does not support D3cold
>> [  102.662148] ACPI: Device does not support D3cold
>> [  102.662258] ACPI: Device does not support D3cold
>> [  102.662374] ACPI: Device does not support D3cold
>> [  102.662486] ACPI: Device does not support D3cold
>> [  102.662597] ACPI: Device does not support D3cold
>> [  102.662711] ACPI: Device does not support D3cold
>> [  102.662814] ACPI: Device does not support D3cold
>> [  102.662918] ACPI: Device does not support D3cold
>> [  102.663019] ACPI: Device does not support D3cold
>
> Can you please check if it goes away with the patch below applied?
>
>> [  102.663039] ACPI: \_SB_.PCI0: No _EJ0 support for device
>
>
> ---
>  drivers/acpi/device_pm.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/device_pm.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/device_pm.c
> +++ linux-pm/drivers/acpi/device_pm.c
> @@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_de
>         int result = 0;
>         bool cut_power = false;
>
> -       if (!device || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD))
> +       if (!device || !device->flags.power_manageable
> +           || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD))
>                 return -EINVAL;
>
>         /* Make sure this is a valid target state */
>

yes, with this change, those print out are gone.

Thanks

Yinghai