From: Yinghai Lu <yinghai@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
cmilsted@redhat.com, "Rafa?? Mi??ecki" <zajec5@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
m@bues.ch,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card
Date: Thu, 9 Jun 2016 17:04:45 -0700 [thread overview]
Message-ID: <CAE9FiQVSxSmhYQhoccDYEhvbRrb0DPnPvZBw9D257OGePGRcAA@mail.gmail.com> (raw)
In-Reply-To: <20160609202036.GA19638@wunner.de>
On 6/9/16, Lukas Wunner <lukas@wunner.de> wrote:
>
> Well, the PCI core would also scan such a bus twice AFAICS.
> And the performance penalty of scanning it twice seems negligible.
> Early quirks can prevent double execution by setting QFLAG_APPLY_ONCE.
> (Three quirks have set that flag already.)
>
> So I think this shouldn't be a concern.
I don't know. I would like see sth like following, and that is simple enough.
Index: linux-2.6/arch/x86/kernel/early-quirks.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/early-quirks.c
+++ linux-2.6/arch/x86/kernel/early-quirks.c
@@ -755,10 +755,16 @@ static int __init check_dev_quirk(int nu
return 0;
}
+static unsigned char __initdata scanned[256];
static void __init early_pci_scan_bus(int bus)
{
int slot, func;
+ if (scanned[bus])
+ return;
+
+ scanned[bus] = 1;
+
/* Poor man's PCI discovery */
for (slot = 0; slot < 32; slot++)
for (func = 0; func < 8; func++) {
next prev parent reply other threads:[~2016-06-10 0:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 23:35 [PATCH] x86: Add early quirk to reset Apple AirPort card Lukas Wunner
2016-05-28 23:35 ` Lukas Wunner
2016-06-02 9:48 ` Matt Fleming
2016-06-02 9:48 ` Matt Fleming
2016-06-08 14:23 ` [tip:x86/urgent] x86/quirks: " tip-bot for Lukas Wunner
2016-06-08 18:56 ` Yinghai Lu
2016-06-08 20:09 ` Lukas Wunner
2016-06-09 6:48 ` Ingo Molnar
2016-06-09 11:04 ` Lukas Wunner
2016-06-09 16:37 ` Yinghai Lu
2016-06-09 20:20 ` Lukas Wunner
2016-06-10 0:04 ` Yinghai Lu [this message]
2016-06-10 11:58 ` Ingo Molnar
2016-06-10 12:16 ` Lukas Wunner
2016-06-10 12:59 ` Ingo Molnar
2016-06-10 13:59 ` Lukas Wunner
2016-06-10 20:08 ` Bjorn Helgaas
2016-06-12 11:13 ` Lukas Wunner
2016-06-09 22:57 ` [PATCH] x86: " Bjorn Helgaas
2016-06-09 22:57 ` Bjorn Helgaas
2016-06-12 10:31 [PATCH v2 3/3] x86/quirks: " Lukas Wunner
2016-07-10 19:01 ` [tip:x86/urgent] " tip-bot for Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQVSxSmhYQhoccDYEhvbRrb0DPnPvZBw9D257OGePGRcAA@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=cmilsted@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m@bues.ch \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.