From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: Re: [Xen-devel] [PATCH v5 16/33] xen, irq: Call irq_alloc_reserved_desc_at() at first Date: Mon, 6 Jan 2014 12:00:28 -0800 Message-ID: References: <1388707565-16535-1-git-send-email-yinghai@kernel.org> <1388707565-16535-17-git-send-email-yinghai@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefano Stabellini Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Bjorn Helgaas , "Rafael J. Wysocki" , Xen Devel , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , ACPI Devel Maling List List-Id: linux-acpi@vger.kernel.org On Fri, Jan 3, 2014 at 9:50 AM, Stefano Stabellini wrote: >> drivers/xen/events.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/xen/events.c b/drivers/xen/events.c >> index 4035e83..020cd77 100644 >> --- a/drivers/xen/events.c >> +++ b/drivers/xen/events.c >> @@ -508,8 +508,12 @@ static int __must_check xen_allocate_irq_gsi(unsigned gsi) >> /* Legacy IRQ descriptors are already allocated by the arch. */ >> if (gsi < NR_IRQS_LEGACY) >> irq = gsi; >> - else >> - irq = irq_alloc_desc_at(gsi, -1); >> + else { >> + /* for x86, irq already get reserved for gsi */ >> + irq = irq_alloc_reserved_desc_at(gsi, -1); >> + if (irq < 0) >> + irq = irq_alloc_desc_at(gsi, -1); >> + } > > This is common code. On ARM I get: > > drivers/xen/events.c: In function 'xen_allocate_irq_gsi': > drivers/xen/events.c:513:3: error: implicit declaration of function 'irq_alloc_reserved_desc_at' [-Werror=implicit-function-declaration] > irq = irq_alloc_reserved_desc_at(gsi, -1); > ^ > cc1: some warnings being treated as errors It's strange. that is defined with irq_alloc_desc_at in parallel in include/linux/irq.h and kernel/irq/irqdesc.c. Did you try the whole tree, or just this patch? Thanks Yinghai