From: Yinghai Lu <yinghai@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>, Greg KH <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@ftp.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>, "H. Peter Anvin" <hpa@zytor.com>,
Laura Abbott <lauraa@codeaurora.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to_bitidx calculation"
Date: Sat, 16 Feb 2013 11:38:31 -0800 [thread overview]
Message-ID: <CAE9FiQVnBeNEOgH4b+=FywMCnR-u7afADXK2KaiU+aSR+UcDYw@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFzTR5nBLXHe4MKtN6E7xrs3=xsbMd1aprr8Ax4mu96onw@mail.gmail.com>
On Sat, Feb 16, 2013 at 10:26 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Feb 15, 2013 at 3:44 AM, Ingo Molnar <mingo@kernel.org> wrote:
>>>
>>> c060f943d092 may be related as you config does not have
>>> CONFIG_SPARSEMEM defined.
>>
>> Right, that's the commit causing the x86 regression:
>>
>> c060f943d0929f3e429c5d9522290584f6281d6e is the first bad commit
>> commit c060f943d0929f3e429c5d9522290584f6281d6e
>> Date: Fri Jan 11 14:31:51 2013 -0800
>>
>> mm: use aligned zone start for pfn_to_bitidx calculation
>
> Ok, looking more at this, I don't really want to revert it, and I have
> an idea of what is wrong.
>
> When we allocate the zone use bitmap, we do not take the
> zone_start_pfn into account. So I *think* that what happens is that
> "pfn_to_bitidx()" simply overruns the allocation for unaligned zonesm
> and the spinlock just happens to be right after (or the overrun causes
> some other memory corruption that then indirectly causes the spinlock
> corruption).
>
> So I'm wondering if the fix is simply something like the attached
> patch. It takes the zone_start_pfn into account when allocating the
> zone bitmap.
Yes, that is right fix.
but you forgot to update setup_usemap() for SPARSEMEM
static inline void setup_usemap(struct pglist_data *pgdat,
struct zone *zone, unsigned long zonesize) {}
Thanks
Yinghai
next prev parent reply other threads:[~2013-02-16 19:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 21:51 Linux v3.8-rc7 Linus Torvalds
2013-02-10 0:14 ` [REGRESSION] -rc7/-rc4+: unable to USB boot - enumeration partially broken (was: Linux v3.8-rc7) Andreas Mohr
2013-02-10 14:05 ` Andreas Mohr
2013-02-12 16:07 ` Andreas Mohr
2013-02-12 16:16 ` Greg KH
2013-02-12 21:25 ` Andreas Mohr
2013-02-13 6:44 ` [REGRESSION] [nailed] USB boot failure: USB: EHCI: make ehci-pci a separate driver Andreas Mohr
2013-02-13 7:16 ` Andreas Mohr
2013-02-13 7:44 ` Andreas Mohr
2013-02-13 7:44 ` Andreas Mohr
2013-02-13 10:05 ` Andreas Mohr
2013-02-13 10:05 ` Andreas Mohr
2013-02-13 10:50 ` Colin Guthrie
2013-02-13 10:50 ` Colin Guthrie
2013-02-13 16:13 ` Andreas Mohr
2013-02-13 16:26 ` Colin Guthrie
2013-02-13 16:26 ` Colin Guthrie
2013-02-13 11:10 ` [-rc7 regression] Block IO/VFS/ext3/timer spinlock lockup? Ingo Molnar
2013-02-13 16:59 ` Linus Torvalds
2013-02-13 23:20 ` Thomas Gleixner
2013-02-14 14:45 ` Ingo Molnar
2013-02-14 14:54 ` Ingo Molnar
2013-02-14 15:08 ` Ingo Molnar
2013-02-14 17:28 ` Thomas Gleixner
2013-02-14 18:22 ` Yinghai Lu
2013-02-15 11:44 ` [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to_bitidx calculation" Ingo Molnar
2013-02-15 22:06 ` Greg KH
2013-02-16 8:29 ` Ingo Molnar
2013-03-01 16:50 ` Greg KH
2013-03-01 17:07 ` Linus Torvalds
2013-03-01 17:14 ` Greg KH
2013-02-16 8:25 ` Ingo Molnar
2013-02-16 18:26 ` Linus Torvalds
2013-02-16 19:38 ` Yinghai Lu [this message]
2013-02-16 19:51 ` Linus Torvalds
2013-02-18 8:49 ` Ingo Molnar
2013-02-18 14:46 ` Mel Gorman
2013-02-18 18:42 ` Laura Abbott
2013-02-14 23:05 ` [-rc7 regression] Block IO/VFS/ext3/timer spinlock lockup? Linus Torvalds
2013-02-15 11:39 ` [PATCH] spinlock/debugging: Print out lock name when available Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE9FiQVnBeNEOgH4b+=FywMCnR-u7afADXK2KaiU+aSR+UcDYw@mail.gmail.com' \
--to=yinghai@kernel.org \
--cc=axboe@kernel.dk \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.