All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [RFC PATCH v2] PCI: Only enable IO window if supported
Date: Wed, 29 Jul 2015 13:21:58 -0700	[thread overview]
Message-ID: <CAE9FiQWxMjJQBw6iQqtQxsBYG8-jxneia_8hrEm-JQH=6rCCTA@mail.gmail.com> (raw)
In-Reply-To: <55B93507.6070101@roeck-us.net>

On Wed, Jul 29, 2015 at 1:18 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On 07/29/2015 12:53 PM, Yinghai Lu wrote:
>>
>> On Wed, Jul 29, 2015 at 12:46 PM, Guenter Roeck <linux@roeck-us.net>
>> wrote:
>>>
>>> On 07/29/2015 12:30 PM, Yinghai Lu wrote:
>>>
>>>>
>>>> so PCI_BUS_FLAGS_SUPPORTS_IO will never get set.
>>>>
>>>
>>> excellent catch. Unfortunately, I don't know how to make it
>>> work with the reversed flag. The idea here was that the flag
>>> propagates from parent to child. This makes sense for an
>>> "it doesn't work" flag to be inherited from the child,
>>> but not for an "it works" flag.
>>>
>>
>> also would be better if we can add has_ioport in hostbridge instead.
>> like has_mem64 in https://patchwork.ozlabs.org/patch/500926/
>> and use
>>
>> to_pci_host_bridge(bus->bridge)->has_ioport
>>
>> to replace pci_root_has_io_resource()
>>
>
> Is there a function to get the root bus ? Otherwise I still need to
> find the root bus first.
host-bridge and rootbus is one to one mapping.

drivers/pci/host-bridge.c has related function.


Yinghai

      reply	other threads:[~2015-07-29 20:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 18:11 [RFC PATCH v2] PCI: Only enable IO window if supported Guenter Roeck
2015-07-24  3:09 ` Guenter Roeck
2015-07-29 16:09 ` Bjorn Helgaas
2015-07-29 19:30   ` Yinghai Lu
2015-07-29 19:46     ` Guenter Roeck
2015-07-29 19:53       ` Yinghai Lu
2015-07-29 20:02         ` Guenter Roeck
2015-07-29 20:24           ` Yinghai Lu
2015-07-29 20:26           ` Bjorn Helgaas
2015-07-30  3:59             ` Yinghai Lu
2015-07-30  4:17               ` Guenter Roeck
2015-07-30 16:18                 ` Bjorn Helgaas
2015-07-30 17:06                   ` Guenter Roeck
2015-07-29 20:18         ` Guenter Roeck
2015-07-29 20:21           ` Yinghai Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE9FiQWxMjJQBw6iQqtQxsBYG8-jxneia_8hrEm-JQH=6rCCTA@mail.gmail.com' \
    --to=yinghai@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.