From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31067C282D7 for ; Wed, 30 Jan 2019 18:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09F8B20869 for ; Wed, 30 Jan 2019 18:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oTw/lUF+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733215AbfA3ShD (ORCPT ); Wed, 30 Jan 2019 13:37:03 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39340 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733103AbfA3ShC (ORCPT ); Wed, 30 Jan 2019 13:37:02 -0500 Received: by mail-lj1-f193.google.com with SMTP id t9-v6so464249ljh.6 for ; Wed, 30 Jan 2019 10:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MFK9fDVCrEcW9cs9+Bfj5Lsq8+kacWpOw55FKDAtOqA=; b=oTw/lUF+PWcmdEgfJkpPInfa7/Ud8w+AfErgLPp4kH5d8qa3YNJlp0M15NucGPRgie GTw35zC/YffKZksIyOKzBUG6tvPXikLfco6y5vLiYNg3d3lJf3MPp7iehgsnNVpj/U5K BCiBSfatvjS8fIY6WXlgcozotQw0fUOQFzmaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MFK9fDVCrEcW9cs9+Bfj5Lsq8+kacWpOw55FKDAtOqA=; b=WHs5XOJojmhd/7xeXSZ2jPUHGmDmB6Z7Xnt7ad5O7ax9vRgqTiXe5kZdsTbe/OR7vN XbOAtDzZW5rr/mzGjUIEJuUXm6ygm0mTQ9tWCjdQubPOMbKuUmPn/z19KNpxD/1aAa8P iI2fsUR5h40p/hUKD8GJRtnBxTwrhg3teWwF1+c0GqMittD+9xt9owtS5kNQPMMEmc8x d52j8EIumZqew4Qj9S8eJ0H3pmEYgCXqMNmybU0DKB+aQlddrEAproPsam93ZZzdmfG+ u1qXSXnl9BC6vN4Kto0NQKDfiCYFSPX1BPuCkdEXmHuRrAPcjxCniC67gWZx8geRu3If xhKw== X-Gm-Message-State: AJcUukffe2CA0TXQzCGMpORL/4fOxrLbZJ1IAUJ7UaOARH/J1rKNrAjf uGy0oSyh1/v11300H7DVanDflR0mqBM= X-Google-Smtp-Source: ALg8bN6JMwbDybzj6cH13w3Tbhy9WYCsBlLyrOI0SXQnv9np/hlwOSE9SPnSGHZo9lZ93c8aNuvO5Q== X-Received: by 2002:a2e:880a:: with SMTP id x10-v6mr26914544ljh.174.1548873420385; Wed, 30 Jan 2019 10:37:00 -0800 (PST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id m63-v6sm442063lje.81.2019.01.30.10.36.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 10:36:59 -0800 (PST) Received: by mail-lj1-f179.google.com with SMTP id v15-v6so407474ljh.13 for ; Wed, 30 Jan 2019 10:36:59 -0800 (PST) X-Received: by 2002:a2e:9715:: with SMTP id r21-v6mr25990512lji.30.1548873076878; Wed, 30 Jan 2019 10:31:16 -0800 (PST) MIME-Version: 1.0 References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> In-Reply-To: <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> From: Evan Green Date: Wed, 30 Jan 2019 10:30:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 11/20] iommu/mediatek: Move vld_pa_rng into plat_data To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Rob Herring , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Arnd Bergmann , yingjoe.chen@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 31, 2018 at 7:58 PM Yong Wu wrote: > > Both mt8173 and mt8183 don't have this vld_pa_rng(valid physical address > range) register while mt2712 have. Move it into the plat_data. > > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 3 ++- > drivers/iommu/mtk_iommu.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 8d8ab21..2913ddb 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -548,7 +548,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) > upper_32_bits(data->protect_base); > writel_relaxed(regval, data->base + REG_MMU_IVRP_PADDR); > > - if (data->enable_4GB && data->plat_data->m4u_plat != M4U_MT8173) { > + if (data->enable_4GB && data->plat_data->vld_pa_rng) { > /* > * If 4GB mode is enabled, the validate PA range is from > * 0x1_0000_0000 to 0x1_ffff_ffff. here record bit[32:30]. > @@ -741,6 +741,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev) > .m4u_plat = M4U_MT2712, > .has_4gb_mode = true, > .has_bclk = true, > + .vld_pa_rng = true, > .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, > }; > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > index b46aeaa..a8c5d1e 100644 > --- a/drivers/iommu/mtk_iommu.h > +++ b/drivers/iommu/mtk_iommu.h > @@ -48,6 +48,7 @@ struct mtk_iommu_plat_data { > /* HW will use the EMI clock if there isn't the "bclk". */ > bool has_bclk; > bool reset_axi; > + bool vld_pa_rng; I agree with Nicolas that valid_pa_range would be much clearer... although, even now that I know what it's supposed to mean, I don't get what it represents. What is this saying? -Evan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evan Green Subject: Re: [PATCH v5 11/20] iommu/mediatek: Move vld_pa_rng into plat_data Date: Wed, 30 Jan 2019 10:30:39 -0800 Message-ID: References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Rob Herring , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Arnd Bergmann , yingjoe.chen@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat List-Id: devicetree@vger.kernel.org On Mon, Dec 31, 2018 at 7:58 PM Yong Wu wrote: > > Both mt8173 and mt8183 don't have this vld_pa_rng(valid physical address > range) register while mt2712 have. Move it into the plat_data. > > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 3 ++- > drivers/iommu/mtk_iommu.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 8d8ab21..2913ddb 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -548,7 +548,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) > upper_32_bits(data->protect_base); > writel_relaxed(regval, data->base + REG_MMU_IVRP_PADDR); > > - if (data->enable_4GB && data->plat_data->m4u_plat != M4U_MT8173) { > + if (data->enable_4GB && data->plat_data->vld_pa_rng) { > /* > * If 4GB mode is enabled, the validate PA range is from > * 0x1_0000_0000 to 0x1_ffff_ffff. here record bit[32:30]. > @@ -741,6 +741,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev) > .m4u_plat = M4U_MT2712, > .has_4gb_mode = true, > .has_bclk = true, > + .vld_pa_rng = true, > .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, > }; > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > index b46aeaa..a8c5d1e 100644 > --- a/drivers/iommu/mtk_iommu.h > +++ b/drivers/iommu/mtk_iommu.h > @@ -48,6 +48,7 @@ struct mtk_iommu_plat_data { > /* HW will use the EMI clock if there isn't the "bclk". */ > bool has_bclk; > bool reset_axi; > + bool vld_pa_rng; I agree with Nicolas that valid_pa_range would be much clearer... although, even now that I know what it's supposed to mean, I don't get what it represents. What is this saying? -Evan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B68CC282D7 for ; Wed, 30 Jan 2019 18:38:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6AC32083B for ; Wed, 30 Jan 2019 18:38:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aQC6uYzF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oTw/lUF+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6AC32083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LjA2X1e4AaFelVy8sxQ+c8cnaVSPXVBXrm0C8/K0Wk0=; b=aQC6uYzFtTGNcf erTrDy6aP6OavHjoIxuIRtF2XJxowVHo7qsKg2JDdcNXZokJJ2+UUjQ0jo5qB7txfoo155Hq4IFOj J9MC3uDldDsLRN0PlF80CgLjK8+3CRgOJftjZ/I+Nj4c9kokQX+bOQwokwKXHI37O7drflBO05Tah OsrPK+lfXS7MhFTf7umWzQOaPZOboo1DlKiHqCRwb7fZI3II6PRcYddaewwWyswp1DjapuiwRbjKI bq5TL7V3BqQJwvcjlxEMwCS14y9cUoFb9nQgeFcOH1ZS3DbeTC91QS6wzzI2iRj7Ms12LE+V1L/Ck QNBkJaDendM6suqqdFFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goul7-00023a-8i; Wed, 30 Jan 2019 18:38:49 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goujq-00012l-7g for linux-arm-kernel@lists.infradead.org; Wed, 30 Jan 2019 18:37:47 +0000 Received: by mail-lj1-x241.google.com with SMTP id k15-v6so448505ljc.8 for ; Wed, 30 Jan 2019 10:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MFK9fDVCrEcW9cs9+Bfj5Lsq8+kacWpOw55FKDAtOqA=; b=oTw/lUF+PWcmdEgfJkpPInfa7/Ud8w+AfErgLPp4kH5d8qa3YNJlp0M15NucGPRgie GTw35zC/YffKZksIyOKzBUG6tvPXikLfco6y5vLiYNg3d3lJf3MPp7iehgsnNVpj/U5K BCiBSfatvjS8fIY6WXlgcozotQw0fUOQFzmaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MFK9fDVCrEcW9cs9+Bfj5Lsq8+kacWpOw55FKDAtOqA=; b=jtLRn1MWXrFlR6zqBc3kYeVUQzw6gsoO+HZXVW4uqATgaTku0Uo7Sb1QomB1dZM5ju qiQ4ODB8vugCaRmEj6xHjZYYSiHkxfvS2Z87kqtopM5VuUOv+u2gZr+f3uqAI82b9EEa 4v+p4OmISHA3nvoEH4DofC2INdFpj7RuxpL5C6zQLuSTkH362Bs32CPe5xr0rHxbjEPL nal0rLdl2Z5tWuHK119VwLKHsXvsza6x0lGCpD28Z9Y5ekjTk9Cqb8/DMzJiFxfkqVMz ZU9NTz5JmCkB7DTmgjJCiFBmYeAODAfKOtwPtf3+ti/Ej0Vc1xo5UDfOtrclmLwBibTh VNXw== X-Gm-Message-State: AJcUukdY9ZY4UwgQW3rdnN5UqdSqWxxu8IYyYuPnsWlG+Ev4R+SG1aw2 HETofBi5RZ/pZ2B53JU/U41+FnND34s= X-Google-Smtp-Source: ALg8bN5/pXtqB8R8p/zAM9Rth7cZZj+U8OFcI9xffMgpxv/UZSpOl2tsB4uETrzRiIc0m/muG5NZhw== X-Received: by 2002:a2e:91d1:: with SMTP id u17-v6mr25682379ljg.160.1548873448491; Wed, 30 Jan 2019 10:37:28 -0800 (PST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id u24sm411196lfi.24.2019.01.30.10.37.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 10:37:28 -0800 (PST) Received: by mail-lj1-f180.google.com with SMTP id n18-v6so456470lji.7 for ; Wed, 30 Jan 2019 10:37:28 -0800 (PST) X-Received: by 2002:a2e:9715:: with SMTP id r21-v6mr25990512lji.30.1548873076878; Wed, 30 Jan 2019 10:31:16 -0800 (PST) MIME-Version: 1.0 References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> In-Reply-To: <1546314952-15990-12-git-send-email-yong.wu@mediatek.com> From: Evan Green Date: Wed, 30 Jan 2019 10:30:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 11/20] iommu/mediatek: Move vld_pa_rng into plat_data To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190130_103731_136977_84198122 X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Nicolas Boichat , Arnd Bergmann , srv_heupstream@mediatek.com, Joerg Roedel , Will Deacon , LKML , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 31, 2018 at 7:58 PM Yong Wu wrote: > > Both mt8173 and mt8183 don't have this vld_pa_rng(valid physical address > range) register while mt2712 have. Move it into the plat_data. > > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 3 ++- > drivers/iommu/mtk_iommu.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 8d8ab21..2913ddb 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -548,7 +548,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data) > upper_32_bits(data->protect_base); > writel_relaxed(regval, data->base + REG_MMU_IVRP_PADDR); > > - if (data->enable_4GB && data->plat_data->m4u_plat != M4U_MT8173) { > + if (data->enable_4GB && data->plat_data->vld_pa_rng) { > /* > * If 4GB mode is enabled, the validate PA range is from > * 0x1_0000_0000 to 0x1_ffff_ffff. here record bit[32:30]. > @@ -741,6 +741,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev) > .m4u_plat = M4U_MT2712, > .has_4gb_mode = true, > .has_bclk = true, > + .vld_pa_rng = true, > .larbid_remap = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, > }; > > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > index b46aeaa..a8c5d1e 100644 > --- a/drivers/iommu/mtk_iommu.h > +++ b/drivers/iommu/mtk_iommu.h > @@ -48,6 +48,7 @@ struct mtk_iommu_plat_data { > /* HW will use the EMI clock if there isn't the "bclk". */ > bool has_bclk; > bool reset_axi; > + bool vld_pa_rng; I agree with Nicolas that valid_pa_range would be much clearer... although, even now that I know what it's supposed to mean, I don't get what it represents. What is this saying? -Evan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel