From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B0CC282D7 for ; Wed, 30 Jan 2019 18:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 902DD20869 for ; Wed, 30 Jan 2019 18:35:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MBj49i9B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733153AbfA3Sfw (ORCPT ); Wed, 30 Jan 2019 13:35:52 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45979 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733011AbfA3Sfv (ORCPT ); Wed, 30 Jan 2019 13:35:51 -0500 Received: by mail-lj1-f194.google.com with SMTP id s5-v6so406057ljd.12 for ; Wed, 30 Jan 2019 10:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vz1pJJHxFDjHYDa5FNImunQFYutxZ8wy7/pKlBaS2E0=; b=MBj49i9BZps1u5Jgm124BfF4vUDqnjlxGywDrDT3pg6LUlgS8dDFSTIC8iXO0P9zw5 a0lLJ8AO1ydAxu6UeYNp/6Tcck53RVHTMoYfi+tjPB39bRM9vLxUnolRzFcqTitNEoog Ms2oVXkF/2VFPWIKH/U0gUp1iyWlW4NlYxUDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vz1pJJHxFDjHYDa5FNImunQFYutxZ8wy7/pKlBaS2E0=; b=qrBONHYsgojJ2WIPA4TBzybsPaCi7ppU7OlxeHkYxzy4X5eBsfJdIqPwucdnQryajy 6MDLFSugktxlUK9CUQ5MSf5ixe1vW7+lPipZqlGNItf85HdPoO0ScUd0K7V2S8Vi/R0b KjUt4efNi5GxCNtQzXabrKKR7QVdmndgpZwcEG9WVSFHDLZz8R6Hp0YNT2FoU0m0vU0N +G/97hr02TbGoQQwdDMqcRNwSfMI9+G2VvEBM+Ob2h20C/vq6fJdPsO/OLtwAupN7a5g GdKWznIy+OGnLcBJNEAfpo67cMFQ5Ol8vn3Jfli8wqtxMflU6dO5ptCvI/RbWclBZjkn 3wVg== X-Gm-Message-State: AJcUukeN7wAQW3y0ttVAVawxeAUkxSEaTpEWbhjIRbyP3pd6IT6IVEYi ott232RxGdmwvhOfqt3AZW1TQQaWE4w= X-Google-Smtp-Source: ALg8bN7wS4fTMKzvPCrrR1rwJFYttsKUe2MJs35IWgUMXvja4f379fUrDux0xZnF9EzlKoV2BtYveg== X-Received: by 2002:a2e:145a:: with SMTP id 26-v6mr24847666lju.116.1548873348530; Wed, 30 Jan 2019 10:35:48 -0800 (PST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id k68-v6sm404400ljb.35.2019.01.30.10.35.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 10:35:48 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id e26so421303lfc.2 for ; Wed, 30 Jan 2019 10:35:48 -0800 (PST) X-Received: by 2002:a19:d381:: with SMTP id k123mr24301931lfg.101.1548872883637; Wed, 30 Jan 2019 10:28:03 -0800 (PST) MIME-Version: 1.0 References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-2-git-send-email-yong.wu@mediatek.com> In-Reply-To: <1546314952-15990-2-git-send-email-yong.wu@mediatek.com> From: Evan Green Date: Wed, 30 Jan 2019 10:27:27 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/20] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Robin Murphy , Rob Herring , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Arnd Bergmann , yingjoe.chen@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 31, 2018 at 7:56 PM Yong Wu wrote: > > This patch adds decriptions for mt8183 IOMMU and SMI. > > mt8183 has only one M4U like mt8173 and is also MTK IOMMU gen2 which > uses ARM Short-Descriptor translation table format. > > The mt8183 M4U-SMI HW diagram is as below: > > EMI > | > M4U > | > ---------- > | | > gals0-rx gals1-rx > | | > | | > gals0-tx gals1-tx > | | > ------------ > SMI Common > ------------ > | > +-----+-----+--------+-----+-----+-------+-------+ > | | | | | | | | > | | gals-rx gals-rx | gals-rx gals-rx gals-rx > | | | | | | | | > | | | | | | | | > | | gals-tx gals-tx | gals-tx gals-tx gals-tx > | | | | | | | | > larb0 larb1 IPU0 IPU1 larb4 larb5 larb6 CCU > disp vdec img cam venc img cam It might be cool to put the gals in the picture in the bindings. Not a big deal though. > > All the connections are HW fixed, SW can NOT adjust it. > > Compared with mt8173, we add a GALS(Global Async Local Sync) module > between SMI-common and M4U, and additional GALS between larb2/3/5/6 > and SMI-common. GALS can help synchronize for the modules in different > clock frequency, it can be seen as a "asynchronous fifo". > > GALS can only help transfer the command/data while it doesn't have > the configuring register, thus it has the special "smi" clock and it > doesn't have the "apb" clock. From the diagram above, we add "gals0" > and "gals1" clocks for smi-common and add a "gals" clock for smi-larb. > > From the diagram above, IPU0/IPU1(Image Processor Unit) and CCU(Camera > Control Unit) is connected with smi-common directly, we can take them > as "larb2", "larb3" and "larb7", and their register spaces are > different with the normal larb. > > Signed-off-by: Yong Wu > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++- > .../memory-controllers/mediatek,smi-common.txt | 11 +- > .../memory-controllers/mediatek,smi-larb.txt | 3 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 +++++++++++++++++++++ > 4 files changed, 153 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > index 6922db5..6e758996 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > @@ -36,6 +36,10 @@ each local arbiter. > like display, video decode, and camera. And there are different ports > in each larb. Take a example, There are many ports like MC, PP, VLD in the > video decode local arbiter, all these ports are according to the video HW. > + In some SoCs, there may be a GALS(Global Async Local Sync) module between > +smi-common and m4u, and additional GALS module between smi-larb and > +smi-common. GALS can been seen as a "asynchronous fifo" which could help > +synchronize for the modules in different clock frequency. > > Required properties: > - compatible : must be one of the following string: > @@ -44,18 +48,23 @@ Required properties: > "mediatek,mt7623-m4u", "mediatek,mt2701-m4u" for mt7623 which uses > generation one m4u HW. > "mediatek,mt8173-m4u" for mt8173 which uses generation two m4u HW. > + "mediatek,mt8183-m4u" for mt8183 which uses generation two m4u HW. > - reg : m4u register base and size. > - interrupts : the interrupt of m4u. > - clocks : must contain one entry for each clock-names. > -- clock-names : must be "bclk", It is the block clock of m4u. > +- clock-names : Only 1 optional clock: > + - "bclk": the block clock of m4u. > + Note that m4u use the EMI clock which always has been enabled before kernel > + if there is no this "bclk". Ideally bclk could be specified a little more crisply, as this is actually required for some SoCs and not used at all on others (as in patch 7). > - mediatek,larbs : List of phandle to the local arbiters in the current Socs. > Refer to bindings/memory-controllers/mediatek,smi-larb.txt. It must sort > according to the local arbiter index, like larb0, larb1, larb2... > - iommu-cells : must be 1. This is the mtk_m4u_id according to the HW. > Specifies the mtk_m4u_id as defined in > dt-binding/memory/mt2701-larb-port.h for mt2701, mt7623 > - dt-binding/memory/mt2712-larb-port.h for mt2712, and > - dt-binding/memory/mt8173-larb-port.h for mt8173. > + dt-binding/memory/mt2712-larb-port.h for mt2712, > + dt-binding/memory/mt8173-larb-port.h for mt8173, and > + dt-binding/memory/mt8183-larb-port.h for mt8183. > > Example: > iommu: iommu@10205000 { > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > index e937ddd..8d3240a 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > @@ -2,9 +2,10 @@ SMI (Smart Multimedia Interface) Common > > The hardware block diagram please check bindings/iommu/mediatek,iommu.txt > > -Mediatek SMI have two generations of HW architecture, mt2712 and mt8173 use > -the second generation of SMI HW while mt2701 uses the first generation HW of > -SMI. > +Mediatek SMI have two generations of HW architecture, here is the list > +which generation the Socs use: > +generation 1: mt2701 and mt7623. > +generation 2: mt2712, mt8173 and mt8183. > > There's slight differences between the two SMI, for generation 2, the > register which control the iommu port is at each larb's register base. But > @@ -19,6 +20,7 @@ Required properties: > "mediatek,mt2712-smi-common" > "mediatek,mt7623-smi-common", "mediatek,mt2701-smi-common" > "mediatek,mt8173-smi-common" > + "mediatek,mt8183-smi-common" > - reg : the register and size of the SMI block. > - power-domains : a phandle to the power domain of this local arbiter. > - clocks : Must contain an entry for each entry in clock-names. > @@ -30,6 +32,9 @@ Required properties: > They may be the same if both source clocks are the same. > - "async" : asynchronous clock, it help transform the smi clock into the emi > clock domain, this clock is only needed by generation 1 smi HW. > + and these 2 option clocks for generation 2 smi HW: > + - "gals0": the path0 clock of GALS(Global Async Local Sync). > + - "gals1": the path1 clock of GALS(Global Async Local Sync). It would also be nice to specify these more clearly too, since these are also required for some SoCs and not used on others (as in patch 12). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evan Green Subject: Re: [PATCH v5 01/20] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI Date: Wed, 30 Jan 2019 10:27:27 -0800 Message-ID: References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-2-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1546314952-15990-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Yong Wu Cc: youlin.pei-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Nicolas Boichat , Arnd Bergmann , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Joerg Roedel , Will Deacon , LKML , Tomasz Figa , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Robin Murphy , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Dec 31, 2018 at 7:56 PM Yong Wu wrote: > > This patch adds decriptions for mt8183 IOMMU and SMI. > > mt8183 has only one M4U like mt8173 and is also MTK IOMMU gen2 which > uses ARM Short-Descriptor translation table format. > > The mt8183 M4U-SMI HW diagram is as below: > > EMI > | > M4U > | > ---------- > | | > gals0-rx gals1-rx > | | > | | > gals0-tx gals1-tx > | | > ------------ > SMI Common > ------------ > | > +-----+-----+--------+-----+-----+-------+-------+ > | | | | | | | | > | | gals-rx gals-rx | gals-rx gals-rx gals-rx > | | | | | | | | > | | | | | | | | > | | gals-tx gals-tx | gals-tx gals-tx gals-tx > | | | | | | | | > larb0 larb1 IPU0 IPU1 larb4 larb5 larb6 CCU > disp vdec img cam venc img cam It might be cool to put the gals in the picture in the bindings. Not a big deal though. > > All the connections are HW fixed, SW can NOT adjust it. > > Compared with mt8173, we add a GALS(Global Async Local Sync) module > between SMI-common and M4U, and additional GALS between larb2/3/5/6 > and SMI-common. GALS can help synchronize for the modules in different > clock frequency, it can be seen as a "asynchronous fifo". > > GALS can only help transfer the command/data while it doesn't have > the configuring register, thus it has the special "smi" clock and it > doesn't have the "apb" clock. From the diagram above, we add "gals0" > and "gals1" clocks for smi-common and add a "gals" clock for smi-larb. > > From the diagram above, IPU0/IPU1(Image Processor Unit) and CCU(Camera > Control Unit) is connected with smi-common directly, we can take them > as "larb2", "larb3" and "larb7", and their register spaces are > different with the normal larb. > > Signed-off-by: Yong Wu > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++- > .../memory-controllers/mediatek,smi-common.txt | 11 +- > .../memory-controllers/mediatek,smi-larb.txt | 3 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 +++++++++++++++++++++ > 4 files changed, 153 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > index 6922db5..6e758996 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > @@ -36,6 +36,10 @@ each local arbiter. > like display, video decode, and camera. And there are different ports > in each larb. Take a example, There are many ports like MC, PP, VLD in the > video decode local arbiter, all these ports are according to the video HW. > + In some SoCs, there may be a GALS(Global Async Local Sync) module between > +smi-common and m4u, and additional GALS module between smi-larb and > +smi-common. GALS can been seen as a "asynchronous fifo" which could help > +synchronize for the modules in different clock frequency. > > Required properties: > - compatible : must be one of the following string: > @@ -44,18 +48,23 @@ Required properties: > "mediatek,mt7623-m4u", "mediatek,mt2701-m4u" for mt7623 which uses > generation one m4u HW. > "mediatek,mt8173-m4u" for mt8173 which uses generation two m4u HW. > + "mediatek,mt8183-m4u" for mt8183 which uses generation two m4u HW. > - reg : m4u register base and size. > - interrupts : the interrupt of m4u. > - clocks : must contain one entry for each clock-names. > -- clock-names : must be "bclk", It is the block clock of m4u. > +- clock-names : Only 1 optional clock: > + - "bclk": the block clock of m4u. > + Note that m4u use the EMI clock which always has been enabled before kernel > + if there is no this "bclk". Ideally bclk could be specified a little more crisply, as this is actually required for some SoCs and not used at all on others (as in patch 7). > - mediatek,larbs : List of phandle to the local arbiters in the current Socs. > Refer to bindings/memory-controllers/mediatek,smi-larb.txt. It must sort > according to the local arbiter index, like larb0, larb1, larb2... > - iommu-cells : must be 1. This is the mtk_m4u_id according to the HW. > Specifies the mtk_m4u_id as defined in > dt-binding/memory/mt2701-larb-port.h for mt2701, mt7623 > - dt-binding/memory/mt2712-larb-port.h for mt2712, and > - dt-binding/memory/mt8173-larb-port.h for mt8173. > + dt-binding/memory/mt2712-larb-port.h for mt2712, > + dt-binding/memory/mt8173-larb-port.h for mt8173, and > + dt-binding/memory/mt8183-larb-port.h for mt8183. > > Example: > iommu: iommu@10205000 { > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > index e937ddd..8d3240a 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > @@ -2,9 +2,10 @@ SMI (Smart Multimedia Interface) Common > > The hardware block diagram please check bindings/iommu/mediatek,iommu.txt > > -Mediatek SMI have two generations of HW architecture, mt2712 and mt8173 use > -the second generation of SMI HW while mt2701 uses the first generation HW of > -SMI. > +Mediatek SMI have two generations of HW architecture, here is the list > +which generation the Socs use: > +generation 1: mt2701 and mt7623. > +generation 2: mt2712, mt8173 and mt8183. > > There's slight differences between the two SMI, for generation 2, the > register which control the iommu port is at each larb's register base. But > @@ -19,6 +20,7 @@ Required properties: > "mediatek,mt2712-smi-common" > "mediatek,mt7623-smi-common", "mediatek,mt2701-smi-common" > "mediatek,mt8173-smi-common" > + "mediatek,mt8183-smi-common" > - reg : the register and size of the SMI block. > - power-domains : a phandle to the power domain of this local arbiter. > - clocks : Must contain an entry for each entry in clock-names. > @@ -30,6 +32,9 @@ Required properties: > They may be the same if both source clocks are the same. > - "async" : asynchronous clock, it help transform the smi clock into the emi > clock domain, this clock is only needed by generation 1 smi HW. > + and these 2 option clocks for generation 2 smi HW: > + - "gals0": the path0 clock of GALS(Global Async Local Sync). > + - "gals1": the path1 clock of GALS(Global Async Local Sync). It would also be nice to specify these more clearly too, since these are also required for some SoCs and not used on others (as in patch 12). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4F4C282D7 for ; Wed, 30 Jan 2019 18:36:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B8F20869 for ; Wed, 30 Jan 2019 18:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X8nd+tZ1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MBj49i9B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B8F20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QtbAJyFsD++k04Y4IGGfwVYVvMt46uQCgiiSr1ND5X4=; b=X8nd+tZ1t4t+04 g0tKvfIjppZwPnUx2LCwOSisSbCY8rQYbLA0GZHPi6Mt0NAY/zj+XJb3mZ582bhhiTCtkzwOHZiuC jj6eXop58FLSSlqGn2hG97LbbA3xISydyP6IqBzgX0P6IrwOWAwEuj5s5hxIx2FFPnODAnvtTpZcI T7ry2JlnBLcZRzawI6tpoVFigWHX72e7iMbDHIWc36V28892tqyN1HWnx6UIgC/CDqXvQmqaJTKhG d+E/m8QF+u+WNPxBJ1CRtDxa5TWccknKA/L6H5HKfm+CdQcMmxZJ203aY/CUxAjCbvcjJThk6UPaF Mra8HtyQz5V4PzoM5OtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouiY-0008PK-KK; Wed, 30 Jan 2019 18:36:10 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gouiR-0008Ov-8A for linux-arm-kernel@lists.infradead.org; Wed, 30 Jan 2019 18:36:07 +0000 Received: by mail-lf1-x144.google.com with SMTP id e26so421724lfc.2 for ; Wed, 30 Jan 2019 10:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vz1pJJHxFDjHYDa5FNImunQFYutxZ8wy7/pKlBaS2E0=; b=MBj49i9BZps1u5Jgm124BfF4vUDqnjlxGywDrDT3pg6LUlgS8dDFSTIC8iXO0P9zw5 a0lLJ8AO1ydAxu6UeYNp/6Tcck53RVHTMoYfi+tjPB39bRM9vLxUnolRzFcqTitNEoog Ms2oVXkF/2VFPWIKH/U0gUp1iyWlW4NlYxUDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vz1pJJHxFDjHYDa5FNImunQFYutxZ8wy7/pKlBaS2E0=; b=j/ppnhLzCfsrqF23nS2k8DYfG6OB33gRIu5uqMRdHCnqvFuemwx4ampxJxlXaQRSLf g364ar65dpnEoKae19gllUgQYwnALEIyewkm/K710URUR2FhxaUjXVVCpOkQWxlVOdKJ IgyGiBAFqyeR+UW5Qzn/91OuEDXQHvN57ts/EVECiLY9xQ1KyII2+vr6T0qpDXQM6aAR 7wZKJ/ZAjIKKgVL2ttqAHWXvcqKdM3A1sHy/WqLOcyvbdhM8vMby701g+8aGTKoNJB5k GmyOFOG8SD8UTmfQ8hPuKILZXaOjXqVN032TlSyDXVSLJ8K4ik7IDoh3t2yxG/2Sinvv 60cA== X-Gm-Message-State: AJcUukfvXhDk9JWZunGzLGYbwio1plucxwuXupF6NxCLyo1zaH9vMonN IJUmOIghZoWyBsbR04fPrFFe4UbeOMk= X-Google-Smtp-Source: ALg8bN7xW1cNE4lVRlCbQg+FGzLWcyodFjy4dULO1/kSJu7IEapYfTIqLoZ4c8vxDGFMNsgeJk6wbg== X-Received: by 2002:a19:db54:: with SMTP id s81mr25890869lfg.102.1548873359752; Wed, 30 Jan 2019 10:35:59 -0800 (PST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id z64sm402674lff.39.2019.01.30.10.35.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 10:35:59 -0800 (PST) Received: by mail-lf1-f44.google.com with SMTP id v5so398420lfe.7 for ; Wed, 30 Jan 2019 10:35:59 -0800 (PST) X-Received: by 2002:a19:d381:: with SMTP id k123mr24301931lfg.101.1548872883637; Wed, 30 Jan 2019 10:28:03 -0800 (PST) MIME-Version: 1.0 References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-2-git-send-email-yong.wu@mediatek.com> In-Reply-To: <1546314952-15990-2-git-send-email-yong.wu@mediatek.com> From: Evan Green Date: Wed, 30 Jan 2019 10:27:27 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/20] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190130_103603_292751_7295C561 X-CRM114-Status: GOOD ( 31.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Nicolas Boichat , Arnd Bergmann , srv_heupstream@mediatek.com, Joerg Roedel , Will Deacon , LKML , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 31, 2018 at 7:56 PM Yong Wu wrote: > > This patch adds decriptions for mt8183 IOMMU and SMI. > > mt8183 has only one M4U like mt8173 and is also MTK IOMMU gen2 which > uses ARM Short-Descriptor translation table format. > > The mt8183 M4U-SMI HW diagram is as below: > > EMI > | > M4U > | > ---------- > | | > gals0-rx gals1-rx > | | > | | > gals0-tx gals1-tx > | | > ------------ > SMI Common > ------------ > | > +-----+-----+--------+-----+-----+-------+-------+ > | | | | | | | | > | | gals-rx gals-rx | gals-rx gals-rx gals-rx > | | | | | | | | > | | | | | | | | > | | gals-tx gals-tx | gals-tx gals-tx gals-tx > | | | | | | | | > larb0 larb1 IPU0 IPU1 larb4 larb5 larb6 CCU > disp vdec img cam venc img cam It might be cool to put the gals in the picture in the bindings. Not a big deal though. > > All the connections are HW fixed, SW can NOT adjust it. > > Compared with mt8173, we add a GALS(Global Async Local Sync) module > between SMI-common and M4U, and additional GALS between larb2/3/5/6 > and SMI-common. GALS can help synchronize for the modules in different > clock frequency, it can be seen as a "asynchronous fifo". > > GALS can only help transfer the command/data while it doesn't have > the configuring register, thus it has the special "smi" clock and it > doesn't have the "apb" clock. From the diagram above, we add "gals0" > and "gals1" clocks for smi-common and add a "gals" clock for smi-larb. > > From the diagram above, IPU0/IPU1(Image Processor Unit) and CCU(Camera > Control Unit) is connected with smi-common directly, we can take them > as "larb2", "larb3" and "larb7", and their register spaces are > different with the normal larb. > > Signed-off-by: Yong Wu > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++- > .../memory-controllers/mediatek,smi-common.txt | 11 +- > .../memory-controllers/mediatek,smi-larb.txt | 3 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 +++++++++++++++++++++ > 4 files changed, 153 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > index 6922db5..6e758996 100644 > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > @@ -36,6 +36,10 @@ each local arbiter. > like display, video decode, and camera. And there are different ports > in each larb. Take a example, There are many ports like MC, PP, VLD in the > video decode local arbiter, all these ports are according to the video HW. > + In some SoCs, there may be a GALS(Global Async Local Sync) module between > +smi-common and m4u, and additional GALS module between smi-larb and > +smi-common. GALS can been seen as a "asynchronous fifo" which could help > +synchronize for the modules in different clock frequency. > > Required properties: > - compatible : must be one of the following string: > @@ -44,18 +48,23 @@ Required properties: > "mediatek,mt7623-m4u", "mediatek,mt2701-m4u" for mt7623 which uses > generation one m4u HW. > "mediatek,mt8173-m4u" for mt8173 which uses generation two m4u HW. > + "mediatek,mt8183-m4u" for mt8183 which uses generation two m4u HW. > - reg : m4u register base and size. > - interrupts : the interrupt of m4u. > - clocks : must contain one entry for each clock-names. > -- clock-names : must be "bclk", It is the block clock of m4u. > +- clock-names : Only 1 optional clock: > + - "bclk": the block clock of m4u. > + Note that m4u use the EMI clock which always has been enabled before kernel > + if there is no this "bclk". Ideally bclk could be specified a little more crisply, as this is actually required for some SoCs and not used at all on others (as in patch 7). > - mediatek,larbs : List of phandle to the local arbiters in the current Socs. > Refer to bindings/memory-controllers/mediatek,smi-larb.txt. It must sort > according to the local arbiter index, like larb0, larb1, larb2... > - iommu-cells : must be 1. This is the mtk_m4u_id according to the HW. > Specifies the mtk_m4u_id as defined in > dt-binding/memory/mt2701-larb-port.h for mt2701, mt7623 > - dt-binding/memory/mt2712-larb-port.h for mt2712, and > - dt-binding/memory/mt8173-larb-port.h for mt8173. > + dt-binding/memory/mt2712-larb-port.h for mt2712, > + dt-binding/memory/mt8173-larb-port.h for mt8173, and > + dt-binding/memory/mt8183-larb-port.h for mt8183. > > Example: > iommu: iommu@10205000 { > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > index e937ddd..8d3240a 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > @@ -2,9 +2,10 @@ SMI (Smart Multimedia Interface) Common > > The hardware block diagram please check bindings/iommu/mediatek,iommu.txt > > -Mediatek SMI have two generations of HW architecture, mt2712 and mt8173 use > -the second generation of SMI HW while mt2701 uses the first generation HW of > -SMI. > +Mediatek SMI have two generations of HW architecture, here is the list > +which generation the Socs use: > +generation 1: mt2701 and mt7623. > +generation 2: mt2712, mt8173 and mt8183. > > There's slight differences between the two SMI, for generation 2, the > register which control the iommu port is at each larb's register base. But > @@ -19,6 +20,7 @@ Required properties: > "mediatek,mt2712-smi-common" > "mediatek,mt7623-smi-common", "mediatek,mt2701-smi-common" > "mediatek,mt8173-smi-common" > + "mediatek,mt8183-smi-common" > - reg : the register and size of the SMI block. > - power-domains : a phandle to the power domain of this local arbiter. > - clocks : Must contain an entry for each entry in clock-names. > @@ -30,6 +32,9 @@ Required properties: > They may be the same if both source clocks are the same. > - "async" : asynchronous clock, it help transform the smi clock into the emi > clock domain, this clock is only needed by generation 1 smi HW. > + and these 2 option clocks for generation 2 smi HW: > + - "gals0": the path0 clock of GALS(Global Async Local Sync). > + - "gals1": the path1 clock of GALS(Global Async Local Sync). It would also be nice to specify these more clearly too, since these are also required for some SoCs and not used on others (as in patch 12). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel