From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFD6C07E9A for ; Mon, 12 Jul 2021 23:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1BCC600CD for ; Mon, 12 Jul 2021 23:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233405AbhGLXtq (ORCPT ); Mon, 12 Jul 2021 19:49:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbhGLXtp (ORCPT ); Mon, 12 Jul 2021 19:49:45 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779A6C0613DD for ; Mon, 12 Jul 2021 16:46:56 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id g22so24926862iom.1 for ; Mon, 12 Jul 2021 16:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cf4yqaJPmTjFkdku0O3vwLmFKdIsVujoTgyzXKaDw0A=; b=K4LjdXUTo4VzmsHX/WnmTu8W+i5OQq+/PImj2JoXAfksmqHgTrxd+f6QtEDjnuLe/O jfmyS1IeRYzi3L5YJzrpxxegX5h3C7k+FTOm2EBSDkhQbkuFli7c3VJjms8+Ps0ZQpdO 4duaNMrChyre5QSRgzTVIWxKoddI/3wB+sEwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cf4yqaJPmTjFkdku0O3vwLmFKdIsVujoTgyzXKaDw0A=; b=LWMpDlS1VRKXK2Sb1gpa7KERaXU0sVag3zjBFeB8kNhsvELUf8emS2CCEXVFY12cMp 7oCef5QW/WRfaH92WqmWeGd+ydcrtRNUSiUMef0AmGKZ2UfKlFkpnO4Q7p27Y8DAqHFc Gr/MskoLrz3ow4uG50hQQCHFGdaX0GIPOS2icmTPIYdH1YxYLhjzcbQQ4o2P8quTf/z7 mXITY4MBSFcDK3AwaKJc4hEaKr9Kv8aW9nO4RsPWTeuzWAGZJgb6CMv7zHtDZfCT7Mzb 1RoS2dseumbYrlU8xJr9sdaeiDPPO7/7Xt+PGjhdNZukpV6g6Nb9n6f7RzTu2jE6wpc8 S+wA== X-Gm-Message-State: AOAM530X5huYjM9juA/CVSksBAxeOXEohYF36MBi//5Pp8XSbQsjypfw g5gETloKKCxZGiulTZug/D0ChcqsYpBXug== X-Google-Smtp-Source: ABdhPJy1Y/gZhDTjfMM3P9VIqvmaRLYLgwrAAxoTy7E6MmQKLi8zeNwo4FKmR0T4xanXzuRR+COjww== X-Received: by 2002:a5d:9c01:: with SMTP id 1mr978333ioe.169.1626133615828; Mon, 12 Jul 2021 16:46:55 -0700 (PDT) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com. [209.85.166.48]) by smtp.gmail.com with ESMTPSA id u15sm3616132ion.34.2021.07.12.16.46.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 16:46:55 -0700 (PDT) Received: by mail-io1-f48.google.com with SMTP id x10so6050968ion.9 for ; Mon, 12 Jul 2021 16:46:54 -0700 (PDT) X-Received: by 2002:a5d:914a:: with SMTP id y10mr1072292ioq.140.1626133614672; Mon, 12 Jul 2021 16:46:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Evan Green Date: Mon, 12 Jul 2021 16:46:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: thunderbolt: Warning and 20 second delay in S4 To: Greg KH Cc: Mika Westerberg , gil.fine@intel.com, Rajmohan Mani , linux-usb@vger.kernel.org, Prashant Malani , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 9, 2021 at 11:34 PM Greg KH wrote: > > On Fri, Jul 09, 2021 at 02:31:35PM -0700, Evan Green wrote: > > Hi Mika et al, > > > > I'm experimenting with suspending to disk (hibernate) on a Tigerlake > > Chromebook running the chromeos-5.4 kernel. I don't have any USB4 > > peripherals plugged in. I'm getting this warning, along with a 20 > > second stall, both when going down for hibernate and coming back up. > > 5.4 is pretty old, especially for thunderbolt issues, can you try 5.13 > please? Good idea. On 5.13.0-next-20210709, I see the warning and delay even at boot when runtime pm kicks in. This should make for an easier repro at least: [ 18.832016] thunderbolt 0000:00:0d.2: 0: timeout reading config space 2 from 0x6 [ 18.840309] ------------[ cut here ]------------ [ 18.845466] thunderbolt 0000:00:0d.2: interrupt for RX ring 0 is already disabled [ 18.853836] WARNING: CPU: 0 PID: 5 at drivers/thunderbolt/nhi.c:103 ring_interrupt_active+0x1b7/0x1da ... [ 18.977736] CPU: 0 PID: 5 Comm: kworker/0:0 Tainted: G U 5.13.0-next-20210709 #18 [ 18.996804] Workqueue: pm pm_runtime_work [ 19.001285] RIP: 0010:ring_interrupt_active+0x1b7/0x1da ... [ 19.100302] Call Trace: [ 19.103031] tb_ring_stop+0x9d/0x17d [ 19.107022] tb_ctl_stop+0x33/0xa0 [ 19.110822] tb_domain_runtime_suspend+0x35/0x3a [ 19.115979] nhi_runtime_suspend+0x1f/0x4c [ 19.120557] pci_pm_runtime_suspend+0x5a/0x173 [ 19.125533] ? pci_pm_restore_noirq+0x73/0x73 [ 19.130411] __rpm_callback+0x8a/0x10d [ 19.134595] rpm_callback+0x22/0x74 [ 19.138489] ? pci_pm_restore_noirq+0x73/0x73 [ 19.143355] rpm_suspend+0x21e/0x514 [ 19.147355] pm_runtime_work+0x8a/0xa5 [ 19.151554] process_one_work+0x1b7/0x368 [ 19.156027] worker_thread+0x213/0x372 [ 19.160217] kthread+0x147/0x15f [ 19.163827] ? pr_cont_work+0x58/0x58 [ 19.167928] ? kthread_blkcg+0x31/0x31 [ 19.172113] ret_from_fork+0x1f/0x30 [ 19.176105] ---[ end trace 438b7f20f6b4049d ]---