From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27CA72 for ; Thu, 17 Jun 2021 11:50:53 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id g22so4784087pgk.1 for ; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=HTT19X0V095oJRTCzBuNJaVN4HZknbDw48KwzexgYxUe8fSxFHwWmx5qCuxOySbqY8 oIhrj+O7sEtFlIQnJUWc8B3UDDiWZ7L1eX+0I1whFlp2IFctgF1Yqe1T6dpLJVdywUwi PnSOnmgj0c1OGJ0xVWQh8sAzW5NzMZoXHcglUWLoaCW+5qtIOnvVlJcA2IUv9VijrNbJ +w0wJnCaVH4AG3cNaf10KKxvykGRkz4rzk461fN+Y+f3xL4ZsAqVxFlqDmQ9byYf3XlY a3nzvcDFou6GLpDPGfHO9wQEClE2m9vU5ZIbj2FddMNRAanPHC78pShAINAcd0YZzSyG BitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=k2tR/ZGfLf5m0ki9SnH0Ap8tl2wMB+OjoxhdoRP9zVB97wRwj1UjiUrA7kX9u7UG2x 6lTDp8juoULenGy7IyOK5iqheDX75BY5finLt+gIokMKheLxyN9Z75zuHdNiZsBhk8om tijzYu1K8APY74yerdbPtrBVW1bhDIhxmH+BVGJipXcUDimc9gEukLB/AvcmQ3pVfQg0 DyKaIthvdQG1tVi0ZyMeiVUYrQtgK9zzrwMgd20QHZxxggrbrmynu5PruEMGuMDa0D1D KTamh96FT538a6X1ISo686UVuEsWSMNiXFC4vm+l2ZioKGRDohema5/Hwk1gIQRC5AqU C5qg== X-Gm-Message-State: AOAM532qSPtjYsTaU1hZ92yWX7h10dukQJ71FDpzN7+R1RXf2LqoJpvp ZMLpeMacwmcD6jEzb67qMZCHqHU6JjL0AoBwqg== X-Google-Smtp-Source: ABdhPJzLsfs3op+S3slb9TqsEE9rDKBjbpT/kYfZDNwghaNqG6qtKFP/8gazWOPOPVAsKMwERdZcGU0aiuCW4mmYCy4= X-Received: by 2002:a63:f344:: with SMTP id t4mr4676265pgj.314.1623930653336; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210615130326.2044-1-fengzheng923@gmail.com> <20210615132207.GG5149@sirena.org.uk> <20210617104828.GA5067@sirena.org.uk> In-Reply-To: <20210617104828.GA5067@sirena.org.uk> From: =?UTF-8?B?54+t5rab?= Date: Thu, 17 Jun 2021 19:50:42 +0800 Message-ID: Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver To: Mark Brown Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, p.zabel@pengutronix.de, Samuel Holland , krzk@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi=EF=BC=8C Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8817=E6=97=A5= =E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=886:48=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, Jun 17, 2021 at 03:42:43PM +0800, =E7=8F=AD=E6=B6=9B wrote: > > Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:22=E5=86=99=E9=81=93=EF=BC=9A > > > > > @@ -0,0 +1,408 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > +/* > > > > + * ALSA SoC DMIC Audio Layer > > > > + * > > > > + * Copyright 2021 Ban Tao > > > > + * > > > > Please make the entire comment a C++ one so things look more > > > intentional. > > > For example; > > // SPDX-License-Identifier: GPL-2.0-or-later > > /* > > * This driver supports the DMIC in Allwinner's H6 SoCs. > > * > > * Copyright 2021 Ban Tao > > * > > */ > > is this OK? > > No, that's what you have already make the entire thing a C++ comment > with //s. I don=E2=80=99t understand. For example, sun4i-codec.c sun4i-i2s.c sun8i-codec.c and sun4i-spdif.c files are the same as mine. Which file can I refer to? what should I do...... > > > > > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > + base =3D devm_ioremap_resource(&pdev->dev, res); > > > > > > devm_platform_ioremap_resource() > > > > But I need to get the register base address of DMIC. E.g res->start. > > host->dma_params_rx.addr =3D res->start + SUN50I_DMIC_DATA; > > OK. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17954C49361 for ; Thu, 17 Jun 2021 11:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0376261412 for ; Thu, 17 Jun 2021 11:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232557AbhFQLxF (ORCPT ); Thu, 17 Jun 2021 07:53:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232580AbhFQLxC (ORCPT ); Thu, 17 Jun 2021 07:53:02 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CACE0C061574 for ; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id n12so4735749pgs.13 for ; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=HTT19X0V095oJRTCzBuNJaVN4HZknbDw48KwzexgYxUe8fSxFHwWmx5qCuxOySbqY8 oIhrj+O7sEtFlIQnJUWc8B3UDDiWZ7L1eX+0I1whFlp2IFctgF1Yqe1T6dpLJVdywUwi PnSOnmgj0c1OGJ0xVWQh8sAzW5NzMZoXHcglUWLoaCW+5qtIOnvVlJcA2IUv9VijrNbJ +w0wJnCaVH4AG3cNaf10KKxvykGRkz4rzk461fN+Y+f3xL4ZsAqVxFlqDmQ9byYf3XlY a3nzvcDFou6GLpDPGfHO9wQEClE2m9vU5ZIbj2FddMNRAanPHC78pShAINAcd0YZzSyG BitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=fHJJdo247M1F0//2xM8XJ9FJyAYY1knbjQLgaK1flEgtbBWNlgePp7u4axP4GuqFlF eqzfswac3V1c9QR6Hj2CXfqY6bnvheylZLwvD7oVk/gQrCtDob4uLuKXWoWEHPEWSZq5 KZve9O5d+iO7SPv3uKWpEptmQGKW0N7KQ9nXzOjdYL9a3Eaoz2CobPbNG1wooI8dzd7U UXU5L1S4Q5iMTiTFYjEuTtdGNGSf9k1EOmwzFhB2cK2l4GV2CaFIEiGMVza0bJrWKxOs 6VqQnxPDa6fxqHHW1IxfoaiY71asP3wQEs4+fgb+Za3Ftsrfb0sfBJPC6QCB/gwsO5/t m7HA== X-Gm-Message-State: AOAM530O2q3KYM9SYWcGXAY3b3Jeh+lkQqhv7BJXTQrDCj4qU167KpKT 2kfL86lVREc874bKHaaH31T4+aan0HuP04X0qETSwonULQdk X-Google-Smtp-Source: ABdhPJzLsfs3op+S3slb9TqsEE9rDKBjbpT/kYfZDNwghaNqG6qtKFP/8gazWOPOPVAsKMwERdZcGU0aiuCW4mmYCy4= X-Received: by 2002:a63:f344:: with SMTP id t4mr4676265pgj.314.1623930653336; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) MIME-Version: 1.0 References: <20210615130326.2044-1-fengzheng923@gmail.com> <20210615132207.GG5149@sirena.org.uk> <20210617104828.GA5067@sirena.org.uk> In-Reply-To: <20210617104828.GA5067@sirena.org.uk> From: =?UTF-8?B?54+t5rab?= Date: Thu, 17 Jun 2021 19:50:42 +0800 Message-ID: Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver To: Mark Brown Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, p.zabel@pengutronix.de, Samuel Holland , krzk@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi=EF=BC=8C Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8817=E6=97=A5= =E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=886:48=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, Jun 17, 2021 at 03:42:43PM +0800, =E7=8F=AD=E6=B6=9B wrote: > > Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:22=E5=86=99=E9=81=93=EF=BC=9A > > > > > @@ -0,0 +1,408 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > +/* > > > > + * ALSA SoC DMIC Audio Layer > > > > + * > > > > + * Copyright 2021 Ban Tao > > > > + * > > > > Please make the entire comment a C++ one so things look more > > > intentional. > > > For example; > > // SPDX-License-Identifier: GPL-2.0-or-later > > /* > > * This driver supports the DMIC in Allwinner's H6 SoCs. > > * > > * Copyright 2021 Ban Tao > > * > > */ > > is this OK? > > No, that's what you have already make the entire thing a C++ comment > with //s. I don=E2=80=99t understand. For example, sun4i-codec.c sun4i-i2s.c sun8i-codec.c and sun4i-spdif.c files are the same as mine. Which file can I refer to? what should I do...... > > > > > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > + base =3D devm_ioremap_resource(&pdev->dev, res); > > > > > > devm_platform_ioremap_resource() > > > > But I need to get the register base address of DMIC. E.g res->start. > > host->dma_params_rx.addr =3D res->start + SUN50I_DMIC_DATA; > > OK. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C2A6C2B9F4 for ; Thu, 17 Jun 2021 14:45:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7631613A9 for ; Thu, 17 Jun 2021 14:45:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7631613A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7DDCF17A0; Thu, 17 Jun 2021 16:44:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7DDCF17A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623941141; bh=ZzfNRq8VlfTSVxlffgyExpOk1y7AxRbVDBop4Zo+QZw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lNQJRYZCSznZLexinB+UlHv9uKfHUCOSCvDWsbXsDvDflBDdcKKu0P3UC9lZ1zYfP 8a/G+yCttKOido+DU/miHJtaM9LB17Xrgpe3IAblgM7SnHDDlJEc0dGY1zEdzJNKAI 039863X/OjNNeNUDN2VTryfjJtd1rxZq0aKeHXpw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6C413F805C1; Thu, 17 Jun 2021 16:35:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7CE5FF8025A; Thu, 17 Jun 2021 13:51:07 +0200 (CEST) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61146F8016D for ; Thu, 17 Jun 2021 13:50:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61146F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTT19X0V" Received: by mail-pg1-x533.google.com with SMTP id e20so4811401pgg.0 for ; Thu, 17 Jun 2021 04:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=HTT19X0V095oJRTCzBuNJaVN4HZknbDw48KwzexgYxUe8fSxFHwWmx5qCuxOySbqY8 oIhrj+O7sEtFlIQnJUWc8B3UDDiWZ7L1eX+0I1whFlp2IFctgF1Yqe1T6dpLJVdywUwi PnSOnmgj0c1OGJ0xVWQh8sAzW5NzMZoXHcglUWLoaCW+5qtIOnvVlJcA2IUv9VijrNbJ +w0wJnCaVH4AG3cNaf10KKxvykGRkz4rzk461fN+Y+f3xL4ZsAqVxFlqDmQ9byYf3XlY a3nzvcDFou6GLpDPGfHO9wQEClE2m9vU5ZIbj2FddMNRAanPHC78pShAINAcd0YZzSyG BitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=I1aaxlA1T3tu5SfLf8f4c116yO/rttE3VwyBOPo1mW+7mz0jvamQNbBZQ5UNi/ZLRm 6AES4mVKnGEzVFuzQ8qg07tm1239VLiA5yB0Bt543s1ZybT/I1HKOILVTv+uBObEIwVc QTISsOiHuJjODeqUs51oaC0O29gEz8b56dWZ/CwtIMyXRxKu/PDttiq+Fj5aUnMNG+Cx SBkX3EVnToRvJrIw1IioB66qDFRs/x+Br4zjNxvxSckyqEwUW0Dh2VpP7UENeXflAog/ uJ+BY/neBWtwXlv7l5sH8w1r/owa4t45FRLCTDtjWIGX6uSj9aoTjwBiphdQsLL8XZVm lGGg== X-Gm-Message-State: AOAM531NnprR7hEHAmw4QPtI4X3pDOO9W786CqEK0SoZqJbYon97xGJ/ t5dh7mvZJtsODxSr81kArekWgYUmd44UkO5Y7g== X-Google-Smtp-Source: ABdhPJzLsfs3op+S3slb9TqsEE9rDKBjbpT/kYfZDNwghaNqG6qtKFP/8gazWOPOPVAsKMwERdZcGU0aiuCW4mmYCy4= X-Received: by 2002:a63:f344:: with SMTP id t4mr4676265pgj.314.1623930653336; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) MIME-Version: 1.0 References: <20210615130326.2044-1-fengzheng923@gmail.com> <20210615132207.GG5149@sirena.org.uk> <20210617104828.GA5067@sirena.org.uk> In-Reply-To: <20210617104828.GA5067@sirena.org.uk> From: =?UTF-8?B?54+t5rab?= Date: Thu, 17 Jun 2021 19:50:42 +0800 Message-ID: Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver To: Mark Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 17 Jun 2021 16:34:45 +0200 Cc: alsa-devel@alsa-project.org, krzk@kernel.org, Samuel Holland , linux-kernel@vger.kernel.org, tiwai@suse.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, wens@csie.org, mripard@kernel.org, p.zabel@pengutronix.de, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi=EF=BC=8C Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8817=E6=97=A5= =E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=886:48=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, Jun 17, 2021 at 03:42:43PM +0800, =E7=8F=AD=E6=B6=9B wrote: > > Mark Brown =E4=BA=8E2021=E5=B9=B46=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=889:22=E5=86=99=E9=81=93=EF=BC=9A > > > > > @@ -0,0 +1,408 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > +/* > > > > + * ALSA SoC DMIC Audio Layer > > > > + * > > > > + * Copyright 2021 Ban Tao > > > > + * > > > > Please make the entire comment a C++ one so things look more > > > intentional. > > > For example; > > // SPDX-License-Identifier: GPL-2.0-or-later > > /* > > * This driver supports the DMIC in Allwinner's H6 SoCs. > > * > > * Copyright 2021 Ban Tao > > * > > */ > > is this OK? > > No, that's what you have already make the entire thing a C++ comment > with //s. I don=E2=80=99t understand. For example, sun4i-codec.c sun4i-i2s.c sun8i-codec.c and sun4i-spdif.c files are the same as mine. Which file can I refer to? what should I do...... > > > > > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > + base =3D devm_ioremap_resource(&pdev->dev, res); > > > > > > devm_platform_ioremap_resource() > > > > But I need to get the register base address of DMIC. E.g res->start. > > host->dma_params_rx.addr =3D res->start + SUN50I_DMIC_DATA; > > OK. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E16C2B9F4 for ; Thu, 17 Jun 2021 11:52:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19763613E7 for ; Thu, 17 Jun 2021 11:52:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19763613E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6bfQ1Dml2yVRKu5H1153D18sfnV5ga1Zder32VIrH/Y=; b=t5qNm4b3D8943V BGUCbyOpYnxQoTzGWTPV5u3JiV/zSiV9H94a7/GdWqOhgW4qBO1cgRud2L7OBNd3k7SQHoqOxDO93 o/4XfGTNTyTIPgCcSnx0C1FQ5qfcmKCqiYQXZD2HqmxhQleK03qeOC6r9LzUW1OM6NP5mDBho801i zvNofLrkdXEhpeDQbI4GaHOAbwWZsNv4PLJgGl8tNkgbnb3ZWDMV+Txmrj71K5fy7w+yPT99d9oN3 iq5Ql+iMAQQ1anxgfTgxrWoXr5Fhi9PkfzXWLSwBdxPLw+Q4q1Nv47db3fs6f2C02lGasjM/LMnNh 23NpfFNsD5HWIQi8riTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltqY1-00A9CM-8b; Thu, 17 Jun 2021 11:51:01 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltqXu-00A9An-Fy for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 11:50:55 +0000 Received: by mail-pg1-x52b.google.com with SMTP id e20so4811398pgg.0 for ; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=HTT19X0V095oJRTCzBuNJaVN4HZknbDw48KwzexgYxUe8fSxFHwWmx5qCuxOySbqY8 oIhrj+O7sEtFlIQnJUWc8B3UDDiWZ7L1eX+0I1whFlp2IFctgF1Yqe1T6dpLJVdywUwi PnSOnmgj0c1OGJ0xVWQh8sAzW5NzMZoXHcglUWLoaCW+5qtIOnvVlJcA2IUv9VijrNbJ +w0wJnCaVH4AG3cNaf10KKxvykGRkz4rzk461fN+Y+f3xL4ZsAqVxFlqDmQ9byYf3XlY a3nzvcDFou6GLpDPGfHO9wQEClE2m9vU5ZIbj2FddMNRAanPHC78pShAINAcd0YZzSyG BitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sKn9UvDVlydbDfhyjcKiR8IQebdYWuPzRo3dE9qFvzU=; b=kB0wX2sOOF9VztktPegZxi0vq5Yo+J6qzQXJr8o0xzFRKZLIfTr0RcWS/1/92+SdWW 3/woblRiidAoI5vd1rPrLOjUP9xPKDnI9Uv0gUbb1y4OdkatKwDTto490nkgb1HpBVx/ cU31Ofg2CEWB7Iuveohlly1vE5k63TjE/bNo2OfyOqezOLV70a+Gp716wK7Ogqbl1bys apl0VP3YguN6tONyQAraqkS/1hyM7leRm7TdG1OSJDh7OqUm9tTXIZKsYy7qr8ZXVix1 Dc9B5bW2CAIXm92srbfur2wj3CytOV/YcDLXq4mY+2kOCYVUKaH1zyvBLo8D91s8WKjf ADdg== X-Gm-Message-State: AOAM533XM0aBdvtRqLL4UTjaBDt0dmjnlDdj5KlsHcu8pVpT28f3dJTd Fmc0zbzsrYeDXKkOzeko6YVeBUqzT6bCHkzM7g== X-Google-Smtp-Source: ABdhPJzLsfs3op+S3slb9TqsEE9rDKBjbpT/kYfZDNwghaNqG6qtKFP/8gazWOPOPVAsKMwERdZcGU0aiuCW4mmYCy4= X-Received: by 2002:a63:f344:: with SMTP id t4mr4676265pgj.314.1623930653336; Thu, 17 Jun 2021 04:50:53 -0700 (PDT) MIME-Version: 1.0 References: <20210615130326.2044-1-fengzheng923@gmail.com> <20210615132207.GG5149@sirena.org.uk> <20210617104828.GA5067@sirena.org.uk> In-Reply-To: <20210617104828.GA5067@sirena.org.uk> From: =?UTF-8?B?54+t5rab?= Date: Thu, 17 Jun 2021 19:50:42 +0800 Message-ID: Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver To: Mark Brown Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, p.zabel@pengutronix.de, Samuel Holland , krzk@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_045054_609610_A1D037C0 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGnvvIwKCk1hcmsgQnJvd24gPGJyb29uaWVAa2VybmVsLm9yZz4g5LqOMjAyMeW5tDbmnIgxN+aX peWRqOWbmyDkuIvljYg2OjQ45YaZ6YGT77yaCj4KPiBPbiBUaHUsIEp1biAxNywgMjAyMSBhdCAw Mzo0Mjo0M1BNICswODAwLCDnj63mtpsgd3JvdGU6Cj4gPiBNYXJrIEJyb3duIDxicm9vbmllQGtl cm5lbC5vcmc+IOS6jjIwMjHlubQ25pyIMTXml6Xlkajkuowg5LiL5Y2IOToyMuWGmemBk++8mgo+ Cj4gPiA+ID4gQEAgLTAsMCArMSw0MDggQEAKPiA+ID4gPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50 aWZpZXI6IEdQTC0yLjAtb3ItbGF0ZXIKPiA+ID4gPiArLyoKPiA+ID4gPiArICogQUxTQSBTb0Mg RE1JQyBBdWRpbyBMYXllcgo+ID4gPiA+ICsgKgo+ID4gPiA+ICsgKiBDb3B5cmlnaHQgMjAyMSBC YW4gVGFvIDxmZW5nemhlbmc5MjNAZ21haWwuY29tPgo+ID4gPiA+ICsgKgo+Cj4gPiA+IFBsZWFz ZSBtYWtlIHRoZSBlbnRpcmUgY29tbWVudCBhIEMrKyBvbmUgc28gdGhpbmdzIGxvb2sgbW9yZQo+ ID4gPiBpbnRlbnRpb25hbC4KPgo+ID4gRm9yIGV4YW1wbGU7Cj4gPiAvLyBTUERYLUxpY2Vuc2Ut SWRlbnRpZmllcjogR1BMLTIuMC1vci1sYXRlcgo+ID4gLyoKPiA+ICAqIFRoaXMgZHJpdmVyIHN1 cHBvcnRzIHRoZSBETUlDIGluIEFsbHdpbm5lcidzIEg2IFNvQ3MuCj4gPiAgKgo+ID4gICogQ29w eXJpZ2h0IDIwMjEgQmFuIFRhbyA8ZmVuZ3poZW5nOTIzQGdtYWlsLmNvbT4KPiA+ICAqCj4gPiAg Ki8KPiA+IGlzIHRoaXMgT0s/Cj4KPiBObywgdGhhdCdzIHdoYXQgeW91IGhhdmUgYWxyZWFkeSBt YWtlIHRoZSBlbnRpcmUgdGhpbmcgYSBDKysgY29tbWVudAo+IHdpdGggLy9zLgoKSSBkb27igJl0 IHVuZGVyc3RhbmQuIEZvciBleGFtcGxlLCBzdW40aS1jb2RlYy5jIHN1bjRpLWkycy5jCnN1bjhp LWNvZGVjLmMgYW5kIHN1bjRpLXNwZGlmLmMgZmlsZXMgYXJlIHRoZSBzYW1lIGFzIG1pbmUuCldo aWNoIGZpbGUgY2FuIEkgcmVmZXIgdG8/IHdoYXQgc2hvdWxkIEkgZG8uLi4uLi4KPgo+ID4gPiA+ ICsgICAgIHJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwg MCk7Cj4gPiA+ID4gKyAgICAgYmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZSgmcGRldi0+ZGV2 LCByZXMpOwo+ID4gPgo+ID4gPiBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UoKQo+ID4K PiA+IEJ1dCBJIG5lZWQgdG8gZ2V0IHRoZSByZWdpc3RlciBiYXNlIGFkZHJlc3Mgb2YgRE1JQy4g RS5nIHJlcy0+c3RhcnQuCj4gPiBob3N0LT5kbWFfcGFyYW1zX3J4LmFkZHIgPSByZXMtPnN0YXJ0 ICsgU1VONTBJX0RNSUNfREFUQTsKPgo+IE9LLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=