From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDE1C6377B for ; Mon, 19 Jul 2021 16:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A12761431 for ; Mon, 19 Jul 2021 16:10:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346748AbhGSPaB (ORCPT ); Mon, 19 Jul 2021 11:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348588AbhGSPYz (ORCPT ); Mon, 19 Jul 2021 11:24:55 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A501C021985 for ; Mon, 19 Jul 2021 08:16:26 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id c16so21716025ybl.9 for ; Mon, 19 Jul 2021 08:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qxsFx/ud5bCkcwO5HB+617yeOVe2OtySxQQLQ/kd00c=; b=SZ7V6QfTXzZC4NeKDxbXlI5mMgJMxbREy18Rd/NI3UwpSRc92lfJL76RaHYwZX6MJz C/I1RP6h7HnirQqf2zki2ZRoLaPPffJhtdolKAblLUcf60syYxAx9ArzCcQcEgvAl+m2 wf7+udjOND7FBJNbP3fLzl45oNkVW6LRN94KMCOzu8bVT1OY7ys6SbVzS08TTYuqb+Xc RSXIOY3d6/S1oVVravKnq652urGIOXj+NTnQMBdKzzrFWFseExCANF1X63bWJKR8/7ST ad2731DR1I/8eWbsbBi73jDbwRhISZtruJ7myR9BtZCc2wlD7vd0gYgZR9fupF7X9sqR F7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qxsFx/ud5bCkcwO5HB+617yeOVe2OtySxQQLQ/kd00c=; b=ELqGU3QabQzjHrK8fqSsHm1NnkHay3GJK5rtK0e6cLFkBsJwT55qfrwk7EATMVb4+j aQp7Cu4gacSate6lw3rdshXw9qgZb7HaM439VYbku9HajXl9bkyKmwZQTN2rMWcVz4hw kcoYkklXG6MmwtcL7rPXyZtnKAWFPg6PDSPtmKnFCTb7l3nPLQNufg8N2JglzX1rUKPB vIM/O2kzduKksV04EAd+cC1cMQ4LUPkU5JH0t/ERomxlOYpGEq/IyEIdsFVpLv/JpS/w hNs8pHuVGryLVG/H7LW1pLZQQ1SVc123krd3krJm5eWThxw5e4dBbLJnEKZ/zzrDyPs4 7/tg== X-Gm-Message-State: AOAM531MeZfQHSGn0KGtITEm6ECUs7CmpnmypHdq/qYaX3Cyh+Yoa51X LnsZgDfNrvRDkaY4lXFbbYPSM73YLQz3vMX5ojgFdg== X-Google-Smtp-Source: ABdhPJzMZXAc4RqPTXHU6XBJrb+duW+lb+Rvxv6ctjrG0OO2TtcXbYDI0TjM/dNlljDupLfuzg9YbHeDP9Q+kfprtZ0= X-Received: by 2002:a25:acde:: with SMTP id x30mr32924263ybd.123.1626709430620; Mon, 19 Jul 2021 08:43:50 -0700 (PDT) MIME-Version: 1.0 References: <20210719092028.3016745-1-eric.dumazet@gmail.com> In-Reply-To: <20210719092028.3016745-1-eric.dumazet@gmail.com> From: Wei Wang Date: Mon, 19 Jul 2021 08:43:36 -0700 Message-ID: Subject: Re: [PATCH net] net/tcp_fastopen: remove obsolete extern To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , netdev , Eric Dumazet , Haishuang Yan , Yuchung Cheng , Neal Cardwell Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 19, 2021 at 2:20 AM Eric Dumazet wrote: > > From: Eric Dumazet > > After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer > a global variable. > > Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob") > Signed-off-by: Eric Dumazet > Cc: Haishuang Yan > Cc: Wei Wang > Cc: Yuchung Cheng > Cc: Neal Cardwell > --- Acked-by: Wei Wang > include/net/tcp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/net/tcp.h b/include/net/tcp.h > index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644 > --- a/include/net/tcp.h > +++ b/include/net/tcp.h > @@ -1709,7 +1709,6 @@ struct tcp_fastopen_context { > struct rcu_head rcu; > }; > > -extern unsigned int sysctl_tcp_fastopen_blackhole_timeout; > void tcp_fastopen_active_disable(struct sock *sk); > bool tcp_fastopen_active_should_disable(struct sock *sk); > void tcp_fastopen_active_disable_ofo_check(struct sock *sk); > -- > 2.32.0.402.g57bb445576-goog >