From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Hlavacek Date: Sat, 22 Sep 2012 02:37:00 +0200 Subject: [U-Boot] [PATCHv4] [RFC] DM: early_malloc for DM added. In-Reply-To: References: <1346069529-27397-1-git-send-email-tmshlvck@gmail.com> <1347952436-5722-1-git-send-email-tmshlvck@gmail.com> <201209181257.53329.marex@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello all, I have sent a new version. Although I tried to take into account all the opinions and comments I might have missed something. On Wed, Sep 19, 2012 at 1:29 AM, Graeme Russ wrote: >> >> I'd say, pull out the modification of global data into separate patch and put it >> before this patch. That'd make review of the core code much easier. > > NAK - The addition of the global data member is intrinsic to the early > malloc implmentaion. Keep them together Yes, I think that in this case one does not make sense with the other. I kept them rather together. > >>> + >>> +struct early_heap_header *early_brk(size_t size) >>> + __attribute__((weak, alias("def_early_brk"))); >> >> what about using (it needs ): >> >> __weak struct early_heap_header *early_brk(size_t size) >> { >> ... >> body >> ... >> } > > We already have a lot of the former - I prefer not to add additional > semantics (unless you want to do a wholesale search/replace ;)) This time I used the shorter / newer variant. Hope this would be better. Tomas -- Tom?? Hlav??ek