All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Szakmeister <john@szakmeister.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	Timo Sand <timo.j.sand@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X
Date: Wed, 3 Apr 2013 20:10:10 -0400	[thread overview]
Message-ID: <CAEBDL5WEChOgG2XVML=tjWtUgp4_5nQq-KqQv-h79tgaDTx9bA@mail.gmail.com> (raw)
In-Reply-To: <7vfvzgrjgz.fsf@alter.siamese.dyndns.org>

On Wed, Mar 27, 2013 at 10:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
[snip]
> If that approach is better than what you originally sent, then yes.
>
> But I do not use OS X, so you may need to pay attention to possible
> complaints and comments from other Mac users on this list for a
> while---there may be people who run the program in question without
> that environment variable.

Sorry it has taken me so long to get back to this.  I searched around
and tried out a few terminal programs that are available, and I think
what you queued--checking that TERM_PROGRAM is non-empty--is the right
fix.

Thanks!

-John

      reply	other threads:[~2013-04-04  0:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMxBVSs6dJFnK78E2Da7t4V9ndJFRVDZEd1fR5QuCFz=u2Bnpw@mail.gmail.com>
2013-03-14 11:39 ` Fwd: Bug: git web--browse doesn't recognise browser on OS X Timo Sand
2013-03-15 11:19   ` Christian Couder
2013-03-22 16:19     ` Timo Sand
2013-03-22 17:36       ` John Szakmeister
2013-03-24 21:05         ` Christian Couder
2013-03-25 10:13           ` [PATCH] git-web--browse: recognize iTerm as a GUI terminal " John Szakmeister
2013-03-25 20:13             ` Christian Couder
2013-03-25 21:44             ` Junio C Hamano
2013-03-26  8:54               ` John Szakmeister
2013-03-27 14:43                 ` Junio C Hamano
2013-04-04  0:10                   ` John Szakmeister [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEBDL5WEChOgG2XVML=tjWtUgp4_5nQq-KqQv-h79tgaDTx9bA@mail.gmail.com' \
    --to=john@szakmeister.net \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=timo.j.sand@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.