From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDD5C433E0 for ; Sat, 23 May 2020 17:01:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 933B320738 for ; Sat, 23 May 2020 17:01:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UnAzIn+3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 933B320738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jcXVz-00036j-Dz; Sat, 23 May 2020 17:00:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jcXVy-00036c-Aa for xen-devel@lists.xenproject.org; Sat, 23 May 2020 17:00:50 +0000 X-Inumbo-ID: f361723e-9d16-11ea-b07b-bc764e2007e4 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f361723e-9d16-11ea-b07b-bc764e2007e4; Sat, 23 May 2020 17:00:49 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id 202so8300202lfe.5 for ; Sat, 23 May 2020 10:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9fDPcNUZbFygQrZ1OlCwnzyfUVPdIJzfte36WKBK3I4=; b=UnAzIn+3r9pO5BkhG4ujop/i71xK5SFgkJhBVTLvFzIZI+LJDZUuMJOOCYZDA9Ckxh zUcALSWGjDuWCJqWWKHnPtM2CwmEOSpwt9lBmMyVoVS/04cfAongYgqW7k0E5QTVKx8c H3qDom1lRp6RCUoxTQpgJ2mitwYaKq134CR80Cbyhb+bwLJk+sV9Jvpnk1M1yA0xxjVr M4JqCiv+gr9wc3uwY4L635R6fsrAymiGt+y7ABYWmuWkAqO6E+h8dfOxGWZCrCN1RV0z BLzm7djTY9A07SWLsb83SrW49yHtSApLJf9ih7qMi5tSCWQMTg8QHLq90ZicoBWK88Lw vtTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9fDPcNUZbFygQrZ1OlCwnzyfUVPdIJzfte36WKBK3I4=; b=mMSwYYGXtc+oon4EFKDECgG9gB60lLajLW3Uub1JVLDtm6IiRLHMC0ElEjmkb8ylEI SIfBk7c+3z3c4+UG/KBEjxcyvK5E/xaRmiJLJ+otoc0mLjw9RUbGOtsrJJqwDpQjg899 SfN158K/0p5csFuM2QjqRcIRzmsKNWcPZTpMkTlOk/FtJTsM6chj0qj3GjZFQFjBCvZg SYMHnal+uBbk6fA3yQ4CX3s6LOrp1CsLNUPfvqRsRe+XhmMo42kB+rBZdxLWmOhdCOGq Rtu+DS0DXpkzt4SPHCKrOHgw++is6cIlj9BjOeDaXciJG/H1JZCB0f0TZsqjnzFS9Ewh l5VA== X-Gm-Message-State: AOAM530DZD01D/E9L7P4IuH2KNAXT+nEGdjLiJFUOS0RJ2dQRTnR8eOF 2q+nNL8w1Q1cwfnAsjAWV9uzyGKJT8LXWfpSJmc= X-Google-Smtp-Source: ABdhPJxrRCNRvbWb2rqnbtUYaBeJ8YjxU69t2Z41coZBu81PXvf0lJ6v8Uj8COeelWR67dK0nQPDTE5Io3ohqp1Qukw= X-Received: by 2002:a05:6512:3139:: with SMTP id p25mr10336280lfd.214.1590253248070; Sat, 23 May 2020 10:00:48 -0700 (PDT) MIME-Version: 1.0 References: <20200522161240.3748320-1-george.dunlap@citrix.com> <20200522161240.3748320-4-george.dunlap@citrix.com> In-Reply-To: <20200522161240.3748320-4-george.dunlap@citrix.com> From: Nick Rosbrook Date: Sat, 23 May 2020 13:00:37 -0400 Message-ID: Subject: Re: [PATCH 3/5] libxl: Generate golang bindings in libxl Makefile To: George Dunlap Content-Type: text/plain; charset="UTF-8" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , Xen-devel , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > The generated golang bindings (types.gen.go and helpers.gen.go) are > left checked in so that they can be fetched from xenbits using the > golang tooling. This means that they must be updated whenever > libxl_types.idl (or other dependencies) are updated. However, the > golang bindings are only built optionally; we can't assume that anyone > updating libxl_types.idl will also descend into the tools/golang tree > to re-generate the bindings. > > Fix this by re-generating the golang bindings from the libxl Makefile > when the IDL dependencies are updated, so that anyone who updates > libxl_types.idl will also end up updating the golang generated files > as well. > > - Make a variable for the generated files, and a target in > xenlight/Makefile which will only re-generate the files. > > - Add a target in libxl/Makefile to call external idl generation > targets (currently only golang). > > For ease of testing, also add a specific target in libxl/Makefile just > to check and update files generated from the IDL. > > This does mean that there are two potential paths for generating the > files during a parallel build; but that shouldn't be an issue, since > tools/golang/xenlight should never be built until after tools/libxl > has completed building anyway. > > Signed-off-by: George Dunlap For the golang side: Reviewed-by: Nick Rosbrook