From: Nick Rosbrook <rosbrookn@gmail.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
paul@xen.org
Subject: Re: [PATCH for-4.14] golang/xenlight: fix code generation for python 2.6
Date: Mon, 20 Jul 2020 20:07:31 -0400 [thread overview]
Message-ID: <CAEBZRSffdZUWweDvZ9ZDMiemO4BGj10M4rj2Qmz3yFkgQhrn+g@mail.gmail.com> (raw)
In-Reply-To: <d406ae82e0cdde2dc33a92d2685ffb77bacab7ee.1595289055.git.rosbrookn@ainfosec.com>
> Before python 2.7, str.format() calls required that the format fields
> were explicitly enumerated, e.g.:
>
> '{0} {1}'.format(foo, bar)
>
> vs.
>
> '{} {}'.format(foo, bar)
>
> Currently, gengotypes.py uses the latter pattern everywhere, which means
> the Go bindings do not build on python 2.6. Use the 2.6 syntax for
> format() in order to support python 2.6 for now.
>
> Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
I should add that I tested this with CONTAINER=centos6
./automation/scripts/containerize for python 2.6, and on my ubuntu
system with both python 2.7 and 3.6.
-NR
next prev parent reply other threads:[~2020-07-21 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 23:54 [PATCH for-4.14] golang/xenlight: fix code generation for python 2.6 Nick Rosbrook
2020-07-21 0:07 ` Nick Rosbrook [this message]
2020-07-21 7:13 ` Paul Durrant
2020-07-21 9:20 ` Andrew Cooper
2020-07-21 9:23 ` Paul Durrant
2020-07-21 9:53 ` George Dunlap
2020-07-21 10:22 ` Paul Durrant
2020-07-21 10:37 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEBZRSffdZUWweDvZ9ZDMiemO4BGj10M4rj2Qmz3yFkgQhrn+g@mail.gmail.com \
--to=rosbrookn@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paul@xen.org \
--cc=rosbrookn@ainfosec.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.