From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Guyader Subject: Re: [PATCH 4/4] xen: Add V4V implementation Date: Thu, 4 Oct 2012 16:03:09 +0100 Message-ID: References: <1348141322-28657-1-git-send-email-jean.guyader@citrix.com> <1348141322-28657-5-git-send-email-jean.guyader@citrix.com> <505B2636020000780009CAA6@nat28.tlf.novell.com> <506D98FE020000780009FA23@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <506D98FE020000780009FA23@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: tim@xen.org, Jean Guyader , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 4 October 2012 13:11, Jan Beulich wrote: >>>> On 04.10.12 at 14:03, Jean Guyader wrote: >> On 20 September 2012 13:20, Jan Beulich wrote: >>>>>> On 20.09.12 at 13:42, Jean Guyader wrote: >>>>+ case V4VOP_register_ring: >>>>+ { >>>>+ XEN_GUEST_HANDLE(v4v_ring_t) ring_hnd = >>>>+ guest_handle_cast(arg1, v4v_ring_t); >>>>+ XEN_GUEST_HANDLE(xen_pfn_t) pfn_hnd = >>>>+ guest_handle_cast(arg2, xen_pfn_t); >>>>+ uint32_t npage = arg3; >>>>+ if ( unlikely(!guest_handle_okay(ring_hnd, 1)) ) >>>>+ goto out; >>>>+ if ( unlikely(!guest_handle_okay(pfn_hnd, npage)) ) >>>>+ goto out; >>> >>> Here and below - this isn't sufficient for compat guests, or else >>> you give them a way to point into the compat m2p table. >>> >> >> I'll probably switch to uint64_t for the v4v mfn list instead of using >> xen_pfn_t which >> are unsigned long. That way I can save the need for a compat wrapper. > > But that comment of yours doesn't address the problem I pointed > out. > [Resent, CCing everyone this time] I'm sorry, I don't really get what you mean them. I've tried to get all my struct layout such as all the offset for the field are the same for 64b and 32b, this way I thought I could get away with doing a compat wrapper. Thanks, Jean