From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay kumar Subject: Re: [PATCH 4/7] drm/exynos: add exynos_dp_panel driver registration to drm driver Date: Sat, 19 Apr 2014 01:20:41 +0530 Message-ID: References: <1397658786-26138-1-git-send-email-ajaykumar.rs@samsung.com> <1397658786-26138-5-git-send-email-ajaykumar.rs@samsung.com> <000201cf5ae4$2b073650$8115a2f0$%han@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1926274490==" Return-path: In-Reply-To: <000201cf5ae4$2b073650$8115a2f0$%han@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jingoo Han Cc: "linux-samsung-soc@vger.kernel.org" , Sean Paul , abrestic@chromium.org, sunil joshi , "dri-devel@lists.freedesktop.org" , a.hajda@samsung.com, Kyungmin Park , treding@nvidia.com, Prashanth G , Ajay Kumar , Rahul Sharma List-Id: linux-samsung-soc@vger.kernel.org --===============1926274490== Content-Type: multipart/alternative; boundary=bcaec547c623f46b5804f756765f --bcaec547c623f46b5804f756765f Content-Type: text/plain; charset=UTF-8 Hi Jingoo, On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han wrote: > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote: > > > > Register exynos_dp_panel before the list of exynos crtcs and > > connectors are probed. > > > > This is needed because exynos_dp_panel should be registered to > > the drm_panel list via panel-exynos-dp probe, i.e much before > > exynos_dp_bind calls of_drm_find_panel(). > > > > Signed-off-by: Ajay Kumar > > --- > > drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 +++++++++++ > > drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 + > > 2 files changed, 12 insertions(+) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c > b/drivers/gpu/drm/exynos/exynos_drm_drv.c > > index 1d1c604..47266e7 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > > @@ -560,12 +560,23 @@ static int exynos_drm_platform_probe(struct > platform_device *pdev) > > goto err_unregister_ipp; > > #endif > > > > +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP > > + ret = platform_driver_register(&exynos_dp_panel_driver); > > + if (ret < 0) > > + goto err_unregister_dp_panel; > > +#endif > > + > > ret = component_master_add(&pdev->dev, &exynos_drm_ops); > > if (ret < 0) > > DRM_DEBUG_KMS("re-tried by last sub driver probed > later.\n"); > > > > return 0; > > > > +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP > > + platform_driver_unregister(&exynos_dp_panel_driver); > > +err_unregister_dp_panel: > > +#endif > > Please add platform_driver_unregister() to exynos_drm_platform_remove(), > Right, I have missed adding it in exynos_drm_platform_remove(). as well as exynos_drm_platform_probe(). > > I have already added for this case! > Best regards, > Jingoo Han > > > + > > #ifdef CONFIG_DRM_EXYNOS_IPP > > exynos_platform_device_ipp_unregister(); > > err_unregister_ipp: > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h > b/drivers/gpu/drm/exynos/exynos_drm_drv.h > > index 257ce09..f606290 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h > > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h > > @@ -368,4 +368,5 @@ extern struct platform_driver fimc_driver; > > extern struct platform_driver rotator_driver; > > extern struct platform_driver gsc_driver; > > extern struct platform_driver ipp_driver; > > +extern struct platform_driver exynos_dp_panel_driver; > > #endif > > -- > > 1.8.1.2 > > Thanks and Regards, Ajay Kumar --bcaec547c623f46b5804f756765f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Jingoo,


On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han <jg1.= han@samsung.com> wrote:
On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
>
> Register exynos_dp_panel before the list of exynos crtcs and
> connectors are probed.
>
> This is needed because exynos_dp_panel should be registered to
> the drm_panel list via panel-exynos-dp probe, i.e much before
> exynos_dp_bind calls of_drm_find_panel().
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> =C2=A0drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 +++++++++++
> =C2=A0drivers/gpu/drm/exynos/exynos_drm_drv.h | =C2=A01 +
> =C2=A02 files changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm= /exynos/exynos_drm_drv.c
> index 1d1c604..47266e7 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -560,12 +560,23 @@ static int exynos_drm_platform_probe(struct plat= form_device *pdev)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto err_unregister_i= pp;
> =C2=A0#endif
>
> +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP
> + =C2=A0 =C2=A0 ret =3D platform_driver_register(&exynos_dp_panel_= driver);
> + =C2=A0 =C2=A0 if (ret < 0)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto err_unregister_dp_pan= el;
> +#endif
> +
> =C2=A0 =C2=A0 =C2=A0 ret =3D component_master_add(&pdev->dev, &= amp;exynos_drm_ops);
> =C2=A0 =C2=A0 =C2=A0 if (ret < 0)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DRM_DEBUG_KMS("r= e-tried by last sub driver probed later.\n");
>
> =C2=A0 =C2=A0 =C2=A0 return 0;
>
> +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP
> + =C2=A0 =C2=A0 platform_driver_unregister(&exynos_dp_panel_driver= );
> +err_unregister_dp_panel:
> +#endif

Please add platform_driver_unregister() to exynos_drm_platform_= remove(),
Right, I have missed adding it in exynos_drm= _platform_remove().

as well as exynos_drm_platform_probe().

I have already added for this case!
=C2=A0
Best regards,
Jingoo Han

> +
> =C2=A0#ifdef CONFIG_DRM_EXYNOS_IPP
> =C2=A0 =C2=A0 =C2=A0 exynos_platform_device_ipp_unregister();
> =C2=A0err_unregister_ipp:
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm= /exynos/exynos_drm_drv.h
> index 257ce09..f606290 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
> @@ -368,4 +368,5 @@ extern struct platform_driver fimc_driver;
> =C2=A0extern struct platform_driver rotator_driver;
> =C2=A0extern struct platform_driver gsc_driver;
> =C2=A0extern struct platform_driver ipp_driver;
> +extern struct platform_driver exynos_dp_panel_driver;
> =C2=A0#endif
> --
> 1.8.1.2


Thanks = and Regards,
Ajay Kumar
--bcaec547c623f46b5804f756765f-- --===============1926274490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1926274490==--