From mboxrd@z Thu Jan 1 00:00:00 1970 From: mohamed nabil Subject: Re: [PATCH 21/22] m68knommu: simplify the ColdFire 532x GPIO struct setup Date: Thu, 26 Apr 2012 03:10:45 +0200 Message-ID: References: <4F989FE1.1090109@snapgear.com> Reply-To: uClinux development list Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3675241749378684453==" Return-path: In-Reply-To: <4F989FE1.1090109@snapgear.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: uclinux-dev-bounces@uclinux.org Sender: uclinux-dev-bounces@uclinux.org To: Greg Ungerer Cc: linux-m68k@vger.kernel.org, Greg Ungerer , uClinux development list List-Id: linux-m68k@vger.kernel.org --===============3675241749378684453== Content-Type: multipart/alternative; boundary=bcaec553fefa516efa04be8aa8a6 --bcaec553fefa516efa04be8aa8a6 Content-Type: text/plain; charset=ISO-8859-1 Ah , Bloody Hell , we should punish this "reflecter" but still 23 emails are too much for 1 bloody min ? no ? On Thu, Apr 26, 2012 at 3:07 AM, Greg Ungerer wrote: > Hi Alex, > > > On 04/26/2012 10:53 AM, Alex LI wrote: > >> You sent 50 mails in 1 min. >> > > I sent 23. And both list archives (linux-m68k and uclinux-dev) only > show the 23 emails. > > Maybe the uclinux-dev reflecter is sending dupes to list recpients? > > Regards > Greg > > > > Sent from my Sony Ericsson Xperia arc S >> >> Greg Ungerer ?: >> >> >> On 04/26/2012 10:36 AM, mohamed nabil wrote: >>> >>>> that's a Fucking spam man !! >>>> >>> >>> Huh? >>> >>> Thats how open source development works. If you don't like it don't >>> subscribe to a developers list. >>> >>> Regards >>> Greg >>> >>> >>> >>> On Thu, Apr 26, 2012 at 2:26 AM,>>> > wrote: >>>> >>>> From: Greg Ungerer> >>>> >>>> The GPIO data struct setup is now the only remaining code in the >>>> platform >>>> gpio.c file. So move it to the platform config.c code and remove the >>>> gpio.c >>>> file. >>>> >>>> Signed-off-by: Greg Ungerer>>> gerg@uclinux.org>> >>>> --- >>>> arch/m68k/platform/532x/**Makefile | 2 +- >>>> arch/m68k/platform/532x/**config.c | 25 ++++++++++++++++++++++ >>>> arch/m68k/platform/532x/gpio.c | 43 >>>> ------------------------------**-------- >>>> 3 files changed, 26 insertions(+), 44 deletions(-) >>>> delete mode 100644 arch/m68k/platform/532x/gpio.c >>>> >>>> diff --git a/arch/m68k/platform/532x/**Makefile >>>> b/arch/m68k/platform/532x/**Makefile >>>> index ce01669..c0d8cf8 100644 >>>> --- a/arch/m68k/platform/532x/**Makefile >>>> +++ b/arch/m68k/platform/532x/**Makefile >>>> @@ -15,4 +15,4 @@ >>>> asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 >>>> >>>> #obj-y := config.o usb-mcf532x.o spi-mcf532x.o >>>> -obj-y := config.o gpio.o >>>> +obj-y := config.o >>>> diff --git a/arch/m68k/platform/532x/**config.c >>>> b/arch/m68k/platform/532x/**config.c >>>> index 2bec347..a4dd3d8 100644 >>>> --- a/arch/m68k/platform/532x/**config.c >>>> +++ b/arch/m68k/platform/532x/**config.c >>>> @@ -26,10 +26,35 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> >>>> /*************************************************************** >>>> ****************/ >>>> >>>> +struct mcf_gpio_chip mcf_gpio_chips[] = { >>>> + MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, >>>> MCFEPORT_EPPDR), >>>> + MCFGPF(FECH, 8, 8), >>>> + MCFGPF(FECL, 16, 8), >>>> + MCFGPF(SSI, 24, 5), >>>> + MCFGPF(BUSCTL, 32, 4), >>>> + MCFGPF(BE, 40, 4), >>>> + MCFGPF(CS, 49, 5), >>>> + MCFGPF(PWM, 58, 4), >>>> + MCFGPF(FECI2C, 64, 4), >>>> + MCFGPF(UART, 72, 8), >>>> + MCFGPF(QSPI, 80, 6), >>>> + MCFGPF(TIMER, 88, 4), >>>> + MCFGPF(LCDDATAH, 96, 2), >>>> + MCFGPF(LCDDATAM, 104, 8), >>>> + MCFGPF(LCDDATAL, 112, 8), >>>> + MCFGPF(LCDCTLH, 120, 1), >>>> + MCFGPF(LCDCTLL, 128, 8), >>>> +}; >>>> + >>>> +unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); >>>> + >>>> +/************************************************************** >>>> *****************/ >>>> + >>>> #ifdef CONFIG_SPI_COLDFIRE_QSPI >>>> >>>> static void __init m532x_qspi_init(void) >>>> diff --git a/arch/m68k/platform/532x/**gpio.c >>>> b/arch/m68k/platform/532x/**gpio.c >>>> deleted file mode 100644 >>>> index 3e1b71d..0000000 >>>> --- a/arch/m68k/platform/532x/**gpio.c >>>> +++ /dev/null >>>> @@ -1,43 +0,0 @@ >>>> -/* >>>> - * Coldfire generic GPIO support >>>> - * >>>> - * (C) Copyright 2009, Steven King>>> > >>>> - * >>>> - * This program is free software; you can redistribute it and/or >>>> modify >>>> - * it under the terms of the GNU General Public License as >>>> published by >>>> - * the Free Software Foundation; version 2 of the License. >>>> - * >>>> - * This program is distributed in the hope that it will be useful, >>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> - * GNU General Public License for more details. >>>> -*/ >>>> - >>>> -#include >>>> -#include >>>> - >>>> -#include >>>> -#include >>>> -#include >>>> - >>>> -struct mcf_gpio_chip mcf_gpio_chips[] = { >>>> - MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, >>>> MCFEPORT_EPPDR), >>>> - MCFGPF(FECH, 8, 8), >>>> - MCFGPF(FECL, 16, 8), >>>> - MCFGPF(SSI, 24, 5), >>>> - MCFGPF(BUSCTL, 32, 4), >>>> - MCFGPF(BE, 40, 4), >>>> - MCFGPF(CS, 49, 5), >>>> - MCFGPF(PWM, 58, 4), >>>> - MCFGPF(FECI2C, 64, 4), >>>> - MCFGPF(UART, 72, 8), >>>> - MCFGPF(QSPI, 80, 6), >>>> - MCFGPF(TIMER, 88, 4), >>>> - MCFGPF(LCDDATAH, 96, 2), >>>> - MCFGPF(LCDDATAM, 104, 8), >>>> - MCFGPF(LCDDATAL, 112, 8), >>>> - MCFGPF(LCDCTLH, 120, 1), >>>> - MCFGPF(LCDCTLL, 128, 8), >>>> -}; >>>> - >>>> -unsigned int mcf_gpio_chips_size = ARRAY_SIZE(mcf_gpio_chips); >>>> -- >>>> 1.7.0.4 >>>> >>>> ______________________________**_________________ >>>> uClinux-dev mailing list >>>> uClinux-dev@uclinux.org<**mailto:uClinux-dev@uclinux.org**> >>>> http://mailman.uclinux.org/**mailman/listinfo/uclinux-dev >>>> This message was resent by uclinux-dev@uclinux.org >>>> > >>>> To unsubscribe see: >>>> http://mailman.uclinux.org/**mailman/options/uclinux-dev >>>> >>>> >>>> >>>> >>>> -- >>>> ______ >>>> Mohamed Nabil Hafez >>>> Embedded Software Engineer >>>> >>>> >>> >>> -- >>> ------------------------------**------------------------------** >>> ------------ >>> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com >>> SnapGear Group, McAfee PHONE: +61 7 3435 2888 >>> 8 Gardner Close, FAX: +61 7 3891 3630 >>> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com >>> ______________________________**_________________ >>> uClinux-dev mailing list >>> uClinux-dev@uclinux.org >>> http://mailman.uclinux.org/**mailman/listinfo/uclinux-dev >>> This message was resent by uclinux-dev@uclinux.org >>> To unsubscribe see: >>> http://mailman.uclinux.org/**mailman/options/uclinux-dev >>> >>> ??? ?&?~?&? ??+-??? ??w??????m?b??f??"??^n?r???z? ??h????&?? ?G???h? >> (????j"?? ? m?????z?????f???h???~?m? >> >> >> > > -- > ------------------------------**------------------------------** > ------------ > Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com > SnapGear Group, McAfee PHONE: +61 7 3435 2888 > 8 Gardner Close, FAX: +61 7 3891 3630 > Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com > -- ______ Mohamed Nabil Hafez Embedded Software Engineer --bcaec553fefa516efa04be8aa8a6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Ah , Bloody Hell , we should punish this "reflecter"=A0
but still 23 emails are too much for 1 blood= y min ? =A0no ?

On Thu, Apr 26, 2012 at 3:07 AM, Greg Ungere= r <gerg@snapgear.com> wrote:
Hi Alex,


On 04/26/2012 10:53 AM, Alex LI wrote:
You sent 50 mails in 1 min.

I sent 23. And both list archives (linux-m68k and uclinux-dev) only
show the 23 emails.

Maybe the uclinux-dev reflecter is sending dupes to list recpients?

Regards
Greg



Sent from my Sony Ericsson Xperia arc S

Greg Ungerer<gerg= @snapgear.com> =A0?:


On 04/26/2012 10:36 AM, mohamed nabil wrote:
that's a Fucking spam man !!

Huh?

Thats how open source development works. If you don't like it don't=
subscribe to a developers list.

Regards
Greg



On Thu, Apr 26, 2012 at 2:26 AM,<gerg@snapgear.com
<mailto:gerg@snap= gear.com>> =A0wrote:

=A0 =A0 From: Greg Ungerer<gerg@uclinux.org<mailto:gerg@uclinux.org>>

=A0 =A0 The GPIO data struct setup is now the only remaining code in the =A0 =A0 platform
=A0 =A0 gpio.c file. So move it to the platform config.c code and remove t= he
=A0 =A0 gpio.c
=A0 =A0 file.

=A0 =A0 Signed-off-by: Greg Ungerer<gerg@uclinux.org<mailto:gerg@uclinux.org>>
=A0 =A0 ---
=A0 =A0 =A0 arch/m68k/platform/532x/Makefile | =A0 =A02 +-
=A0 =A0 =A0 arch/m68k/platform/532x/config.c | =A0 25 +++++++++++++= +++++++++
=A0 =A0 =A0 arch/m68k/platform/532x/gpio.c =A0 | =A0 43
=A0 =A0 --------------------------------------
=A0 =A0 =A0 3 files changed, 26 insertions(+), 44 deletions(-)
=A0 =A0 =A0 delete mode 100644 arch/m68k/platform/532x/gpio.c

=A0 =A0 diff --git a/arch/m68k/platform/532x/Makefile
=A0 =A0 b/arch/m68k/platform/532x/Makefile
=A0 =A0 index ce01669..c0d8cf8 100644
=A0 =A0 --- a/arch/m68k/platform/532x/Makefile
=A0 =A0 +++ b/arch/m68k/platform/532x/Makefile
=A0 =A0 @@ -15,4 +15,4 @@
=A0 =A0 =A0 asflags-$(CONFIG_FULLDEBUG) :=3D -DDEBUGGER_COMPATIBLE_CACHE= =3D1

=A0 =A0 =A0 #obj-y :=3D config.o usb-mcf532x.o spi-mcf532x.o
=A0 =A0 -obj-y :=3D config.o gpio.o
=A0 =A0 +obj-y :=3D config.o
=A0 =A0 diff --git a/arch/m68k/platform/532x/config.c
=A0 =A0 b/arch/m68k/platform/532x/config.c
=A0 =A0 index 2bec347..a4dd3d8 100644
=A0 =A0 --- a/arch/m68k/platform/532x/config.c
=A0 =A0 +++ b/arch/m68k/platform/532x/config.c
=A0 =A0 @@ -26,10 +26,35 @@
=A0 =A0 =A0 #include<asm/mcfsim.h>
=A0 =A0 =A0 #include<asm/mcfuart.h>
=A0 =A0 =A0 #include<asm/mcfdma.h>
=A0 =A0 +#include<asm/mcfgpio.h>
=A0 =A0 =A0 #include<asm/mcfwdebug.h>

=A0 =A0 =A0 /******************************************************= *********************/

=A0 =A0 +struct mcf_gpio_chip mcf_gpio_chips[] =3D {
=A0 =A0 + =A0 =A0 =A0 MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, =A0 =A0 MCFEPORT_EPPDR),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(FECH, 8, 8),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(FECL, 16, 8),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(SSI, 24, 5),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(BUSCTL, 32, 4),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(BE, 40, 4),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(CS, 49, 5),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(PWM, 58, 4),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(FECI2C, 64, 4),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(UART, 72, 8),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(QSPI, 80, 6),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(TIMER, 88, 4),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(LCDDATAH, 96, 2),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(LCDDATAM, 104, 8),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(LCDDATAL, 112, 8),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(LCDCTLH, 120, 1),
=A0 =A0 + =A0 =A0 =A0 MCFGPF(LCDCTLL, 128, 8),
=A0 =A0 +};
=A0 =A0 +
=A0 =A0 +unsigned int mcf_gpio_chips_size =3D ARRAY_SIZE(mcf_gpio_chips);<= br> =A0 =A0 +
=A0 =A0 +/*********************************************************= ******************/
=A0 =A0 +
=A0 =A0 =A0 #ifdef CONFIG_SPI_COLDFIRE_QSPI

=A0 =A0 =A0 static void __init m532x_qspi_init(void)
=A0 =A0 diff --git a/arch/m68k/platform/532x/gpio.c
=A0 =A0 b/arch/m68k/platform/532x/gpio.c
=A0 =A0 deleted file mode 100644
=A0 =A0 index 3e1b71d..0000000
=A0 =A0 --- a/arch/m68k/platform/532x/gpio.c
=A0 =A0 +++ /dev/null
=A0 =A0 @@ -1,43 +0,0 @@
=A0 =A0 -/*
=A0 =A0 - * Coldfire generic GPIO support
=A0 =A0 - *
=A0 =A0 - * (C) Copyright 2009, Steven King<sfking@fdwdc.com
=A0 =A0 <mailto:s= fking@fdwdc.com>>
=A0 =A0 - *
=A0 =A0 - * This program is free software; you can redistribute it and/or = modify
=A0 =A0 - * it under the terms of the GNU General Public License as publis= hed by
=A0 =A0 - * the Free Software Foundation; version 2 of the License.
=A0 =A0 - *
=A0 =A0 - * This program is distributed in the hope that it will be useful= ,
=A0 =A0 - * but WITHOUT ANY WARRANTY; without even the implied warranty of=
=A0 =A0 - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. =A0See th= e
=A0 =A0 - * GNU General Public License for more details.
=A0 =A0 -*/
=A0 =A0 -
=A0 =A0 -#include<linux/kernel.h>
=A0 =A0 -#include<linux/init.h>
=A0 =A0 -
=A0 =A0 -#include<asm/coldfire.h>
=A0 =A0 -#include<asm/mcfsim.h>
=A0 =A0 -#include<asm/mcfgpio.h>
=A0 =A0 -
=A0 =A0 -struct mcf_gpio_chip mcf_gpio_chips[] =3D {
=A0 =A0 - =A0 =A0 =A0 MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, =A0 =A0 MCFEPORT_EPPDR),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(FECH, 8, 8),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(FECL, 16, 8),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(SSI, 24, 5),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(BUSCTL, 32, 4),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(BE, 40, 4),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(CS, 49, 5),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(PWM, 58, 4),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(FECI2C, 64, 4),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(UART, 72, 8),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(QSPI, 80, 6),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(TIMER, 88, 4),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(LCDDATAH, 96, 2),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(LCDDATAM, 104, 8),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(LCDDATAL, 112, 8),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(LCDCTLH, 120, 1),
=A0 =A0 - =A0 =A0 =A0 MCFGPF(LCDCTLL, 128, 8),
=A0 =A0 -};
=A0 =A0 -
=A0 =A0 -unsigned int mcf_gpio_chips_size =3D ARRAY_SIZE(mcf_gpio_chips);<= br> =A0 =A0 --
=A0 =A0 1.7.0.4

=A0 =A0 _______________________________________________
=A0 =A0 uClinux-dev mailing list
=A0 =A0 uClin= ux-dev@uclinux.org<mailto:uClinux-dev@uclinux.org>
=A0 =A0 http://mailman.uclinux.org/mailman/listinfo/ucli= nux-dev
=A0 =A0 This message was resent by uclinux-dev@uclinux.org
=A0 =A0 <mailto:uclinux-dev@uclinux.org>
=A0 =A0 To unsubscribe see:
=A0 =A0 http://mailman.uclinux.org/mailman/options/uclinu= x-dev




--
______
Mohamed Nabil Hafez
Embedded Software Engineer



--
-------------------------------------------------------------= -----------
Greg Ungerer =A0-- =A0Principal Engineer =A0 =A0 =A0 =A0EMAIL: =A0 =A0 gerg@snapgear.com SnapGear Group, McAfee =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0PHONE: = =A0 =A0 =A0 +61 7 3435 2888
8 Gardner Close, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0FAX= : =A0 =A0 =A0 =A0 +61 7 3891 3630
Milton, QLD, 4064, Australia =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uc= linux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev<= /a>
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

=A0??? ?&?~?&? ??+-??? ??w??????m?b??f??"??^n?r???z? ??h????&a= mp;?? ?G???h? (????j"?? ? m?????z?????f???h???~?m?




--
-------------------------------------------------------------= -----------
Greg Ungerer =A0-- =A0Principal Engineer =A0 =A0 =A0 =A0EMAIL: =A0 =A0 gerg@snapgear.com SnapGear Group, McAfee =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0PHONE: = =A0 =A0 =A0 +61 7 3435 2888
8 Gardner Close, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0FAX= : =A0 =A0 =A0 =A0 +61 7 3891 3630
Milton, QLD, 4064, Australia =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0WEB: http://www.SnapGear.com



--
= ______
Mohamed Nabil Hafez
Embedded Software Engineer

--bcaec553fefa516efa04be8aa8a6-- --===============3675241749378684453== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev --===============3675241749378684453==--