From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8262C433F5 for ; Tue, 21 Sep 2021 04:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D0F460F4B for ; Tue, 21 Sep 2021 04:31:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbhIUEdV (ORCPT ); Tue, 21 Sep 2021 00:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbhIUEdV (ORCPT ); Tue, 21 Sep 2021 00:33:21 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25357C061574 for ; Mon, 20 Sep 2021 21:31:53 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id x27so76344647lfu.5 for ; Mon, 20 Sep 2021 21:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8mDe5rbnLvO060XX9nGaWK4P5GkvGrT6mYXSVNAOw78=; b=nQIzrFfqYXnXnvGGHKK3AiocAQAr4s7hYZ2882e5Qcd8yf2Z52l7k12rBkJXS27y/S 9KGegh6KIxMYhjlUbn+dPo6KC4LywdO4OLmTMgxedy/ZUwjx+go1ZZVekdZK71Z1m4fK 2W0poCuEzaYOB064+Ka73sB/Bd7sURpzHf2VIFPLgA6AsyPJJVvMtjxbuckYvVUiCnWe kM5Aarpv/IZYS9gCv8Zp7sYQ5Qzv9F5Gtr2BA7mSVcwyzOkeHzXiup89yFpXxJ4lytf7 uy8cLBHE/T0gbQtIoArl4aUwwr9TSh+s4au/R928uGpPfW79iOdPQv7Td0WJbbWyIZww dehA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8mDe5rbnLvO060XX9nGaWK4P5GkvGrT6mYXSVNAOw78=; b=LtVPiVMcYdCjtWD+VEfK+k9VCaON6RwJRtj4EN2hgbSd5GbX5I31rnWYUx+G5DwQZ0 0SaVUsjjakem/iJPWnwd9FhexfLzZffHefKEUI8yW0YVblMms8JXyysU5x9K2/C/cwZ7 qbuYCHpVX3a02oiYhk+2JC5gSorpaWTmJyX+vjFg7pMg0kMb4s6Myc5ox8kUv5lCXT1m gGegnH7wQU0a7rWDkb+QaVOzhSEjk6QY+/pT/p4FSWb7khv79uqLuETBNJYJeOIBp3nv /4TrxJ8o5aKEiOgMfxMiNCYeykkoQFpE7y5HJ5JSS2oFq8Ad5EsqY1gzKH+H/tTmNJmh CJAA== X-Gm-Message-State: AOAM5317lYJkHQ7lBhUW8VMR66rYUuSAwWsJpflDfOsNqJtIkHmwwZ4u IIqV49xm4gWoaKzIDe9k1myv9XaQ5eSuM+MV/No= X-Google-Smtp-Source: ABdhPJxVk4CH30B8tsSGbMpThOQ3zumdhlIBuszW2M2MS14jOKX4WfsW8BU/9Mtnk4OEDqee/tKKn9zPibRXt/opl/Y= X-Received: by 2002:ac2:446e:: with SMTP id y14mr5491856lfl.326.1632198711294; Mon, 20 Sep 2021 21:31:51 -0700 (PDT) MIME-Version: 1.0 References: <20210827031222.2778522-1-zixuanwang@google.com> <20210827031222.2778522-10-zixuanwang@google.com> <3fd467ae-63c9-adba-9d29-09b8a7beb92d@redhat.com> In-Reply-To: <3fd467ae-63c9-adba-9d29-09b8a7beb92d@redhat.com> From: Zixuan Wang Date: Mon, 20 Sep 2021 21:31:15 -0700 Message-ID: Subject: Re: [kvm-unit-tests PATCH v2 09/17] x86 UEFI: Set up page tables To: Paolo Bonzini Cc: Zixuan Wang , kvm@vger.kernel.org, drjones@redhat.com, Marc Orr , "Hyunwook (Wooky) Baek" , tmroeder@google.com, erdemaktas@google.com, rientjes@google.com, seanjc@google.com, brijesh.singh@amd.com, Thomas.Lendacky@amd.com, varad.gautam@suse.com, jroedel@suse.de, bp@suse.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Sep 20, 2021 at 6:26 PM Paolo Bonzini wrote: > > On 27/08/21 05:12, Zixuan Wang wrote: > > +static void setup_page_table(void) > > It would also be nice if cstart64.S reused setup_page_table, but unlike > GDT/IDT/TSS I guess it's not super-necessary. > > Paolo > I can update this in the next version. I can also move the page table definitions to a C file, maybe lib/x86/desc.c or lib/x86/vm.c? I'm not sure which file is better. Best regards, Zixuan