From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFBA0C31E40 for ; Mon, 12 Aug 2019 23:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8133920679 for ; Mon, 12 Aug 2019 23:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Az/KAHeX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbfHLXk5 (ORCPT ); Mon, 12 Aug 2019 19:40:57 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34305 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbfHLXk5 (ORCPT ); Mon, 12 Aug 2019 19:40:57 -0400 Received: by mail-ot1-f67.google.com with SMTP id n5so165771312otk.1; Mon, 12 Aug 2019 16:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pPEYAuAye+0GqC7OnP9046qaqHZYqZpPqW1iRwks6UA=; b=Az/KAHeXWMTK6hZoEHd2o4MQYecAB/NgvnMRDnUZzVhXDkbMTvsthJSrrVcLyIVGuQ LVzU0ExEzwQNwWcILcnqpux7LRq7Pd1qSkB6eC+g6fwszr9wFB4ErXIhaGXDPYoCO0rv pMTcAXFbhCOg1XGFgjerQ+dc+mqA0hzjGc7BXUkfO6eMyx/1piKi9i9vK/U/kw6GE4gD 773IvbSspzM4MSxA3WRpuHbv+AfIXIq4oeBOCH7MdYMlswP0aaiDugAkwcyxCvWhnBRv n0HaEonKGwLDsQznMyf3w0/GPE5m7PEZs6cCaPGYJy8lmgi5gsjsZxHu8AgF0+1x6gfL fVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pPEYAuAye+0GqC7OnP9046qaqHZYqZpPqW1iRwks6UA=; b=EzxdQT+CmPrQk3ASznEEDJ8x+DFR7I9tRFv3Ty+R3wzwIbpUZSjXtrsbB5PlN9rpAN 6mCmw0CODWoMIqci/nbLSeEZtluZs2WTdg2mQ4vqC9iIfWd//HVl1UOG/vRpL0SlwRJP 2Gn27FoKHISD5yvQCNIXQ4dwqsKExZfsJ9c7iZUYs0bqJggQ9z9a5natFYtKsDoyYzr9 7dnjNym8Dh6D1I0aC53M/G4ELmNLSZtg8MAQ9cOq+s6IdaIPJZkpSwtbwmzKo1UKLTbI OSGeSxQWUILAzYHoWLR7r7TmtO0q+7qUPxLf9bMy6bSNQ/hFALnCPblPGFSsMviqfRcR +GwQ== X-Gm-Message-State: APjAAAVYVEA2WqvQtRgwZZDXRpwdVnWHvv+0f+hsS/vtUlvW1Li/FxUc 70I0kVwhvz1RiAIXuihgUepBl+qq9Q9moeWUA0k= X-Google-Smtp-Source: APXvYqwdCwEVUV+9iATbwHthiTuqT8FRW51Zis4SYydD2va0Jx7WyHS0BxXBm3kCBot3qcQDULuG0pks3KT0NGUUszE= X-Received: by 2002:a6b:fd13:: with SMTP id c19mr12236684ioi.168.1565653256193; Mon, 12 Aug 2019 16:40:56 -0700 (PDT) MIME-Version: 1.0 References: <20190810052829.6032-1-tiny.windzz@gmail.com> <20190810052829.6032-3-tiny.windzz@gmail.com> <20190812085604.ozhl35wwm3ehlvqn@flea> In-Reply-To: <20190812085604.ozhl35wwm3ehlvqn@flea> From: Frank Lee Date: Tue, 13 Aug 2019 07:40:44 +0800 Message-ID: Subject: Re: [PATCH v5 02/18] dt-bindings: thermal: add binding document for h6 thermal controller To: Maxime Ripard Cc: rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Chen-Yu Tsai , Mauro Carvalho Chehab , David Miller , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , Linux PM , devicetree , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 4:56 PM Maxime Ripard wrote: > > On Sat, Aug 10, 2019 at 05:28:13AM +0000, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li > > --- > > .../bindings/thermal/sun8i-thermal.yaml | 79 +++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > new file mode 100644 > > index 000000000000..e0973199ba3c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > We've used so far for the schemas the first compatible to introduce > that controller as the filename, we should be consistent here. In that > case that would be allwinner,sun8i-a23-ths.yaml > > > @@ -0,0 +1,79 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > > + > > +maintainers: > > + - Yangtao Li > > + > > +description: |- > > + This describes the device tree binding for the Allwinner thermal > > + controller which measures the on-SoC temperatures. > > + > > +properties: > > + compatible: > > + enum: > > + - allwinner,sun50i-h6-ths > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: bus > > + > > + "#thermal-sensor-cells": > > + const: 1 > > + > > + nvmem-cells: > > You need a maxItems here too > > > + description: ths calibrate data > > What about something like this: > > Calibration data for the thermal sensor > > > + > > + nvmem-cell-names: > > + const: calib > > I'm not sure we need a abbreviation here, calibration would be more > explicit > > > + > > +required: > > + - compatible > > + - reg > > + - reset > > + - clocks > > + - clock-names > > + - interrupts > > + - "#thermal-sensor-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + ths: ths@5070400 { > > + compatible = "allwinner,sun50i-h6-ths"; > > + reg = <0x05070400 0x100>; > > + clocks = <&ccu CLK_BUS_THS>; > > + clock-names = "bus"; > > + resets = <&ccu RST_BUS_THS>; > > + interrupts = ; > > Those examples won't compile. Emmm, I have some questions about this. I added this information and it can be compiled. Yours, Yangtao > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524C0C31E40 for ; Mon, 12 Aug 2019 23:41:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20B2420679 for ; Mon, 12 Aug 2019 23:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PuV/uaHL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Az/KAHeX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20B2420679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ib2KkUqMl7pxtxnvWTiVwMiHsd1MifVsi4hO4lLlXrs=; b=PuV/uaHLPzSP6W oqh/2BG+OqM6L4VXBgzqCkDCo8syt0CuKp84p4lJwnPn5FGZgJrU96ZiTiTaF7ZorzWfYQVs8xnFc 4GSHpWcwnz+M4Blrhq5PIZC21Ot2+vYuqUynzBFtc7ork7OxM2RKMHOx22uDqzZwlenvxCMB6RgQY eOzefAbXAf0iRsDk18RE3X+EJa5ceKOKSuluwEK+e7VbuXsQ7xEusoQkp6d1Fs2QQwSvMJS37vXWS uiw1B6+boppywpNWSgTHhcMcq5qlkcqO+Cuh2T8Oc3sIckzp3hs8i+qzp2LHxTFPC0c80gp0pFBBt HjbtJew3IcMNrS56TG8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxJvx-0000iw-JZ; Mon, 12 Aug 2019 23:41:01 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxJvt-0000i6-T5 for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2019 23:40:59 +0000 Received: by mail-ot1-x341.google.com with SMTP id k18so33570663otr.3 for ; Mon, 12 Aug 2019 16:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pPEYAuAye+0GqC7OnP9046qaqHZYqZpPqW1iRwks6UA=; b=Az/KAHeXWMTK6hZoEHd2o4MQYecAB/NgvnMRDnUZzVhXDkbMTvsthJSrrVcLyIVGuQ LVzU0ExEzwQNwWcILcnqpux7LRq7Pd1qSkB6eC+g6fwszr9wFB4ErXIhaGXDPYoCO0rv pMTcAXFbhCOg1XGFgjerQ+dc+mqA0hzjGc7BXUkfO6eMyx/1piKi9i9vK/U/kw6GE4gD 773IvbSspzM4MSxA3WRpuHbv+AfIXIq4oeBOCH7MdYMlswP0aaiDugAkwcyxCvWhnBRv n0HaEonKGwLDsQznMyf3w0/GPE5m7PEZs6cCaPGYJy8lmgi5gsjsZxHu8AgF0+1x6gfL fVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pPEYAuAye+0GqC7OnP9046qaqHZYqZpPqW1iRwks6UA=; b=GMr/eADUPN05RU8T+OrNBV/qU5gWqBiWP9RXPUCY+2FbVIOOpVpcB6OdFjE/+rc+3R IelH3G4sUKfmd9shMoSlqut7nuR028u0FR9B/Uw0q3Z/Y4oUh2Z+0g9vfXtusvPxC5IP 99ec81uSNK5Cy6U3SisGIWmkUKLdTnkO9MLmQWBl31IKN9w9TCN7inZzdyQBX79XoJZF WOhhvQKq4xu982iyBoutuP7DPbQlMGH68g4U6yLUxajX/ydhFsRudZzyGWok1LOBEqaz aISzFlc2X7gXvEQUKoVoA/rRL7F9QgfH3K7JEB/Iap/n12oqEdPilXeZvFOuxHfHBjaN uEwg== X-Gm-Message-State: APjAAAXqWJj7TZuHUIIyRl4cz/R/KtMrVF4TRgs2MwdNPYzaDh4fmJYs gcp7qVY7ayr61vmreTZnMlIWq5KsSe6c2J6yym4= X-Google-Smtp-Source: APXvYqwdCwEVUV+9iATbwHthiTuqT8FRW51Zis4SYydD2va0Jx7WyHS0BxXBm3kCBot3qcQDULuG0pks3KT0NGUUszE= X-Received: by 2002:a6b:fd13:: with SMTP id c19mr12236684ioi.168.1565653256193; Mon, 12 Aug 2019 16:40:56 -0700 (PDT) MIME-Version: 1.0 References: <20190810052829.6032-1-tiny.windzz@gmail.com> <20190810052829.6032-3-tiny.windzz@gmail.com> <20190812085604.ozhl35wwm3ehlvqn@flea> In-Reply-To: <20190812085604.ozhl35wwm3ehlvqn@flea> From: Frank Lee Date: Tue, 13 Aug 2019 07:40:44 +0800 Message-ID: Subject: Re: [PATCH v5 02/18] dt-bindings: thermal: add binding document for h6 thermal controller To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190812_164057_965280_E8A058D2 X-CRM114-Status: GOOD ( 23.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Linux PM , Greg Kroah-Hartman , Daniel Lezcano , Linux Kernel Mailing List , Eduardo Valentin , Chen-Yu Tsai , Rob Herring , Jonathan.Cameron@huawei.com, Mauro Carvalho Chehab , rui.zhang@intel.com, David Miller , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2019 at 4:56 PM Maxime Ripard wrote: > > On Sat, Aug 10, 2019 at 05:28:13AM +0000, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li > > --- > > .../bindings/thermal/sun8i-thermal.yaml | 79 +++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > new file mode 100644 > > index 000000000000..e0973199ba3c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > We've used so far for the schemas the first compatible to introduce > that controller as the filename, we should be consistent here. In that > case that would be allwinner,sun8i-a23-ths.yaml > > > @@ -0,0 +1,79 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > > + > > +maintainers: > > + - Yangtao Li > > + > > +description: |- > > + This describes the device tree binding for the Allwinner thermal > > + controller which measures the on-SoC temperatures. > > + > > +properties: > > + compatible: > > + enum: > > + - allwinner,sun50i-h6-ths > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: bus > > + > > + "#thermal-sensor-cells": > > + const: 1 > > + > > + nvmem-cells: > > You need a maxItems here too > > > + description: ths calibrate data > > What about something like this: > > Calibration data for the thermal sensor > > > + > > + nvmem-cell-names: > > + const: calib > > I'm not sure we need a abbreviation here, calibration would be more > explicit > > > + > > +required: > > + - compatible > > + - reg > > + - reset > > + - clocks > > + - clock-names > > + - interrupts > > + - "#thermal-sensor-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + ths: ths@5070400 { > > + compatible = "allwinner,sun50i-h6-ths"; > > + reg = <0x05070400 0x100>; > > + clocks = <&ccu CLK_BUS_THS>; > > + clock-names = "bus"; > > + resets = <&ccu RST_BUS_THS>; > > + interrupts = ; > > Those examples won't compile. Emmm, I have some questions about this. I added this information and it can be compiled. Yours, Yangtao > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel