From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C570FC04AAF for ; Thu, 16 May 2019 18:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89B2E2082E for ; Thu, 16 May 2019 18:07:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lPr5OWc1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbfEPSHH (ORCPT ); Thu, 16 May 2019 14:07:07 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:38238 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfEPSHG (ORCPT ); Thu, 16 May 2019 14:07:06 -0400 Received: by mail-it1-f194.google.com with SMTP id i63so7794811ita.3; Thu, 16 May 2019 11:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=7Wo9xzmx/e1rfFyqrlLyhqwSx9QNN6cqUUgSBlZipdY=; b=lPr5OWc1MAuUYOaem0KSVMrE8kiPAHl5BA7wszQ/51yhVtO/+6Ehn/av3IErU317wK o8xAG9KAyyrP/67pypTINVNjopM/PR0g41jDn9Z3pbyU2//y07e1Jy+6mpthVFW1YXRi cW841EPX03yuWhsGj+w9/SowxC2TcEKLd8zN97WI858TQXZKrJyPYqLreZi0J2zwNyJJ 0cfBJiLmYA2zVYh5KmJikRlUWxfmXRIadWfShN49yatx4dhnYj53/9ec/MNNoCkIBwxW LQIhEYQFZj8BXyNJ8NpqA8Y6ZZFJkMSpX7FXHGOHxRWMN1IscA3y1m2WiJk5KQYa12Dz nlOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=7Wo9xzmx/e1rfFyqrlLyhqwSx9QNN6cqUUgSBlZipdY=; b=QFOpiIWKYmV8uO1Fvn/l5FNB2wc2T4tusDxgydFaiJ6UuJB8gPj60Bh9f/1EViUUxf pw4qd3DoYRVkoJseqsaaQuLeU03zSBaLeucPPWsm7PuBC6YuTh/ifQeMEAL7EHMLfRQa 2FY0KwUbJMfnTAqhrVCiRzuPXwElN9iefzlGZIBY71U/SCFpL6jXYq5bilaLSOGhJcrH Znkn7dW5jxYTcz3i5MzCXey3DolB40O4jEgBQZmkqfEJC6vQj9UJHdiTtHaEDNw+jW/2 VDBxzeC18UrXGBVJGd9jQtW9O9bt/cIaOCkhZw7st7/CJ+uMR3d7PtafZlT61rm3bMU+ IeNQ== X-Gm-Message-State: APjAAAWEw7CJzON+XwJDIoVOz0KyvBPe52F4G8a+4wt9hIZLr0aBYg2t nxe65Bu1WMmyKiBozykZCp/aFP+usRVLVJ/py9g= X-Google-Smtp-Source: APXvYqzvan2yioCF/efQYVkzIt/FeMd9pbpNvXX42GmHzx8kcl9QGWU1tG86XUAwYdCJxa8kih0hLDvUtblhFHCsnR4= X-Received: by 2002:a05:660c:105:: with SMTP id w5mr1018044itj.37.1558030025091; Thu, 16 May 2019 11:07:05 -0700 (PDT) MIME-Version: 1.0 References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512221612.ubmknvim4utnqpl4@core.my.home> In-Reply-To: <20190512221612.ubmknvim4utnqpl4@core.my.home> From: Frank Lee Date: Fri, 17 May 2019 02:06:53 +0800 Message-ID: Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 To: Yangtao Li , rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , robh+dt@kernel.org, Mark Rutland , Maxime Ripard , Chen-Yu Tsai , catalin.marinas@arm.com, will.deacon@arm.com, David Miller , Mauro Carvalho Chehab , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , paulmck@linux.ibm.com, Andy Gross , olof@lixom.net, bjorn.andersson@linaro.org, Jagan Teki , marc.w.gonzalez@free.fr, stefan.wahren@i2se.com, enric.balletbo@collabora.com, devicetree@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , Linux PM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Ond=C5=99ej, On Mon, May 13, 2019 at 6:16 AM Ond=C5=99ej Jirman wrot= e: > > Hello Yangtao, > > On Sun, May 12, 2019 at 04:26:13AM -0400, Yangtao Li wrote: > > diff --git a/drivers/thermal/sun50i_thermal.c b/drivers/thermal/sun50i_= thermal.c > > new file mode 100644 > > index 000000000000..3bdb3677b3d4 > > --- /dev/null > > +++ b/drivers/thermal/sun50i_thermal.c > > @@ -0,0 +1,357 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Thermal sensor driver for Allwinner SOC > > + * Copyright (C) 2019 Yangtao Li > > + * > > + * Based on the work of Icenowy Zheng > > + * Based on the work of Ondrej Jirman > > + * Based on the work of Josef Gajdusek > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define MAX_SENSOR_NUM 4 > > + > > +#define FT_TEMP_MASK GENMASK(11, 0) > > +#define TEMP_CALIB_MASK GENMASK(11, 0) > > +#define TEMP_TO_REG 672 > > +#define CALIBRATE_DEFAULT 0x800 > > + > > +#define SUN50I_THS_CTRL0 0x00 > > +#define SUN50I_H6_THS_ENABLE 0x04 > > +#define SUN50I_H6_THS_PC 0x08 > > +#define SUN50I_H6_THS_MFC 0x30 > > +#define SUN50I_H6_TEMP_CALIB 0xa0 > > +#define SUN50I_H6_TEMP_DATA 0xc0 > > + > > +#define SUN50I_THS_CTRL0_T_ACQ(x) ((GENMASK(15, 0) & (x)) <= < 16) > > +#define SUN50I_THS_FILTER_EN BIT(2) > > +#define SUN50I_THS_FILTER_TYPE(x) (GENMASK(1, 0) & (x)) > > +#define SUN50I_H6_THS_PC_TEMP_PERIOD(x) ((GENMASK(19, 0) = & (x)) << 12) > > + > > +/* millidegree celsius */ > > +#define SUN50I_H6_FT_DEVIATION 7000 > > + > > +struct tsens_device; > > + > > +struct tsensor { > > + struct tsens_device *tmdev; > > + struct thermal_zone_device *tzd; > > + int id; > > +}; > > + > > +struct sun50i_thermal_chip { > > + int sensor_num; > > + int offset; > > + int scale; > > + int ft_deviation; > > + int temp_calib_base; > > + int temp_data_base; > > + int (*enable)(struct tsens_device *tmdev); > > + int (*disable)(struct tsens_device *tmdev); > > +}; > > + > > + > > +struct tsens_device { > > + const struct sun50i_thermal_chip *chip; > > + struct device *dev; > > + struct regmap *regmap; > > + struct reset_control *reset; > > + struct clk *bus_clk; > > + struct tsensor sensor[MAX_SENSOR_NUM]; > > +}; > > + > > +/* Temp Unit: millidegree Celsius */ > > +static int tsens_reg2temp(struct tsens_device *tmdev, > > + int reg) > > Please name all functions so that they are more clearly identifiable > in stack traces as belonging to this driver. For example: > > sun8i_ths_reg2temp > > The same applies for all tsens_* functions below. tsens_* is too > generic. Done but no sun8i_ths_reg2temp. ths_reg2tem() should be a generic func. I think it should be suitable for all platforms=EF=BC=8C so no platform pre= fix. > > > +{ > > + return (reg + tmdev->chip->offset) * tmdev->chip->scale; > > +} > > + > > +static int tsens_get_temp(void *data, int *temp) > > +{ > > + struct tsensor *s =3D data; > > + struct tsens_device *tmdev =3D s->tmdev; > > + int val; > > + > > + regmap_read(tmdev->regmap, tmdev->chip->temp_data_base + > > + 0x4 * s->id, &val); > > + > > + if (unlikely(val =3D=3D 0)) > > + return -EBUSY; > > + > > + *temp =3D tsens_reg2temp(tmdev, val); > > + if (tmdev->chip->ft_deviation) > > + *temp +=3D tmdev->chip->ft_deviation; > > + > > + return 0; > > +} > > + > > +static const struct thermal_zone_of_device_ops tsens_ops =3D { > > + .get_temp =3D tsens_get_temp, > > +}; > > + > > +static const struct regmap_config config =3D { > > + .reg_bits =3D 32, > > + .val_bits =3D 32, > > + .reg_stride =3D 4, > > + .fast_io =3D true, > > +}; > > + > > +static int tsens_init(struct tsens_device *tmdev) > > +{ > > + struct device *dev =3D tmdev->dev; > > + struct platform_device *pdev =3D to_platform_device(dev); > > + struct resource *mem; > > + void __iomem *base; > > + > > + mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + base =3D devm_ioremap_resource(dev, mem); > > + if (IS_ERR(base)) > > + return PTR_ERR(base); > > + > > + tmdev->regmap =3D devm_regmap_init_mmio_clk(dev, "bus", > > + base, > > + &config); > > + if (IS_ERR(tmdev->regmap)) > > + return PTR_ERR(tmdev->regmap); > > + > > + tmdev->reset =3D devm_reset_control_get(dev, "bus"); > > + if (IS_ERR(tmdev->reset)) > > + return PTR_ERR(tmdev->reset); > > + > > + tmdev->bus_clk =3D devm_clk_get(&pdev->dev, "bus"); > > + if (IS_ERR(tmdev->bus_clk)) > > + return PTR_ERR(tmdev->bus_clk); > > + > > + return 0; > > +} > > + > > +/* > > + * Even if the external calibration data stored in sid is not accessib= le, > > + * the THS hardware can still work, although the data won't be so accu= rate. > > + * The default value of calibration register is 0x800 for every sensor= , > > + * and the calibration value is usually 0x7xx or 0x8xx, so they won't = be > > + * away from the default value for a lot. > > + * > > + * So here we do not return error if the calibartion data is > > + * not available, except the probe needs deferring. > > + */ > > +static int tsens_calibrate(struct tsens_device *tmdev) > > +{ > > + struct nvmem_cell *calcell; > > + struct device *dev =3D tmdev->dev; > > + u16 *caldata; > > + size_t callen; > > + int ft_temp; > > + int i =3D 0; > > + > > + calcell =3D devm_nvmem_cell_get(dev, "calib"); > > + if (IS_ERR(calcell)) { > > + if (PTR_ERR(calcell) =3D=3D -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + goto out; > > + } > > + > > + caldata =3D nvmem_cell_read(calcell, &callen); > > + if (IS_ERR(caldata)) > > + goto out; > > + > > + if (!caldata[0] || callen < 2 + 2 * tmdev->chip->sensor_num) > > + goto out_free; > > + > > + /* > > + * The calbration data on H6 is stored as temperature-value > > + * pair when being filled at factory test stage. > > + * The unit of stored FT temperature is 0.1 degreee celusis. > > + */ > > Please describe the calibration data layout more clearly. Done. > > > + ft_temp =3D caldata[0] & FT_TEMP_MASK; > > + > > + for (; i < tmdev->chip->sensor_num; i++) { > > + int reg =3D (int)caldata[i + 1]; > > + int sensor_temp =3D tsens_reg2temp(tmdev, reg); > > + int delta, cdata, calib_offest; > > + > > + /* > > + * To calculate the calibration value: > > + * > > + * X(in Celsius) =3D Ts - ft_temp > > + * delta =3D X * 10000 / TEMP_TO_REG > > + * cdata =3D CALIBRATE_DEFAULT - delta > > + * > > + * cdata: calibration value > > + */ > > + delta =3D (sensor_temp - ft_temp * 100) * 10 / TEMP_TO_RE= G; > > + cdata =3D CALIBRATE_DEFAULT - delta; > > + if (cdata & ~TEMP_CALIB_MASK) { > > + dev_warn(dev, "sensor%d calibration value error",= i); > > Please use a more descriptive error message. What error is this? See commnt in v2. > > > + continue; > > + } > > + > > + calib_offest =3D tmdev->chip->temp_calib_base + (i / 2) *= 0x4; > > + if (i % 2) { > > + int val; > > + > > + regmap_read(tmdev->regmap, calib_offest, &val); > > + val =3D (val & TEMP_CALIB_MASK) | (cdata << 16); > > + regmap_write(tmdev->regmap, calib_offest, val); > > + } else > > + regmap_write(tmdev->regmap, calib_offest, cdata); > > + } > > + > > +out_free: > > + kfree(caldata); > > +out: > > + return 0; > > +} > > + > > +static int tsens_register(struct tsens_device *tmdev) > > +{ > > + struct thermal_zone_device *tzd; > > + int i =3D 0; > > + > > + for (; i < tmdev->chip->sensor_num; i++) { > > + tmdev->sensor[i].tmdev =3D tmdev; > > + tmdev->sensor[i].id =3D i; > > + tmdev->sensor[i].tzd =3D devm_thermal_zone_of_sensor_regi= ster( > > + tmdev->dev, i, &tmdev->sensor[i], > > + &tsens_ops); > > + if (IS_ERR(tmdev->sensor[i].tzd)) > > + return PTR_ERR(tzd); > > + } > > + > > + return 0; > > +} > > + > > +static int tsens_probe(struct platform_device *pdev) > > +{ > > + struct tsens_device *tmdev; > > + struct device *dev =3D &pdev->dev; > > + int ret; > > + > > + tmdev =3D devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > + if (!tmdev) > > + return -ENOMEM; > > + > > + tmdev->dev =3D dev; > > + tmdev->chip =3D of_device_get_match_data(&pdev->dev); > > + if (!tmdev->chip) > > + return -EINVAL; > > + > > + ret =3D tsens_init(tmdev); > > + if (ret) > > + return ret; > > + > > + ret =3D tsens_register(tmdev); > > + if (ret) > > + return ret; > > Why split this out of probe into separate functions? > > > + ret =3D tmdev->chip->enable(tmdev); > > + if (ret) > > + return ret; > > + > > + platform_set_drvdata(pdev, tmdev); > > + > > + return ret; > > +} > > + > > +static int tsens_remove(struct platform_device *pdev) > > +{ > > + struct tsens_device *tmdev =3D platform_get_drvdata(pdev); > > + > > + tmdev->chip->disable(tmdev); > > + > > + return 0; > > +} > > + > > +static int sun50i_thermal_enable(struct tsens_device *tmdev) > > +{ > > + int ret, val; > > + > > + ret =3D reset_control_deassert(tmdev->reset); > > + if (ret) > > + return ret; > > + > > + ret =3D clk_prepare_enable(tmdev->bus_clk); > > + if (ret) > > + goto assert_reset; > > + > > + ret =3D tsens_calibrate(tmdev); > > + if (ret) > > + return ret; > > If this fails (it may likely fail with EPROBE_DEFER) you are leaving rese= t > deasserted, and clock enabled. > > Overall, I think, reset/clock management and nvmem reading will be common > to all the HW variants, so it doesn't make much sense splitting it out > of probe into separate functions, and makes it more error prone. Our long-term goal is to support all platforms. Bacicallt there is a differencr between each generation. So I feel it necessary to isolate these differences. Maybe: At some point, we can draw a part of the public part and platform difference into different files. something like qcom thermal driver. Regards, Yangtao > > thank you and regards, > o. > > > + /* > > + * clkin =3D 24MHz > > + * T acquire =3D clkin / (SUN50I_THS_CTRL0_T_ACQ + 1) > > + * =3D 20us > > + */ > > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0, > > + SUN50I_THS_CTRL0_T_ACQ(479)); > > + /* average over 4 samples */ > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC, > > + SUN50I_THS_FILTER_EN | > > + SUN50I_THS_FILTER_TYPE(1)); > > + /* period =3D (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; = ~10ms */ > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC, > > + SUN50I_H6_THS_PC_TEMP_PERIOD(58)); > > + /* enable sensor */ > > + val =3D GENMASK(tmdev->chip->sensor_num - 1, 0); > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_ENABLE, val); > > + > > + return 0; > > + > > +assert_reset: > > + reset_control_assert(tmdev->reset); > > + > > + return ret; > > +} > > + > > +static int sun50i_thermal_disable(struct tsens_device *tmdev) > > +{ > > + clk_disable_unprepare(tmdev->bus_clk); > > + reset_control_assert(tmdev->reset); > > + > > + return 0; > > +} > > + > > +static const struct sun50i_thermal_chip sun50i_h6_ths =3D { > > + .sensor_num =3D 2, > > + .offset =3D -2794, > > + .scale =3D -67, > > + .ft_deviation =3D SUN50I_H6_FT_DEVIATION, > > + .temp_calib_base =3D SUN50I_H6_TEMP_CALIB, > > + .temp_data_base =3D SUN50I_H6_TEMP_DATA, > > + .enable =3D sun50i_thermal_enable, > > + .disable =3D sun50i_thermal_disable, > > +}; > > + > > +static const struct of_device_id of_tsens_match[] =3D { > > + { .compatible =3D "allwinner,sun50i-h6-ths", .data =3D &sun50i_h6= _ths }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, of_tsens_match); > > + > > +static struct platform_driver tsens_driver =3D { > > + .probe =3D tsens_probe, > > + .remove =3D tsens_remove, > > + .driver =3D { > > + .name =3D "sun50i-thermal", > > + .of_match_table =3D of_tsens_match, > > + }, > > +}; > > +module_platform_driver(tsens_driver); > > + > > +MODULE_DESCRIPTION("Thermal sensor driver for Allwinner SOC"); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.17.0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Lee Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Date: Fri, 17 May 2019 02:06:53 +0800 Message-ID: References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512221612.ubmknvim4utnqpl4@core.my.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190512221612.ubmknvim4utnqpl4@core.my.home> Sender: linux-kernel-owner@vger.kernel.org To: Yangtao Li , rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , robh+dt@kernel.org, Mark Rutland , Maxime Ripard , Chen-Yu Tsai , catalin.marinas@arm.com, will.deacon@arm.com, David Miller , Mauro Carvalho Chehab , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , paulmck@linux.ibm.com, Andy Gross , olof@lixom.net, bjorn.andersson@linaro.org, Jagan Teki , marc.w.gonzalez@free.fr, stefan.wahren@i2se.com, enric.balletbo@collabora.com, devicetree@vger.kernel.or List-Id: devicetree@vger.kernel.org HI Ond=C5=99ej, On Mon, May 13, 2019 at 6:16 AM Ond=C5=99ej Jirman wrot= e: > > Hello Yangtao, > > On Sun, May 12, 2019 at 04:26:13AM -0400, Yangtao Li wrote: > > diff --git a/drivers/thermal/sun50i_thermal.c b/drivers/thermal/sun50i_= thermal.c > > new file mode 100644 > > index 000000000000..3bdb3677b3d4 > > --- /dev/null > > +++ b/drivers/thermal/sun50i_thermal.c > > @@ -0,0 +1,357 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Thermal sensor driver for Allwinner SOC > > + * Copyright (C) 2019 Yangtao Li > > + * > > + * Based on the work of Icenowy Zheng > > + * Based on the work of Ondrej Jirman > > + * Based on the work of Josef Gajdusek > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define MAX_SENSOR_NUM 4 > > + > > +#define FT_TEMP_MASK GENMASK(11, 0) > > +#define TEMP_CALIB_MASK GENMASK(11, 0) > > +#define TEMP_TO_REG 672 > > +#define CALIBRATE_DEFAULT 0x800 > > + > > +#define SUN50I_THS_CTRL0 0x00 > > +#define SUN50I_H6_THS_ENABLE 0x04 > > +#define SUN50I_H6_THS_PC 0x08 > > +#define SUN50I_H6_THS_MFC 0x30 > > +#define SUN50I_H6_TEMP_CALIB 0xa0 > > +#define SUN50I_H6_TEMP_DATA 0xc0 > > + > > +#define SUN50I_THS_CTRL0_T_ACQ(x) ((GENMASK(15, 0) & (x)) <= < 16) > > +#define SUN50I_THS_FILTER_EN BIT(2) > > +#define SUN50I_THS_FILTER_TYPE(x) (GENMASK(1, 0) & (x)) > > +#define SUN50I_H6_THS_PC_TEMP_PERIOD(x) ((GENMASK(19, 0) = & (x)) << 12) > > + > > +/* millidegree celsius */ > > +#define SUN50I_H6_FT_DEVIATION 7000 > > + > > +struct tsens_device; > > + > > +struct tsensor { > > + struct tsens_device *tmdev; > > + struct thermal_zone_device *tzd; > > + int id; > > +}; > > + > > +struct sun50i_thermal_chip { > > + int sensor_num; > > + int offset; > > + int scale; > > + int ft_deviation; > > + int temp_calib_base; > > + int temp_data_base; > > + int (*enable)(struct tsens_device *tmdev); > > + int (*disable)(struct tsens_device *tmdev); > > +}; > > + > > + > > +struct tsens_device { > > + const struct sun50i_thermal_chip *chip; > > + struct device *dev; > > + struct regmap *regmap; > > + struct reset_control *reset; > > + struct clk *bus_clk; > > + struct tsensor sensor[MAX_SENSOR_NUM]; > > +}; > > + > > +/* Temp Unit: millidegree Celsius */ > > +static int tsens_reg2temp(struct tsens_device *tmdev, > > + int reg) > > Please name all functions so that they are more clearly identifiable > in stack traces as belonging to this driver. For example: > > sun8i_ths_reg2temp > > The same applies for all tsens_* functions below. tsens_* is too > generic. Done but no sun8i_ths_reg2temp. ths_reg2tem() should be a generic func. I think it should be suitable for all platforms=EF=BC=8C so no platform pre= fix. > > > +{ > > + return (reg + tmdev->chip->offset) * tmdev->chip->scale; > > +} > > + > > +static int tsens_get_temp(void *data, int *temp) > > +{ > > + struct tsensor *s =3D data; > > + struct tsens_device *tmdev =3D s->tmdev; > > + int val; > > + > > + regmap_read(tmdev->regmap, tmdev->chip->temp_data_base + > > + 0x4 * s->id, &val); > > + > > + if (unlikely(val =3D=3D 0)) > > + return -EBUSY; > > + > > + *temp =3D tsens_reg2temp(tmdev, val); > > + if (tmdev->chip->ft_deviation) > > + *temp +=3D tmdev->chip->ft_deviation; > > + > > + return 0; > > +} > > + > > +static const struct thermal_zone_of_device_ops tsens_ops =3D { > > + .get_temp =3D tsens_get_temp, > > +}; > > + > > +static const struct regmap_config config =3D { > > + .reg_bits =3D 32, > > + .val_bits =3D 32, > > + .reg_stride =3D 4, > > + .fast_io =3D true, > > +}; > > + > > +static int tsens_init(struct tsens_device *tmdev) > > +{ > > + struct device *dev =3D tmdev->dev; > > + struct platform_device *pdev =3D to_platform_device(dev); > > + struct resource *mem; > > + void __iomem *base; > > + > > + mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + base =3D devm_ioremap_resource(dev, mem); > > + if (IS_ERR(base)) > > + return PTR_ERR(base); > > + > > + tmdev->regmap =3D devm_regmap_init_mmio_clk(dev, "bus", > > + base, > > + &config); > > + if (IS_ERR(tmdev->regmap)) > > + return PTR_ERR(tmdev->regmap); > > + > > + tmdev->reset =3D devm_reset_control_get(dev, "bus"); > > + if (IS_ERR(tmdev->reset)) > > + return PTR_ERR(tmdev->reset); > > + > > + tmdev->bus_clk =3D devm_clk_get(&pdev->dev, "bus"); > > + if (IS_ERR(tmdev->bus_clk)) > > + return PTR_ERR(tmdev->bus_clk); > > + > > + return 0; > > +} > > + > > +/* > > + * Even if the external calibration data stored in sid is not accessib= le, > > + * the THS hardware can still work, although the data won't be so accu= rate. > > + * The default value of calibration register is 0x800 for every sensor= , > > + * and the calibration value is usually 0x7xx or 0x8xx, so they won't = be > > + * away from the default value for a lot. > > + * > > + * So here we do not return error if the calibartion data is > > + * not available, except the probe needs deferring. > > + */ > > +static int tsens_calibrate(struct tsens_device *tmdev) > > +{ > > + struct nvmem_cell *calcell; > > + struct device *dev =3D tmdev->dev; > > + u16 *caldata; > > + size_t callen; > > + int ft_temp; > > + int i =3D 0; > > + > > + calcell =3D devm_nvmem_cell_get(dev, "calib"); > > + if (IS_ERR(calcell)) { > > + if (PTR_ERR(calcell) =3D=3D -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + goto out; > > + } > > + > > + caldata =3D nvmem_cell_read(calcell, &callen); > > + if (IS_ERR(caldata)) > > + goto out; > > + > > + if (!caldata[0] || callen < 2 + 2 * tmdev->chip->sensor_num) > > + goto out_free; > > + > > + /* > > + * The calbration data on H6 is stored as temperature-value > > + * pair when being filled at factory test stage. > > + * The unit of stored FT temperature is 0.1 degreee celusis. > > + */ > > Please describe the calibration data layout more clearly. Done. > > > + ft_temp =3D caldata[0] & FT_TEMP_MASK; > > + > > + for (; i < tmdev->chip->sensor_num; i++) { > > + int reg =3D (int)caldata[i + 1]; > > + int sensor_temp =3D tsens_reg2temp(tmdev, reg); > > + int delta, cdata, calib_offest; > > + > > + /* > > + * To calculate the calibration value: > > + * > > + * X(in Celsius) =3D Ts - ft_temp > > + * delta =3D X * 10000 / TEMP_TO_REG > > + * cdata =3D CALIBRATE_DEFAULT - delta > > + * > > + * cdata: calibration value > > + */ > > + delta =3D (sensor_temp - ft_temp * 100) * 10 / TEMP_TO_RE= G; > > + cdata =3D CALIBRATE_DEFAULT - delta; > > + if (cdata & ~TEMP_CALIB_MASK) { > > + dev_warn(dev, "sensor%d calibration value error",= i); > > Please use a more descriptive error message. What error is this? See commnt in v2. > > > + continue; > > + } > > + > > + calib_offest =3D tmdev->chip->temp_calib_base + (i / 2) *= 0x4; > > + if (i % 2) { > > + int val; > > + > > + regmap_read(tmdev->regmap, calib_offest, &val); > > + val =3D (val & TEMP_CALIB_MASK) | (cdata << 16); > > + regmap_write(tmdev->regmap, calib_offest, val); > > + } else > > + regmap_write(tmdev->regmap, calib_offest, cdata); > > + } > > + > > +out_free: > > + kfree(caldata); > > +out: > > + return 0; > > +} > > + > > +static int tsens_register(struct tsens_device *tmdev) > > +{ > > + struct thermal_zone_device *tzd; > > + int i =3D 0; > > + > > + for (; i < tmdev->chip->sensor_num; i++) { > > + tmdev->sensor[i].tmdev =3D tmdev; > > + tmdev->sensor[i].id =3D i; > > + tmdev->sensor[i].tzd =3D devm_thermal_zone_of_sensor_regi= ster( > > + tmdev->dev, i, &tmdev->sensor[i], > > + &tsens_ops); > > + if (IS_ERR(tmdev->sensor[i].tzd)) > > + return PTR_ERR(tzd); > > + } > > + > > + return 0; > > +} > > + > > +static int tsens_probe(struct platform_device *pdev) > > +{ > > + struct tsens_device *tmdev; > > + struct device *dev =3D &pdev->dev; > > + int ret; > > + > > + tmdev =3D devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > + if (!tmdev) > > + return -ENOMEM; > > + > > + tmdev->dev =3D dev; > > + tmdev->chip =3D of_device_get_match_data(&pdev->dev); > > + if (!tmdev->chip) > > + return -EINVAL; > > + > > + ret =3D tsens_init(tmdev); > > + if (ret) > > + return ret; > > + > > + ret =3D tsens_register(tmdev); > > + if (ret) > > + return ret; > > Why split this out of probe into separate functions? > > > + ret =3D tmdev->chip->enable(tmdev); > > + if (ret) > > + return ret; > > + > > + platform_set_drvdata(pdev, tmdev); > > + > > + return ret; > > +} > > + > > +static int tsens_remove(struct platform_device *pdev) > > +{ > > + struct tsens_device *tmdev =3D platform_get_drvdata(pdev); > > + > > + tmdev->chip->disable(tmdev); > > + > > + return 0; > > +} > > + > > +static int sun50i_thermal_enable(struct tsens_device *tmdev) > > +{ > > + int ret, val; > > + > > + ret =3D reset_control_deassert(tmdev->reset); > > + if (ret) > > + return ret; > > + > > + ret =3D clk_prepare_enable(tmdev->bus_clk); > > + if (ret) > > + goto assert_reset; > > + > > + ret =3D tsens_calibrate(tmdev); > > + if (ret) > > + return ret; > > If this fails (it may likely fail with EPROBE_DEFER) you are leaving rese= t > deasserted, and clock enabled. > > Overall, I think, reset/clock management and nvmem reading will be common > to all the HW variants, so it doesn't make much sense splitting it out > of probe into separate functions, and makes it more error prone. Our long-term goal is to support all platforms. Bacicallt there is a differencr between each generation. So I feel it necessary to isolate these differences. Maybe: At some point, we can draw a part of the public part and platform difference into different files. something like qcom thermal driver. Regards, Yangtao > > thank you and regards, > o. > > > + /* > > + * clkin =3D 24MHz > > + * T acquire =3D clkin / (SUN50I_THS_CTRL0_T_ACQ + 1) > > + * =3D 20us > > + */ > > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0, > > + SUN50I_THS_CTRL0_T_ACQ(479)); > > + /* average over 4 samples */ > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC, > > + SUN50I_THS_FILTER_EN | > > + SUN50I_THS_FILTER_TYPE(1)); > > + /* period =3D (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; = ~10ms */ > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC, > > + SUN50I_H6_THS_PC_TEMP_PERIOD(58)); > > + /* enable sensor */ > > + val =3D GENMASK(tmdev->chip->sensor_num - 1, 0); > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_ENABLE, val); > > + > > + return 0; > > + > > +assert_reset: > > + reset_control_assert(tmdev->reset); > > + > > + return ret; > > +} > > + > > +static int sun50i_thermal_disable(struct tsens_device *tmdev) > > +{ > > + clk_disable_unprepare(tmdev->bus_clk); > > + reset_control_assert(tmdev->reset); > > + > > + return 0; > > +} > > + > > +static const struct sun50i_thermal_chip sun50i_h6_ths =3D { > > + .sensor_num =3D 2, > > + .offset =3D -2794, > > + .scale =3D -67, > > + .ft_deviation =3D SUN50I_H6_FT_DEVIATION, > > + .temp_calib_base =3D SUN50I_H6_TEMP_CALIB, > > + .temp_data_base =3D SUN50I_H6_TEMP_DATA, > > + .enable =3D sun50i_thermal_enable, > > + .disable =3D sun50i_thermal_disable, > > +}; > > + > > +static const struct of_device_id of_tsens_match[] =3D { > > + { .compatible =3D "allwinner,sun50i-h6-ths", .data =3D &sun50i_h6= _ths }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, of_tsens_match); > > + > > +static struct platform_driver tsens_driver =3D { > > + .probe =3D tsens_probe, > > + .remove =3D tsens_remove, > > + .driver =3D { > > + .name =3D "sun50i-thermal", > > + .of_match_table =3D of_tsens_match, > > + }, > > +}; > > +module_platform_driver(tsens_driver); > > + > > +MODULE_DESCRIPTION("Thermal sensor driver for Allwinner SOC"); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.17.0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B80C04AAF for ; Thu, 16 May 2019 18:07:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED6E22082E for ; Thu, 16 May 2019 18:07:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e8Xf6TNU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lPr5OWc1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED6E22082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Q/P/COb+3qtVdTcVueSc5b5xNx/7WrtD1AuFzitNdO8=; b=e8Xf6TNU0mL6hjw/j7z7tHkwYY xLXVWf5XViBmWlWBUIDHKDw9b9GavYicuwGnx2jTE9PY6va44wbt4KgQrz4seA87yhC2fnmF4GwjD cQW5oTl0BhUfRjAmebvVqc/Kqbx2MBIxHh2Q3NxoaacNUMDd7zO+y0jMJjlzxSgUrkuNr421Qosi3 g7chFSL3QdgFzleBpne23x5WAX0j3ZxGI9XObfafwhmNYkou0wqyAQn6yxJRolmGqH4MaNbBtsQMx 0LNVR/BvzIDsY4/Q/tPeiR2P4Q8gY3arvGXcapHQRPsIT88PGcjZxqh3WQbrrnn1nHmiJzHoCVzq+ VgEmauqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRKmc-0003EI-5x; Thu, 16 May 2019 18:07:10 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRKmY-0003Di-Aa for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2019 18:07:08 +0000 Received: by mail-it1-x144.google.com with SMTP id u186so7826620ith.0 for ; Thu, 16 May 2019 11:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=7Wo9xzmx/e1rfFyqrlLyhqwSx9QNN6cqUUgSBlZipdY=; b=lPr5OWc1MAuUYOaem0KSVMrE8kiPAHl5BA7wszQ/51yhVtO/+6Ehn/av3IErU317wK o8xAG9KAyyrP/67pypTINVNjopM/PR0g41jDn9Z3pbyU2//y07e1Jy+6mpthVFW1YXRi cW841EPX03yuWhsGj+w9/SowxC2TcEKLd8zN97WI858TQXZKrJyPYqLreZi0J2zwNyJJ 0cfBJiLmYA2zVYh5KmJikRlUWxfmXRIadWfShN49yatx4dhnYj53/9ec/MNNoCkIBwxW LQIhEYQFZj8BXyNJ8NpqA8Y6ZZFJkMSpX7FXHGOHxRWMN1IscA3y1m2WiJk5KQYa12Dz nlOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=7Wo9xzmx/e1rfFyqrlLyhqwSx9QNN6cqUUgSBlZipdY=; b=HztxhsqnIs6T23flqVcLMj4e+85zZ8oisyPy4X2dcSkP6gnWjEO7ktZy9lGjnBiRg/ 1ZpAA6A/c9UT/h8zey8FTlhfAQab5KADIAPyHs4xHACnV4tvJ7Q4M0TdJ3iMKA5z4eYU nLsMb//Qpv9pn6ggVmtXI8naGL2x78ucMv7OGkDsV8qW8rd1zyX3hfppX2UI2uHvv+Ho qTaKcTclZ4gz03n01y6aunEaXH7IrpVkxgxgJQ75v427yi7wQ9ous9X9ZkFjdgK8GtPb oJNVyMqrkjK0cjq4zZQzbLbvmDSpKPQqhlD5FzajG1QTQpuN6aOPsjNUnb8ClwpatdYI JvjA== X-Gm-Message-State: APjAAAXP1nUUZDt0xQ5ncSmLXCrQcQFMmJjXXK1H5/D/lzbXfXhW1xZG tipy5rRIzYoQrsMHqsy8HJBEanROTn4BScxQYpY= X-Google-Smtp-Source: APXvYqzvan2yioCF/efQYVkzIt/FeMd9pbpNvXX42GmHzx8kcl9QGWU1tG86XUAwYdCJxa8kih0hLDvUtblhFHCsnR4= X-Received: by 2002:a05:660c:105:: with SMTP id w5mr1018044itj.37.1558030025091; Thu, 16 May 2019 11:07:05 -0700 (PDT) MIME-Version: 1.0 References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512221612.ubmknvim4utnqpl4@core.my.home> In-Reply-To: <20190512221612.ubmknvim4utnqpl4@core.my.home> From: Frank Lee Date: Fri, 17 May 2019 02:06:53 +0800 Message-ID: Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 To: Yangtao Li , rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , robh+dt@kernel.org, Mark Rutland , Maxime Ripard , Chen-Yu Tsai , catalin.marinas@arm.com, will.deacon@arm.com, David Miller , Mauro Carvalho Chehab , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , paulmck@linux.ibm.com, Andy Gross , olof@lixom.net, bjorn.andersson@linaro.org, Jagan Teki , marc.w.gonzalez@free.fr, stefan.wahren@i2se.com, enric.balletbo@collabora.com, devicetree@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , Linux PM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190516_110706_376699_CCA5CAF0 X-CRM114-Status: GOOD ( 29.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SEkgT25kxZllaiwKCk9uIE1vbiwgTWF5IDEzLCAyMDE5IGF0IDY6MTYgQU0gT25kxZllaiBKaXJt YW4gPG1lZ291c0BtZWdvdXMuY29tPiB3cm90ZToKPgo+IEhlbGxvIFlhbmd0YW8sCj4KPiBPbiBT dW4sIE1heSAxMiwgMjAxOSBhdCAwNDoyNjoxM0FNIC0wNDAwLCBZYW5ndGFvIExpIHdyb3RlOgo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGhlcm1hbC9zdW41MGlfdGhlcm1hbC5jIGIvZHJpdmVy cy90aGVybWFsL3N1bjUwaV90aGVybWFsLmMKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBp bmRleCAwMDAwMDAwMDAwMDAuLjNiZGIzNjc3YjNkNAo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysr IGIvZHJpdmVycy90aGVybWFsL3N1bjUwaV90aGVybWFsLmMKPiA+IEBAIC0wLDAgKzEsMzU3IEBA Cj4gPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiA+ICsvKgo+ID4gKyAq IFRoZXJtYWwgc2Vuc29yIGRyaXZlciBmb3IgQWxsd2lubmVyIFNPQwo+ID4gKyAqIENvcHlyaWdo dCAoQykgMjAxOSBZYW5ndGFvIExpCj4gPiArICoKPiA+ICsgKiBCYXNlZCBvbiB0aGUgd29yayBv ZiBJY2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2MuaW8+Cj4gPiArICogQmFzZWQgb24gdGhlIHdv cmsgb2YgT25kcmVqIEppcm1hbiA8bWVnb3VzQG1lZ291cy5jb20+Cj4gPiArICogQmFzZWQgb24g dGhlIHdvcmsgb2YgSm9zZWYgR2FqZHVzZWsgPGF0eEBhdHgubmFtZT4KPiA+ICsgKi8KPiA+ICsK PiA+ICsjaW5jbHVkZSA8bGludXgvY2xrLmg+Cj4gPiArI2luY2x1ZGUgPGxpbnV4L2RldmljZS5o Pgo+ID4gKyNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvbnZt ZW0tY29uc3VtZXIuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvb2ZfZGV2aWNlLmg+Cj4gPiArI2lu Y2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9yZWdt YXAuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvcmVzZXQuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgv c2xhYi5oPgo+ID4gKyNpbmNsdWRlIDxsaW51eC90aGVybWFsLmg+Cj4gPiArCj4gPiArI2RlZmlu ZSBNQVhfU0VOU09SX05VTSAgICAgICA0Cj4gPiArCj4gPiArI2RlZmluZSBGVF9URU1QX01BU0sg ICAgICAgICAgICAgICAgICAgICAgICAgR0VOTUFTSygxMSwgMCkKPiA+ICsjZGVmaW5lIFRFTVBf Q0FMSUJfTUFTSyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFTk1BU0soMTEsIDApCj4g PiArI2RlZmluZSBURU1QX1RPX1JFRyAgICAgICAgICAgICAgICAgICAgICAgICAgNjcyCj4gPiAr I2RlZmluZSBDQUxJQlJBVEVfREVGQVVMVCAgICAgICAgICAgICAgICAgICAgMHg4MDAKPiA+ICsK PiA+ICsjZGVmaW5lIFNVTjUwSV9USFNfQ1RSTDAgICAgICAgICAgICAgICAgICAgICAweDAwCj4g PiArI2RlZmluZSBTVU41MElfSDZfVEhTX0VOQUJMRSAgICAgICAgICAgICAgICAgMHgwNAo+ID4g KyNkZWZpbmUgU1VONTBJX0g2X1RIU19QQyAgICAgICAgICAgICAgICAgICAgIDB4MDgKPiA+ICsj ZGVmaW5lIFNVTjUwSV9INl9USFNfTUZDICAgICAgICAgICAgICAgICAgICAweDMwCj4gPiArI2Rl ZmluZSBTVU41MElfSDZfVEVNUF9DQUxJQiAgICAgICAgICAgICAgICAgMHhhMAo+ID4gKyNkZWZp bmUgU1VONTBJX0g2X1RFTVBfREFUQSAgICAgICAgICAgICAgICAgIDB4YzAKPiA+ICsKPiA+ICsj ZGVmaW5lIFNVTjUwSV9USFNfQ1RSTDBfVF9BQ1EoeCkgICAgICAgICAgICAoKEdFTk1BU0soMTUs IDApICYgKHgpKSA8PCAxNikKPiA+ICsjZGVmaW5lIFNVTjUwSV9USFNfRklMVEVSX0VOICAgICAg ICAgICAgICAgICBCSVQoMikKPiA+ICsjZGVmaW5lIFNVTjUwSV9USFNfRklMVEVSX1RZUEUoeCkg ICAgICAgICAgICAoR0VOTUFTSygxLCAwKSAmICh4KSkKPiA+ICsjZGVmaW5lIFNVTjUwSV9INl9U SFNfUENfVEVNUF9QRVJJT0QoeCkgICAgICAgICAgICAgICgoR0VOTUFTSygxOSwgMCkgJiAoeCkp IDw8IDEyKQo+ID4gKwo+ID4gKy8qIG1pbGxpZGVncmVlIGNlbHNpdXMgKi8KPiA+ICsjZGVmaW5l IFNVTjUwSV9INl9GVF9ERVZJQVRJT04gICAgICAgICAgICAgICAgICAgICAgIDcwMDAKPiA+ICsK PiA+ICtzdHJ1Y3QgdHNlbnNfZGV2aWNlOwo+ID4gKwo+ID4gK3N0cnVjdCB0c2Vuc29yIHsKPiA+ ICsgICAgIHN0cnVjdCB0c2Vuc19kZXZpY2UgICAgICAgICAgICAgKnRtZGV2Owo+ID4gKyAgICAg c3RydWN0IHRoZXJtYWxfem9uZV9kZXZpY2UgICAgICAqdHpkOwo+ID4gKyAgICAgaW50ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpZDsKPiA+ICt9Owo+ID4gKwo+ID4gK3N0cnVjdCBzdW41 MGlfdGhlcm1hbF9jaGlwIHsKPiA+ICsgICAgIGludCAgICAgc2Vuc29yX251bTsKPiA+ICsgICAg IGludCAgICAgb2Zmc2V0Owo+ID4gKyAgICAgaW50ICAgICBzY2FsZTsKPiA+ICsgICAgIGludCAg ICAgZnRfZGV2aWF0aW9uOwo+ID4gKyAgICAgaW50ICAgICB0ZW1wX2NhbGliX2Jhc2U7Cj4gPiAr ICAgICBpbnQgICAgIHRlbXBfZGF0YV9iYXNlOwo+ID4gKyAgICAgaW50ICAgICAoKmVuYWJsZSko c3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXYpOwo+ID4gKyAgICAgaW50ICAgICAoKmRpc2FibGUp KHN0cnVjdCB0c2Vuc19kZXZpY2UgKnRtZGV2KTsKPiA+ICt9Owo+ID4gKwo+ID4gKwo+ID4gK3N0 cnVjdCB0c2Vuc19kZXZpY2Ugewo+ID4gKyAgICAgY29uc3Qgc3RydWN0IHN1bjUwaV90aGVybWFs X2NoaXAgICAgICAgICpjaGlwOwo+ID4gKyAgICAgc3RydWN0IGRldmljZSAgICAgICAgICAgICAg ICAgICAgICAgICAgICpkZXY7Cj4gPiArICAgICBzdHJ1Y3QgcmVnbWFwICAgICAgICAgICAgICAg ICAgICAgICAgICAgKnJlZ21hcDsKPiA+ICsgICAgIHN0cnVjdCByZXNldF9jb250cm9sICAgICAg ICAgICAgICAgICAgICAqcmVzZXQ7Cj4gPiArICAgICBzdHJ1Y3QgY2xrICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKmJ1c19jbGs7Cj4gPiArICAgICBzdHJ1Y3QgdHNlbnNvciAgICAgICAg ICAgICAgICAgICAgICAgICAgc2Vuc29yW01BWF9TRU5TT1JfTlVNXTsKPiA+ICt9Owo+ID4gKwo+ ID4gKy8qIFRlbXAgVW5pdDogbWlsbGlkZWdyZWUgQ2Vsc2l1cyAqLwo+ID4gK3N0YXRpYyBpbnQg dHNlbnNfcmVnMnRlbXAoc3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXYsCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW50IHJlZykKPgo+IFBsZWFzZSBuYW1lIGFsbCBmdW5jdGlvbnMg c28gdGhhdCB0aGV5IGFyZSBtb3JlIGNsZWFybHkgaWRlbnRpZmlhYmxlCj4gaW4gc3RhY2sgdHJh Y2VzIGFzIGJlbG9uZ2luZyB0byB0aGlzIGRyaXZlci4gRm9yIGV4YW1wbGU6Cj4KPiAgIHN1bjhp X3Roc19yZWcydGVtcAo+Cj4gVGhlIHNhbWUgYXBwbGllcyBmb3IgYWxsIHRzZW5zXyogZnVuY3Rp b25zIGJlbG93LiB0c2Vuc18qIGlzIHRvbwo+IGdlbmVyaWMuCgpEb25lIGJ1dCBubyBzdW44aV90 aHNfcmVnMnRlbXAuCgp0aHNfcmVnMnRlbSgpIHNob3VsZCBiZSBhIGdlbmVyaWMgZnVuYy4KSSB0 aGluayBpdCBzaG91bGQgYmUgc3VpdGFibGUgZm9yIGFsbCBwbGF0Zm9ybXPvvIwgc28gbm8gcGxh dGZvcm0gcHJlZml4LgoKPgo+ID4gK3sKPiA+ICsgICAgIHJldHVybiAocmVnICsgdG1kZXYtPmNo aXAtPm9mZnNldCkgKiB0bWRldi0+Y2hpcC0+c2NhbGU7Cj4gPiArfQo+ID4gKwo+ID4gK3N0YXRp YyBpbnQgdHNlbnNfZ2V0X3RlbXAodm9pZCAqZGF0YSwgaW50ICp0ZW1wKQo+ID4gK3sKPiA+ICsg ICAgIHN0cnVjdCB0c2Vuc29yICpzID0gZGF0YTsKPiA+ICsgICAgIHN0cnVjdCB0c2Vuc19kZXZp Y2UgKnRtZGV2ID0gcy0+dG1kZXY7Cj4gPiArICAgICBpbnQgdmFsOwo+ID4gKwo+ID4gKyAgICAg cmVnbWFwX3JlYWQodG1kZXYtPnJlZ21hcCwgdG1kZXYtPmNoaXAtPnRlbXBfZGF0YV9iYXNlICsK PiA+ICsgICAgICAgICAgICAgICAgIDB4NCAqIHMtPmlkLCAmdmFsKTsKPiA+ICsKPiA+ICsgICAg IGlmICh1bmxpa2VseSh2YWwgPT0gMCkpCj4gPiArICAgICAgICAgICAgIHJldHVybiAtRUJVU1k7 Cj4gPiArCj4gPiArICAgICAqdGVtcCA9IHRzZW5zX3JlZzJ0ZW1wKHRtZGV2LCB2YWwpOwo+ID4g KyAgICAgaWYgKHRtZGV2LT5jaGlwLT5mdF9kZXZpYXRpb24pCj4gPiArICAgICAgICAgICAgICp0 ZW1wICs9IHRtZGV2LT5jaGlwLT5mdF9kZXZpYXRpb247Cj4gPiArCj4gPiArICAgICByZXR1cm4g MDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCB0aGVybWFsX3pvbmVfb2Zf ZGV2aWNlX29wcyB0c2Vuc19vcHMgPSB7Cj4gPiArICAgICAuZ2V0X3RlbXAgPSB0c2Vuc19nZXRf dGVtcCwKPiA+ICt9Owo+ID4gKwo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZp ZyBjb25maWcgPSB7Cj4gPiArICAgICAucmVnX2JpdHMgPSAzMiwKPiA+ICsgICAgIC52YWxfYml0 cyA9IDMyLAo+ID4gKyAgICAgLnJlZ19zdHJpZGUgPSA0LAo+ID4gKyAgICAgLmZhc3RfaW8gPSB0 cnVlLAo+ID4gK307Cj4gPiArCj4gPiArc3RhdGljIGludCB0c2Vuc19pbml0KHN0cnVjdCB0c2Vu c19kZXZpY2UgKnRtZGV2KQo+ID4gK3sKPiA+ICsgICAgIHN0cnVjdCBkZXZpY2UgKmRldiA9IHRt ZGV2LT5kZXY7Cj4gPiArICAgICBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gdG9fcGxh dGZvcm1fZGV2aWNlKGRldik7Cj4gPiArICAgICBzdHJ1Y3QgcmVzb3VyY2UgKm1lbTsKPiA+ICsg ICAgIHZvaWQgX19pb21lbSAqYmFzZTsKPiA+ICsKPiA+ICsgICAgIG1lbSA9IHBsYXRmb3JtX2dl dF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7Cj4gPiArICAgICBiYXNlID0gZGV2 bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgbWVtKTsKPiA+ICsgICAgIGlmIChJU19FUlIoYmFzZSkp Cj4gPiArICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKGJhc2UpOwo+ID4gKwo+ID4gKyAgICAg dG1kZXYtPnJlZ21hcCA9IGRldm1fcmVnbWFwX2luaXRfbW1pb19jbGsoZGV2LCAiYnVzIiwKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJhc2UsCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmY29uZmln KTsKPiA+ICsgICAgIGlmIChJU19FUlIodG1kZXYtPnJlZ21hcCkpCj4gPiArICAgICAgICAgICAg IHJldHVybiBQVFJfRVJSKHRtZGV2LT5yZWdtYXApOwo+ID4gKwo+ID4gKyAgICAgdG1kZXYtPnJl c2V0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldChkZXYsICJidXMiKTsKPiA+ICsgICAgIGlmIChJ U19FUlIodG1kZXYtPnJlc2V0KSkKPiA+ICsgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIodG1k ZXYtPnJlc2V0KTsKPiA+ICsKPiA+ICsgICAgIHRtZGV2LT5idXNfY2xrID0gZGV2bV9jbGtfZ2V0 KCZwZGV2LT5kZXYsICJidXMiKTsKPiA+ICsgICAgIGlmIChJU19FUlIodG1kZXYtPmJ1c19jbGsp KQo+ID4gKyAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUih0bWRldi0+YnVzX2Nsayk7Cj4gPiAr Cj4gPiArICAgICByZXR1cm4gMDsKPiA+ICt9Cj4gPiArCj4gPiArLyoKPiA+ICsgKiBFdmVuIGlm IHRoZSBleHRlcm5hbCBjYWxpYnJhdGlvbiBkYXRhIHN0b3JlZCBpbiBzaWQgaXMgbm90IGFjY2Vz c2libGUsCj4gPiArICogdGhlIFRIUyBoYXJkd2FyZSBjYW4gc3RpbGwgd29yaywgYWx0aG91Z2gg dGhlIGRhdGEgd29uJ3QgYmUgc28gYWNjdXJhdGUuCj4gPiArICogVGhlIGRlZmF1bHQgdmFsdWUg b2YgY2FsaWJyYXRpb24gcmVnaXN0ZXIgaXMgMHg4MDAgZm9yIGV2ZXJ5IHNlbnNvciwKPiA+ICsg KiBhbmQgdGhlIGNhbGlicmF0aW9uIHZhbHVlIGlzIHVzdWFsbHkgMHg3eHggb3IgMHg4eHgsIHNv IHRoZXkgd29uJ3QgYmUKPiA+ICsgKiBhd2F5IGZyb20gdGhlIGRlZmF1bHQgdmFsdWUgZm9yIGEg bG90Lgo+ID4gKyAqCj4gPiArICogU28gaGVyZSB3ZSBkbyBub3QgcmV0dXJuIGVycm9yIGlmIHRo ZSBjYWxpYmFydGlvbiBkYXRhIGlzCj4gPiArICogbm90IGF2YWlsYWJsZSwgZXhjZXB0IHRoZSBw cm9iZSBuZWVkcyBkZWZlcnJpbmcuCj4gPiArICovCj4gPiArc3RhdGljIGludCB0c2Vuc19jYWxp YnJhdGUoc3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXYpCj4gPiArewo+ID4gKyAgICAgc3RydWN0 IG52bWVtX2NlbGwgKmNhbGNlbGw7Cj4gPiArICAgICBzdHJ1Y3QgZGV2aWNlICpkZXYgPSB0bWRl di0+ZGV2Owo+ID4gKyAgICAgdTE2ICpjYWxkYXRhOwo+ID4gKyAgICAgc2l6ZV90IGNhbGxlbjsK PiA+ICsgICAgIGludCBmdF90ZW1wOwo+ID4gKyAgICAgaW50IGkgPSAwOwo+ID4gKwo+ID4gKyAg ICAgY2FsY2VsbCA9IGRldm1fbnZtZW1fY2VsbF9nZXQoZGV2LCAiY2FsaWIiKTsKPiA+ICsgICAg IGlmIChJU19FUlIoY2FsY2VsbCkpIHsKPiA+ICsgICAgICAgICAgICAgaWYgKFBUUl9FUlIoY2Fs Y2VsbCkgPT0gLUVQUk9CRV9ERUZFUikKPiA+ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4g LUVQUk9CRV9ERUZFUjsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgZ290byBvdXQ7Cj4gPiArICAg ICB9Cj4gPiArCj4gPiArICAgICBjYWxkYXRhID0gbnZtZW1fY2VsbF9yZWFkKGNhbGNlbGwsICZj YWxsZW4pOwo+ID4gKyAgICAgaWYgKElTX0VSUihjYWxkYXRhKSkKPiA+ICsgICAgICAgICAgICAg Z290byBvdXQ7Cj4gPiArCj4gPiArICAgICBpZiAoIWNhbGRhdGFbMF0gfHwgY2FsbGVuIDwgMiAr IDIgKiB0bWRldi0+Y2hpcC0+c2Vuc29yX251bSkKPiA+ICsgICAgICAgICAgICAgZ290byBvdXRf ZnJlZTsKPiA+ICsKPiA+ICsgICAgIC8qCj4gPiArICAgICAgKiBUaGUgY2FsYnJhdGlvbiBkYXRh IG9uIEg2IGlzIHN0b3JlZCBhcyB0ZW1wZXJhdHVyZS12YWx1ZQo+ID4gKyAgICAgICogcGFpciB3 aGVuIGJlaW5nIGZpbGxlZCBhdCBmYWN0b3J5IHRlc3Qgc3RhZ2UuCj4gPiArICAgICAgKiBUaGUg dW5pdCBvZiBzdG9yZWQgRlQgdGVtcGVyYXR1cmUgaXMgMC4xIGRlZ3JlZWUgY2VsdXNpcy4KPiA+ ICsgICAgICAqLwo+Cj4gUGxlYXNlIGRlc2NyaWJlIHRoZSBjYWxpYnJhdGlvbiBkYXRhIGxheW91 dCBtb3JlIGNsZWFybHkuCkRvbmUuCj4KPiA+ICsgICAgIGZ0X3RlbXAgPSBjYWxkYXRhWzBdICYg RlRfVEVNUF9NQVNLOwo+ID4gKwo+ID4gKyAgICAgZm9yICg7IGkgPCB0bWRldi0+Y2hpcC0+c2Vu c29yX251bTsgaSsrKSB7Cj4gPiArICAgICAgICAgICAgIGludCByZWcgPSAoaW50KWNhbGRhdGFb aSArIDFdOwo+ID4gKyAgICAgICAgICAgICBpbnQgc2Vuc29yX3RlbXAgPSB0c2Vuc19yZWcydGVt cCh0bWRldiwgcmVnKTsKPiA+ICsgICAgICAgICAgICAgaW50IGRlbHRhLCBjZGF0YSwgY2FsaWJf b2ZmZXN0Owo+ID4gKwo+ID4gKyAgICAgICAgICAgICAvKgo+ID4gKyAgICAgICAgICAgICAgKiBU byBjYWxjdWxhdGUgdGhlIGNhbGlicmF0aW9uIHZhbHVlOgo+ID4gKyAgICAgICAgICAgICAgKgo+ ID4gKyAgICAgICAgICAgICAgKiBYKGluIENlbHNpdXMpID0gVHMgLSBmdF90ZW1wCj4gPiArICAg ICAgICAgICAgICAqIGRlbHRhID0gWCAqIDEwMDAwIC8gVEVNUF9UT19SRUcKPiA+ICsgICAgICAg ICAgICAgICogY2RhdGEgPSBDQUxJQlJBVEVfREVGQVVMVCAtIGRlbHRhCj4gPiArICAgICAgICAg ICAgICAqCj4gPiArICAgICAgICAgICAgICAqIGNkYXRhOiBjYWxpYnJhdGlvbiB2YWx1ZQo+ID4g KyAgICAgICAgICAgICAgKi8KPiA+ICsgICAgICAgICAgICAgZGVsdGEgPSAoc2Vuc29yX3RlbXAg LSBmdF90ZW1wICogMTAwKSAqIDEwIC8gVEVNUF9UT19SRUc7Cj4gPiArICAgICAgICAgICAgIGNk YXRhID0gQ0FMSUJSQVRFX0RFRkFVTFQgLSBkZWx0YTsKPiA+ICsgICAgICAgICAgICAgaWYgKGNk YXRhICYgflRFTVBfQ0FMSUJfTUFTSykgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGRldl93 YXJuKGRldiwgInNlbnNvciVkIGNhbGlicmF0aW9uIHZhbHVlIGVycm9yIiwgaSk7Cj4KPiBQbGVh c2UgdXNlIGEgbW9yZSBkZXNjcmlwdGl2ZSBlcnJvciBtZXNzYWdlLiBXaGF0IGVycm9yIGlzIHRo aXM/CgpTZWUgY29tbW50IGluIHYyLgoKPgo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGNvbnRp bnVlOwo+ID4gKyAgICAgICAgICAgICB9Cj4gPiArCj4gPiArICAgICAgICAgICAgIGNhbGliX29m ZmVzdCA9IHRtZGV2LT5jaGlwLT50ZW1wX2NhbGliX2Jhc2UgKyAoaSAvIDIpICogMHg0Owo+ID4g KyAgICAgICAgICAgICBpZiAoaSAlIDIpIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBpbnQg dmFsOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJlZ21hcF9yZWFkKHRtZGV2LT5y ZWdtYXAsIGNhbGliX29mZmVzdCwgJnZhbCk7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgdmFs ID0gKHZhbCAmIFRFTVBfQ0FMSUJfTUFTSykgfCAoY2RhdGEgPDwgMTYpOwo+ID4gKyAgICAgICAg ICAgICAgICAgICAgIHJlZ21hcF93cml0ZSh0bWRldi0+cmVnbWFwLCBjYWxpYl9vZmZlc3QsIHZh bCk7Cj4gPiArICAgICAgICAgICAgIH0gZWxzZQo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJl Z21hcF93cml0ZSh0bWRldi0+cmVnbWFwLCBjYWxpYl9vZmZlc3QsIGNkYXRhKTsKPiA+ICsgICAg IH0KPiA+ICsKPiA+ICtvdXRfZnJlZToKPiA+ICsgICAgIGtmcmVlKGNhbGRhdGEpOwo+ID4gK291 dDoKPiA+ICsgICAgIHJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgaW50IHRzZW5z X3JlZ2lzdGVyKHN0cnVjdCB0c2Vuc19kZXZpY2UgKnRtZGV2KQo+ID4gK3sKPiA+ICsgICAgIHN0 cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNlICp0emQ7Cj4gPiArICAgICBpbnQgaSA9IDA7Cj4gPiAr Cj4gPiArICAgICBmb3IgKDsgaSA8IHRtZGV2LT5jaGlwLT5zZW5zb3JfbnVtOyBpKyspIHsKPiA+ ICsgICAgICAgICAgICAgdG1kZXYtPnNlbnNvcltpXS50bWRldiA9IHRtZGV2Owo+ID4gKyAgICAg ICAgICAgICB0bWRldi0+c2Vuc29yW2ldLmlkID0gaTsKPiA+ICsgICAgICAgICAgICAgdG1kZXYt PnNlbnNvcltpXS50emQgPSBkZXZtX3RoZXJtYWxfem9uZV9vZl9zZW5zb3JfcmVnaXN0ZXIoCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRtZGV2LT5kZXYsIGksICZ0 bWRldi0+c2Vuc29yW2ldLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAmdHNlbnNfb3BzKTsKPiA+ICsgICAgICAgICAgICAgaWYgKElTX0VSUih0bWRldi0+c2Vuc29y W2ldLnR6ZCkpCj4gPiArICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIodHpkKTsK PiA+ICsgICAgIH0KPiA+ICsKPiA+ICsgICAgIHJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+ICtz dGF0aWMgaW50IHRzZW5zX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiAr ewo+ID4gKyAgICAgc3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXY7Cj4gPiArICAgICBzdHJ1Y3Qg ZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ID4gKyAgICAgaW50IHJldDsKPiA+ICsKPiA+ICsg ICAgIHRtZGV2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCp0bWRldiksIEdGUF9LRVJORUwp Owo+ID4gKyAgICAgaWYgKCF0bWRldikKPiA+ICsgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07 Cj4gPiArCj4gPiArICAgICB0bWRldi0+ZGV2ID0gZGV2Owo+ID4gKyAgICAgdG1kZXYtPmNoaXAg PSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4gPiArICAgICBpZiAoIXRt ZGV2LT5jaGlwKQo+ID4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICsKPiA+ICsg ICAgIHJldCA9IHRzZW5zX2luaXQodG1kZXYpOwo+ID4gKyAgICAgaWYgKHJldCkKPiA+ICsgICAg ICAgICAgICAgcmV0dXJuIHJldDsKPiA+ICsKPiA+ICsgICAgIHJldCA9IHRzZW5zX3JlZ2lzdGVy KHRtZGV2KTsKPiA+ICsgICAgIGlmIChyZXQpCj4gPiArICAgICAgICAgICAgIHJldHVybiByZXQ7 Cj4KPiBXaHkgc3BsaXQgdGhpcyBvdXQgb2YgcHJvYmUgaW50byBzZXBhcmF0ZSBmdW5jdGlvbnM/ Cj4KPiA+ICsgICAgIHJldCA9IHRtZGV2LT5jaGlwLT5lbmFibGUodG1kZXYpOwo+ID4gKyAgICAg aWYgKHJldCkKPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ICsKPiA+ICsgICAgIHBs YXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIHRtZGV2KTsKPiA+ICsKPiA+ICsgICAgIHJldHVybiBy ZXQ7Cj4gPiArfQo+ID4gKwo+ID4gK3N0YXRpYyBpbnQgdHNlbnNfcmVtb3ZlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiArewo+ID4gKyAgICAgc3RydWN0IHRzZW5zX2RldmljZSAq dG1kZXYgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ICsKPiA+ICsgICAgIHRtZGV2 LT5jaGlwLT5kaXNhYmxlKHRtZGV2KTsKPiA+ICsKPiA+ICsgICAgIHJldHVybiAwOwo+ID4gK30K PiA+ICsKPiA+ICtzdGF0aWMgaW50IHN1bjUwaV90aGVybWFsX2VuYWJsZShzdHJ1Y3QgdHNlbnNf ZGV2aWNlICp0bWRldikKPiA+ICt7Cj4gPiArICAgICBpbnQgcmV0LCB2YWw7Cj4gPiArCj4gPiAr ICAgICByZXQgPSByZXNldF9jb250cm9sX2RlYXNzZXJ0KHRtZGV2LT5yZXNldCk7Cj4gPiArICAg ICBpZiAocmV0KQo+ID4gKyAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ID4gKwo+ID4gKyAgICAg cmV0ID0gY2xrX3ByZXBhcmVfZW5hYmxlKHRtZGV2LT5idXNfY2xrKTsKPiA+ICsgICAgIGlmIChy ZXQpCj4gPiArICAgICAgICAgICAgIGdvdG8gYXNzZXJ0X3Jlc2V0Owo+ID4gKwo+ID4gKyAgICAg cmV0ID0gdHNlbnNfY2FsaWJyYXRlKHRtZGV2KTsKPiA+ICsgICAgIGlmIChyZXQpCj4gPiArICAg ICAgICAgICAgIHJldHVybiByZXQ7Cj4KPiBJZiB0aGlzIGZhaWxzIChpdCBtYXkgbGlrZWx5IGZh aWwgd2l0aCBFUFJPQkVfREVGRVIpIHlvdSBhcmUgbGVhdmluZyByZXNldAo+IGRlYXNzZXJ0ZWQs IGFuZCBjbG9jayBlbmFibGVkLgo+Cj4gT3ZlcmFsbCwgSSB0aGluaywgcmVzZXQvY2xvY2sgbWFu YWdlbWVudCBhbmQgbnZtZW0gcmVhZGluZyB3aWxsIGJlIGNvbW1vbgo+IHRvIGFsbCB0aGUgSFcg dmFyaWFudHMsIHNvIGl0IGRvZXNuJ3QgbWFrZSBtdWNoIHNlbnNlIHNwbGl0dGluZyBpdCBvdXQK PiBvZiBwcm9iZSBpbnRvIHNlcGFyYXRlIGZ1bmN0aW9ucywgYW5kIG1ha2VzIGl0IG1vcmUgZXJy b3IgcHJvbmUuCgpPdXIgbG9uZy10ZXJtIGdvYWwgaXMgdG8gc3VwcG9ydCBhbGwgcGxhdGZvcm1z LgpCYWNpY2FsbHQgdGhlcmUgaXMgYSBkaWZmZXJlbmNyIGJldHdlZW4gZWFjaCBnZW5lcmF0aW9u LgpTbyBJIGZlZWwgaXQgbmVjZXNzYXJ5IHRvIGlzb2xhdGUgdGhlc2UgZGlmZmVyZW5jZXMuCgpN YXliZToKQXQgc29tZSBwb2ludCwgd2UgY2FuIGRyYXcgYSBwYXJ0IG9mIHRoZSBwdWJsaWMgcGFy dCBhbmQgcGxhdGZvcm0KZGlmZmVyZW5jZSBpbnRvIGRpZmZlcmVudApmaWxlcy4gc29tZXRoaW5n IGxpa2UgcWNvbSB0aGVybWFsIGRyaXZlci4KClJlZ2FyZHMsCllhbmd0YW8KPgo+IHRoYW5rIHlv dSBhbmQgcmVnYXJkcywKPiAgICAgICAgIG8uCj4KPiA+ICsgICAgIC8qCj4gPiArICAgICAgKiBj bGtpbiA9IDI0TUh6Cj4gPiArICAgICAgKiBUIGFjcXVpcmUgPSBjbGtpbiAvIChTVU41MElfVEhT X0NUUkwwX1RfQUNRICsgMSkKPiA+ICsgICAgICAqICAgICAgICAgICA9IDIwdXMKPiA+ICsgICAg ICAqLwo+ID4gKyAgICAgcmVnbWFwX3dyaXRlKHRtZGV2LT5yZWdtYXAsIFNVTjUwSV9USFNfQ1RS TDAsCj4gPiArICAgICAgICAgICAgICAgICAgU1VONTBJX1RIU19DVFJMMF9UX0FDUSg0NzkpKTsK PiA+ICsgICAgIC8qIGF2ZXJhZ2Ugb3ZlciA0IHNhbXBsZXMgKi8KPiA+ICsgICAgIHJlZ21hcF93 cml0ZSh0bWRldi0+cmVnbWFwLCBTVU41MElfSDZfVEhTX01GQywKPiA+ICsgICAgICAgICAgICAg ICAgICBTVU41MElfVEhTX0ZJTFRFUl9FTiB8Cj4gPiArICAgICAgICAgICAgICAgICAgU1VONTBJ X1RIU19GSUxURVJfVFlQRSgxKSk7Cj4gPiArICAgICAvKiBwZXJpb2QgPSAoU1VONTBJX0g2X1RI U19QQ19URU1QX1BFUklPRCArIDEpICogNDA5NiAvIGNsa2luOyB+MTBtcyAqLwo+ID4gKyAgICAg cmVnbWFwX3dyaXRlKHRtZGV2LT5yZWdtYXAsIFNVTjUwSV9INl9USFNfUEMsCj4gPiArICAgICAg ICAgICAgICAgICAgU1VONTBJX0g2X1RIU19QQ19URU1QX1BFUklPRCg1OCkpOwo+ID4gKyAgICAg LyogZW5hYmxlIHNlbnNvciAqLwo+ID4gKyAgICAgdmFsID0gR0VOTUFTSyh0bWRldi0+Y2hpcC0+ c2Vuc29yX251bSAtIDEsIDApOwo+ID4gKyAgICAgcmVnbWFwX3dyaXRlKHRtZGV2LT5yZWdtYXAs IFNVTjUwSV9INl9USFNfRU5BQkxFLCB2YWwpOwo+ID4gKwo+ID4gKyAgICAgcmV0dXJuIDA7Cj4g PiArCj4gPiArYXNzZXJ0X3Jlc2V0Ogo+ID4gKyAgICAgcmVzZXRfY29udHJvbF9hc3NlcnQodG1k ZXYtPnJlc2V0KTsKPiA+ICsKPiA+ICsgICAgIHJldHVybiByZXQ7Cj4gPiArfQo+ID4gKwo+ID4g K3N0YXRpYyBpbnQgc3VuNTBpX3RoZXJtYWxfZGlzYWJsZShzdHJ1Y3QgdHNlbnNfZGV2aWNlICp0 bWRldikKPiA+ICt7Cj4gPiArICAgICBjbGtfZGlzYWJsZV91bnByZXBhcmUodG1kZXYtPmJ1c19j bGspOwo+ID4gKyAgICAgcmVzZXRfY29udHJvbF9hc3NlcnQodG1kZXYtPnJlc2V0KTsKPiA+ICsK PiA+ICsgICAgIHJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0 IHN1bjUwaV90aGVybWFsX2NoaXAgc3VuNTBpX2g2X3RocyA9IHsKPiA+ICsgICAgIC5zZW5zb3Jf bnVtID0gMiwKPiA+ICsgICAgIC5vZmZzZXQgPSAtMjc5NCwKPiA+ICsgICAgIC5zY2FsZSA9IC02 NywKPiA+ICsgICAgIC5mdF9kZXZpYXRpb24gPSBTVU41MElfSDZfRlRfREVWSUFUSU9OLAo+ID4g KyAgICAgLnRlbXBfY2FsaWJfYmFzZSA9IFNVTjUwSV9INl9URU1QX0NBTElCLAo+ID4gKyAgICAg LnRlbXBfZGF0YV9iYXNlID0gU1VONTBJX0g2X1RFTVBfREFUQSwKPiA+ICsgICAgIC5lbmFibGUg PSBzdW41MGlfdGhlcm1hbF9lbmFibGUsCj4gPiArICAgICAuZGlzYWJsZSA9IHN1bjUwaV90aGVy bWFsX2Rpc2FibGUsCj4gPiArfTsKPiA+ICsKPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rl dmljZV9pZCBvZl90c2Vuc19tYXRjaFtdID0gewo+ID4gKyAgICAgeyAuY29tcGF0aWJsZSA9ICJh bGx3aW5uZXIsc3VuNTBpLWg2LXRocyIsIC5kYXRhID0gJnN1bjUwaV9oNl90aHMgfSwKPiA+ICsg ICAgIHsgLyogc2VudGluZWwgKi8gfSwKPiA+ICt9Owo+ID4gK01PRFVMRV9ERVZJQ0VfVEFCTEUo b2YsIG9mX3RzZW5zX21hdGNoKTsKPiA+ICsKPiA+ICtzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2Ry aXZlciB0c2Vuc19kcml2ZXIgPSB7Cj4gPiArICAgICAucHJvYmUgPSB0c2Vuc19wcm9iZSwKPiA+ ICsgICAgIC5yZW1vdmUgPSB0c2Vuc19yZW1vdmUsCj4gPiArICAgICAuZHJpdmVyID0gewo+ID4g KyAgICAgICAgICAgICAubmFtZSA9ICJzdW41MGktdGhlcm1hbCIsCj4gPiArICAgICAgICAgICAg IC5vZl9tYXRjaF90YWJsZSA9IG9mX3RzZW5zX21hdGNoLAo+ID4gKyAgICAgfSwKPiA+ICt9Owo+ ID4gK21vZHVsZV9wbGF0Zm9ybV9kcml2ZXIodHNlbnNfZHJpdmVyKTsKPiA+ICsKPiA+ICtNT0RV TEVfREVTQ1JJUFRJT04oIlRoZXJtYWwgc2Vuc29yIGRyaXZlciBmb3IgQWxsd2lubmVyIFNPQyIp Owo+ID4gK01PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiA+IC0tCj4gPiAyLjE3LjAKPiA+Cj4g Pgo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=