From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D07AC04AAF for ; Thu, 16 May 2019 18:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD30520862 for ; Thu, 16 May 2019 18:14:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1a1UQAW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbfEPSOL (ORCPT ); Thu, 16 May 2019 14:14:11 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:38344 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfEPSOL (ORCPT ); Thu, 16 May 2019 14:14:11 -0400 Received: by mail-it1-f196.google.com with SMTP id i63so7830387ita.3; Thu, 16 May 2019 11:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oYizfKO0iUCkCx87QTv9y+9/yguDDJWHGpNmrjjyMQE=; b=T1a1UQAWEN1zwXTAxJ0W6YsgQvMdJVGrZGrDTxkDkBdftsG7bFuxqMMuyRYIbwpp3N zpUtrb0fyJY34h5ZAqJ5AKxT5uAswqiB8LO5sX7EJZTZgfYEuGvfO/pb8QwJVTKmVOqr MpYvM0qdYL46t4TGTV4SiIP/n20fxoie6h4lu9vHtVeHW6WMLT7uWNa4D7JCmGJdqinU Pff5NHk3/urnJe9KHzJ6+b6680Gwf/AWHqMdWWb+a/6DEl/LFjfmKJv/qzjGlsL+oluN QFRErVrPnqIzZrVDXUDAYofBl17/UhgtMEOjPMZ4uAeyPqGuIKtX1oJjyRayHP/2d5U4 lc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oYizfKO0iUCkCx87QTv9y+9/yguDDJWHGpNmrjjyMQE=; b=aI3BJkR77k41yerUhldC952Lgy/oKTQNv9pFBpp6ZHJXfWHgNppFPPKR63/OgKNvji WOEectIMFLrFFPfkZPpWVc3p+bvNXB7fLNa6FV3/3ZNjO2yw7UW26KV6kxV36U+KWg5U bmlCZOBl7xzdvEVv0lkmUZuT3kxYRUh8ba+ICWZYza8TjF4oCYJbDNVs0w/48Zf6Ie6u xeGx5x3cFESJ2dKxx1GXmfQdsCCB/RMzYNultjszjl/Ux9VUYapFRZ/H6nvcJuLi3IJp J0HnF6EkFzgNjjLUGaEgscd7vcywjSnxUJNUFno03ZVo6wOqQvSShYDvTKkOccxRog08 TLeg== X-Gm-Message-State: APjAAAXXykYoKxaINn+ab7wg/iSsFv4vFk9F6yssAfPJjgiq8rV5gEe0 Ue3/o0J0gJc52+tHt/XwASXbTEd3TW+lgHNXpyQ= X-Google-Smtp-Source: APXvYqzg91EbMijFJyKzCeNsU32nhaqbI5CANe+33pKz919XCTOUPyqfIi2K6fq6NPt65fI6+i8jOiwXWRTfBrRl2y4= X-Received: by 2002:a05:660c:105:: with SMTP id w5mr1049148itj.37.1558030450144; Thu, 16 May 2019 11:14:10 -0700 (PDT) MIME-Version: 1.0 References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-4-tiny.windzz@gmail.com> <20190512134152.yrletgtiglxncyo4@flea> In-Reply-To: <20190512134152.yrletgtiglxncyo4@flea> From: Frank Lee Date: Fri, 17 May 2019 02:13:58 +0800 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller To: Maxime Ripard Cc: rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , robh+dt@kernel.org, Mark Rutland , Chen-Yu Tsai , catalin.marinas@arm.com, will.deacon@arm.com, David Miller , Mauro Carvalho Chehab , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , paulmck@linux.ibm.com, Andy Gross , olof@lixom.net, bjorn.andersson@linaro.org, Jagan Teki , marc.w.gonzalez@free.fr, stefan.wahren@i2se.com, enric.balletbo@collabora.com, Linux PM , devicetree@vger.kernel.org, Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 12, 2019 at 9:41 PM Maxime Ripard wrote: > > Hi, > > On Sun, May 12, 2019 at 04:26:14AM -0400, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li > > --- > > .../bindings/thermal/sun50i-thermal.txt | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > We're starting to convert to YAML for binding descriptions that will > allow to validate that all DT are properly using the binding. It would > be great if you could use it as well. What have been changed to this now? > > > diff --git a/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > new file mode 100644 > > index 000000000000..67eda7794262 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > @@ -0,0 +1,32 @@ > > +Binding for Thermal Sensor of Allwinner SOC. > > + > > +This describes the device tree binding for the Allwinner thermal controller > > +which measures the on-SoC temperatures. > > + > > +Required properties: > > +- compatible: > > + - "allwinner,sun50i-h6-ths" : For H6 > > +- reg: Address range of the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. > > + The required clocks for h6 are: "bus". > > If there's a single clock, then we don't need clock-names Yeah, but, IIRC, H3 have two clk. So I'd like to keep it. > > > +- resets, reset-names: Reference to the reset controller controlling > > + the thermal controller. > > Ditto. Done. Thx, Yangtao > > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calib" > > I thought you said that nvmem support was optional in the > driver. Maybe we could make it optional in the DT too? > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Lee Subject: Re: [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller Date: Fri, 17 May 2019 02:13:58 +0800 Message-ID: References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-4-tiny.windzz@gmail.com> <20190512134152.yrletgtiglxncyo4@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190512134152.yrletgtiglxncyo4@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: rui.zhang@intel.com, Eduardo Valentin , Daniel Lezcano , robh+dt@kernel.org, Mark Rutland , Chen-Yu Tsai , catalin.marinas@arm.com, will.deacon@arm.com, David Miller , Mauro Carvalho Chehab , Greg Kroah-Hartman , Jonathan.Cameron@huawei.com, Nicolas Ferre , paulmck@linux.ibm.com, Andy Gross , olof@lixom.net, bjorn.andersson@linaro.org, Jagan Teki , marc.w.gonzalez@free.fr, stefan.wahren@i2se.com, enric.balletbo@collabora.com, Linux PM , devicetree@vger.kernel.org, Linux ARM List-Id: devicetree@vger.kernel.org On Sun, May 12, 2019 at 9:41 PM Maxime Ripard wrote: > > Hi, > > On Sun, May 12, 2019 at 04:26:14AM -0400, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li > > --- > > .../bindings/thermal/sun50i-thermal.txt | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > We're starting to convert to YAML for binding descriptions that will > allow to validate that all DT are properly using the binding. It would > be great if you could use it as well. What have been changed to this now? > > > diff --git a/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > new file mode 100644 > > index 000000000000..67eda7794262 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > @@ -0,0 +1,32 @@ > > +Binding for Thermal Sensor of Allwinner SOC. > > + > > +This describes the device tree binding for the Allwinner thermal controller > > +which measures the on-SoC temperatures. > > + > > +Required properties: > > +- compatible: > > + - "allwinner,sun50i-h6-ths" : For H6 > > +- reg: Address range of the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. > > + The required clocks for h6 are: "bus". > > If there's a single clock, then we don't need clock-names Yeah, but, IIRC, H3 have two clk. So I'd like to keep it. > > > +- resets, reset-names: Reference to the reset controller controlling > > + the thermal controller. > > Ditto. Done. Thx, Yangtao > > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calib" > > I thought you said that nvmem support was optional in the > driver. Maybe we could make it optional in the DT too? > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F70AC04AAF for ; Thu, 16 May 2019 18:14:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AB9920833 for ; Thu, 16 May 2019 18:14:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OMO8gqjz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1a1UQAW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB9920833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cghproEOQekP8y6jOJt51BtSKMHiBLsIp8t+1lFl8Ls=; b=OMO8gqjz+tfkxF imgoPLLav9rmnj9FGCPRE83s5Rz/7JmXrMhOTRYTyu9lOE0TgkFdAKk8God8m2qsWcpJgY2uBFMZq 8u32E6ret9UD7tCl3ioOkUA05eA4qtgmbtDs9mBsMlH95+fXM5ZdusBxnqz78vVD0Xo4UpdGPN5nW TQGoa8PjJddp0xXtJbMA/Psq2hpEh+CJ3eCJp8DM5YN5b1fDVDCKQvKMxBehuGmphFVVli8XlSNGL gZtxDVtvUw5/fXn0Tc65H6xx8rXIzCQzZN3eSZXWZissHj5Tr5Cn0HmtvyqGyajBs8c+SHpce+0hG X+EsBApoWbTmBCo6itWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRKtS-0005e5-CT; Thu, 16 May 2019 18:14:14 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRKtP-0005dG-4E for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2019 18:14:12 +0000 Received: by mail-it1-x144.google.com with SMTP id m140so7852198itg.2 for ; Thu, 16 May 2019 11:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oYizfKO0iUCkCx87QTv9y+9/yguDDJWHGpNmrjjyMQE=; b=T1a1UQAWEN1zwXTAxJ0W6YsgQvMdJVGrZGrDTxkDkBdftsG7bFuxqMMuyRYIbwpp3N zpUtrb0fyJY34h5ZAqJ5AKxT5uAswqiB8LO5sX7EJZTZgfYEuGvfO/pb8QwJVTKmVOqr MpYvM0qdYL46t4TGTV4SiIP/n20fxoie6h4lu9vHtVeHW6WMLT7uWNa4D7JCmGJdqinU Pff5NHk3/urnJe9KHzJ6+b6680Gwf/AWHqMdWWb+a/6DEl/LFjfmKJv/qzjGlsL+oluN QFRErVrPnqIzZrVDXUDAYofBl17/UhgtMEOjPMZ4uAeyPqGuIKtX1oJjyRayHP/2d5U4 lc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oYizfKO0iUCkCx87QTv9y+9/yguDDJWHGpNmrjjyMQE=; b=bly6mXwjNF8z3CBUquAFab01V81PR73FNP6IqNxBizMKrt0YE07z0BUTMKKGQyQAfa dT26mbp3pfETRiFGYeyPj5X/OROcYtjqCXbsbzzGlORV5F0ts79T5e2X1X2z0NPxnKtL Xpkr7bUiF7jwMpFq7fkD1f+iL/hpwvGipN8QDKTLztsTnRxLWqr+RQ4z21lK4MkH0c0Z 32w4I3b+gYdnHwrV1VYjuMHicxzNf5hJHZtiuEai/ItBgCNOLMrizLQMpqBa/5gdRBCy sqV00ReLoCgnwY/LZM67hmjcd4Wc11yWv+ZpXF6CyS5fqdhEqlwlg0kDOXor0V55Jllx F70Q== X-Gm-Message-State: APjAAAXbqOl4H26XQ/gw71SJCG0RAtFPV2EXbBr/Coqn8Vi2/G82OPuK aXtjwTUmVG8/6QW+Eyn4n/Rn9QToTU4ZIGAe6P8= X-Google-Smtp-Source: APXvYqzg91EbMijFJyKzCeNsU32nhaqbI5CANe+33pKz919XCTOUPyqfIi2K6fq6NPt65fI6+i8jOiwXWRTfBrRl2y4= X-Received: by 2002:a05:660c:105:: with SMTP id w5mr1049148itj.37.1558030450144; Thu, 16 May 2019 11:14:10 -0700 (PDT) MIME-Version: 1.0 References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-4-tiny.windzz@gmail.com> <20190512134152.yrletgtiglxncyo4@flea> In-Reply-To: <20190512134152.yrletgtiglxncyo4@flea> From: Frank Lee Date: Fri, 17 May 2019 02:13:58 +0800 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190516_111411_172175_13AE6BDE X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 12, 2019 at 9:41 PM Maxime Ripard wrote: > > Hi, > > On Sun, May 12, 2019 at 04:26:14AM -0400, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li > > --- > > .../bindings/thermal/sun50i-thermal.txt | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > We're starting to convert to YAML for binding descriptions that will > allow to validate that all DT are properly using the binding. It would > be great if you could use it as well. What have been changed to this now? > > > diff --git a/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > new file mode 100644 > > index 000000000000..67eda7794262 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > @@ -0,0 +1,32 @@ > > +Binding for Thermal Sensor of Allwinner SOC. > > + > > +This describes the device tree binding for the Allwinner thermal controller > > +which measures the on-SoC temperatures. > > + > > +Required properties: > > +- compatible: > > + - "allwinner,sun50i-h6-ths" : For H6 > > +- reg: Address range of the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. > > + The required clocks for h6 are: "bus". > > If there's a single clock, then we don't need clock-names Yeah, but, IIRC, H3 have two clk. So I'd like to keep it. > > > +- resets, reset-names: Reference to the reset controller controlling > > + the thermal controller. > > Ditto. Done. Thx, Yangtao > > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calib" > > I thought you said that nvmem support was optional in the > driver. Maybe we could make it optional in the DT too? > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel