From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:52616 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753650Ab2JKOqs (ORCPT ); Thu, 11 Oct 2012 10:46:48 -0400 MIME-Version: 1.0 In-Reply-To: <20121011144141.GD4405@twin.jikos.cz> References: <1349863655-29320-1-git-send-email-zwu.kernel@gmail.com> <1349863655-29320-2-git-send-email-zwu.kernel@gmail.com> <20121010162842.GZ4405@twin.jikos.cz> <20121011144141.GD4405@twin.jikos.cz> Date: Thu, 11 Oct 2012 22:46:46 +0800 Message-ID: Subject: Re: [RFC v3 01/13] btrfs: add one new mount option '-o hot_track' From: Zhi Yong Wu To: dave@jikos.cz, Zhi Yong Wu , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linuxram@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, david@fromorbit.com, tytso@mit.edu, cmm@us.ibm.com, Zhi Yong Wu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Oct 11, 2012 at 10:41 PM, David Sterba wrote: > On Thu, Oct 11, 2012 at 10:35:28PM +0800, Zhi Yong Wu wrote: >> >> --- a/fs/btrfs/super.c >> >> +++ b/fs/btrfs/super.c >> >> @@ -303,7 +304,7 @@ enum { >> >> Opt_notreelog, Opt_ratio, Opt_flushoncommit, Opt_discard, >> >> Opt_space_cache, Opt_clear_cache, Opt_user_subvol_rm_allowed, >> >> Opt_enospc_debug, Opt_subvolrootid, Opt_defrag, Opt_inode_cache, >> >> - Opt_no_space_cache, Opt_recovery, Opt_skip_balance, >> >> + Opt_no_space_cache, Opt_recovery, Opt_skip_balance, Opt_hot_track, >> > >> > Please add the new option to the end. >> To be honest, it can't be added to the end, if you check Opt_err's >> pattern value, you will find it is NULL, it will cause match_one() >> return 1. So if we add Opt_hot_track to the end of this array, it will >> be covered by match_token(), so i prefer to add it to >> Opt_fatal_errors. Do you think of it? > > Ah, sorry, I was not clear what the 'end' means here. The Opt_err is a > end-of-the-list token, so yes please add hot_track between > Opt_fatal_errors and Opt_err. Done, thanks. It will be appreciated if you can make comments on other patches of this series.:) > > david -- Regards, Zhi Yong Wu