From: Zhi Yong Wu <zwu.kernel@gmail.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
cmm@us.ibm.com, wuzhy@linux.vnet.ibm.com,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: add hot tracking support
Date: Mon, 29 Oct 2012 10:24:50 +0800 [thread overview]
Message-ID: <CAEH94LjZtT-Nh-6AqUaPCSwrbkLmz-BuO8D=9FjeE=_xqGmJzA@mail.gmail.com> (raw)
In-Reply-To: <20121029023244.GA5319@gmail.com>
On Mon, Oct 29, 2012 at 10:32 AM, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> On Sun, Oct 28, 2012 at 09:45:49PM +0800, Zhi Yong Wu wrote:
> [snip]
>> On Sun, Oct 28, 2012 at 5:22 PM, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
>> > @@ -864,6 +865,8 @@ static void ext4_put_super(struct super_block *sb)
>> > ext4_ext_release(sb);
>> > ext4_xattr_put_super(sb);
>> >
>> > + if (sbi->s_hottrack_enable)
>> > + hot_track_exit(sb);
>> > if (!(sb->s_flags & MS_RDONLY)) {
>> > EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
>> > es->s_state = cpu_to_le16(sbi->s_mount_state);
>> HI, Zheng,
>>
>> Do you not need to free stuff related to hot tracking when umount?
>
> I call hot_track_exit() in put_super callback function. I have no idea
> that there still has some other functions that need to be called. Am I
> missing something?
You are right....
>
> Regards,
> Zheng
--
Regards,
Zhi Yong Wu
next prev parent reply other threads:[~2012-10-29 2:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:08 [RFC v4 00/15] vfs: hot data tracking zwu.kernel
2012-10-25 15:08 ` [RFC v4 01/15] vfs,hot_track: introduce private radix tree structures zwu.kernel
2012-10-25 15:08 ` [RFC v4 02/15] vfs,hot_track: initialize and free key data structures zwu.kernel
2012-10-25 15:08 ` [RFC v4 03/15] vfs,hot_track: add the function for collecting I/O frequency zwu.kernel
2012-10-28 7:55 ` Zheng Liu
2012-10-28 13:51 ` Zhi Yong Wu
2012-10-29 2:01 ` Dave Chinner
2012-10-29 2:14 ` Zhi Yong Wu
2012-10-25 15:08 ` [RFC v4 04/15] vfs,hot_track: add two map arrays zwu.kernel
2012-10-25 15:08 ` [RFC v4 05/15] vfs,hot_track: add hooks to enable hot data tracking zwu.kernel
2012-10-25 15:08 ` [RFC v4 06/15] vfs,hot_track: add the function for updating map arrays zwu.kernel
2012-10-25 15:08 ` [RFC v4 07/15] vfs,hot_track: add the aging function zwu.kernel
2012-10-25 15:09 ` [RFC v4 08/15] vfs,hot_track: add one work queue zwu.kernel
2012-10-25 15:09 ` [RFC v4 09/15] vfs,hot_track: register one memory shrinker zwu.kernel
2012-10-25 15:09 ` [RFC v4 10/15] vfs,hot_track: add one new ioctl interface zwu.kernel
2012-10-25 15:09 ` [RFC v4 11/15] vfs,hot_track: add debugfs support zwu.kernel
2012-10-25 15:09 ` [RFC v4 12/15] vfs,hot_track: turn some Micro into be tunable zwu.kernel
2012-10-25 15:09 ` [RFC v4 13/15] btrfs: add hot tracking support zwu.kernel
2012-10-25 15:09 ` [RFC v4 14/15] xfs: " zwu.kernel
2012-10-25 15:09 ` [RFC v4 15/15] vfs,hot_track: add the documentation zwu.kernel
2012-10-28 9:22 ` [PATCH] ext4: add hot tracking support Zheng Liu
2012-10-28 13:45 ` Zhi Yong Wu
2012-10-29 2:32 ` Zheng Liu
2012-10-29 2:24 ` Zhi Yong Wu [this message]
2012-11-07 8:37 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEH94LjZtT-Nh-6AqUaPCSwrbkLmz-BuO8D=9FjeE=_xqGmJzA@mail.gmail.com' \
--to=zwu.kernel@gmail.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
--cc=wuzhy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.