From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4A5FBE00832; Thu, 26 Mar 2015 14:12:39 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (max.oss.09[at]gmail.com) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.192.42 listed in list.dnswl.org] Received: from mail-qg0-f42.google.com (mail-qg0-f42.google.com [209.85.192.42]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id DFCC0E0056E for ; Thu, 26 Mar 2015 14:12:37 -0700 (PDT) Received: by qgep97 with SMTP id p97so117755045qge.1 for ; Thu, 26 Mar 2015 14:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Kvqo9zDh6ehkSP3Ti6oLV5EQggA5JsuF9l+jOGEAFc8=; b=Z8u0wlY116hZDqJof7wKaqf8DSINaqhtKT4NQrWmU7gZAMEP4roZjBwiCtCsPhF5vX DNygn9tgdaOOL/xB/pUaQ34rMMFpp4EC+T+K5vb8ncJP7Oj0g1TkTURBqVgrXUp48plr U9/gORq56Td+OhuC7iMh5cLtmIfVMq81LlbptPMUrw7I7eXn3w2u+jSDYHjJuYJ4uSx8 DfU2utw3ViKWgFvx6i/dLRo/b6xsA2RJObn8QU5cQWI7vPJcFRfu/uuGuSMHlSZloWJH W7dMXYO9Yagy2yrXg8tdLrOkrj98M7kjJoLh3ucPT4NpnzOUBZoDFmSFw6LjxVKpFxOw TBzA== MIME-Version: 1.0 X-Received: by 10.140.44.97 with SMTP id f88mr19867640qga.88.1427404356594; Thu, 26 Mar 2015 14:12:36 -0700 (PDT) Received: by 10.140.82.72 with HTTP; Thu, 26 Mar 2015 14:12:36 -0700 (PDT) In-Reply-To: References: <1427396155-12759-1-git-send-email-max.oss.09@gmail.com> Date: Thu, 26 Mar 2015 22:12:36 +0100 Message-ID: From: Max Krummenacher To: Otavio Salvador Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH v2] fsl-dynamic-packagearch: on thumb builds, add MACHINE_SOCARCH arm feed X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 21:12:39 -0000 Content-Type: text/plain; charset=ISO-8859-1 2015-03-26 20:24 GMT+01:00 Otavio Salvador : > Hello Max, >> diff --git a/classes/fsl-dynamic-packagearch.bbclass b/classes/fsl-dynamic-packagearch.bbclass >> index 40eae6c..32930d0 100644 >> --- a/classes/fsl-dynamic-packagearch.bbclass >> +++ b/classes/fsl-dynamic-packagearch.bbclass >> @@ -29,6 +29,7 @@ python __anonymous () { >> machine_arch_filter = set((d.getVar("MACHINE_ARCH_FILTER", True) or "").split()) >> machine_socarch_filter = set((d.getVar("MACHINE_SOCARCH_FILTER", True) or "").split()) >> if machine_socarch_filter or machine_arch_filter: >> + socarch = d.getVar('MACHINE_SOCARCH', True) >> provides = set((d.getVar("PROVIDES", True) or "").split()) >> depends = set((d.getVar("DEPENDS", True) or "").split()) >> PN = d.getVar("PN", True) >> @@ -37,11 +38,24 @@ python __anonymous () { >> if list(machine_arch_filter & (provides | depends)): >> package_arch = d.getVar("MACHINE_ARCH", True) >> elif list(machine_socarch_filter & (provides | depends)): >> - package_arch = d.getVar("MACHINE_SOCARCH", True) >> + package_arch = socarch >> if not package_arch: >> bb.parse.SkipPackage("You must set MACHINE_SOCARCH as MACHINE_SOCARCH_FILTER is set for this SoC.") >> >> if package_arch: >> bb.debug(1, "Use '%s' as package archictecture for '%s'" % (package_arch, PN)) >> d.setVar("PACKAGE_ARCH", package_arch) >> + >> + suffix = socarch[len(d.getVar("TUNE_PKGARCH", True)):] > > Could use 'ARM_THUMB_SUFFIX' no? > No. This cuts of the TUNE_PKGARCH part away so that we get the e.g. suffix="-mx6qdl" part. MACHINE_SOCARCH_mx6q = "${TUNE_PKGARCH}-mx6qdl" >> + # If TUNE_PKGARCH is set for thumb allow also arm for package extra archs and vice versa >> + if d.getVar("ARM_INSTRUCTION_SET", True) == "thumb": > > ARMPKGSFX_THUMB will be non-empty here, no? Yes. If this becomes true we have have MACHINE_SOCARCH pointing to a thumb feed and get the arm feed name in extrasocarch. > >> + extrasocarch = d.getVar("ARMPKGARCH", True) + \ >> + d.getVar("ARMPKGSFX_DSP", True) + d.getVar("ARMPKGSFX_EABI", True) + \ >> + d.getVar("ARMPKGSFX_ENDIAN", True) + d.getVar("ARMPKGSFX_FPU", True) + suffix >> + else: >> + extrasocarch = d.getVar("ARMPKGARCH", True) + \ >> + d.getVar("ARM_THUMB_SUFFIX", True) + \ >> + d.getVar("ARMPKGSFX_DSP", True) + d.getVar("ARMPKGSFX_EABI", True) + \ >> + d.getVar("ARMPKGSFX_ENDIAN", True) + d.getVar("ARMPKGSFX_FPU", True) + suffix >> + d.appendVar("PACKAGE_EXTRA_ARCHS", " " + socarch + " " + extrasocarch) >> } >> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc >> index bb5539c..40b6f87 100644 >> --- a/conf/machine/include/imx-base.inc >> +++ b/conf/machine/include/imx-base.inc >> @@ -46,7 +46,6 @@ MACHINE_SOCARCH_mx6sx = "${TUNE_PKGARCH}-mx6sx" >> MACHINE_SOCARCH_mx6sl = "${TUNE_PKGARCH}-mx6sl" >> MACHINE_SOCARCH_vf60 = "${TUNE_PKGARCH}-vf60" >> MACHINE_SOCARCH_vf50 = "${TUNE_PKGARCH}-vf50" >> -PACKAGE_EXTRA_ARCHS_append = " ${MACHINE_SOCARCH}" > > mxs-base.inc seems to require same change, no? > Ups, forgot about that. >> MACHINE_ARCH_FILTER = "virtual/kernel" >> MACHINE_SOCARCH_FILTER = "libfslcodec libfslvpuwrap libfslparser gst-fsl-plugins" >> -- >> 1.9.3 >> Unless you disagree I will put together a v3 which only adds mxs-base.inc. Regards Max