All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel C <nix.or.die@googlemail.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Wei Huang <wei.huang2@amd.com>
Subject: Re: k10temp: ZEN3 readings are broken
Date: Wed, 23 Dec 2020 12:22:29 +0100	[thread overview]
Message-ID: <CAEJqkghfOODze7eKO=+45eevx2KN-u275qU7j1mFYyVVDMy9uw@mail.gmail.com> (raw)
In-Reply-To: <4483r6o2-245o-147-s71r-s64ss3nqr8ps@vanv.qr>

Am Mi., 23. Dez. 2020 um 11:41 Uhr schrieb Jan Engelhardt <jengelh@inai.de>:
>
>
> On Tuesday 2020-12-22 04:58, Guenter Roeck wrote:
> >On 12/21/20 5:45 PM, Gabriel C wrote:
> >> Hello Guenter,
> >>
> >> while trying to add ZEN3 support for zenpower out of tree modules, I find out
> >> the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ).
> >
> >[...] since I do not have time to actively maintain
> >the driver, since each chip variant seems to use different addresses and scales,
> >and since the information about voltages and currents is unpublished by AMD,
> >I'll remove support for voltage/current readings from the upstream driver.
>
> I support that decision.
>
> /proc/cpuinfo::AMD Ryzen 7 3700X 8-Core Processor, fam 23 model 113 step 0
>
> A synthetic load (perl -e '1 while 1') x 16 shows:
> Adapter: PCI adapter
> Vcore:        +1.28 V
> Vsoc:         +1.02 V
> Tctl:         +94.8°C
> Tdie:         +94.8°C
> Tccd1:        +94.8°C
> Icore:       +76.00 A
> Isoc:         +6.75 A
>
> A BOINC workload on average:
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:        +1.17 V
> Vsoc:         +1.02 V
> Tctl:         +94.9°C
> Tdie:         +94.9°C
> Tccd1:        +95.0°C
> Icore:       +88.00 A
> Isoc:         +8.00 A
>
> The BOINC workload, when it momentarily spikes:
> Adapter: PCI adapter
> Vcore:        +1.32 V
> Vsoc:         +1.02 V
> Tctl:         +94.1°C
> Tdie:         +94.1°C
> Tccd1:        +96.0°C
> Icore:       +105.00 A
> Isoc:         +7.75 A
>
> For a processor sold as a 65 W part, observing reported sensors as
> 88 A x 1.17 V + 8 A x 1.02 V = 111.12 W just can't be. We are off by a
> factor of about 2.

Yes, those are wrong, bc the code is wrong.
ZEN2 desktop is mixed with ZEN2 Server/TR code.

Best Reagrds,

Gabriel C

  reply	other threads:[~2020-12-23 11:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22  1:45 k10temp: ZEN3 readings are broken Gabriel C
2020-12-22  3:58 ` Guenter Roeck
2020-12-22  4:33   ` Wei Huang
2020-12-22  5:09     ` Gabriel C
2020-12-22  6:08       ` Wei Huang
2020-12-22  4:33   ` Gabriel C
2020-12-22  6:07     ` Guenter Roeck
2020-12-22  6:16     ` Guenter Roeck
2020-12-22 15:26       ` Gabriel C
2020-12-22 15:51         ` Guenter Roeck
2020-12-23 10:41   ` Jan Engelhardt
2020-12-23 11:22     ` Gabriel C [this message]
2020-12-23 11:27     ` Gabriel C
2020-12-23 14:25     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEJqkghfOODze7eKO=+45eevx2KN-u275qU7j1mFYyVVDMy9uw@mail.gmail.com' \
    --to=nix.or.die@googlemail.com \
    --cc=jengelh@inai.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.