From mboxrd@z Thu Jan 1 00:00:00 1970 From: Code Kipper Subject: Re: [PATCH] ARM: dts: sun4i: A1000: add axp209 regulator nodes Date: Tue, 20 Dec 2016 16:56:13 +0100 Message-ID: References: <20161220102242.2423-1-codekipper@gmail.com> <20161220141613.czhs54laqpovidej@lukather> Reply-To: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20161220141613.czhs54laqpovidej@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: linux-arm-kernel , devicetree , linux-sunxi List-Id: devicetree@vger.kernel.org On 20 December 2016 at 15:16, Maxime Ripard wrote: > On Tue, Dec 20, 2016 at 11:22:42AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Marcus Cooper >> >> This patch adds the regulator nodes for the axp209 by including >> the axp209 dtsi. >> >> Signed-off-by: Marcus Cooper >> --- >> arch/arm/boot/dts/sun4i-a10-a1000.dts | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> index 68c6bdb2cf7c..e7394d701856 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-a1000.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> @@ -196,6 +196,40 @@ >> }; >> }; >> >> +#include "axp209.dtsi" >> + >> +®_dcdc2 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpu"; >> +}; >> + >> +®_dcdc3 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1250000>; >> + regulator-name = "vdd-int-dll"; >> +}; >> + >> +®_ldo1 { >> + regulator-name = "vdd-rtc"; >> +}; >> + >> +®_ldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "avcc"; >> +}; >> + >> +®_ldo3 { >> + regulator-always-on; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-name = "vcc-wifi"; > > If this is used only for the wifi, there's no point in keeping it > enabled. > > Also, taking the chance to enable cpufreq by setting the cpu-suplly > property would be a good idea. Ack....fortunately my A1000 was out of it's box as I've been looking at the channel reversal issue. I'll respin now. CK > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: codekipper@gmail.com (Code Kipper) Date: Tue, 20 Dec 2016 16:56:13 +0100 Subject: [linux-sunxi][PATCH] ARM: dts: sun4i: A1000: add axp209 regulator nodes In-Reply-To: <20161220141613.czhs54laqpovidej@lukather> References: <20161220102242.2423-1-codekipper@gmail.com> <20161220141613.czhs54laqpovidej@lukather> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20 December 2016 at 15:16, Maxime Ripard wrote: > On Tue, Dec 20, 2016 at 11:22:42AM +0100, codekipper at gmail.com wrote: >> From: Marcus Cooper >> >> This patch adds the regulator nodes for the axp209 by including >> the axp209 dtsi. >> >> Signed-off-by: Marcus Cooper >> --- >> arch/arm/boot/dts/sun4i-a10-a1000.dts | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> index 68c6bdb2cf7c..e7394d701856 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-a1000.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> @@ -196,6 +196,40 @@ >> }; >> }; >> >> +#include "axp209.dtsi" >> + >> +®_dcdc2 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpu"; >> +}; >> + >> +®_dcdc3 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1250000>; >> + regulator-name = "vdd-int-dll"; >> +}; >> + >> +®_ldo1 { >> + regulator-name = "vdd-rtc"; >> +}; >> + >> +®_ldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "avcc"; >> +}; >> + >> +®_ldo3 { >> + regulator-always-on; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-name = "vcc-wifi"; > > If this is used only for the wifi, there's no point in keeping it > enabled. > > Also, taking the chance to enable cpufreq by setting the cpu-suplly > property would be a good idea. Ack....fortunately my A1000 was out of it's box as I've been looking at the channel reversal issue. I'll respin now. CK > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com