From: Kevin Winchester <kjwinchester@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: acme@ghostprotocols.net, mingo@elte.hu, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: warning: ‘x86_get_event_constraints’ defined but not used
Date: Tue, 23 Aug 2011 10:31:50 -0300 [thread overview]
Message-ID: <CAELBVzBO7VcXG=A=hey3-GsbCPvUZtBfPSFdjidzTqEmMg__iA@mail.gmail.com> (raw)
In-Reply-To: <1314105839.8002.51.camel@twins>
On 23 August 2011 10:23, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Mon, 2011-08-15 at 20:40 -0300, Kevin Winchester wrote:
>> Is there are reason why those C
>> files are included directly in another C file rather than being linked
>> together?
>
> Sheer suckyness on my part.. we needed a 'quick' fix to make these
> CPU_SUP_* things build at all and never got around to cleaning it up
> afterwards.
>
>> Or is there some other way the code could be improved and
>> also remove the warning at the same time?
>
> creation of a arch/x86/kernel/cpu/perf_event.h and enough code massage
> to make all these .c files compile independently would be appreciated,
> not sure that'll immediately solve your issue though.
>
>> I do not mind doing some coding here to make this happen. I am very
>> close to a warning-free build, so I would definitely like to take care
>> of this one.
>
> You could slip something like it into the 'cleanup' if nothing else
> presents itself :-)
>
Sure, I'll give the above suggestion a try and see if I can ensure
that the function is not compiled unless it is needed.
Kevin
next prev parent reply other threads:[~2011-08-23 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 23:40 warning: ‘x86_get_event_constraints’ defined but not used Kevin Winchester
2011-08-23 13:23 ` Peter Zijlstra
2011-08-23 13:31 ` Kevin Winchester [this message]
2011-08-30 11:21 ` [RFC PATCH] x86: perf: Clean up perf_event cpu code Kevin Winchester
2011-08-30 11:35 ` Peter Zijlstra
2011-08-30 23:41 ` [PATCH] " Kevin Winchester
2011-09-02 13:32 ` Peter Zijlstra
2011-09-19 10:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELBVzBO7VcXG=A=hey3-GsbCPvUZtBfPSFdjidzTqEmMg__iA@mail.gmail.com' \
--to=kjwinchester@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.