From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756772Ab1HEVfk (ORCPT ); Fri, 5 Aug 2011 17:35:40 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:56915 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756701Ab1HEVfi convert rfc822-to-8bit (ORCPT ); Fri, 5 Aug 2011 17:35:38 -0400 MIME-Version: 1.0 In-Reply-To: References: <1312515303-17169-1-git-send-email-tgih.jun@samsung.com> Date: Fri, 5 Aug 2011 22:35:36 +0100 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: Fix DDR mode support. From: Jae hoon Chung To: Will Newton Cc: Seungwon Jeon , linux-mmc@vger.kernel.org, cjb@laptop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Seungwon This patch is looks fine to me.. Just ask to you...Don't you want to locate MMC_CAP_MMC_HIGHSPEED in platdata? Regards, Jaehoon Chung 2011/8/5 Will Newton : > On Fri, Aug 5, 2011 at 4:35 AM, Seungwon Jeon wrote: >> Host driver can't get a hint of DDR mode through ios->ddr flag anymore. >> ios->timing is currently used to inform DDR mode as a substitute. >> And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support. >> >> Signed-off-by: Seungwon Jeon >> --- >>  drivers/mmc/host/dw_mmc.c |    4 ++-- >>  1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index d65511e..b412a1d 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -699,7 +699,7 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) >>        } >> >>        /* DDR mode set */ >> -       if (ios->ddr) { >> +       if (ios->timing == MMC_TIMING_UHS_DDR50) { >>                regs = mci_readl(slot->host, UHS_REG); >>                regs |= (0x1 << slot->id) << 16; >>                mci_writel(slot->host, UHS_REG, regs); >> @@ -1646,7 +1646,7 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id) >>                        mmc->caps |= MMC_CAP_4_BIT_DATA; >> >>        if (host->pdata->quirks & DW_MCI_QUIRK_HIGHSPEED) >> -               mmc->caps |= MMC_CAP_SD_HIGHSPEED; >> +               mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; >> >>  #ifdef CONFIG_MMC_DW_IDMAC >>        mmc->max_segs = host->ring_size; >> -- >> 1.7.0.4 > > Acked-by: Will Newton > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html >