From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sathyanarayanan Kuppuswamy Natarajan Subject: Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq Date: Sat, 3 Jun 2017 10:28:32 -0700 Message-ID: References: <20170531070225.bymdhhpclidwwtpt@dell> <3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-yw0-f193.google.com ([209.85.161.193]:34384 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdFCR2e (ORCPT ); Sat, 3 Jun 2017 13:28:34 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Andy Shevchenko Cc: Kuppuswamy Sathyanarayanan , Alexandre Courbot , "Krogerus, Heikki" , Greg Kroah-Hartman , Linus Walleij , "edubezval@gmail.com" , "dvhart@infradead.org" , "Zhang, Rui" , Lee Jones , Andy Shevchenko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , USB , "linux-kernel@vger.kernel.org" , Platform Driver Hi, On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko wrote: > On Thu, Jun 1, 2017 at 1:37 AM, > wrote: >> From: Kuppuswamy Sathyanarayanan >> >> PMIC mfd driver only exports first level irq for thermal device. >> But currently we are reading the irqs from the second level irq >> chip, So this patch fixes this issue by adding support to use >> first level PMIC thermal irq. >> > > Shouldn't be this squashed to patch 2? There is no compilation dependency between patch 2 and 3. But they are functionally dependent. Should we squash functionally dependent patches too ? > >> Signed-off-by: Kuppuswamy Sathyanarayanan >> Acked-by: Zhang Rui >> --- >> drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Changes since v1: >> * None >> >> Changes since v2: >> * Rebased on top of latest release. >> >> Changes since v3: >> * Rebased on top of latest release. >> >> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c >> index 0f19a39..ef6b322 100644 >> --- a/drivers/thermal/intel_bxt_pmic_thermal.c >> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c >> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) >> } >> >> regmap = pmic->regmap; >> - regmap_irq_chip = pmic->irq_chip_data_level2; >> + regmap_irq_chip = pmic->irq_chip_data; >> >> pmic_irq_count = 0; >> while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) { >> -- >> 2.7.4 >> > > > > -- > With Best Regards, > Andy Shevchenko -- Sathya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751217AbdFCR2g (ORCPT ); Sat, 3 Jun 2017 13:28:36 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34384 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdFCR2e (ORCPT ); Sat, 3 Jun 2017 13:28:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170531070225.bymdhhpclidwwtpt@dell> <3e58ab749a67cce5c956ef13db8563fb0a8bc190.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy Natarajan Date: Sat, 3 Jun 2017 10:28:32 -0700 Message-ID: Subject: Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq To: Andy Shevchenko Cc: Kuppuswamy Sathyanarayanan , Alexandre Courbot , "Krogerus, Heikki" , Greg Kroah-Hartman , Linus Walleij , "edubezval@gmail.com" , "dvhart@infradead.org" , "Zhang, Rui" , Lee Jones , Andy Shevchenko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , USB , "linux-kernel@vger.kernel.org" , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko wrote: > On Thu, Jun 1, 2017 at 1:37 AM, > wrote: >> From: Kuppuswamy Sathyanarayanan >> >> PMIC mfd driver only exports first level irq for thermal device. >> But currently we are reading the irqs from the second level irq >> chip, So this patch fixes this issue by adding support to use >> first level PMIC thermal irq. >> > > Shouldn't be this squashed to patch 2? There is no compilation dependency between patch 2 and 3. But they are functionally dependent. Should we squash functionally dependent patches too ? > >> Signed-off-by: Kuppuswamy Sathyanarayanan >> Acked-by: Zhang Rui >> --- >> drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Changes since v1: >> * None >> >> Changes since v2: >> * Rebased on top of latest release. >> >> Changes since v3: >> * Rebased on top of latest release. >> >> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c >> index 0f19a39..ef6b322 100644 >> --- a/drivers/thermal/intel_bxt_pmic_thermal.c >> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c >> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev) >> } >> >> regmap = pmic->regmap; >> - regmap_irq_chip = pmic->irq_chip_data_level2; >> + regmap_irq_chip = pmic->irq_chip_data; >> >> pmic_irq_count = 0; >> while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) { >> -- >> 2.7.4 >> > > > > -- > With Best Regards, > Andy Shevchenko -- Sathya