On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
> Add libxl functions to set/get domain's parameters for rtds scheduler
> Note: VCPU's information (period, budget) is in microsecond (us).
>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>
Mostly looks good.
The main thing which is missing is a #define LIBXL_HAVE_XXX in libxl to
advertise this new feature (there are a bunch of existing examples which
you can copy).
> + if (scinfo->period != LIBXL_DOMAIN_SCHED_PARAM_PERIOD_DEFAULT) {
> + if (scinfo->period < 1) {
> + LOG(ERROR, "VCPU period is not set or out of range, "
> + "valid values are larger than 1");
There's no upper limit? Likewise for the budget further down?