From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFfJr-0005jp-U4 for qemu-devel@nongnu.org; Tue, 18 Feb 2014 02:42:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFfJq-0006qg-NZ for qemu-devel@nongnu.org; Tue, 18 Feb 2014 02:42:19 -0500 Received: from mail-ve0-x236.google.com ([2607:f8b0:400c:c01::236]:49797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFfJq-0006qZ-HO for qemu-devel@nongnu.org; Tue, 18 Feb 2014 02:42:18 -0500 Received: by mail-ve0-f182.google.com with SMTP id jy13so13460223veb.27 for ; Mon, 17 Feb 2014 23:42:18 -0800 (PST) MIME-Version: 1.0 Sender: kgrace.liu@gmail.com In-Reply-To: <53024E69.1080505@redhat.com> References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-14-git-send-email-cyliu@suse.com> <53024E69.1080505@redhat.com> Date: Tue, 18 Feb 2014 15:42:17 +0800 Message-ID: From: Chunyan Liu Content-Type: multipart/alternative; boundary=089e0160ca9e5c50bb04f2a9691c Subject: Re: [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Dong Xu Wang , qemu-devel@nongnu.org, stefanha@redhat.com --089e0160ca9e5c50bb04f2a9691c Content-Type: text/plain; charset=UTF-8 2014-02-18 2:01 GMT+08:00 Eric Blake : > On 02/11/2014 11:33 PM, Chunyan Liu wrote: > > qed.c: replace QEMUOptionParameter with QemuOpts > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > block/qed.c | 89 > +++++++++++++++++++++++++++++------------------------------ > > block/qed.h | 3 +- > > 2 files changed, 45 insertions(+), 47 deletions(-) > > > > > + cluster_size = qemu_opt_get_size_del(opts, > > + BLOCK_OPT_CLUSTER_SIZE, > > + QED_DEFAULT_CLUSTER_SIZE); > > + table_size = qemu_opt_get_size_del(opts, BLOCK_OPT_TABLE_SIZE, > > + QED_DEFAULT_TABLE_SIZE); > > > > > + { > > + .name = BLOCK_OPT_CLUSTER_SIZE, > > + .type = QEMU_OPT_SIZE, > > + .help = "Cluster size (in bytes)", > > + .def_value_str = stringify(QED_DEFAULT_CLUSTER_SIZE) > > + }, > > + { > > + .name = BLOCK_OPT_TABLE_SIZE, > > + .type = QEMU_OPT_SIZE, > > + .help = "L1/L2 table size (in clusters)" > > + }, > > Why does cluster size list a default, but table size does not? > Changed it from create_options, no default for table size in original create_options. > > > +++ b/block/qed.h > > @@ -43,7 +43,7 @@ > > * > > * All fields are little-endian on disk. > > */ > > - > > +#define QED_DEFAULT_CLUSTER_SIZE 65536 > > enum { > > QED_MAGIC = 'Q' | 'E' << 8 | 'D' << 16 | '\0' << 24, > > > > @@ -69,7 +69,6 @@ enum { > > */ > > QED_MIN_CLUSTER_SIZE = 4 * 1024, /* in bytes */ > > QED_MAX_CLUSTER_SIZE = 64 * 1024 * 1024, > > - QED_DEFAULT_CLUSTER_SIZE = 64 * 1024, > > > Why this change? I actually prefer enums over #defines, because they > behave nicer in gdb. > > For stringify() correctness. .def_value_str = stringify(QED_DEFAULT_CLUSTER_SIZE) > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > --089e0160ca9e5c50bb04f2a9691c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



2014-02-18 2:01 GMT+08:00 Eric Blake <eblake@redhat.com>:
On 02/11/= 2014 11:33 PM, Chunyan Liu wrote:
> qed.c: replace QEMUOptionParameter with QemuOpts
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu= @suse.com>
> ---
> =C2=A0block/qed.c | =C2=A0 89 +++++++++++++++++++++++++++++-----------= -------------------
> =C2=A0block/qed.h | =C2=A0 =C2=A03 +-
> =C2=A02 files changed, 45 insertions(+), 47 deletions(-)
>

> + =C2=A0 =C2=A0cluster_size =3D qemu_opt_get_siz= e_del(opts,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 B= LOCK_OPT_CLUSTER_SIZE,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Q= ED_DEFAULT_CLUSTER_SIZE);
> + =C2=A0 =C2=A0table_size =3D qemu_opt_get_size_del(opts, BLOCK_OPT_TA= BLE_SIZE,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 QED_DEFA= ULT_TABLE_SIZE);
>

> + =C2=A0 =C2=A0 =C2=A0 =C2=A0{
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.name =3D BLOCK_OPT_CLUSTER= _SIZE,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.type =3D QEMU_OPT_SIZE, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.help =3D "Cluster siz= e (in bytes)",
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.def_value_str =3D stringif= y(QED_DEFAULT_CLUSTER_SIZE)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0},
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0{
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.name =3D BLOCK_OPT_TABLE_S= IZE,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.type =3D QEMU_OPT_SIZE, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.help =3D "L1/L2 table= size (in clusters)"
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0},

Why does cluster size list a default, but table size does not?

Changed it from create_options, no default for table siz= e in original
create_options.
=C2=A0

> +++ b/block/qed.h
> @@ -43,7 +43,7 @@
> =C2=A0 *
> =C2=A0 * All fields are little-endian on disk.
> =C2=A0 */
> -
> +#define =C2=A0QED_DEFAULT_CLUSTER_SIZE =C2=A065536
> =C2=A0enum {
> =C2=A0 =C2=A0 =C2=A0QED_MAGIC =3D 'Q' | 'E' << 8= | 'D' << 16 | '\0' << 24,
>
> @@ -69,7 +69,6 @@ enum {
> =C2=A0 =C2=A0 =C2=A0 */
> =C2=A0 =C2=A0 =C2=A0QED_MIN_CLUSTER_SIZE =3D 4 * 1024, /* in bytes */<= br> > =C2=A0 =C2=A0 =C2=A0QED_MAX_CLUSTER_SIZE =3D 64 * 1024 * 1024,
> - =C2=A0 =C2=A0QED_DEFAULT_CLUSTER_SIZE =3D 64 * 1024,


Why this change? =C2=A0I actually prefer enums over #defines, because= they
behave nicer in gdb.

=C2=A0For stringify() correctness.
.def_value_str =3D stringify(QED_D= EFAULT_CLUSTER_SIZE)
--
Eric Blake =C2=A0 eblake redhat com =C2=A0 =C2=A0+1-919-301-3266
Libvirt virtualization library http://libvirt.org


--089e0160ca9e5c50bb04f2a9691c--