From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C69EC433DB for ; Thu, 11 Mar 2021 03:07:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94B6264DAD for ; Thu, 11 Mar 2021 03:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94B6264DAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKBfq-00037m-KX for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 22:07:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKBdb-0001Nm-Pv; Wed, 10 Mar 2021 22:05:23 -0500 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]:32858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKBdW-0004jF-Aq; Wed, 10 Mar 2021 22:05:23 -0500 Received: by mail-yb1-xb32.google.com with SMTP id x19so20225767ybe.0; Wed, 10 Mar 2021 19:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=84BJANA8aiN31htTlgNI/whq07EWbozc5fHZDXSzGIE=; b=HUTvvuh3qyWwv5Cne4CM/iXj9+qcDXwBuV/qI5VelPYyVA3fyRsIpQekdRKGnAs/K5 +MRkAfgN8RD8YujIdDOXAAh0qL7Py5T7RrmqPksQPAIza6SQsydr6FMIMbP8NPS8rAZg 9bglFbNpHQZcfVvjnMclSXLrsJquiqeg/ZRxEONOJswgKs+AEKOm2YLwhJbOTzhX4vcC OPWudb/y0+A7QAXocMc5k275KDPfYI2LMtYrnKlZoKMoVYrb7btpSdblHxg2ekTIjB6h H7EAJywBRFVS7lB21ls9eoes+wSCDyLe8rscQKETIgA/BElvK5YcGp9X/GzUwORLRjHS 2JlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=84BJANA8aiN31htTlgNI/whq07EWbozc5fHZDXSzGIE=; b=pC1DbsiBRvtyuWNH7TeamwVxM7YV2Do2FcrbIPF4In3zhBAer6zqfZmV1YpTkOQ8Pq HxV8giTjfGWHJMSCUan/bS4sUe7UvLANehS0hskaYFAopkO1c6iFz+IF5xmV1Kq1MmhL zTP0cmRbFqu+AAyis9AkNKN7lOKoXz/FWim07JrHw9WP23i2hs2XkMsLLlh3nE2DELha Jl5QxWgjZQ/jHfWqIcfjFhN6iRT5ZscDlk7SOFyNyNdqX+/IdXU6tT0MbqTmfb2lchjN SSacUP/THzdlM5P7I7AkDEB1oJhWuwmydI+M5H67bFEY/fSipvxzdKtdt1v5ClLqI4G1 kOeA== X-Gm-Message-State: AOAM532uveTbXI/vAujr60lOq38YryHhUHNeM0WlLl1QwnqwQJ+M4Ts+ 98M3zGdGGxSZNPVJOGxzBj84xFaAKyqIxGEH5kc= X-Google-Smtp-Source: ABdhPJzfL2kzUP+TLl+Wx3rFxsjt0DpUhFS02vxvsflOzngGhofcuzMYHiS1egaTVrNbli1HmWU0RBsI1pce2/CXNTo= X-Received: by 2002:a25:d08d:: with SMTP id h135mr8814775ybg.122.1615431916932; Wed, 10 Mar 2021 19:05:16 -0800 (PST) MIME-Version: 1.0 References: <20210310170528.1184868-1-philmd@redhat.com> <20210310170528.1184868-8-philmd@redhat.com> In-Reply-To: <20210310170528.1184868-8-philmd@redhat.com> From: Bin Meng Date: Thu, 11 Mar 2021 11:05:05 +0800 Message-ID: Subject: Re: [PATCH v2 07/12] hw/block/pflash_cfi02: Factor out pflash_reset_state_machine() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stephen Checkoway , Qemu-block , "qemu-devel@nongnu.org Developers" , Max Reitz , David Edmondson , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Mar 11, 2021 at 1:36 AM Philippe Mathieu-Daud=C3=A9 wrote: > > There is multiple places resetting the internal state machine. > Factor the code out in a new pflash_reset_state_machine() method. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/block/pflash_cfi02.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng