From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: xhci-mem: Fix scratchpad array issue
Date: Tue, 8 Jan 2019 14:34:17 +0800 [thread overview]
Message-ID: <CAEUhbmU2jqK_rZ745Gk67GoUe+YOLOAKnNxS_wrwZ0HwWJbhmQ@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB441469B2DCDE0C4BC677411DE48A0@VI1PR04MB4414.eurprd04.prod.outlook.com>
On Tue, Jan 8, 2019 at 12:00 PM Ye Li <ye.li@nxp.com> wrote:
>
> On 1/7/2019 5:54 PM, Bin Meng wrote:
> > On Mon, Jan 7, 2019 at 10:45 AM Ye Li <ye.li@nxp.com> wrote:
> >>
> >> After updating the value of dev_context_ptrs[0], we should flush this
> >> from cache to memory. Otherwise the xhci controller won't use it.
> >>
> >> Signed-off-by: Ye Li <ye.li@nxp.com>
> >> Reviewed-by: Marek Vasut <marex@denx.de>
> >> ---
> >> Changes for v2:
> >> - Change to use sizeof(ctrl->dcbaa->dev_context_ptrs[0])
> >>
> >> drivers/usb/host/xhci-mem.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > But you need do the same in xhci_scratchpad_free() too. Please fix it in v3.
> >
> The xhci controller has been stopped before calling xhci_scratchpad_free, is it necessary to
> add flush in this function? And I don't see other buffers are flushed when freeing.
>
Ah, yes. It's called after HCD reset, so that's not needed.
Regards,
Bin
next prev parent reply other threads:[~2019-01-08 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 2:45 [U-Boot] [PATCH v2] usb: xhci-mem: Fix scratchpad array issue Ye Li
2019-01-07 6:22 ` Marek Vasut
2019-01-07 9:54 ` Bin Meng
2019-01-08 4:00 ` Ye Li
2019-01-08 6:34 ` Bin Meng [this message]
2019-01-08 11:11 ` Marek Vasut
2019-01-09 7:05 ` Bin Meng
2019-01-09 15:04 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmU2jqK_rZ745Gk67GoUe+YOLOAKnNxS_wrwZ0HwWJbhmQ@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.