From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Fri, 8 Jan 2016 08:02:36 +0800
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the
	kernel
In-Reply-To: <CAOMZO5ArEGTkp5iDEX_wvLpeXb=bpE1UZ7OhkpqYnweR6NwAOA@mail.gmail.com>
References: <1452113598-32409-1-git-send-email-festevam@gmail.com>
 <CAEUhbmWijmsSLrzBXRxrCZPKrZcDn6Bw5U6gYW=-xctLqg9-aQ@mail.gmail.com>
 <CAOMZO5AWvC3hAOqiyX-b0m5zmTA9R1ErOti4=v+ddF_+ndxDLg@mail.gmail.com>
 <CAEUhbmX_xYmVZWcJHFhd2tLTRELo8nEpUWpwLmva6xXfEMZjcQ@mail.gmail.com>
 <CAOMZO5ChruMj=abNAUs3Jm2Mge3xZTfTmEXWOh6QBKS3p1wJFQ@mail.gmail.com>
 <20160107162830.GC3359@bill-the-cat>
 <CAOMZO5ArEGTkp5iDEX_wvLpeXb=bpE1UZ7OhkpqYnweR6NwAOA@mail.gmail.com>
Message-ID: <CAEUhbmU6MTDE=As4UBDNi--CM4UPTU9kARLztP+WMq+Cs8GgBQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Fabio,

On Fri, Jan 8, 2016 at 12:49 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jan 7, 2016 at 2:28 PM, Tom Rini <trini@konsulko.com> wrote:
>> On Thu, Jan 07, 2016 at 11:31:06AM -0200, Fabio Estevam wrote:
>>> On Thu, Jan 7, 2016 at 10:58 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>
>>> > Ah, yes! Sorry I wanted to say the original proposal to "return 0"
>>> > instead. But now I failed to understand why this fixed the issue
>>> > because those error numbers are not zero.
>>>
>>> The problem only happens if we return a negative value.
>>>
>>> > And why returning zero is bad? From a working PCIe controller (either
>>>
>>> It is not bad, but I still prefer to keep in sync with the kernel driver.
>>
>> And would allow further features later on?
>
> That's correct, Tom.

What new feature would benefit from this? These two PCIe drivers are
non-DM drivers and DM PCI is not utilizing those error codes, instead
DM PCI is using U-Boot standard error codes.

Regards,
Bin