From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Tue, 30 Jun 2020 14:42:52 +0800 Subject: [PATCH v1 18/43] x86: pinctrl: Update comment for intel_pinctrl_get_pad() In-Reply-To: <20200614215726.v1.18.Id23a87cbfe05f86560b788a8e180e9109c35b20d@changeid> References: <20200615035738.248710-1-sjg@chromium.org> <20200614215726.v1.18.Id23a87cbfe05f86560b788a8e180e9109c35b20d@changeid> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > Add information about what is returned on error. > > Signed-off-by: Simon Glass > --- > > arch/x86/include/asm/intel_pinctrl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/intel_pinctrl.h b/arch/x86/include/asm/intel_pinctrl.h > index f39ebde539..982b2514a0 100644 > --- a/arch/x86/include/asm/intel_pinctrl.h > +++ b/arch/x86/include/asm/intel_pinctrl.h > @@ -300,6 +300,7 @@ u32 intel_pinctrl_get_config_reg(struct udevice *dev, uint offset); > * @pad: Pad to check > * @devp: Returns pinctrl device containing that pad > * @offsetp: Returns offset of pad within that pinctrl device > + * @return 0 if OK, -ENOTBLK if pad number is invalid It's weird that ENOTBLK is used for a pinctrl. > */ > int intel_pinctrl_get_pad(uint pad, struct udevice **devp, uint *offsetp); > > -- Regards, Bin