From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DD1C4338F for ; Mon, 2 Aug 2021 02:50:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 973E160F35 for ; Mon, 2 Aug 2021 02:50:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 973E160F35 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EEB8683330; Mon, 2 Aug 2021 04:50:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UBtE+QVE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2DA658332A; Mon, 2 Aug 2021 04:50:29 +0200 (CEST) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6E7D58332A for ; Mon, 2 Aug 2021 04:50:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb2a.google.com with SMTP id e4so12648484ybn.2 for ; Sun, 01 Aug 2021 19:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yfncb23TvY57vHgdyIsxWANHV1JcVGanIwGtbKHXBFc=; b=UBtE+QVE1wBLSvaAZHfWhe47hConKyNx4mGGvNNtmG/fuymw8xQv0nR144DHWAThx7 YfpKejBAJXYdKXgVfZ/J5FbSf0TG9L8nYej+UB/IviaRHcnpmG82nHTJW7INSL1txNE1 qGPNCoQ0G0Owo/fm2LXsg0FgVWKjUXT8ZsioBSxj77p0Hktkn9XXCCDehZKxVVAfkGri BQXm5aJ0eESHzY+f/Sl8i9wN/bcbqgGg5KQ3FwstNCLl4vd0rvkN8xlYkiGOBDu+URRr 2SaMmNCIuKd/BdC9rS0ypBrfcz8d/OGpch2CfT2tMTvx+k4Iwss/vDH4HbwCN/PZXNhc rgDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yfncb23TvY57vHgdyIsxWANHV1JcVGanIwGtbKHXBFc=; b=ChLK1TNItlpU2UP/kO9ckMh3R2mo/FqHPuJxYuP10xjlZyquCGxKaHJu2eXPO6ARhZ x2rQk12a1uD0qR9j5YHDYzPiew1/V0FxM6k88pk7mJevIXMAn6hakPhhtG8r79hPxmFf WcvGj39Ifc4V6KmnkC8ponAzrdUTbG7FSTzGgcIXHxTqmKbjRGjiC9dLMByGKKWq4c+Y STrLZVAuVEHIhk5acbv0mTAXWpR2aynGhNUZoqNxSHwQ7IhFM8dEknMU6nlUMrRoRBqj TvRDNeGE40pLu2Jxk1a308UUIfvgiDwVTFB2oGwz41ntfjP3vB7lIeHs6YfIBlkoBPwb YoXg== X-Gm-Message-State: AOAM531xM7QtbH1JMclNJ2dY71wsgtky2Is6SInnjFrDQuOzpvRUKx26 wBKe2RRfzNTAMbSOlKwqyW59StkWpHeSH6ffhWI= X-Google-Smtp-Source: ABdhPJzUb8IxJSsp9h8pyrFfx85ddQvmDhOLR5RRgNQpSIQIrhWVMFPZJhZufo/v1vPQsYoPyFT/CGlLFrJ+NFX3yZo= X-Received: by 2002:a5b:304:: with SMTP id j4mr17701944ybp.314.1627872625234; Sun, 01 Aug 2021 19:50:25 -0700 (PDT) MIME-Version: 1.0 References: <20210731084529.7524-1-bmeng.cn@gmail.com> <20210731084529.7524-3-bmeng.cn@gmail.com> In-Reply-To: From: Bin Meng Date: Mon, 2 Aug 2021 10:50:13 +0800 Message-ID: Subject: Re: [PATCH 2/7] x86: mtrr: Do not clear the unused ones in mtrr_commit() To: Simon Glass Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > Current mtrr_commit() logic assumes that MTRR MSRs are programmed > > consecutively from index 0 to its maximum number, and whenever it > > detects an unused one, it clears all other MTRRs starting from that > > one. However this may not always be the case. > > > > In fact, the clear is not much helpful because these MTRRs come out > > of reset as disabled already. Drop the clear codes. > > > > Signed-off-by: Bin Meng > > --- > > > > arch/x86/cpu/mtrr.c | 4 ---- > > 1 file changed, 4 deletions(-) > > Reviewed-by: Simon Glass > Tested on chromebook_coral, chromebook_samus, chromebook_link, minnowmax > Tested-by: Simon Glass applied to u-boot-x86, thanks!