From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Tue, 2 Feb 2016 10:25:44 +0800 Subject: [U-Boot] [PATCH 00/23] x86: Convert to use DM PCI APIs completely In-Reply-To: References: <1454319658-17431-1-git-send-email-bmeng.cn@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Tue, Feb 2, 2016 at 12:19 AM, Simon Glass wrote: > Hi Bin, > > On 1 February 2016 at 02:40, Bin Meng wrote: >> There are still some codes that use the legacy PCI APIs to access >> the configuration space registers. This series converts those codes >> to completely use DM PCI APIs. >> >> This includes adding several new ops to the PCH uclass driver, and >> some clean up to the SPI/GPIO/IRQ drivers. >> >> Tested on QEMU and Crown Bay. This series is available in pci-working >> branch of u-boot-x86 repo. > > Looks great! This is a big step forward. > > I've tested it on minnowmax and will test on link in the next day or so. > > Here are a few things that I think can still be cleaned up: > - void pci_assign_irqs(int bus, int device, u8 irq[4]) should use a > struct udevice I guess no, unless we expand struct udevice to include interrupt routing information? But that's not generic across architectures. I am not sure how. > - pci_x86_read/write_config() move into drivers/pci/pci_x86.c (needs > ivybridge fix which I'll look at) Yep. I wanted to do this when reviewing one of previous patches. > - disable DM_PCI_COMPAT for x86 Looks e1000 and pch_gbe (Crown Bay) ethernet drivers are still using legacy PCI APIs. e1000 might need quite amount of work as it is being widely used on lots of boards. I can update pch_gbe driver later. > - use the PCI mmio access method instead of I/O once it becomes possible Yep. > - moving vesa video to driver model (UCLASS_VIDEO) I was not following the dm video changes recently, but I guess yes. Regards, Bin