From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F019CC48BE6 for ; Mon, 14 Jun 2021 03:48:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2E6561042 for ; Mon, 14 Jun 2021 03:48:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2E6561042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0CD0F80C58; Mon, 14 Jun 2021 05:47:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gUv/Fz6d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 120CB80EC7; Mon, 14 Jun 2021 05:47:57 +0200 (CEST) Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A91880412 for ; Mon, 14 Jun 2021 05:47:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb30.google.com with SMTP id q21so13463122ybg.8 for ; Sun, 13 Jun 2021 20:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=xxhRU964tycZYI2BjWj2KtvWDYZ5Yvx1tNCwritwhbM=; b=gUv/Fz6drnbO/b/fMC932VfPwVwEKdzQ7rsQmDqtpq7RAvFHw4xdNUD6p/CSgeMn7L DuCeO6vn/Lp00yxeowN73Yf6XLakuXeArYZGVZLpGjImvjOSJa4VbwWSRThn+l4wFnCp qCnurZv1Y9iiRo6c/NZhAORDQ2qmW4eWjSHp2J4KY+993tR+UNJ3VwvjyxhPBbO00c5Q bAznCDdDsRWaJhq80iwAbEmVjuHQOs0vf+KPfmgFhZtPhCaDiDgCkyY2Q+gdAFiQEtEV 039RsxMsVsNyVxUZzghWZU/ap59KG4gyV8biRCWZ6hiLDzjUKFPd8FtiO7YEwq5jHdj5 5pxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xxhRU964tycZYI2BjWj2KtvWDYZ5Yvx1tNCwritwhbM=; b=bmdJZ2g0EOikjr/bbmpxu4zaIERPNb3RmOuaoKqhWHkElSf26ypLxV862hdytY0x4T CepHYn6QuB4g3t8atdbgaHvqTQnLKKc7nqu8ZaProOLY0kuuqckVXKQtuxg3nJqg8sCL bXbvppvcS28RCiL9/yrivZkHG79XYGVog3kDtgfyHRiNjomRHWKkl5Xy0vblCvWSObXd 3RLBGyS28DAFdZLtl71T532053PKgrIbudQiXNW1C2mivkrqkkpfMaETyfzckSTLTpju QUVvwurTMPSMLHZ2waD0q6kgSWbrMFZV0qb+rBZjHY1b3bZXy8zXIeJ+Wp36OwUHqg9I 9n+A== X-Gm-Message-State: AOAM530zGp0/e4xBBD/xfCVrRL6zwCGrypDdPRWuTBQcQUEXVvU2Gsb5 NyJIYJULdaM0h1F6NBNX0DSJc0HiArev7oJDZAU= X-Google-Smtp-Source: ABdhPJz3VspiZ1/gkOdqfZtOvtoNQb9hLHleeieUWQisxtXH3tmyYWAV04Fzho5w8Uf/W1W/RCx7A4bLeZFPu4UdVG0= X-Received: by 2002:a25:be09:: with SMTP id h9mr22835354ybk.239.1623642472993; Sun, 13 Jun 2021 20:47:52 -0700 (PDT) MIME-Version: 1.0 References: <20210609075602.157709-1-bmeng.cn@gmail.com> In-Reply-To: <20210609075602.157709-1-bmeng.cn@gmail.com> From: Bin Meng Date: Mon, 14 Jun 2021 11:47:41 +0800 Message-ID: Subject: Re: [RFT PATCH] riscv: andes_plic: Fix riscv_get_ipi() mask To: Rick Chen , Leo Liang , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Jun 9, 2021 at 3:55 PM Bin Meng wrote: > > Current logic in riscv_get_ipi() for Andes PLICSW does not look good > to me. The mask to test IPI pending bits for a hart should be left > shifted by (8 * gd->arch.boot_hart), just the same as what is done in > riscv_send_ipi(). > > Signed-off-by: Bin Meng > > --- > It looks there is no datasheet released from Andes that describes how > PLICSW works, and its register fields. I can only get an understanding > from current U-Boot and OpenSBI PLICSW driver. > > This requires testing on Andes hardware, which I don't have access to. > > arch/riscv/lib/andes_plic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Ping?