All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 00/22] x86: kconfig clean up
@ 2017-07-30 13:23 Bin Meng
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER Bin Meng
                   ` (21 more replies)
  0 siblings, 22 replies; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

This series cleans up x86 Kconfig files a lot.

The rules are:

- Select all x86 must have Kconfig options from
  X86 in arch/Kconfig
- Imply all DM uclass drivers from X86 in arch/Kconfig
- Select platform-dependent initialization hooks from
  arch/x86/cpu/<platform>/Kconfig
- Imply platform-specific drivers from
  arch/x86/cpu/<platform>/Kconfig
- Select board-specific initialization hooks from
  board/vendor/board/Kconfig
- Select specific SPI flash from board/vendor/board/Kconfig

This series is available at u-boot-x86/kconfig-working for testing.
Buildman testing has passed.

Changes in v2:
- sync defconfigs
- imply ENV_IS_IN_SPI_FLASH for ivybridge
- imply ENV_IS_IN_SPI_FLASH for broadwell
- imply more common drivers for coreboot
- imply ENV_IS_IN_SPI_FLASH for queensbay
- imply ENV_IS_IN_SPI_FLASH for quark
- imply ENV_IS_NOWHERE for qemu
- rebase on top of u-boot/master

Bin Meng (22):
  x86: kconfig: Select TIMER and X86_TSC_TIMER
  x86: kconfig: Select USE_PRIVATE_LIBGCC
  x86: kconfig: Select PCI and DM_PCI
  x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig
  x86: kconfig: Let board select BOARD_EARLY_INIT_F
  x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig
  x86: kconfig: Select ARCH_EARLY_INIT_R in the platform Kconfig
  x86: kconfig: Imply ENABLE_MRC_CACHE in the platform Kconfig
  x86: kconfig: Select OF_CONTROL
  x86: kconfig: Imply DM uclass drivers
  x86: baytrail: kconfig: Imply platform specific drivers
  x86: ivybridge: kconfig: Imply platform specific drivers
  x86: broadwell: kconfig: Imply platform specific drivers
  x86: coreboot: kconfig: Imply drivers that are useful
  x86: queensbay: kconfig: Imply platform specific drivers
  x86: tangier: kconfig: Imply platform specific drivers
  x86: quark: kconfig: Imply platform specific drivers
  x86: qemu: kconfig: Imply platform specific drivers
  x86: qemu: Remove SPI flash from defconfigs
  x86: kconfig: Let board select SPI flash
  x86: kconfig: Move USB to platform Kconfig
  x86: Convert INTEL_ICH6_GPIO to Kconfig

 arch/Kconfig                                       | 22 ++++++++++++------
 arch/x86/cpu/baytrail/Kconfig                      | 16 +++++++++++++
 arch/x86/cpu/broadwell/Kconfig                     | 11 +++++++++
 arch/x86/cpu/broadwell/refcode.c                   | 17 +++++++++++++-
 arch/x86/cpu/coreboot/Kconfig                      | 13 +++++++++++
 arch/x86/cpu/coreboot/coreboot.c                   | 10 ---------
 arch/x86/cpu/efi/efi.c                             | 10 ---------
 arch/x86/cpu/ivybridge/Kconfig                     | 10 +++++++++
 arch/x86/cpu/qemu/Kconfig                          |  7 ++++++
 arch/x86/cpu/quark/Kconfig                         | 15 +++++++++++++
 arch/x86/cpu/queensbay/Kconfig                     | 15 +++++++++++++
 arch/x86/cpu/tangier/Kconfig                       |  8 +++++++
 arch/x86/include/asm/cpu.h                         | 12 ----------
 board/advantech/som-db5800-som-6867/Kconfig        |  2 ++
 .../som-db5800-som-6867/som-db5800-som-6867.c      |  5 -----
 board/congatec/conga-qeval20-qa3-e3845/Kconfig     |  2 ++
 .../conga-qeval20-qa3-e3845/conga-qeval20-qa3.c    |  5 -----
 board/coreboot/coreboot/Kconfig                    | 11 +++++++++
 board/coreboot/coreboot/Makefile                   |  2 +-
 board/coreboot/coreboot/coreboot.c                 | 14 ------------
 board/dfi/dfi-bt700/Kconfig                        |  2 ++
 board/efi/efi-x86/efi.c                            |  6 -----
 board/google/chromebook_link/Kconfig               |  1 +
 board/google/chromebook_link/link.c                | 16 -------------
 board/google/chromebook_samus/Kconfig              |  1 +
 board/google/chromebook_samus/samus.c              | 11 ---------
 board/google/chromebox_panther/Kconfig             |  1 +
 board/google/chromebox_panther/panther.c           | 11 ---------
 board/intel/bayleybay/Kconfig                      |  1 +
 board/intel/cougarcanyon2/Kconfig                  |  2 ++
 board/intel/crownbay/Kconfig                       |  2 ++
 board/intel/galileo/Kconfig                        |  1 +
 board/intel/galileo/galileo.c                      |  5 -----
 board/intel/minnowmax/Kconfig                      |  1 +
 board/intel/minnowmax/minnowmax.c                  |  5 -----
 common/Kconfig                                     |  2 --
 configs/bayleybay_defconfig                        | 25 ---------------------
 configs/chromebook_link64_defconfig                | 19 ++--------------
 configs/chromebook_link_defconfig                  | 18 +--------------
 configs/chromebook_samus_defconfig                 | 17 --------------
 configs/chromebox_panther_defconfig                | 19 +---------------
 ...conga-qeval20-qa3-e3845-internal-uart_defconfig | 23 -------------------
 configs/conga-qeval20-qa3-e3845_defconfig          | 23 -------------------
 configs/coreboot-x86_defconfig                     | 17 --------------
 configs/cougarcanyon2_defconfig                    | 15 ++-----------
 configs/crownbay_defconfig                         | 23 -------------------
 configs/dfi-bt700-q7x-151_defconfig                | 23 -------------------
 configs/edison_defconfig                           | 14 ------------
 configs/efi-x86_defconfig                          | 10 +--------
 configs/galileo_defconfig                          | 22 ------------------
 configs/minnowmax_defconfig                        | 26 ----------------------
 configs/qemu-x86_64_defconfig                      | 18 ---------------
 configs/qemu-x86_defconfig                         | 17 --------------
 configs/qemu-x86_efi_payload32_defconfig           | 17 --------------
 configs/qemu-x86_efi_payload64_defconfig           | 17 --------------
 configs/som-db5800-som-6867_defconfig              | 20 -----------------
 configs/theadorable-x86-dfi-bt700_defconfig        | 24 --------------------
 drivers/gpio/Kconfig                               |  6 +++++
 drivers/pci/Kconfig                                |  2 +-
 drivers/timer/Kconfig                              |  1 -
 include/configs/efi-x86.h                          |  1 -
 include/configs/qemu-x86.h                         |  3 ---
 include/configs/x86-common.h                       |  3 ---
 scripts/config_whitelist.txt                       |  1 -
 64 files changed, 168 insertions(+), 531 deletions(-)
 delete mode 100644 board/coreboot/coreboot/coreboot.c

-- 
2.9.2

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC Bin Meng
                   ` (20 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Without a timer, U-Boot just doesn't boot. This is not something
we can turn off.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

---

Changes in v2:
- sync defconfigs

 arch/Kconfig                                            | 2 ++
 configs/bayleybay_defconfig                             | 3 +--
 configs/chromebook_link64_defconfig                     | 5 ++---
 configs/chromebook_link_defconfig                       | 5 ++---
 configs/chromebook_samus_defconfig                      | 3 +--
 configs/chromebox_panther_defconfig                     | 5 ++---
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/coreboot-x86_defconfig                          | 1 -
 configs/cougarcanyon2_defconfig                         | 3 +--
 configs/crownbay_defconfig                              | 3 +--
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/edison_defconfig                                | 1 -
 configs/efi-x86_defconfig                               | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 3 +--
 configs/qemu-x86_64_defconfig                           | 1 -
 configs/qemu-x86_defconfig                              | 1 -
 configs/qemu-x86_efi_payload32_defconfig                | 1 -
 configs/qemu-x86_efi_payload64_defconfig                | 1 -
 configs/som-db5800-som-6867_defconfig                   | 3 +--
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 drivers/timer/Kconfig                                   | 1 -
 23 files changed, 14 insertions(+), 34 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 3701647..7ccdbf7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -94,6 +94,8 @@ config X86
 	select DM_GPIO
 	select DM_SPI
 	select DM_SPI_FLASH
+	select TIMER
+	select X86_TSC_TIMER
 	select USB
 	select USB_EHCI_HCD
 	imply CMD_FPGA_LOADMK
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index ddb3c21..847811d 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -46,6 +46,7 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_CPU=y
 CONFIG_MMC=y
 CONFIG_MMC_PCI=y
@@ -59,10 +60,8 @@ CONFIG_DM_ETH=y
 CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 95bedb0..a3b1897 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -58,6 +58,8 @@ CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SPL_SYSCON=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
@@ -70,14 +72,11 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
-CONFIG_DM_SCSI=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index 3b87ad5..bdc068b 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -41,6 +41,8 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
@@ -53,14 +55,11 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
-CONFIG_DM_SCSI=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index 1b5e490..27bf5dd 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -41,6 +41,7 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_CPU=y
 CONFIG_INTEL_BROADWELL_GPIO=y
 CONFIG_CROS_EC=y
@@ -51,13 +52,11 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 4f1b69d..e67b06b 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -37,6 +37,8 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
+CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
@@ -48,11 +50,8 @@ CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
-CONFIG_DM_SCSI=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index 4802525..2841a54 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -67,7 +67,6 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 753ee3f..1313245 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -66,7 +66,6 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 3950bfc..15b7de2 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -43,7 +43,6 @@ CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_TIMER=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index ea418c5..3dce566 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -30,14 +30,13 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index 3e8d129..c097edc 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -36,6 +36,7 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_CPU=y
 CONFIG_MMC=y
 CONFIG_MMC_PCI=y
@@ -51,10 +52,8 @@ CONFIG_E1000=y
 CONFIG_PCH_GBE=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 57b4075..87a6343 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -64,7 +64,6 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index f33b35c..52d3adf 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -39,7 +39,6 @@ CONFIG_DM_PCI=y
 CONFIG_DM_PCI_COMPAT=y
 CONFIG_DM_RTC=y
 CONFIG_INTEL_MID_SERIAL=y
-CONFIG_TIMER=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GADGET=y
 CONFIG_USB_GADGET=y
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index f93f937..36be406 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -37,7 +37,6 @@ CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
 CONFIG_DEBUG_UART_CLOCK=0
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_EFI=y
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 5fa8a54..2a77474 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -56,7 +56,6 @@ CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 85a2814..4e4dca2 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -47,6 +47,7 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_CPU=y
 CONFIG_MMC=y
 CONFIG_MMC_PCI=y
@@ -61,12 +62,10 @@ CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 30d4d24..4c1689a 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -70,7 +70,6 @@ CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 53cbb6a..7c418e5 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -48,7 +48,6 @@ CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 6e021b9..8cd8820 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -45,7 +45,6 @@ CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index 026f08f..86d16cd 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -46,7 +46,6 @@ CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index d694f75..54d2174 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -43,6 +43,7 @@ CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_SCSI=y
 CONFIG_CPU=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
@@ -53,12 +54,10 @@ CONFIG_DM_ETH=y
 CONFIG_E1000=y
 CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
-CONFIG_SCSI=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index cf5cb72..ad02e0c 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -63,7 +63,6 @@ CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_TIMER=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig
index 17e7dfe..c666303 100644
--- a/drivers/timer/Kconfig
+++ b/drivers/timer/Kconfig
@@ -36,7 +36,6 @@ config SANDBOX_TIMER
 config X86_TSC_TIMER
 	bool "x86 Time-Stamp Counter (TSC) timer support"
 	depends on TIMER && X86
-	default y if X86
 	help
 	  Select this to enable Time-Stamp Counter (TSC) timer for x86.
 
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI Bin Meng
                   ` (19 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

x86 is using the built-in libgcc implementation and this cannot be
turned off.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/Kconfig                                            | 1 +
 configs/bayleybay_defconfig                             | 1 -
 configs/chromebook_link64_defconfig                     | 1 -
 configs/chromebook_link_defconfig                       | 1 -
 configs/chromebook_samus_defconfig                      | 1 -
 configs/chromebox_panther_defconfig                     | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/coreboot-x86_defconfig                          | 1 -
 configs/cougarcanyon2_defconfig                         | 1 -
 configs/crownbay_defconfig                              | 1 -
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/edison_defconfig                                | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/qemu-x86_64_defconfig                           | 1 -
 configs/qemu-x86_defconfig                              | 1 -
 configs/qemu-x86_efi_payload32_defconfig                | 1 -
 configs/qemu-x86_efi_payload64_defconfig                | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 21 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 7ccdbf7..193e494 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -87,6 +87,7 @@ config X86
 	bool "x86 architecture"
 	select CREATE_ARCH_SYMLINK
 	select HAVE_PRIVATE_LIBGCC
+	select USE_PRIVATE_LIBGCC
 	select SUPPORT_OF_CONTROL
 	select DM
 	select DM_KEYBOARD
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 847811d..d6798be 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -70,4 +70,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index a3b1897..9946ab3 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -87,6 +87,5 @@ CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_IVYBRIDGE_IGD=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_TPM=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index bdc068b..ddd1349 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -70,6 +70,5 @@ CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_IVYBRIDGE_IGD=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_TPM=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index 27bf5dd..bbfb238 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -66,5 +66,4 @@ CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_BROADWELL_IGD=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_TPM=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index e67b06b..c38948a 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -61,5 +61,4 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_TPM=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index 2841a54..f21736e 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -75,4 +75,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 1313245..009b94d 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -74,4 +74,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 15b7de2..3165a8b 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -50,5 +50,4 @@ CONFIG_USB_KEYBOARD=y
 CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_COREBOOT=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_TPM=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 3dce566..8eb83ac 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -40,4 +40,3 @@ CONFIG_ICH_SPI=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index c097edc..a852a33 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -61,4 +61,3 @@ CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 87a6343..fd84bb8 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -72,4 +72,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index 52d3adf..de8b36a 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -48,5 +48,4 @@ CONFIG_G_DNL_VENDOR_NUM=0x8087
 CONFIG_G_DNL_PRODUCT_NUM=0x0a99
 CONFIG_TANGIER_WATCHDOG=y
 CONFIG_FAT_WRITE=y
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_SHA1=y
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 2a77474..81c0d13 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -59,4 +59,3 @@ CONFIG_ICH_SPI=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 4e4dca2..03b9d42 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -75,4 +75,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 4c1689a..94041ee 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -78,4 +78,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 7c418e5..0f94f42 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -56,4 +56,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 8cd8820..3ac4251 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -53,6 +53,5 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_EFI=y
 CONFIG_EFI_STUB=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index 86d16cd..ef4cda5 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -54,7 +54,6 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_EFI=y
 CONFIG_EFI_STUB=y
 CONFIG_EFI_STUB_64BIT=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 54d2174..29671ae 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -66,4 +66,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index ad02e0c..35cac6a 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -71,4 +71,3 @@ CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-CONFIG_USE_PRIVATE_LIBGCC=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER Bin Meng
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig Bin Meng
                   ` (18 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

PCI is the de facto interconnect bus in an x86 system.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/Kconfig                                            | 2 ++
 configs/bayleybay_defconfig                             | 1 -
 configs/chromebook_link64_defconfig                     | 1 -
 configs/chromebook_link_defconfig                       | 1 -
 configs/chromebook_samus_defconfig                      | 1 -
 configs/chromebox_panther_defconfig                     | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/coreboot-x86_defconfig                          | 1 -
 configs/cougarcanyon2_defconfig                         | 1 -
 configs/crownbay_defconfig                              | 1 -
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/edison_defconfig                                | 1 -
 configs/efi-x86_defconfig                               | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/qemu-x86_64_defconfig                           | 1 -
 configs/qemu-x86_defconfig                              | 1 -
 configs/qemu-x86_efi_payload32_defconfig                | 1 -
 configs/qemu-x86_efi_payload64_defconfig                | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 drivers/pci/Kconfig                                     | 2 +-
 23 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 193e494..b062826 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -93,6 +93,8 @@ config X86
 	select DM_KEYBOARD
 	select DM_SERIAL
 	select DM_GPIO
+	select PCI
+	select DM_PCI
 	select DM_SPI
 	select DM_SPI_FLASH
 	select TIMER
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index d6798be..6572a38 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -58,7 +58,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 9946ab3..5224497 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -70,7 +70,6 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index ddd1349..495a5bc 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -53,7 +53,6 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index bbfb238..39a9b0d 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -50,7 +50,6 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index c38948a..4052f5c 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -48,7 +48,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index f21736e..e88751d 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -61,7 +61,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 009b94d..8c6733f 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -60,7 +60,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 3165a8b..3a08dc4 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -40,7 +40,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_TPM_TIS_LPC=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 8eb83ac..2e729fa 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -33,7 +33,6 @@ CONFIG_SYSCON=y
 CONFIG_SCSI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index a852a33..af9c3c0 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -50,7 +50,6 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
 CONFIG_PCH_GBE=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index fd84bb8..5543e94 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -58,7 +58,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index de8b36a..02bc760 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -35,7 +35,6 @@ CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_TANGIER=y
-CONFIG_DM_PCI=y
 CONFIG_DM_PCI_COMPAT=y
 CONFIG_DM_RTC=y
 CONFIG_INTEL_MID_SERIAL=y
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 36be406..26db27b 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -32,7 +32,6 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_OF_EMBED=y
-CONFIG_DM_PCI=y
 CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
 CONFIG_DEBUG_UART_CLOCK=0
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 81c0d13..a842db0 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -52,7 +52,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 03b9d42..f610765 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -60,7 +60,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 94041ee..1e472e5 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -65,7 +65,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 0f94f42..cf9ed9f 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -45,7 +45,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_DM_USB=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 3ac4251..6b11630 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -42,7 +42,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_DM_USB=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index ef4cda5..d1964c2 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -43,7 +43,6 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_DM_USB=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 29671ae..ae0bbb3 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -52,7 +52,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 35cac6a..027bfb7 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -59,7 +59,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_PCI=y
 CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index 692a398..e2a1c0a 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -1,6 +1,6 @@
 menuconfig PCI
 	bool "PCI support"
-	default y if PPC || X86
+	default y if PPC
 	help
 	  Enable support for PCI (Peripheral Interconnect Bus), a type of bus
 	  used on some devices to allow the CPU to communicate with its
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (2 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F Bin Meng
                   ` (17 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Intel Management Engine is required by the platform, however it's
not a must have when building a U-Boot image. For example, during
development normally programming ME firmware is a one-time effort.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/baytrail/Kconfig                           | 1 +
 arch/x86/cpu/broadwell/Kconfig                          | 1 +
 arch/x86/cpu/ivybridge/Kconfig                          | 1 +
 configs/bayleybay_defconfig                             | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 10 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 4e7d4a4..216d7d7 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -8,6 +8,7 @@ config INTEL_BAYTRAIL
 	bool
 	select HAVE_FSP if !EFI
 	imply ENV_IS_IN_SPI_FLASH
+	imply HAVE_INTEL_ME if !EFI
 
 if INTEL_BAYTRAIL
 config INTERNAL_UART
diff --git a/arch/x86/cpu/broadwell/Kconfig b/arch/x86/cpu/broadwell/Kconfig
index 1ce3848..8501949 100644
--- a/arch/x86/cpu/broadwell/Kconfig
+++ b/arch/x86/cpu/broadwell/Kconfig
@@ -6,6 +6,7 @@
 config INTEL_BROADWELL
 	bool
 	select CACHE_MRC_BIN
+	imply HAVE_INTEL_ME
 
 if INTEL_BROADWELL
 
diff --git a/arch/x86/cpu/ivybridge/Kconfig b/arch/x86/cpu/ivybridge/Kconfig
index e23d01a..ed6b834 100644
--- a/arch/x86/cpu/ivybridge/Kconfig
+++ b/arch/x86/cpu/ivybridge/Kconfig
@@ -8,6 +8,7 @@
 config NORTHBRIDGE_INTEL_IVYBRIDGE
 	bool
 	select CACHE_MRC_BIN if HAVE_MRC
+	imply HAVE_INTEL_ME
 
 if NORTHBRIDGE_INTEL_IVYBRIDGE
 
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 6572a38..a7767d6 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="bayleybay"
 CONFIG_TARGET_BAYLEYBAY=y
 CONFIG_INTERNAL_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index e88751d..3a5dbe6 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -4,7 +4,6 @@ CONFIG_TARGET_CONGA_QEVAL20_QA3_E3845=y
 CONFIG_DEFAULT_DEVICE_TREE="conga-qeval20-qa3-e3845"
 CONFIG_INTERNAL_UART=y
 CONFIG_DEBUG_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 8c6733f..4afa26c 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_CONGATEC=y
 CONFIG_TARGET_CONGA_QEVAL20_QA3_E3845=y
 CONFIG_DEFAULT_DEVICE_TREE="conga-qeval20-qa3-e3845"
 CONFIG_DEBUG_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 5543e94..bed4f28 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_DFI=y
 CONFIG_DEFAULT_DEVICE_TREE="dfi-bt700-q7x-151"
 CONFIG_TARGET_DFI_BT700=y
 CONFIG_DEBUG_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index f610765..cc528c0 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -4,7 +4,6 @@ CONFIG_DEFAULT_DEVICE_TREE="minnowmax"
 CONFIG_TARGET_MINNOWMAX=y
 CONFIG_INTERNAL_UART=y
 CONFIG_DEBUG_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index ae0bbb3..499ae05 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_ADVANTECH=y
 CONFIG_TARGET_SOM_DB5800_SOM_6867=y
 CONFIG_DEFAULT_DEVICE_TREE="baytrail_som-db5800-som-6867"
 CONFIG_DEBUG_UART=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 027bfb7..64af353 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -2,7 +2,6 @@ CONFIG_X86=y
 CONFIG_VENDOR_DFI=y
 CONFIG_DEFAULT_DEVICE_TREE="theadorable-x86-dfi-bt700"
 CONFIG_TARGET_DFI_BT700=y
-CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (3 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig Bin Meng
                   ` (16 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

CONFIG_BOARD_EARLY_INIT_F, by its mean is provided by board-specific
codes and should be not 'default y' for all x86 boards.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/coreboot/coreboot.c               | 5 -----
 arch/x86/cpu/efi/efi.c                         | 5 -----
 board/advantech/som-db5800-som-6867/Kconfig    | 1 +
 board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 +
 board/dfi/dfi-bt700/Kconfig                    | 1 +
 board/google/chromebook_link/link.c            | 5 -----
 board/google/chromebook_samus/samus.c          | 5 -----
 board/google/chromebox_panther/panther.c       | 5 -----
 board/intel/cougarcanyon2/Kconfig              | 1 +
 board/intel/crownbay/Kconfig                   | 1 +
 board/intel/galileo/galileo.c                  | 5 -----
 common/Kconfig                                 | 1 -
 configs/bayleybay_defconfig                    | 1 -
 configs/coreboot-x86_defconfig                 | 1 -
 configs/edison_defconfig                       | 1 -
 configs/efi-x86_defconfig                      | 1 -
 configs/minnowmax_defconfig                    | 1 -
 configs/qemu-x86_64_defconfig                  | 1 -
 configs/qemu-x86_defconfig                     | 1 -
 configs/qemu-x86_efi_payload32_defconfig       | 1 -
 configs/qemu-x86_efi_payload64_defconfig       | 1 -
 21 files changed, 5 insertions(+), 40 deletions(-)

diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
index 658b900..cb5396c 100644
--- a/arch/x86/cpu/coreboot/coreboot.c
+++ b/arch/x86/cpu/coreboot/coreboot.c
@@ -29,11 +29,6 @@ int arch_cpu_init(void)
 	return x86_cpu_init_f();
 }
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 int checkcpu(void)
 {
 	return 0;
diff --git a/arch/x86/cpu/efi/efi.c b/arch/x86/cpu/efi/efi.c
index 741613f..8c79eb6 100644
--- a/arch/x86/cpu/efi/efi.c
+++ b/arch/x86/cpu/efi/efi.c
@@ -13,11 +13,6 @@ int arch_cpu_init(void)
 	return 0;
 }
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 int checkcpu(void)
 {
 	return 0;
diff --git a/board/advantech/som-db5800-som-6867/Kconfig b/board/advantech/som-db5800-som-6867/Kconfig
index f6f3748..945aa43 100644
--- a/board/advantech/som-db5800-som-6867/Kconfig
+++ b/board/advantech/som-db5800-som-6867/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR if !EFI_STUB
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
+	select BOARD_EARLY_INIT_F
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/board/congatec/conga-qeval20-qa3-e3845/Kconfig b/board/congatec/conga-qeval20-qa3-e3845/Kconfig
index 24b8f69..f91ffa1 100644
--- a/board/congatec/conga-qeval20-qa3-e3845/Kconfig
+++ b/board/congatec/conga-qeval20-qa3-e3845/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR if !EFI_STUB
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 
 config PCIE_ECAM_BASE
diff --git a/board/dfi/dfi-bt700/Kconfig b/board/dfi/dfi-bt700/Kconfig
index fca8b53..59f45ef 100644
--- a/board/dfi/dfi-bt700/Kconfig
+++ b/board/dfi/dfi-bt700/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR if !EFI_STUB
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 
 config PCIE_ECAM_BASE
diff --git a/board/google/chromebook_link/link.c b/board/google/chromebook_link/link.c
index 42615e1..64e7c1a 100644
--- a/board/google/chromebook_link/link.c
+++ b/board/google/chromebook_link/link.c
@@ -16,8 +16,3 @@ int arch_early_init_r(void)
 {
 	return 0;
 }
-
-int board_early_init_f(void)
-{
-	return 0;
-}
diff --git a/board/google/chromebook_samus/samus.c b/board/google/chromebook_samus/samus.c
index 3c3f5d4..356b92a 100644
--- a/board/google/chromebook_samus/samus.c
+++ b/board/google/chromebook_samus/samus.c
@@ -11,8 +11,3 @@ int arch_early_init_r(void)
 {
 	return cpu_run_reference_code();
 }
-
-int board_early_init_f(void)
-{
-	return 0;
-}
diff --git a/board/google/chromebox_panther/panther.c b/board/google/chromebox_panther/panther.c
index e3baf88..ed60e44 100644
--- a/board/google/chromebox_panther/panther.c
+++ b/board/google/chromebox_panther/panther.c
@@ -11,8 +11,3 @@ int arch_early_init_r(void)
 {
 	return 0;
 }
-
-int board_early_init_f(void)
-{
-	return 0;
-}
diff --git a/board/intel/cougarcanyon2/Kconfig b/board/intel/cougarcanyon2/Kconfig
index 95a617b..4e7d021 100644
--- a/board/intel/cougarcanyon2/Kconfig
+++ b/board/intel/cougarcanyon2/Kconfig
@@ -21,5 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select NORTHBRIDGE_INTEL_IVYBRIDGE
 	select HAVE_FSP
 	select BOARD_ROMSIZE_KB_2048
+	select BOARD_EARLY_INIT_F
 
 endif
diff --git a/board/intel/crownbay/Kconfig b/board/intel/crownbay/Kconfig
index b30701a..05626a9 100644
--- a/board/intel/crownbay/Kconfig
+++ b/board/intel/crownbay/Kconfig
@@ -20,5 +20,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR
 	select INTEL_QUEENSBAY
 	select BOARD_ROMSIZE_KB_1024
+	select BOARD_EARLY_INIT_F
 
 endif
diff --git a/board/intel/galileo/galileo.c b/board/intel/galileo/galileo.c
index 568bd4d..2fe1923 100644
--- a/board/intel/galileo/galileo.c
+++ b/board/intel/galileo/galileo.c
@@ -9,11 +9,6 @@
 #include <asm/arch/device.h>
 #include <asm/arch/quark.h>
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 /*
  * Intel Galileo gen2 board uses GPIO Resume Well bank pin0 as the PERST# pin.
  *
diff --git a/common/Kconfig b/common/Kconfig
index 8c8d2e4..d005a3b 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -875,7 +875,6 @@ config ARCH_MISC_INIT
 
 config BOARD_EARLY_INIT_F
 	bool "Call board-specific init before relocation"
-	default y if X86
 	help
 	  Some boards need to perform initialisation as soon as possible
 	  after boot. With this option, U-Boot calls board_early_init_f()
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index a7767d6..4a31b4e 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -17,7 +17,6 @@ CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_ARCH_MISC_INIT=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 3a08dc4..ed9592c 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -6,7 +6,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_IDE=y
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index 02bc760..ba43b47 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -4,7 +4,6 @@ CONFIG_DEFAULT_DEVICE_TREE="edison"
 CONFIG_TARGET_EDISON=y
 CONFIG_SMP=y
 # CONFIG_ARCH_EARLY_INIT_R is not set
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 26db27b..20681b0 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -8,7 +8,6 @@ CONFIG_ENV_IS_NOWHERE=y
 CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_ARCH_EARLY_INIT_R is not set
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_BOOTM is not set
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index cc528c0..c4ff647 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -18,7 +18,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_ARCH_MISC_INIT=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 1e472e5..bfd3881 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -21,7 +21,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SPL_CPU_SUPPORT=y
 CONFIG_SPL_ENV_SUPPORT=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index cf9ed9f..679a254 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -10,7 +10,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 6b11630..ca5b96a 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -7,7 +7,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index d1964c2..f70bae9 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -7,7 +7,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_BOARD_EARLY_INIT_F is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (4 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R " Bin Meng
                   ` (15 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

arch_misc_init() is intended to do architecture-dependent stuff.
This is required by each platform.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/baytrail/Kconfig                           | 1 +
 arch/x86/cpu/coreboot/coreboot.c                        | 5 -----
 arch/x86/cpu/efi/efi.c                                  | 5 -----
 arch/x86/cpu/quark/Kconfig                              | 1 +
 configs/bayleybay_defconfig                             | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 10 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 216d7d7..ac27e7a 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -7,6 +7,7 @@
 config INTEL_BAYTRAIL
 	bool
 	select HAVE_FSP if !EFI
+	select ARCH_MISC_INIT if !EFI
 	imply ENV_IS_IN_SPI_FLASH
 	imply HAVE_INTEL_ME if !EFI
 
diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
index cb5396c..df5ad13 100644
--- a/arch/x86/cpu/coreboot/coreboot.c
+++ b/arch/x86/cpu/coreboot/coreboot.c
@@ -85,8 +85,3 @@ int misc_init_r(void)
 {
 	return 0;
 }
-
-int arch_misc_init(void)
-{
-	return 0;
-}
diff --git a/arch/x86/cpu/efi/efi.c b/arch/x86/cpu/efi/efi.c
index 8c79eb6..d82147b 100644
--- a/arch/x86/cpu/efi/efi.c
+++ b/arch/x86/cpu/efi/efi.c
@@ -31,8 +31,3 @@ int misc_init_r(void)
 {
 	return 0;
 }
-
-int arch_misc_init(void)
-{
-	return 0;
-}
diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index 163caac..641aa22 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -7,6 +7,7 @@
 config INTEL_QUARK
 	bool
 	select HAVE_RMU
+	select ARCH_MISC_INIT
 
 if INTEL_QUARK
 
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 4a31b4e..9436784 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -16,7 +16,6 @@ CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_ARCH_EARLY_INIT_R is not set
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index 3a5dbe6..fe75414 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -16,7 +16,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 4afa26c..334f0a2 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -15,7 +15,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index a842db0..f53970a 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -12,7 +12,6 @@ CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index c4ff647..1301c16 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -17,7 +17,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 499ae05..c393d72 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -15,7 +15,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-CONFIG_ARCH_MISC_INIT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R in the platform Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (5 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE " Bin Meng
                   ` (14 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

This is architecture-dependent early initialization hence should
be put in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/broadwell/Kconfig                          |  1 +
 arch/x86/cpu/broadwell/refcode.c                        | 17 ++++++++++++++++-
 arch/x86/cpu/qemu/Kconfig                               |  1 +
 arch/x86/cpu/quark/Kconfig                              |  1 +
 arch/x86/cpu/queensbay/Kconfig                          |  1 +
 arch/x86/include/asm/cpu.h                              | 12 ------------
 .../advantech/som-db5800-som-6867/som-db5800-som-6867.c |  5 -----
 .../conga-qeval20-qa3-e3845/conga-qeval20-qa3.c         |  5 -----
 board/coreboot/coreboot/Makefile                        |  2 +-
 board/coreboot/coreboot/coreboot.c                      | 14 --------------
 board/efi/efi-x86/efi.c                                 |  6 ------
 board/google/chromebook_link/link.c                     | 11 -----------
 board/google/chromebook_samus/samus.c                   |  6 ------
 board/google/chromebox_panther/panther.c                |  6 ------
 board/intel/minnowmax/minnowmax.c                       |  5 -----
 common/Kconfig                                          |  1 -
 configs/bayleybay_defconfig                             |  1 -
 configs/cougarcanyon2_defconfig                         |  1 -
 configs/dfi-bt700-q7x-151_defconfig                     |  1 -
 configs/edison_defconfig                                |  1 -
 configs/efi-x86_defconfig                               |  1 -
 configs/theadorable-x86-dfi-bt700_defconfig             |  1 -
 22 files changed, 21 insertions(+), 79 deletions(-)
 delete mode 100644 board/coreboot/coreboot/coreboot.c

diff --git a/arch/x86/cpu/broadwell/Kconfig b/arch/x86/cpu/broadwell/Kconfig
index 8501949..f3006c3 100644
--- a/arch/x86/cpu/broadwell/Kconfig
+++ b/arch/x86/cpu/broadwell/Kconfig
@@ -6,6 +6,7 @@
 config INTEL_BROADWELL
 	bool
 	select CACHE_MRC_BIN
+	select ARCH_EARLY_INIT_R
 	imply HAVE_INTEL_ME
 
 if INTEL_BROADWELL
diff --git a/arch/x86/cpu/broadwell/refcode.c b/arch/x86/cpu/broadwell/refcode.c
index 436c6c4..4fa4de3 100644
--- a/arch/x86/cpu/broadwell/refcode.c
+++ b/arch/x86/cpu/broadwell/refcode.c
@@ -56,7 +56,17 @@ struct rmodule_header {
 	uint32_t padding[4];
 } __packed;
 
-int cpu_run_reference_code(void)
+/**
+ * cpu_run_reference_code() - Run the platform reference code
+ *
+ * Some platforms require a binary blob to be executed once SDRAM is
+ * available. This is used to set up various platform features, such as the
+ * platform controller hub (PCH). This function should be implemented by the
+ * CPU-specific code.
+ *
+ * @return 0 on success, -ve on failure
+ */
+static int cpu_run_reference_code(void)
 {
 	struct pei_data _pei_data __aligned(8);
 	struct pei_data *pei_data = &_pei_data;
@@ -111,3 +121,8 @@ int cpu_run_reference_code(void)
 
 	return 0;
 }
+
+int arch_early_init_r(void)
+{
+	return cpu_run_reference_code();
+}
diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
index 6808c9a..6f61744 100644
--- a/arch/x86/cpu/qemu/Kconfig
+++ b/arch/x86/cpu/qemu/Kconfig
@@ -6,6 +6,7 @@
 
 config QEMU
 	bool
+	select ARCH_EARLY_INIT_R
 
 if QEMU
 
diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index 641aa22..9e7d983 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -7,6 +7,7 @@
 config INTEL_QUARK
 	bool
 	select HAVE_RMU
+	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
 
 if INTEL_QUARK
diff --git a/arch/x86/cpu/queensbay/Kconfig b/arch/x86/cpu/queensbay/Kconfig
index 6136d75..e2dfe19 100644
--- a/arch/x86/cpu/queensbay/Kconfig
+++ b/arch/x86/cpu/queensbay/Kconfig
@@ -8,6 +8,7 @@ config INTEL_QUEENSBAY
 	bool
 	select HAVE_FSP
 	select HAVE_CMC
+	select ARCH_EARLY_INIT_R
 
 if INTEL_QUEENSBAY
 
diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
index c00687a..bc2c4ff 100644
--- a/arch/x86/include/asm/cpu.h
+++ b/arch/x86/include/asm/cpu.h
@@ -288,16 +288,4 @@ u32 cpu_get_family_model(void);
  */
 u32 cpu_get_stepping(void);
 
-/**
- * cpu_run_reference_code() - Run the platform reference code
- *
- * Some platforms require a binary blob to be executed once SDRAM is
- * available. This is used to set up various platform features, such as the
- * platform controller hub (PCH). This function should be implemented by the
- * CPU-specific code.
- *
- * @return 0 on success, -ve on failure
- */
-int cpu_run_reference_code(void);
-
 #endif
diff --git a/board/advantech/som-db5800-som-6867/som-db5800-som-6867.c b/board/advantech/som-db5800-som-6867/som-db5800-som-6867.c
index 5bed2c1..6158795 100644
--- a/board/advantech/som-db5800-som-6867/som-db5800-som-6867.c
+++ b/board/advantech/som-db5800-som-6867/som-db5800-som-6867.c
@@ -17,8 +17,3 @@ int board_early_init_f(void)
 
 	return 0;
 }
-
-int arch_early_init_r(void)
-{
-	return 0;
-}
diff --git a/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c b/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
index 7a5b765..1283eeb 100644
--- a/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
+++ b/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
@@ -28,11 +28,6 @@ int board_early_init_f(void)
 	return 0;
 }
 
-int arch_early_init_r(void)
-{
-	return 0;
-}
-
 int board_late_init(void)
 {
 	struct udevice *dev;
diff --git a/board/coreboot/coreboot/Makefile b/board/coreboot/coreboot/Makefile
index 27ebe78..4f2ac89 100644
--- a/board/coreboot/coreboot/Makefile
+++ b/board/coreboot/coreboot/Makefile
@@ -12,4 +12,4 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-obj-y	+= coreboot_start.o coreboot.o
+obj-y	+= coreboot_start.o
diff --git a/board/coreboot/coreboot/coreboot.c b/board/coreboot/coreboot/coreboot.c
deleted file mode 100644
index bb7f778..0000000
--- a/board/coreboot/coreboot/coreboot.c
+++ /dev/null
@@ -1,14 +0,0 @@
-/*
- * Copyright (C) 2013 Google, Inc
- *
- * SPDX-License-Identifier:	GPL-2.0+
- */
-
-#include <common.h>
-#include <cros_ec.h>
-#include <asm/gpio.h>
-
-int arch_early_init_r(void)
-{
-	return 0;
-}
diff --git a/board/efi/efi-x86/efi.c b/board/efi/efi-x86/efi.c
index 1fbe36a..2adc202 100644
--- a/board/efi/efi-x86/efi.c
+++ b/board/efi/efi-x86/efi.c
@@ -5,9 +5,3 @@
  */
 
 #include <common.h>
-#include <asm/gpio.h>
-
-int arch_early_init_r(void)
-{
-	return 0;
-}
diff --git a/board/google/chromebook_link/link.c b/board/google/chromebook_link/link.c
index 64e7c1a..dc22592 100644
--- a/board/google/chromebook_link/link.c
+++ b/board/google/chromebook_link/link.c
@@ -5,14 +5,3 @@
  */
 
 #include <common.h>
-#include <cros_ec.h>
-#include <dm.h>
-#include <asm/gpio.h>
-#include <asm/io.h>
-#include <asm/pci.h>
-#include <asm/arch/pch.h>
-
-int arch_early_init_r(void)
-{
-	return 0;
-}
diff --git a/board/google/chromebook_samus/samus.c b/board/google/chromebook_samus/samus.c
index 356b92a..5b5eb19 100644
--- a/board/google/chromebook_samus/samus.c
+++ b/board/google/chromebook_samus/samus.c
@@ -5,9 +5,3 @@
  */
 
 #include <common.h>
-#include <asm/cpu.h>
-
-int arch_early_init_r(void)
-{
-	return cpu_run_reference_code();
-}
diff --git a/board/google/chromebox_panther/panther.c b/board/google/chromebox_panther/panther.c
index ed60e44..2adc202 100644
--- a/board/google/chromebox_panther/panther.c
+++ b/board/google/chromebox_panther/panther.c
@@ -5,9 +5,3 @@
  */
 
 #include <common.h>
-#include <asm/arch/pch.h>
-
-int arch_early_init_r(void)
-{
-	return 0;
-}
diff --git a/board/intel/minnowmax/minnowmax.c b/board/intel/minnowmax/minnowmax.c
index 99aed53..5bdb2fd 100644
--- a/board/intel/minnowmax/minnowmax.c
+++ b/board/intel/minnowmax/minnowmax.c
@@ -12,11 +12,6 @@
 
 #define GPIO_BANKE_NAME		"gpioe"
 
-int arch_early_init_r(void)
-{
-	return 0;
-}
-
 int misc_init_r(void)
 {
 	struct udevice *dev;
diff --git a/common/Kconfig b/common/Kconfig
index d005a3b..e1bbf44 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -858,7 +858,6 @@ menu "Start-up hooks"
 
 config ARCH_EARLY_INIT_R
 	bool "Call arch-specific init soon after relocation"
-	default y if X86
 	help
 	  With this option U-Boot will call arch_early_init_r() soon after
 	  relocation. Driver model is running by this point, and the cache
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 9436784..bf00390 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -15,7 +15,6 @@ CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 2e729fa..84856aa 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -5,7 +5,6 @@ CONFIG_TARGET_COUGARCANYON2=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index bed4f28..76cdf55 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -15,7 +15,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index ba43b47..02c09aa 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="edison"
 CONFIG_TARGET_EDISON=y
 CONFIG_SMP=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 20681b0..7495da4 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -7,7 +7,6 @@ CONFIG_FIT=y
 CONFIG_ENV_IS_NOWHERE=y
 CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_BOOTM is not set
 # CONFIG_CMD_IMLS is not set
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 64af353..dee551b 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -15,7 +15,6 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
-# CONFIG_ARCH_EARLY_INIT_R is not set
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
 # CONFIG_CMD_IMLS is not set
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE in the platform Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (6 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL Bin Meng
                   ` (13 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Platform knows whether MRC cache is implemented, but using it can
be a choice of a specific board.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/baytrail/Kconfig                           | 1 +
 arch/x86/cpu/broadwell/Kconfig                          | 1 +
 arch/x86/cpu/ivybridge/Kconfig                          | 1 +
 arch/x86/cpu/quark/Kconfig                              | 1 +
 configs/bayleybay_defconfig                             | 1 -
 configs/chromebook_link64_defconfig                     | 1 -
 configs/chromebook_link_defconfig                       | 1 -
 configs/chromebook_samus_defconfig                      | 1 -
 configs/chromebox_panther_defconfig                     | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/cougarcanyon2_defconfig                         | 1 +
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 17 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index ac27e7a..57a3a96 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -10,6 +10,7 @@ config INTEL_BAYTRAIL
 	select ARCH_MISC_INIT if !EFI
 	imply ENV_IS_IN_SPI_FLASH
 	imply HAVE_INTEL_ME if !EFI
+	imply ENABLE_MRC_CACHE
 
 if INTEL_BAYTRAIL
 config INTERNAL_UART
diff --git a/arch/x86/cpu/broadwell/Kconfig b/arch/x86/cpu/broadwell/Kconfig
index f3006c3..a9a461d 100644
--- a/arch/x86/cpu/broadwell/Kconfig
+++ b/arch/x86/cpu/broadwell/Kconfig
@@ -8,6 +8,7 @@ config INTEL_BROADWELL
 	select CACHE_MRC_BIN
 	select ARCH_EARLY_INIT_R
 	imply HAVE_INTEL_ME
+	imply ENABLE_MRC_CACHE
 
 if INTEL_BROADWELL
 
diff --git a/arch/x86/cpu/ivybridge/Kconfig b/arch/x86/cpu/ivybridge/Kconfig
index ed6b834..5df5e3a 100644
--- a/arch/x86/cpu/ivybridge/Kconfig
+++ b/arch/x86/cpu/ivybridge/Kconfig
@@ -9,6 +9,7 @@ config NORTHBRIDGE_INTEL_IVYBRIDGE
 	bool
 	select CACHE_MRC_BIN if HAVE_MRC
 	imply HAVE_INTEL_ME
+	imply ENABLE_MRC_CACHE
 
 if NORTHBRIDGE_INTEL_IVYBRIDGE
 
diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index 9e7d983..68bb219 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -9,6 +9,7 @@ config INTEL_QUARK
 	select HAVE_RMU
 	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
+	imply ENABLE_MRC_CACHE
 
 if INTEL_QUARK
 
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index bf00390..036ea20 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="bayleybay"
 CONFIG_TARGET_BAYLEYBAY=y
 CONFIG_INTERNAL_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_VGA_BIOS_ADDR=0xfffa0000
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 5224497..c8f6c2b 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -11,7 +11,6 @@ CONFIG_VENDOR_GOOGLE=y
 CONFIG_DEFAULT_DEVICE_TREE="chromebook_link"
 CONFIG_TARGET_CHROMEBOOK_LINK64=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_HAVE_MRC=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index 495a5bc..83af9e1 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -4,7 +4,6 @@ CONFIG_VENDOR_GOOGLE=y
 CONFIG_DEFAULT_DEVICE_TREE="chromebook_link"
 CONFIG_TARGET_CHROMEBOOK_LINK=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_HAVE_MRC=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index 39a9b0d..7af4898 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -4,7 +4,6 @@ CONFIG_VENDOR_GOOGLE=y
 CONFIG_DEFAULT_DEVICE_TREE="chromebook_samus"
 CONFIG_TARGET_CHROMEBOOK_SAMUS=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_HAVE_MRC=y
 CONFIG_HAVE_REFCODE=y
 CONFIG_SMP=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 4052f5c..6cc2953 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -2,7 +2,6 @@ CONFIG_X86=y
 CONFIG_VENDOR_GOOGLE=y
 CONFIG_DEFAULT_DEVICE_TREE="chromebox_panther"
 CONFIG_TARGET_CHROMEBOX_PANTHER=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_HAVE_MRC=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_FIT=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index fe75414..20e64fd 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -4,7 +4,6 @@ CONFIG_TARGET_CONGA_QEVAL20_QA3_E3845=y
 CONFIG_DEFAULT_DEVICE_TREE="conga-qeval20-qa3-e3845"
 CONFIG_INTERNAL_UART=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 334f0a2..496479a 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_CONGATEC=y
 CONFIG_TARGET_CONGA_QEVAL20_QA3_E3845=y
 CONFIG_DEFAULT_DEVICE_TREE="conga-qeval20-qa3-e3845"
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 84856aa..ea56e58 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -2,6 +2,7 @@ CONFIG_X86=y
 CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="cougarcanyon2"
 CONFIG_TARGET_COUGARCANYON2=y
+# CONFIG_ENABLE_MRC_CACHE is not set
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 76cdf55..193bb54 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_DFI=y
 CONFIG_DEFAULT_DEVICE_TREE="dfi-bt700-q7x-151"
 CONFIG_TARGET_DFI_BT700=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index f53970a..e8b11e4 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -2,7 +2,6 @@ CONFIG_X86=y
 CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="galileo"
 CONFIG_TARGET_GALILEO=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_GENERATE_PIRQ_TABLE=y
 CONFIG_GENERATE_MP_TABLE=y
 CONFIG_GENERATE_ACPI_TABLE=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 1301c16..3d8fdbf 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -4,7 +4,6 @@ CONFIG_DEFAULT_DEVICE_TREE="minnowmax"
 CONFIG_TARGET_MINNOWMAX=y
 CONFIG_INTERNAL_UART=y
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index c393d72..52d8d6e 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_ADVANTECH=y
 CONFIG_TARGET_SOM_DB5800_SOM_6867=y
 CONFIG_DEFAULT_DEVICE_TREE="baytrail_som-db5800-som-6867"
 CONFIG_DEBUG_UART=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index dee551b..bbc0fce 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -2,7 +2,6 @@ CONFIG_X86=y
 CONFIG_VENDOR_DFI=y
 CONFIG_DEFAULT_DEVICE_TREE="theadorable-x86-dfi-bt700"
 CONFIG_TARGET_DFI_BT700=y
-CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_VGA_BIOS_ADDR=0xfffa0000
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (7 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:11   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers Bin Meng
                   ` (12 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

This is a must have for all x86 boards.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/Kconfig                                            | 1 +
 configs/bayleybay_defconfig                             | 1 -
 configs/chromebook_link64_defconfig                     | 1 -
 configs/chromebook_link_defconfig                       | 1 -
 configs/chromebook_samus_defconfig                      | 1 -
 configs/chromebox_panther_defconfig                     | 1 -
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
 configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
 configs/coreboot-x86_defconfig                          | 1 -
 configs/cougarcanyon2_defconfig                         | 1 -
 configs/crownbay_defconfig                              | 1 -
 configs/dfi-bt700-q7x-151_defconfig                     | 1 -
 configs/edison_defconfig                                | 1 -
 configs/efi-x86_defconfig                               | 1 -
 configs/galileo_defconfig                               | 1 -
 configs/minnowmax_defconfig                             | 1 -
 configs/qemu-x86_64_defconfig                           | 1 -
 configs/qemu-x86_defconfig                              | 1 -
 configs/qemu-x86_efi_payload32_defconfig                | 1 -
 configs/qemu-x86_efi_payload64_defconfig                | 1 -
 configs/som-db5800-som-6867_defconfig                   | 1 -
 configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
 22 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index b062826..71dfeb3 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -89,6 +89,7 @@ config X86
 	select HAVE_PRIVATE_LIBGCC
 	select USE_PRIVATE_LIBGCC
 	select SUPPORT_OF_CONTROL
+	select OF_CONTROL
 	select DM
 	select DM_KEYBOARD
 	select DM_SERIAL
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 036ea20..858ee9f 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -38,7 +38,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index c8f6c2b..d418db9 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -50,7 +50,6 @@ CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
-CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_SPL_DM=y
 CONFIG_REGMAP=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index 83af9e1..8382a55 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -37,7 +37,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index 7af4898..a7ace13 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -37,7 +37,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 6cc2953..240fad5 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -33,7 +33,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index 20e64fd..e76f17a 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -40,7 +40,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 496479a..990604f 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -39,7 +39,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index ed9592c..d882438 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -30,7 +30,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SPI_FLASH=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index ea56e58..bedbc66 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -27,7 +27,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index af9c3c0..35d4e52 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -33,7 +33,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 193bb54..eb5ecb8 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -38,7 +38,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index 02c09aa..d4020f9 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -23,7 +23,6 @@ CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
-CONFIG_OF_CONTROL=y
 CONFIG_OF_EMBED=y
 CONFIG_CPU=y
 CONFIG_DFU_MMC=y
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 7495da4..416b544 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -28,7 +28,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_OF_EMBED=y
 CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index e8b11e4..948b8df 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -35,7 +35,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 3d8fdbf..29711c9 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -40,7 +40,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index bfd3881..a55f6f7 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -50,7 +50,6 @@ CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
-CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_SPL_DM=y
 CONFIG_REGMAP=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 679a254..3051cc8 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -34,7 +34,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index ca5b96a..5a1012f 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -31,7 +31,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index f70bae9..27f75d4 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -32,7 +32,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 52d8d6e..7e9d420 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -37,7 +37,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SCSI=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index bbc0fce..764bf4a 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -38,7 +38,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
-CONFIG_OF_CONTROL=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (8 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers Bin Meng
                   ` (11 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Now that all x86 boards have been converted to use DM, we can imply
these uclass drivers (DM_ETH, DM_RTC, DM_USB, DM_VIDEO) from the
top level.

Previously DM_GPIO, DM_KEYBOARD, DM_SERIAL, DM_SPI, DM_SPI_FLASH
are selected. Change to use 'imply' to allow them to be removed.

Note with this change, chromebook_link64 build fails:

common/built-in.o:(.data.env_htab+0xc): undefined reference to 'env_flags_validate'
lib/built-in.o: In function `hsearch_r':
lib/hashtable.c:380: undefined reference to 'env_callback_init'
lib/hashtable.c:382: undefined reference to 'env_flags_init'
make[1]: *** [spl/u-boot-spl] Error 1

CONFIG_SPL_ENV_SUPPORT is required for chromebook_link64 to build
again. This is just a workaround as it is not needed at all. See
commit bda40d5 "x86: qemu: Add a config for 64-bit U-Boot" for
the same issue seen on QEMU 64-bit target.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/Kconfig                                            | 16 ++++++++++------
 configs/bayleybay_defconfig                             |  4 ----
 configs/chromebook_link64_defconfig                     |  4 +---
 configs/chromebook_link_defconfig                       |  3 ---
 configs/chromebook_samus_defconfig                      |  3 ---
 configs/chromebox_panther_defconfig                     |  4 ----
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
 configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
 configs/coreboot-x86_defconfig                          |  4 ----
 configs/cougarcanyon2_defconfig                         |  3 ---
 configs/crownbay_defconfig                              |  4 ----
 configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
 configs/edison_defconfig                                |  1 -
 configs/efi-x86_defconfig                               |  3 +--
 configs/galileo_defconfig                               |  4 ----
 configs/minnowmax_defconfig                             |  4 ----
 configs/qemu-x86_64_defconfig                           |  4 ----
 configs/qemu-x86_defconfig                              |  4 ----
 configs/qemu-x86_efi_payload32_defconfig                |  4 ----
 configs/qemu-x86_efi_payload64_defconfig                |  4 ----
 configs/som-db5800-som-6867_defconfig                   |  4 ----
 configs/theadorable-x86-dfi-bt700_defconfig             |  4 ----
 22 files changed, 12 insertions(+), 81 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 71dfeb3..fef06d6 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -91,17 +91,21 @@ config X86
 	select SUPPORT_OF_CONTROL
 	select OF_CONTROL
 	select DM
-	select DM_KEYBOARD
-	select DM_SERIAL
-	select DM_GPIO
-	select PCI
 	select DM_PCI
-	select DM_SPI
-	select DM_SPI_FLASH
+	select PCI
 	select TIMER
 	select X86_TSC_TIMER
 	select USB
 	select USB_EHCI_HCD
+	imply DM_ETH
+	imply DM_GPIO
+	imply DM_KEYBOARD
+	imply DM_RTC
+	imply DM_SERIAL
+	imply DM_SPI
+	imply DM_SPI_FLASH
+	imply DM_USB
+	imply DM_VIDEO
 	imply CMD_FPGA_LOADMK
 	imply CMD_GETTIME
 	imply CMD_IO
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 858ee9f..4885103 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -50,15 +50,11 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index d418db9..ab01909 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -22,6 +22,7 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SPL_CPU_SUPPORT=y
+CONFIG_SPL_ENV_SUPPORT=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_NET_SUPPORT=y
 CONFIG_SPL_PCI_SUPPORT=y
@@ -68,17 +69,14 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index 8382a55..b1e2b6a 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -51,17 +51,14 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index a7ace13..e6d6fd6 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -48,17 +48,14 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_BROADWELL_IGD=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 240fad5..d86d416 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -44,16 +44,12 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index e76f17a..1ba6e1f 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -55,17 +55,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 990604f..3cceb26 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -54,17 +54,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index d882438..68406ba 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -36,15 +36,11 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_TPM_TIS_LPC=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_COREBOOT=y
 CONFIG_CONSOLE_SCROLL_LINES=5
 CONFIG_TPM=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index bedbc66..17ea047 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -4,7 +4,6 @@ CONFIG_DEFAULT_DEVICE_TREE="cougarcanyon2"
 CONFIG_TARGET_COUGARCANYON2=y
 # CONFIG_ENABLE_MRC_CACHE is not set
 CONFIG_ENV_IS_IN_SPI_FLASH=y
-CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
@@ -32,9 +31,7 @@ CONFIG_SYSCON=y
 CONFIG_SCSI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index 35d4e52..5d8f0a2 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -46,16 +46,12 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SST=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
 CONFIG_PCH_GBE=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index eb5ecb8..9cf146c 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -52,17 +52,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index d4020f9..e129fc6 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -33,7 +33,6 @@ CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_TANGIER=y
 CONFIG_DM_PCI_COMPAT=y
-CONFIG_DM_RTC=y
 CONFIG_INTEL_MID_SERIAL=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GADGET=y
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 416b544..47843f7 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -5,7 +5,6 @@ CONFIG_TARGET_EFI=y
 CONFIG_DEBUG_UART=y
 CONFIG_FIT=y
 CONFIG_ENV_IS_NOWHERE=y
-CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_BOOTM is not set
@@ -18,7 +17,6 @@ CONFIG_CMD_GPIO=y
 # CONFIG_CMD_NET is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
-CONFIG_CMD_DATE=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
@@ -29,6 +27,7 @@ CONFIG_MAC_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_OF_EMBED=y
+# CONFIG_DM_ETH is not set
 CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
 CONFIG_DEBUG_UART_CLOCK=0
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 948b8df..492b6cd 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -9,7 +9,6 @@ CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
-CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -47,11 +46,8 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 29711c9..3a5b75b 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -53,18 +53,14 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_RTL8169=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index a55f6f7..83b2dc7 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -61,16 +61,12 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 3051cc8..9723db5 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -41,14 +41,10 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 5a1012f..d7f1d5f 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -38,14 +38,10 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index 27f75d4..0d94ed0 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -39,14 +39,10 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 7e9d420..0795b1f 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -46,17 +46,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 764bf4a..ffb0332 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -53,15 +53,11 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_DM_ETH=y
 CONFIG_E1000=y
-CONFIG_DM_RTC=y
 CONFIG_SYS_NS16550=y
 CONFIG_ICH_SPI=y
-CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_DM_VIDEO=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (9 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 12/22] x86: ivybridge: " Bin Meng
                   ` (10 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

BayTrail integrates lots of peripherals that have U-Boot drivers.
Imply those in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/baytrail/Kconfig                           | 11 ++++++++++-
 configs/bayleybay_defconfig                             |  9 ---------
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  8 --------
 configs/conga-qeval20-qa3-e3845_defconfig               |  8 --------
 configs/dfi-bt700-q7x-151_defconfig                     |  8 --------
 configs/minnowmax_defconfig                             |  9 ---------
 configs/som-db5800-som-6867_defconfig                   |  5 -----
 configs/theadorable-x86-dfi-bt700_defconfig             |  8 --------
 8 files changed, 10 insertions(+), 56 deletions(-)

diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 57a3a96..9f4947d 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -8,9 +8,18 @@ config INTEL_BAYTRAIL
 	bool
 	select HAVE_FSP if !EFI
 	select ARCH_MISC_INIT if !EFI
-	imply ENV_IS_IN_SPI_FLASH
 	imply HAVE_INTEL_ME if !EFI
 	imply ENABLE_MRC_CACHE
+	imply ENV_IS_IN_SPI_FLASH
+	imply ICH_SPI
+	imply MMC
+	imply MMC_PCI
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply SCSI
+	imply SPI_FLASH
+	imply SYS_NS16550
+	imply VIDEO_VESA
 
 if INTEL_BAYTRAIL
 config INTERNAL_UART
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 4885103..a63e7cf 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -40,22 +40,13 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_CPU=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index 1ba6e1f..c164f32 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -46,11 +46,6 @@ CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_WINBOND_W83627=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
@@ -58,11 +53,8 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 3cceb26..e75fae5 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -45,11 +45,6 @@ CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_WINBOND_W83627=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
@@ -57,11 +52,8 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 9cf146c..85311ba 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -43,11 +43,6 @@ CONFIG_SYSCON=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_NUVOTON_NCT6102D=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
@@ -55,11 +50,8 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 3a5b75b..b7b5ebe 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -42,13 +42,7 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_CPU=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
@@ -56,12 +50,9 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_RTL8169=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 0795b1f..81e31d9 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -39,9 +39,7 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_STMICRO=y
@@ -49,11 +47,8 @@ CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index ffb0332..748554d 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -43,22 +43,14 @@ CONFIG_SYSCON=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_NUVOTON_NCT6102D=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_114=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 12/22] x86: ivybridge: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (10 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 13/22] x86: broadwell: " Bin Meng
                   ` (9 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply drivers that are working with Ivybridge platform in the
platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply ENV_IS_IN_SPI_FLASH for ivybridge

 arch/x86/cpu/ivybridge/Kconfig      | 5 +++++
 configs/chromebook_link64_defconfig | 5 -----
 configs/chromebook_link_defconfig   | 5 -----
 configs/chromebox_panther_defconfig | 5 -----
 configs/cougarcanyon2_defconfig     | 5 +----
 5 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/arch/x86/cpu/ivybridge/Kconfig b/arch/x86/cpu/ivybridge/Kconfig
index 5df5e3a..82af7ac 100644
--- a/arch/x86/cpu/ivybridge/Kconfig
+++ b/arch/x86/cpu/ivybridge/Kconfig
@@ -10,6 +10,11 @@ config NORTHBRIDGE_INTEL_IVYBRIDGE
 	select CACHE_MRC_BIN if HAVE_MRC
 	imply HAVE_INTEL_ME
 	imply ENABLE_MRC_CACHE
+	imply ENV_IS_IN_SPI_FLASH
+	imply ICH_SPI
+	imply SCSI
+	imply SPI_FLASH
+	imply VIDEO_VESA
 
 if NORTHBRIDGE_INTEL_IVYBRIDGE
 
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index ab01909..9cdd84c 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -18,7 +18,6 @@ CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SPL_CPU_SUPPORT=y
@@ -57,7 +56,6 @@ CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SPL_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CPU=y
@@ -65,7 +63,6 @@ CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
@@ -73,11 +70,9 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_IVYBRIDGE_IGD=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index b1e2b6a..eb272cc 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -10,7 +10,6 @@ CONFIG_HAVE_VGA_BIOS=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -39,7 +38,6 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CPU=y
@@ -47,7 +45,6 @@ CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
@@ -55,11 +52,9 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_VIDEO_IVYBRIDGE_IGD=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index d86d416..12e87d1 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -7,7 +7,6 @@ CONFIG_HAVE_VGA_BIOS=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
@@ -35,22 +34,18 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_RTL8169=y
 CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 17ea047..fabed53 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -3,7 +3,6 @@ CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="cougarcanyon2"
 CONFIG_TARGET_COUGARCANYON2=y
 # CONFIG_ENABLE_MRC_CACHE is not set
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
@@ -28,10 +27,8 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
+# CONFIG_VIDEO_VESA is not set
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 13/22] x86: broadwell: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (11 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 12/22] x86: ivybridge: " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful Bin Meng
                   ` (8 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply Broadwell-specific drivers in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply ENV_IS_IN_SPI_FLASH for broadwell

 arch/x86/cpu/broadwell/Kconfig     | 6 ++++++
 configs/chromebook_samus_defconfig | 6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/cpu/broadwell/Kconfig b/arch/x86/cpu/broadwell/Kconfig
index a9a461d..c56f90d 100644
--- a/arch/x86/cpu/broadwell/Kconfig
+++ b/arch/x86/cpu/broadwell/Kconfig
@@ -9,6 +9,12 @@ config INTEL_BROADWELL
 	select ARCH_EARLY_INIT_R
 	imply HAVE_INTEL_ME
 	imply ENABLE_MRC_CACHE
+	imply ENV_IS_IN_SPI_FLASH
+	imply ICH_SPI
+	imply INTEL_BROADWELL_GPIO
+	imply SCSI
+	imply SPI_FLASH
+	imply VIDEO_BROADWELL_IGD
 
 if INTEL_BROADWELL
 
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index e6d6fd6..2976097 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -10,7 +10,6 @@ CONFIG_SMP=y
 CONFIG_HAVE_VGA_BIOS=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -39,12 +38,9 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_CPU=y
-CONFIG_INTEL_BROADWELL_GPIO=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
@@ -52,12 +48,10 @@ CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
 CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_11A=y
-CONFIG_VIDEO_BROADWELL_IGD=y
 CONFIG_CONSOLE_SCROLL_LINES=5
 CONFIG_TPM=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (12 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 13/22] x86: broadwell: " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers Bin Meng
                   ` (7 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

U-Boot as coreboot payload can run on any x86 hardware ideally.
Let's imply some common drivers that are useful.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply more common drivers for coreboot

 arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
 configs/coreboot-x86_defconfig |  5 -----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
index 9820651..31fe17b 100644
--- a/arch/x86/cpu/coreboot/Kconfig
+++ b/arch/x86/cpu/coreboot/Kconfig
@@ -3,6 +3,16 @@ if TARGET_COREBOOT
 config SYS_COREBOOT
 	bool
 	default y
+	imply ENV_IS_NOWHERE
+	imply E1000
+	imply ICH_SPI
+	imply MMC
+	imply MMC_PCI
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply SPI_FLASH
+	imply SYS_NS16550
+	imply VIDEO_COREBOOT
 	imply CMD_CBFS
 	imply FS_CBFS
 
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 68406ba..ef5d75b 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -4,7 +4,6 @@ CONFIG_TARGET_COREBOOT=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMLS is not set
@@ -32,15 +31,11 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_COREBOOT=y
 CONFIG_CONSOLE_SCROLL_LINES=5
 CONFIG_TPM=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (13 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 16/22] x86: tangier: " Bin Meng
                   ` (6 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply drivers that work with Intel Queensbay platform.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply ENV_IS_IN_SPI_FLASH for queensbay

 arch/x86/cpu/queensbay/Kconfig | 11 +++++++++++
 configs/crownbay_defconfig     | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/x86/cpu/queensbay/Kconfig b/arch/x86/cpu/queensbay/Kconfig
index e2dfe19..6e47ee5 100644
--- a/arch/x86/cpu/queensbay/Kconfig
+++ b/arch/x86/cpu/queensbay/Kconfig
@@ -9,6 +9,17 @@ config INTEL_QUEENSBAY
 	select HAVE_FSP
 	select HAVE_CMC
 	select ARCH_EARLY_INIT_R
+	imply ENV_IS_IN_SPI_FLASH
+	imply ICH_SPI
+	imply MMC
+	imply MMC_PCI
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply PCH_GBE
+	imply SCSI
+	imply SPI_FLASH
+	imply SYS_NS16550
+	imply VIDEO_VESA
 
 if INTEL_QUEENSBAY
 
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index 5d8f0a2..1ec8744 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -8,7 +8,6 @@ CONFIG_HAVE_VGA_BIOS=y
 CONFIG_GENERATE_PIRQ_TABLE=y
 CONFIG_GENERATE_MP_TABLE=y
 CONFIG_FIT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -35,23 +34,13 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SCSI=y
 CONFIG_CPU=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SST=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
-CONFIG_PCH_GBE=y
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 16/22] x86: tangier: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (14 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 17/22] x86: quark: " Bin Meng
                   ` (5 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply Tangier-specific drivers in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/x86/cpu/tangier/Kconfig | 7 +++++++
 configs/edison_defconfig     | 7 -------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/x86/cpu/tangier/Kconfig b/arch/x86/cpu/tangier/Kconfig
index b67c6a7..e7d16db 100644
--- a/arch/x86/cpu/tangier/Kconfig
+++ b/arch/x86/cpu/tangier/Kconfig
@@ -7,6 +7,13 @@
 config INTEL_TANGIER
 	bool
 	depends on INTEL_MID
+	imply INTEL_MID_SERIAL
+	imply MMC
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply MMC_SDHCI_TANGIER
+	imply TANGIER_WATCHDOG
+	imply USB_DWC3
 
 config SYS_CAR_ADDR
 	hex
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index e129fc6..cefcfa8 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -27,20 +27,13 @@ CONFIG_OF_EMBED=y
 CONFIG_CPU=y
 CONFIG_DFU_MMC=y
 CONFIG_DFU_RAM=y
-CONFIG_MMC=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_MMC_SDHCI_TANGIER=y
 CONFIG_DM_PCI_COMPAT=y
-CONFIG_INTEL_MID_SERIAL=y
-CONFIG_USB_DWC3=y
 CONFIG_USB_DWC3_GADGET=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Intel"
 CONFIG_G_DNL_VENDOR_NUM=0x8087
 CONFIG_G_DNL_PRODUCT_NUM=0x0a99
-CONFIG_TANGIER_WATCHDOG=y
 CONFIG_FAT_WRITE=y
 CONFIG_SHA1=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 17/22] x86: quark: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (15 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 16/22] x86: tangier: " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 18/22] x86: qemu: " Bin Meng
                   ` (4 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply Quark-specific drivers in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply ENV_IS_IN_SPI_FLASH for quark

 arch/x86/cpu/quark/Kconfig | 9 +++++++++
 configs/galileo_defconfig  | 9 ---------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index 68bb219..46dade3 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -10,6 +10,15 @@ config INTEL_QUARK
 	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
 	imply ENABLE_MRC_CACHE
+	imply ENV_IS_IN_SPI_FLASH
+	imply ETH_DESIGNWARE
+	imply ICH_SPI
+	imply MMC
+	imply MMC_PCI
+	imply MMC_SDHCI
+	imply MMC_SDHCI_SDMA
+	imply SPI_FLASH
+	imply SYS_NS16550
 
 if INTEL_QUARK
 
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 492b6cd..963ae81 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -8,7 +8,6 @@ CONFIG_GENERATE_ACPI_TABLE=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -38,16 +37,8 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_MMC=y
-CONFIG_MMC_PCI=y
-CONFIG_MMC_SDHCI=y
-CONFIG_MMC_SDHCI_SDMA=y
-CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_ETH_DESIGNWARE=y
-CONFIG_SYS_NS16550=y
-CONFIG_ICH_SPI=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 18/22] x86: qemu: kconfig: Imply platform specific drivers
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (16 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 17/22] x86: quark: " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs Bin Meng
                   ` (3 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Imply Qemu-specific drivers in the platform Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- imply ENV_IS_NOWHERE for qemu

 arch/x86/cpu/qemu/Kconfig                | 4 ++++
 configs/qemu-x86_64_defconfig            | 4 ----
 configs/qemu-x86_defconfig               | 4 ----
 configs/qemu-x86_efi_payload32_defconfig | 4 ----
 configs/qemu-x86_efi_payload64_defconfig | 4 ----
 5 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
index 6f61744..ef0fd30 100644
--- a/arch/x86/cpu/qemu/Kconfig
+++ b/arch/x86/cpu/qemu/Kconfig
@@ -7,6 +7,10 @@
 config QEMU
 	bool
 	select ARCH_EARLY_INIT_R
+	imply ENV_IS_NOWHERE
+	imply E1000
+	imply SYS_NS16550
+	imply VIDEO_VESA
 
 if QEMU
 
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 83b2dc7..c203725 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -19,7 +19,6 @@ CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SPL_CPU_SUPPORT=y
@@ -61,13 +60,10 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_SYS_NS16550=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 9723db5..9a674be 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -8,7 +8,6 @@ CONFIG_GENERATE_ACPI_TABLE=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -41,11 +40,8 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index d7f1d5f..1e0f7a2 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -5,7 +5,6 @@ CONFIG_SMP=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -38,11 +37,8 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index 0d94ed0..440328f 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -5,7 +5,6 @@ CONFIG_SMP=y
 CONFIG_FIT=y
 CONFIG_BOOTSTAGE=y
 CONFIG_BOOTSTAGE_REPORT=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_CPU=y
@@ -39,11 +38,8 @@ CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_E1000=y
-CONFIG_SYS_NS16550=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 CONFIG_CONSOLE_SCROLL_LINES=5
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (17 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 18/22] x86: qemu: " Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash Bin Meng
                   ` (2 subsequent siblings)
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

QEMU does not support ICH SPI controller yet. It's meaningless to
include SPI flash support.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 configs/qemu-x86_64_defconfig            | 5 -----
 configs/qemu-x86_defconfig               | 4 ----
 configs/qemu-x86_efi_payload32_defconfig | 4 ----
 configs/qemu-x86_efi_payload64_defconfig | 4 ----
 4 files changed, 17 deletions(-)

diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index c203725..bda94ab 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x1000
 CONFIG_MAX_CPUS=2
 CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
-CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI_SUPPORT=y
 CONFIG_X86_RUN_64BIT=y
 CONFIG_DEFAULT_DEVICE_TREE="qemu-x86_i440fx"
@@ -56,10 +55,6 @@ CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_SPL_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_USB_STORAGE=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index 9a674be..068b1cd 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -36,10 +36,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index 1e0f7a2..5f1045a 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -33,10 +33,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index 440328f..d76f7fd 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -34,10 +34,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (18 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig Bin Meng
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig Bin Meng
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Only a specific type of SPI flash exists on a board, having board
Kconfig to select the SPI flash seems to make more sense. Other
flash types are not necessary except coreboot, which implies all
available flash drivers there.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2: None

 board/advantech/som-db5800-som-6867/Kconfig             |  1 +
 board/congatec/conga-qeval20-qa3-e3845/Kconfig          |  1 +
 board/coreboot/coreboot/Kconfig                         | 11 +++++++++++
 board/dfi/dfi-bt700/Kconfig                             |  1 +
 board/google/chromebook_link/Kconfig                    |  1 +
 board/google/chromebook_samus/Kconfig                   |  1 +
 board/google/chromebox_panther/Kconfig                  |  1 +
 board/intel/bayleybay/Kconfig                           |  1 +
 board/intel/cougarcanyon2/Kconfig                       |  1 +
 board/intel/crownbay/Kconfig                            |  1 +
 board/intel/galileo/Kconfig                             |  1 +
 board/intel/minnowmax/Kconfig                           |  1 +
 configs/bayleybay_defconfig                             |  3 ---
 configs/chromebook_link64_defconfig                     |  3 ---
 configs/chromebook_link_defconfig                       |  3 ---
 configs/chromebook_samus_defconfig                      |  3 ---
 configs/chromebox_panther_defconfig                     |  3 ---
 configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
 configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
 configs/coreboot-x86_defconfig                          |  3 ---
 configs/cougarcanyon2_defconfig                         |  1 -
 configs/crownbay_defconfig                              |  4 ----
 configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
 configs/galileo_defconfig                               |  3 ---
 configs/minnowmax_defconfig                             |  4 ----
 configs/som-db5800-som-6867_defconfig                   |  4 ----
 configs/theadorable-x86-dfi-bt700_defconfig             |  5 -----
 27 files changed, 22 insertions(+), 51 deletions(-)

diff --git a/board/advantech/som-db5800-som-6867/Kconfig b/board/advantech/som-db5800-som-6867/Kconfig
index 945aa43..fac562a 100644
--- a/board/advantech/som-db5800-som-6867/Kconfig
+++ b/board/advantech/som-db5800-som-6867/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
 	select BOARD_EARLY_INIT_F
+	select SPI_FLASH_MACRONIX
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/board/congatec/conga-qeval20-qa3-e3845/Kconfig b/board/congatec/conga-qeval20-qa3-e3845/Kconfig
index f91ffa1..c2649d2 100644
--- a/board/congatec/conga-qeval20-qa3-e3845/Kconfig
+++ b/board/congatec/conga-qeval20-qa3-e3845/Kconfig
@@ -23,6 +23,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_8192
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SPI_FLASH_STMICRO
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/board/coreboot/coreboot/Kconfig b/board/coreboot/coreboot/Kconfig
index 3ff64f4..cfa1d50 100644
--- a/board/coreboot/coreboot/Kconfig
+++ b/board/coreboot/coreboot/Kconfig
@@ -12,6 +12,17 @@ config SYS_SOC
 config SYS_TEXT_BASE
 	default 0x01110000
 
+config BOARD_SPECIFIC_OPTIONS # dummy
+	def_bool y
+	imply SPI_FLASH_ATMEL
+	imply SPI_FLASH_EON
+	imply SPI_FLASH_GIGADEVICE
+	imply SPI_FLASH_MACRONIX
+	imply SPI_FLASH_SPANSION
+	imply SPI_FLASH_STMICRO
+	imply SPI_FLASH_SST
+	imply SPI_FLASH_WINBOND
+
 comment "coreboot-specific options"
 
 config SYS_CONFIG_NAME
diff --git a/board/dfi/dfi-bt700/Kconfig b/board/dfi/dfi-bt700/Kconfig
index 59f45ef..81a2575 100644
--- a/board/dfi/dfi-bt700/Kconfig
+++ b/board/dfi/dfi-bt700/Kconfig
@@ -23,6 +23,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_8192
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SPI_FLASH_STMICRO
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/board/google/chromebook_link/Kconfig b/board/google/chromebook_link/Kconfig
index 8999b58..944716d 100644
--- a/board/google/chromebook_link/Kconfig
+++ b/board/google/chromebook_link/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select NORTHBRIDGE_INTEL_IVYBRIDGE
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
+	select SPI_FLASH_WINBOND
 
 config PCIE_ECAM_BASE
 	default 0xf0000000
diff --git a/board/google/chromebook_samus/Kconfig b/board/google/chromebook_samus/Kconfig
index f2b9481..afbfe53 100644
--- a/board/google/chromebook_samus/Kconfig
+++ b/board/google/chromebook_samus/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select INTEL_BROADWELL
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
+	select SPI_FLASH_WINBOND
 
 config PCIE_ECAM_BASE
 	default 0xf0000000
diff --git a/board/google/chromebox_panther/Kconfig b/board/google/chromebox_panther/Kconfig
index 2af3aa9..875df9d 100644
--- a/board/google/chromebox_panther/Kconfig
+++ b/board/google/chromebox_panther/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select NORTHBRIDGE_INTEL_IVYBRIDGE
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
+	select SPI_FLASH_WINBOND
 
 config SYS_CAR_ADDR
 	hex
diff --git a/board/intel/bayleybay/Kconfig b/board/intel/bayleybay/Kconfig
index 597228f..a622499 100644
--- a/board/intel/bayleybay/Kconfig
+++ b/board/intel/bayleybay/Kconfig
@@ -20,6 +20,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
+	select SPI_FLASH_WINBOND
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/board/intel/cougarcanyon2/Kconfig b/board/intel/cougarcanyon2/Kconfig
index 4e7d021..ed76448 100644
--- a/board/intel/cougarcanyon2/Kconfig
+++ b/board/intel/cougarcanyon2/Kconfig
@@ -22,5 +22,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_FSP
 	select BOARD_ROMSIZE_KB_2048
 	select BOARD_EARLY_INIT_F
+	select SPI_FLASH_WINBOND
 
 endif
diff --git a/board/intel/crownbay/Kconfig b/board/intel/crownbay/Kconfig
index 05626a9..1eed227 100644
--- a/board/intel/crownbay/Kconfig
+++ b/board/intel/crownbay/Kconfig
@@ -21,5 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select INTEL_QUEENSBAY
 	select BOARD_ROMSIZE_KB_1024
 	select BOARD_EARLY_INIT_F
+	select SPI_FLASH_SST
 
 endif
diff --git a/board/intel/galileo/Kconfig b/board/intel/galileo/Kconfig
index 87a0ec4..1416c89 100644
--- a/board/intel/galileo/Kconfig
+++ b/board/intel/galileo/Kconfig
@@ -20,6 +20,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR
 	select INTEL_QUARK
 	select BOARD_ROMSIZE_KB_1024
+	select SPI_FLASH_WINBOND
 
 config SMBIOS_PRODUCT_NAME
 	default "GalileoGen2"
diff --git a/board/intel/minnowmax/Kconfig b/board/intel/minnowmax/Kconfig
index 7e975f9..a8668e4 100644
--- a/board/intel/minnowmax/Kconfig
+++ b/board/intel/minnowmax/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select X86_RESET_VECTOR if !EFI_STUB
 	select INTEL_BAYTRAIL
 	select BOARD_ROMSIZE_KB_8192
+	select SPI_FLASH_STMICRO
 
 config PCIE_ECAM_BASE
 	default 0xe0000000
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index a63e7cf..f12503a 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -41,9 +41,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 9cdd84c..8da05cd 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -63,9 +63,6 @@ CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index eb272cc..69cdc6c 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -45,9 +45,6 @@ CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index 2976097..0a2cbb8 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -41,9 +41,6 @@ CONFIG_SYSCON=y
 CONFIG_CPU=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
 CONFIG_DEBUG_UART_BOARD_INIT=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 12e87d1..f325ba4 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -38,9 +38,6 @@ CONFIG_DM_SCSI=y
 CONFIG_BLK=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_LPC=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_RTL8169=y
 CONFIG_SYS_NS16550=y
 CONFIG_TPM_TIS_LPC=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index c164f32..ff058f9 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -46,10 +46,6 @@ CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_WINBOND_W83627=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index e75fae5..e4f9713 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -45,10 +45,6 @@ CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_INTEL=y
 CONFIG_WINBOND_W83627=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index ef5d75b..a137972 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -31,9 +31,6 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_TPM_TIS_LPC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index fabed53..d347c0a 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -27,7 +27,6 @@ CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index 1ec8744..a17aa75 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -35,10 +35,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_SST=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index 85311ba..13d911c 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -43,10 +43,6 @@ CONFIG_SYSCON=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_NUVOTON_NCT6102D=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 963ae81..fb6e84f 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -37,8 +37,5 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index b7b5ebe..5a770a9 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -43,10 +43,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_RTL8169=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 81e31d9..4c60d03 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -40,10 +40,6 @@ CONFIG_EFI_PARTITION=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_CPU=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 748554d..29d48b6 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -43,11 +43,6 @@ CONFIG_SYSCON=y
 CONFIG_CPU=y
 CONFIG_DM_I2C=y
 CONFIG_NUVOTON_NCT6102D=y
-CONFIG_SPI_FLASH_GIGADEVICE=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_SPI_FLASH_SPANSION=y
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_E1000=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (19 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig Bin Meng
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

Like other peripheral drivers, move USB related drivers to platform
Kconfig as well.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---

Changes in v2: None

 arch/Kconfig                   | 2 --
 arch/x86/cpu/baytrail/Kconfig  | 3 +++
 arch/x86/cpu/broadwell/Kconfig | 2 ++
 arch/x86/cpu/coreboot/Kconfig  | 3 +++
 arch/x86/cpu/ivybridge/Kconfig | 2 ++
 arch/x86/cpu/qemu/Kconfig      | 2 ++
 arch/x86/cpu/quark/Kconfig     | 2 ++
 arch/x86/cpu/queensbay/Kconfig | 2 ++
 arch/x86/cpu/tangier/Kconfig   | 1 +
 configs/efi-x86_defconfig      | 2 --
 configs/minnowmax_defconfig    | 1 -
 11 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index fef06d6..99617b7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -95,8 +95,6 @@ config X86
 	select PCI
 	select TIMER
 	select X86_TSC_TIMER
-	select USB
-	select USB_EHCI_HCD
 	imply DM_ETH
 	imply DM_GPIO
 	imply DM_KEYBOARD
diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 9f4947d..7ea43b9 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -19,6 +19,9 @@ config INTEL_BAYTRAIL
 	imply SCSI
 	imply SPI_FLASH
 	imply SYS_NS16550
+	imply USB
+	imply USB_EHCI_HCD
+	imply USB_XHCI_HCD
 	imply VIDEO_VESA
 
 if INTEL_BAYTRAIL
diff --git a/arch/x86/cpu/broadwell/Kconfig b/arch/x86/cpu/broadwell/Kconfig
index c56f90d..7e71325 100644
--- a/arch/x86/cpu/broadwell/Kconfig
+++ b/arch/x86/cpu/broadwell/Kconfig
@@ -14,6 +14,8 @@ config INTEL_BROADWELL
 	imply INTEL_BROADWELL_GPIO
 	imply SCSI
 	imply SPI_FLASH
+	imply USB
+	imply USB_EHCI_HCD
 	imply VIDEO_BROADWELL_IGD
 
 if INTEL_BROADWELL
diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
index 31fe17b..07d3fb8 100644
--- a/arch/x86/cpu/coreboot/Kconfig
+++ b/arch/x86/cpu/coreboot/Kconfig
@@ -12,6 +12,9 @@ config SYS_COREBOOT
 	imply MMC_SDHCI_SDMA
 	imply SPI_FLASH
 	imply SYS_NS16550
+	imply USB
+	imply USB_EHCI_HCD
+	imply USB_XHCI_HCD
 	imply VIDEO_COREBOOT
 	imply CMD_CBFS
 	imply FS_CBFS
diff --git a/arch/x86/cpu/ivybridge/Kconfig b/arch/x86/cpu/ivybridge/Kconfig
index 82af7ac..5630da0 100644
--- a/arch/x86/cpu/ivybridge/Kconfig
+++ b/arch/x86/cpu/ivybridge/Kconfig
@@ -14,6 +14,8 @@ config NORTHBRIDGE_INTEL_IVYBRIDGE
 	imply ICH_SPI
 	imply SCSI
 	imply SPI_FLASH
+	imply USB
+	imply USB_EHCI_HCD
 	imply VIDEO_VESA
 
 if NORTHBRIDGE_INTEL_IVYBRIDGE
diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig
index ef0fd30..b6297f7 100644
--- a/arch/x86/cpu/qemu/Kconfig
+++ b/arch/x86/cpu/qemu/Kconfig
@@ -10,6 +10,8 @@ config QEMU
 	imply ENV_IS_NOWHERE
 	imply E1000
 	imply SYS_NS16550
+	imply USB
+	imply USB_EHCI_HCD
 	imply VIDEO_VESA
 
 if QEMU
diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index 46dade3..ce0c454 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -19,6 +19,8 @@ config INTEL_QUARK
 	imply MMC_SDHCI_SDMA
 	imply SPI_FLASH
 	imply SYS_NS16550
+	imply USB
+	imply USB_EHCI_HCD
 
 if INTEL_QUARK
 
diff --git a/arch/x86/cpu/queensbay/Kconfig b/arch/x86/cpu/queensbay/Kconfig
index 6e47ee5..9b9c756 100644
--- a/arch/x86/cpu/queensbay/Kconfig
+++ b/arch/x86/cpu/queensbay/Kconfig
@@ -19,6 +19,8 @@ config INTEL_QUEENSBAY
 	imply SCSI
 	imply SPI_FLASH
 	imply SYS_NS16550
+	imply USB
+	imply USB_EHCI_HCD
 	imply VIDEO_VESA
 
 if INTEL_QUEENSBAY
diff --git a/arch/x86/cpu/tangier/Kconfig b/arch/x86/cpu/tangier/Kconfig
index e7d16db..86a3340 100644
--- a/arch/x86/cpu/tangier/Kconfig
+++ b/arch/x86/cpu/tangier/Kconfig
@@ -13,6 +13,7 @@ config INTEL_TANGIER
 	imply MMC_SDHCI_SDMA
 	imply MMC_SDHCI_TANGIER
 	imply TANGIER_WATCHDOG
+	imply USB
 	imply USB_DWC3
 
 config SYS_CAR_ADDR
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 47843f7..d45932b 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -32,7 +32,5 @@ CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
 CONFIG_DEBUG_UART_CLOCK=0
 CONFIG_ICH_SPI=y
-CONFIG_USB_STORAGE=y
-CONFIG_USB_KEYBOARD=y
 CONFIG_EFI=y
 # CONFIG_EFI_LOADER is not set
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 5a770a9..0d58848 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -46,7 +46,6 @@ CONFIG_CPU=y
 CONFIG_RTL8169=y
 CONFIG_DEBUG_UART_BASE=0x3f8
 CONFIG_DEBUG_UART_CLOCK=1843200
-CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig
  2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
                   ` (20 preceding siblings ...)
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig Bin Meng
@ 2017-07-30 13:23 ` Bin Meng
  2017-08-01  9:12   ` Simon Glass
  21 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-07-30 13:23 UTC (permalink / raw)
  To: u-boot

This converts Intel ICH6 GPIO driver to Kconfig, and add it to the
imply list of platform drivers.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

Changes in v2:
- rebase on top of u-boot/master

 arch/x86/cpu/baytrail/Kconfig  | 1 +
 arch/x86/cpu/ivybridge/Kconfig | 1 +
 arch/x86/cpu/quark/Kconfig     | 1 +
 arch/x86/cpu/queensbay/Kconfig | 1 +
 drivers/gpio/Kconfig           | 6 ++++++
 include/configs/efi-x86.h      | 1 -
 include/configs/qemu-x86.h     | 3 ---
 include/configs/x86-common.h   | 3 ---
 scripts/config_whitelist.txt   | 1 -
 9 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 7ea43b9..052d77f 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -12,6 +12,7 @@ config INTEL_BAYTRAIL
 	imply ENABLE_MRC_CACHE
 	imply ENV_IS_IN_SPI_FLASH
 	imply ICH_SPI
+	imply INTEL_ICH6_GPIO
 	imply MMC
 	imply MMC_PCI
 	imply MMC_SDHCI
diff --git a/arch/x86/cpu/ivybridge/Kconfig b/arch/x86/cpu/ivybridge/Kconfig
index 5630da0..7bac4c5 100644
--- a/arch/x86/cpu/ivybridge/Kconfig
+++ b/arch/x86/cpu/ivybridge/Kconfig
@@ -12,6 +12,7 @@ config NORTHBRIDGE_INTEL_IVYBRIDGE
 	imply ENABLE_MRC_CACHE
 	imply ENV_IS_IN_SPI_FLASH
 	imply ICH_SPI
+	imply INTEL_ICH6_GPIO
 	imply SCSI
 	imply SPI_FLASH
 	imply USB
diff --git a/arch/x86/cpu/quark/Kconfig b/arch/x86/cpu/quark/Kconfig
index ce0c454..7ec46e9 100644
--- a/arch/x86/cpu/quark/Kconfig
+++ b/arch/x86/cpu/quark/Kconfig
@@ -13,6 +13,7 @@ config INTEL_QUARK
 	imply ENV_IS_IN_SPI_FLASH
 	imply ETH_DESIGNWARE
 	imply ICH_SPI
+	imply INTEL_ICH6_GPIO
 	imply MMC
 	imply MMC_PCI
 	imply MMC_SDHCI
diff --git a/arch/x86/cpu/queensbay/Kconfig b/arch/x86/cpu/queensbay/Kconfig
index 9b9c756..80b6bc5 100644
--- a/arch/x86/cpu/queensbay/Kconfig
+++ b/arch/x86/cpu/queensbay/Kconfig
@@ -11,6 +11,7 @@ config INTEL_QUEENSBAY
 	select ARCH_EARLY_INIT_R
 	imply ENV_IS_IN_SPI_FLASH
 	imply ICH_SPI
+	imply INTEL_ICH6_GPIO
 	imply MMC
 	imply MMC_PCI
 	imply MMC_SDHCI
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 15135e5..63951e0 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -67,6 +67,12 @@ config INTEL_BROADWELL_GPIO
 	  driver from the common Intel ICH6 driver. It supports a total of
 	  95 GPIOs which can be configured from the device tree.
 
+config INTEL_ICH6_GPIO
+	bool "Intel ICH6 compatible legacy GPIO driver"
+	depends on DM_GPIO
+	help
+	  Say yes here to select Intel ICH6 compatible legacy GPIO driver.
+
 config IMX_RGPIO2P
 	bool "i.MX7ULP RGPIO2P driver"
 	depends on DM
diff --git a/include/configs/efi-x86.h b/include/configs/efi-x86.h
index f533191..4a6b665 100644
--- a/include/configs/efi-x86.h
+++ b/include/configs/efi-x86.h
@@ -14,7 +14,6 @@
 #undef CONFIG_TPM_TIS_BASE_ADDRESS
 
 #undef CONFIG_SCSI_AHCI
-#undef CONFIG_INTEL_ICH6_GPIO
 #undef CONFIG_USB_EHCI_PCI
 
 #define CONFIG_STD_DEVICES_SETTINGS     "stdin=usbkbd,vga,serial\0" \
diff --git a/include/configs/qemu-x86.h b/include/configs/qemu-x86.h
index 64cbc80..033b5e2 100644
--- a/include/configs/qemu-x86.h
+++ b/include/configs/qemu-x86.h
@@ -44,9 +44,6 @@
 	{PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_AHCI}
 #endif
 
-/* GPIO is not supported */
-#undef CONFIG_INTEL_ICH6_GPIO
-
 /* SPI is not supported */
 
 #define CONFIG_SPL_FRAMEWORK
diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
index aa1e505..a70fc9d 100644
--- a/include/configs/x86-common.h
+++ b/include/configs/x86-common.h
@@ -63,9 +63,6 @@
 
 #define CONFIG_SUPPORT_VFAT
 
-/* x86 GPIOs are accessed through a PCI device */
-#define CONFIG_INTEL_ICH6_GPIO
-
 /*-----------------------------------------------------------------------
  * Command line configuration.
  */
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
index 2d642de..1019bd9 100644
--- a/scripts/config_whitelist.txt
+++ b/scripts/config_whitelist.txt
@@ -1156,7 +1156,6 @@ CONFIG_INI_MAX_LINE
 CONFIG_INI_MAX_NAME
 CONFIG_INI_MAX_SECTION
 CONFIG_INTEGRITY
-CONFIG_INTEL_ICH6_GPIO
 CONFIG_INTERRUPTS
 CONFIG_IO
 CONFIG_IO64
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Without a timer, U-Boot just doesn't boot. This is not something
> we can turn off.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> ---
>
> Changes in v2:
> - sync defconfigs
>
>  arch/Kconfig                                            | 2 ++
>  configs/bayleybay_defconfig                             | 3 +--
>  configs/chromebook_link64_defconfig                     | 5 ++---
>  configs/chromebook_link_defconfig                       | 5 ++---
>  configs/chromebook_samus_defconfig                      | 3 +--
>  configs/chromebox_panther_defconfig                     | 5 ++---
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/coreboot-x86_defconfig                          | 1 -
>  configs/cougarcanyon2_defconfig                         | 3 +--
>  configs/crownbay_defconfig                              | 3 +--
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/edison_defconfig                                | 1 -
>  configs/efi-x86_defconfig                               | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 3 +--
>  configs/qemu-x86_64_defconfig                           | 1 -
>  configs/qemu-x86_defconfig                              | 1 -
>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 3 +--
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  drivers/timer/Kconfig                                   | 1 -
>  23 files changed, 14 insertions(+), 34 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> x86 is using the built-in libgcc implementation and this cannot be
> turned off.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/Kconfig                                            | 1 +
>  configs/bayleybay_defconfig                             | 1 -
>  configs/chromebook_link64_defconfig                     | 1 -
>  configs/chromebook_link_defconfig                       | 1 -
>  configs/chromebook_samus_defconfig                      | 1 -
>  configs/chromebox_panther_defconfig                     | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/coreboot-x86_defconfig                          | 1 -
>  configs/cougarcanyon2_defconfig                         | 1 -
>  configs/crownbay_defconfig                              | 1 -
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/edison_defconfig                                | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/qemu-x86_64_defconfig                           | 1 -
>  configs/qemu-x86_defconfig                              | 1 -
>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  21 files changed, 1 insertion(+), 20 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> PCI is the de facto interconnect bus in an x86 system.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/Kconfig                                            | 2 ++
>  configs/bayleybay_defconfig                             | 1 -
>  configs/chromebook_link64_defconfig                     | 1 -
>  configs/chromebook_link_defconfig                       | 1 -
>  configs/chromebook_samus_defconfig                      | 1 -
>  configs/chromebox_panther_defconfig                     | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/coreboot-x86_defconfig                          | 1 -
>  configs/cougarcanyon2_defconfig                         | 1 -
>  configs/crownbay_defconfig                              | 1 -
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/edison_defconfig                                | 1 -
>  configs/efi-x86_defconfig                               | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/qemu-x86_64_defconfig                           | 1 -
>  configs/qemu-x86_defconfig                              | 1 -
>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  drivers/pci/Kconfig                                     | 2 +-
>  23 files changed, 3 insertions(+), 22 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Intel Management Engine is required by the platform, however it's
> not a must have when building a U-Boot image. For example, during
> development normally programming ME firmware is a one-time effort.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>  arch/x86/cpu/broadwell/Kconfig                          | 1 +
>  arch/x86/cpu/ivybridge/Kconfig                          | 1 +
>  configs/bayleybay_defconfig                             | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  10 files changed, 3 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01  9:17     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> CONFIG_BOARD_EARLY_INIT_F, by its mean is provided by board-specific

What does 'by its mean' mean?

> codes and should be not 'default y' for all x86 boards.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/coreboot/coreboot.c               | 5 -----
>  arch/x86/cpu/efi/efi.c                         | 5 -----
>  board/advantech/som-db5800-som-6867/Kconfig    | 1 +
>  board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 +
>  board/dfi/dfi-bt700/Kconfig                    | 1 +
>  board/google/chromebook_link/link.c            | 5 -----
>  board/google/chromebook_samus/samus.c          | 5 -----
>  board/google/chromebox_panther/panther.c       | 5 -----
>  board/intel/cougarcanyon2/Kconfig              | 1 +
>  board/intel/crownbay/Kconfig                   | 1 +
>  board/intel/galileo/galileo.c                  | 5 -----
>  common/Kconfig                                 | 1 -
>  configs/bayleybay_defconfig                    | 1 -
>  configs/coreboot-x86_defconfig                 | 1 -
>  configs/edison_defconfig                       | 1 -
>  configs/efi-x86_defconfig                      | 1 -
>  configs/minnowmax_defconfig                    | 1 -
>  configs/qemu-x86_64_defconfig                  | 1 -
>  configs/qemu-x86_defconfig                     | 1 -
>  configs/qemu-x86_efi_payload32_defconfig       | 1 -
>  configs/qemu-x86_efi_payload64_defconfig       | 1 -
>  21 files changed, 5 insertions(+), 40 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01  9:18     ` Bin Meng
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 2 replies; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> arch_misc_init() is intended to do architecture-dependent stuff.
> This is required by each platform.

It looks like some platforms don't require it?

>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>  arch/x86/cpu/coreboot/coreboot.c                        | 5 -----
>  arch/x86/cpu/efi/efi.c                                  | 5 -----
>  arch/x86/cpu/quark/Kconfig                              | 1 +
>  configs/bayleybay_defconfig                             | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  10 files changed, 2 insertions(+), 16 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R in the platform Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R " Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:22     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> This is architecture-dependent early initialization hence should
> be put in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/broadwell/Kconfig                          |  1 +
>  arch/x86/cpu/broadwell/refcode.c                        | 17 ++++++++++++++++-
>  arch/x86/cpu/qemu/Kconfig                               |  1 +
>  arch/x86/cpu/quark/Kconfig                              |  1 +
>  arch/x86/cpu/queensbay/Kconfig                          |  1 +
>  arch/x86/include/asm/cpu.h                              | 12 ------------
>  .../advantech/som-db5800-som-6867/som-db5800-som-6867.c |  5 -----
>  .../conga-qeval20-qa3-e3845/conga-qeval20-qa3.c         |  5 -----
>  board/coreboot/coreboot/Makefile                        |  2 +-
>  board/coreboot/coreboot/coreboot.c                      | 14 --------------
>  board/efi/efi-x86/efi.c                                 |  6 ------
>  board/google/chromebook_link/link.c                     | 11 -----------
>  board/google/chromebook_samus/samus.c                   |  6 ------
>  board/google/chromebox_panther/panther.c                |  6 ------
>  board/intel/minnowmax/minnowmax.c                       |  5 -----
>  common/Kconfig                                          |  1 -
>  configs/bayleybay_defconfig                             |  1 -
>  configs/cougarcanyon2_defconfig                         |  1 -
>  configs/dfi-bt700-q7x-151_defconfig                     |  1 -
>  configs/edison_defconfig                                |  1 -
>  configs/efi-x86_defconfig                               |  1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             |  1 -
>  22 files changed, 21 insertions(+), 79 deletions(-)
>  delete mode 100644 board/coreboot/coreboot/coreboot.c

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE in the platform Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE " Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Platform knows whether MRC cache is implemented, but using it can
> be a choice of a specific board.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>  arch/x86/cpu/broadwell/Kconfig                          | 1 +
>  arch/x86/cpu/ivybridge/Kconfig                          | 1 +
>  arch/x86/cpu/quark/Kconfig                              | 1 +
>  configs/bayleybay_defconfig                             | 1 -
>  configs/chromebook_link64_defconfig                     | 1 -
>  configs/chromebook_link_defconfig                       | 1 -
>  configs/chromebook_samus_defconfig                      | 1 -
>  configs/chromebox_panther_defconfig                     | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/cougarcanyon2_defconfig                         | 1 +
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  17 files changed, 5 insertions(+), 12 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL Bin Meng
@ 2017-08-01  9:11   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:11 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> This is a must have for all x86 boards.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/Kconfig                                            | 1 +
>  configs/bayleybay_defconfig                             | 1 -
>  configs/chromebook_link64_defconfig                     | 1 -
>  configs/chromebook_link_defconfig                       | 1 -
>  configs/chromebook_samus_defconfig                      | 1 -
>  configs/chromebox_panther_defconfig                     | 1 -
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>  configs/coreboot-x86_defconfig                          | 1 -
>  configs/cougarcanyon2_defconfig                         | 1 -
>  configs/crownbay_defconfig                              | 1 -
>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>  configs/edison_defconfig                                | 1 -
>  configs/efi-x86_defconfig                               | 1 -
>  configs/galileo_defconfig                               | 1 -
>  configs/minnowmax_defconfig                             | 1 -
>  configs/qemu-x86_64_defconfig                           | 1 -
>  configs/qemu-x86_defconfig                              | 1 -
>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>  configs/som-db5800-som-6867_defconfig                   | 1 -
>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>  22 files changed, 1 insertion(+), 21 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Now that all x86 boards have been converted to use DM, we can imply
> these uclass drivers (DM_ETH, DM_RTC, DM_USB, DM_VIDEO) from the
> top level.
>
> Previously DM_GPIO, DM_KEYBOARD, DM_SERIAL, DM_SPI, DM_SPI_FLASH
> are selected. Change to use 'imply' to allow them to be removed.
>
> Note with this change, chromebook_link64 build fails:
>
> common/built-in.o:(.data.env_htab+0xc): undefined reference to 'env_flags_validate'
> lib/built-in.o: In function `hsearch_r':
> lib/hashtable.c:380: undefined reference to 'env_callback_init'
> lib/hashtable.c:382: undefined reference to 'env_flags_init'
> make[1]: *** [spl/u-boot-spl] Error 1
>
> CONFIG_SPL_ENV_SUPPORT is required for chromebook_link64 to build
> again. This is just a workaround as it is not needed at all. See
> commit bda40d5 "x86: qemu: Add a config for 64-bit U-Boot" for
> the same issue seen on QEMU 64-bit target.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/Kconfig                                            | 16 ++++++++++------
>  configs/bayleybay_defconfig                             |  4 ----
>  configs/chromebook_link64_defconfig                     |  4 +---
>  configs/chromebook_link_defconfig                       |  3 ---
>  configs/chromebook_samus_defconfig                      |  3 ---
>  configs/chromebox_panther_defconfig                     |  4 ----
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
>  configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
>  configs/coreboot-x86_defconfig                          |  4 ----
>  configs/cougarcanyon2_defconfig                         |  3 ---
>  configs/crownbay_defconfig                              |  4 ----
>  configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
>  configs/edison_defconfig                                |  1 -
>  configs/efi-x86_defconfig                               |  3 +--
>  configs/galileo_defconfig                               |  4 ----
>  configs/minnowmax_defconfig                             |  4 ----
>  configs/qemu-x86_64_defconfig                           |  4 ----
>  configs/qemu-x86_defconfig                              |  4 ----
>  configs/qemu-x86_efi_payload32_defconfig                |  4 ----
>  configs/qemu-x86_efi_payload64_defconfig                |  4 ----
>  configs/som-db5800-som-6867_defconfig                   |  4 ----
>  configs/theadorable-x86-dfi-bt700_defconfig             |  4 ----
>  22 files changed, 12 insertions(+), 81 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> BayTrail integrates lots of peripherals that have U-Boot drivers.
> Imply those in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/baytrail/Kconfig                           | 11 ++++++++++-
>  configs/bayleybay_defconfig                             |  9 ---------
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  8 --------
>  configs/conga-qeval20-qa3-e3845_defconfig               |  8 --------
>  configs/dfi-bt700-q7x-151_defconfig                     |  8 --------
>  configs/minnowmax_defconfig                             |  9 ---------
>  configs/som-db5800-som-6867_defconfig                   |  5 -----
>  configs/theadorable-x86-dfi-bt700_defconfig             |  8 --------
>  8 files changed, 10 insertions(+), 56 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 12/22] x86: ivybridge: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 12/22] x86: ivybridge: " Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply drivers that are working with Ivybridge platform in the
> platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply ENV_IS_IN_SPI_FLASH for ivybridge
>
>  arch/x86/cpu/ivybridge/Kconfig      | 5 +++++
>  configs/chromebook_link64_defconfig | 5 -----
>  configs/chromebook_link_defconfig   | 5 -----
>  configs/chromebox_panther_defconfig | 5 -----
>  configs/cougarcanyon2_defconfig     | 5 +----
>  5 files changed, 6 insertions(+), 19 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 13/22] x86: broadwell: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 13/22] x86: broadwell: " Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply Broadwell-specific drivers in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply ENV_IS_IN_SPI_FLASH for broadwell
>
>  arch/x86/cpu/broadwell/Kconfig     | 6 ++++++
>  configs/chromebook_samus_defconfig | 6 ------
>  2 files changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> U-Boot as coreboot payload can run on any x86 hardware ideally.
> Let's imply some common drivers that are useful.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply more common drivers for coreboot
>
>  arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
>  configs/coreboot-x86_defconfig |  5 -----
>  2 files changed, 10 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply drivers that work with Intel Queensbay platform.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply ENV_IS_IN_SPI_FLASH for queensbay
>
>  arch/x86/cpu/queensbay/Kconfig | 11 +++++++++++
>  configs/crownbay_defconfig     | 11 -----------
>  2 files changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 16/22] x86: tangier: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 16/22] x86: tangier: " Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply Tangier-specific drivers in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/tangier/Kconfig | 7 +++++++
>  configs/edison_defconfig     | 7 -------
>  2 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 17/22] x86: quark: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 17/22] x86: quark: " Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply Quark-specific drivers in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply ENV_IS_IN_SPI_FLASH for quark
>
>  arch/x86/cpu/quark/Kconfig | 9 +++++++++
>  configs/galileo_defconfig  | 9 ---------
>  2 files changed, 9 insertions(+), 9 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 18/22] x86: qemu: kconfig: Imply platform specific drivers
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 18/22] x86: qemu: " Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:23     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Imply Qemu-specific drivers in the platform Kconfig.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - imply ENV_IS_NOWHERE for qemu
>
>  arch/x86/cpu/qemu/Kconfig                | 4 ++++
>  configs/qemu-x86_64_defconfig            | 4 ----
>  configs/qemu-x86_defconfig               | 4 ----
>  configs/qemu-x86_efi_payload32_defconfig | 4 ----
>  configs/qemu-x86_efi_payload64_defconfig | 4 ----
>  5 files changed, 4 insertions(+), 16 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:24     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> QEMU does not support ICH SPI controller yet. It's meaningless to
> include SPI flash support.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  configs/qemu-x86_64_defconfig            | 5 -----
>  configs/qemu-x86_defconfig               | 4 ----
>  configs/qemu-x86_efi_payload32_defconfig | 4 ----
>  configs/qemu-x86_efi_payload64_defconfig | 4 ----
>  4 files changed, 17 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:24     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Only a specific type of SPI flash exists on a board, having board
> Kconfig to select the SPI flash seems to make more sense. Other
> flash types are not necessary except coreboot, which implies all
> available flash drivers there.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2: None
>
>  board/advantech/som-db5800-som-6867/Kconfig             |  1 +
>  board/congatec/conga-qeval20-qa3-e3845/Kconfig          |  1 +
>  board/coreboot/coreboot/Kconfig                         | 11 +++++++++++
>  board/dfi/dfi-bt700/Kconfig                             |  1 +
>  board/google/chromebook_link/Kconfig                    |  1 +
>  board/google/chromebook_samus/Kconfig                   |  1 +
>  board/google/chromebox_panther/Kconfig                  |  1 +
>  board/intel/bayleybay/Kconfig                           |  1 +
>  board/intel/cougarcanyon2/Kconfig                       |  1 +
>  board/intel/crownbay/Kconfig                            |  1 +
>  board/intel/galileo/Kconfig                             |  1 +
>  board/intel/minnowmax/Kconfig                           |  1 +
>  configs/bayleybay_defconfig                             |  3 ---
>  configs/chromebook_link64_defconfig                     |  3 ---
>  configs/chromebook_link_defconfig                       |  3 ---
>  configs/chromebook_samus_defconfig                      |  3 ---
>  configs/chromebox_panther_defconfig                     |  3 ---
>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
>  configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
>  configs/coreboot-x86_defconfig                          |  3 ---
>  configs/cougarcanyon2_defconfig                         |  1 -
>  configs/crownbay_defconfig                              |  4 ----
>  configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
>  configs/galileo_defconfig                               |  3 ---
>  configs/minnowmax_defconfig                             |  4 ----
>  configs/som-db5800-som-6867_defconfig                   |  4 ----
>  configs/theadorable-x86-dfi-bt700_defconfig             |  5 -----
>  27 files changed, 22 insertions(+), 51 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:24     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> Like other peripheral drivers, move USB related drivers to platform
> Kconfig as well.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v2: None
>
>  arch/Kconfig                   | 2 --
>  arch/x86/cpu/baytrail/Kconfig  | 3 +++
>  arch/x86/cpu/broadwell/Kconfig | 2 ++
>  arch/x86/cpu/coreboot/Kconfig  | 3 +++
>  arch/x86/cpu/ivybridge/Kconfig | 2 ++
>  arch/x86/cpu/qemu/Kconfig      | 2 ++
>  arch/x86/cpu/quark/Kconfig     | 2 ++
>  arch/x86/cpu/queensbay/Kconfig | 2 ++
>  arch/x86/cpu/tangier/Kconfig   | 1 +
>  configs/efi-x86_defconfig      | 2 --
>  configs/minnowmax_defconfig    | 1 -
>  11 files changed, 17 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig
  2017-07-30 13:23 ` [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig Bin Meng
@ 2017-08-01  9:12   ` Simon Glass
  2017-08-01 12:24     ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Simon Glass @ 2017-08-01  9:12 UTC (permalink / raw)
  To: u-boot

On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
> This converts Intel ICH6 GPIO driver to Kconfig, and add it to the
> imply list of platform drivers.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
> Changes in v2:
> - rebase on top of u-boot/master
>
>  arch/x86/cpu/baytrail/Kconfig  | 1 +
>  arch/x86/cpu/ivybridge/Kconfig | 1 +
>  arch/x86/cpu/quark/Kconfig     | 1 +
>  arch/x86/cpu/queensbay/Kconfig | 1 +
>  drivers/gpio/Kconfig           | 6 ++++++
>  include/configs/efi-x86.h      | 1 -
>  include/configs/qemu-x86.h     | 3 ---
>  include/configs/x86-common.h   | 3 ---
>  scripts/config_whitelist.txt   | 1 -
>  9 files changed, 10 insertions(+), 8 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01  9:17     ` Bin Meng
  2017-08-01 12:22       ` Bin Meng
  0 siblings, 1 reply; 69+ messages in thread
From: Bin Meng @ 2017-08-01  9:17 UTC (permalink / raw)
  To: u-boot

Hi Simon,

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> CONFIG_BOARD_EARLY_INIT_F, by its mean is provided by board-specific
>
> What does 'by its mean' mean?

Sorry, I mean "literally". Will reword when applying.

>
>> codes and should be not 'default y' for all x86 boards.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/coreboot/coreboot.c               | 5 -----
>>  arch/x86/cpu/efi/efi.c                         | 5 -----
>>  board/advantech/som-db5800-som-6867/Kconfig    | 1 +
>>  board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 +
>>  board/dfi/dfi-bt700/Kconfig                    | 1 +
>>  board/google/chromebook_link/link.c            | 5 -----
>>  board/google/chromebook_samus/samus.c          | 5 -----
>>  board/google/chromebox_panther/panther.c       | 5 -----
>>  board/intel/cougarcanyon2/Kconfig              | 1 +
>>  board/intel/crownbay/Kconfig                   | 1 +
>>  board/intel/galileo/galileo.c                  | 5 -----
>>  common/Kconfig                                 | 1 -
>>  configs/bayleybay_defconfig                    | 1 -
>>  configs/coreboot-x86_defconfig                 | 1 -
>>  configs/edison_defconfig                       | 1 -
>>  configs/efi-x86_defconfig                      | 1 -
>>  configs/minnowmax_defconfig                    | 1 -
>>  configs/qemu-x86_64_defconfig                  | 1 -
>>  configs/qemu-x86_defconfig                     | 1 -
>>  configs/qemu-x86_efi_payload32_defconfig       | 1 -
>>  configs/qemu-x86_efi_payload64_defconfig       | 1 -
>>  21 files changed, 5 insertions(+), 40 deletions(-)
>>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Bin

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01  9:18     ` Bin Meng
  2017-08-01 12:22     ` Bin Meng
  1 sibling, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01  9:18 UTC (permalink / raw)
  To: u-boot

Hi Simon,

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> arch_misc_init() is intended to do architecture-dependent stuff.
>> This is required by each platform.
>
> It looks like some platforms don't require it?

Correct.

>
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>>  arch/x86/cpu/coreboot/coreboot.c                        | 5 -----
>>  arch/x86/cpu/efi/efi.c                                  | 5 -----
>>  arch/x86/cpu/quark/Kconfig                              | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  10 files changed, 2 insertions(+), 16 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Bin

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:22     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Without a timer, U-Boot just doesn't boot. This is not something
>> we can turn off.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - sync defconfigs
>>
>>  arch/Kconfig                                            | 2 ++
>>  configs/bayleybay_defconfig                             | 3 +--
>>  configs/chromebook_link64_defconfig                     | 5 ++---
>>  configs/chromebook_link_defconfig                       | 5 ++---
>>  configs/chromebook_samus_defconfig                      | 3 +--
>>  configs/chromebox_panther_defconfig                     | 5 ++---
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/coreboot-x86_defconfig                          | 1 -
>>  configs/cougarcanyon2_defconfig                         | 3 +--
>>  configs/crownbay_defconfig                              | 3 +--
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/edison_defconfig                                | 1 -
>>  configs/efi-x86_defconfig                               | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 3 +--
>>  configs/qemu-x86_64_defconfig                           | 1 -
>>  configs/qemu-x86_defconfig                              | 1 -
>>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 3 +--
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  drivers/timer/Kconfig                                   | 1 -
>>  23 files changed, 14 insertions(+), 34 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:22     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> x86 is using the built-in libgcc implementation and this cannot be
>> turned off.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/Kconfig                                            | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/chromebook_link64_defconfig                     | 1 -
>>  configs/chromebook_link_defconfig                       | 1 -
>>  configs/chromebook_samus_defconfig                      | 1 -
>>  configs/chromebox_panther_defconfig                     | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/coreboot-x86_defconfig                          | 1 -
>>  configs/cougarcanyon2_defconfig                         | 1 -
>>  configs/crownbay_defconfig                              | 1 -
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/edison_defconfig                                | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/qemu-x86_64_defconfig                           | 1 -
>>  configs/qemu-x86_defconfig                              | 1 -
>>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  21 files changed, 1 insertion(+), 20 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:22     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> PCI is the de facto interconnect bus in an x86 system.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/Kconfig                                            | 2 ++
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/chromebook_link64_defconfig                     | 1 -
>>  configs/chromebook_link_defconfig                       | 1 -
>>  configs/chromebook_samus_defconfig                      | 1 -
>>  configs/chromebox_panther_defconfig                     | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/coreboot-x86_defconfig                          | 1 -
>>  configs/cougarcanyon2_defconfig                         | 1 -
>>  configs/crownbay_defconfig                              | 1 -
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/edison_defconfig                                | 1 -
>>  configs/efi-x86_defconfig                               | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/qemu-x86_64_defconfig                           | 1 -
>>  configs/qemu-x86_defconfig                              | 1 -
>>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  drivers/pci/Kconfig                                     | 2 +-
>>  23 files changed, 3 insertions(+), 22 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:22     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Intel Management Engine is required by the platform, however it's
>> not a must have when building a U-Boot image. For example, during
>> development normally programming ME firmware is a one-time effort.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>>  arch/x86/cpu/broadwell/Kconfig                          | 1 +
>>  arch/x86/cpu/ivybridge/Kconfig                          | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  10 files changed, 3 insertions(+), 7 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F
  2017-08-01  9:17     ` Bin Meng
@ 2017-08-01 12:22       ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:17 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
>> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> CONFIG_BOARD_EARLY_INIT_F, by its mean is provided by board-specific
>>
>> What does 'by its mean' mean?
>
> Sorry, I mean "literally". Will reword when applying.

Reworded the commit message, and

>
>>
>>> codes and should be not 'default y' for all x86 boards.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>>  arch/x86/cpu/coreboot/coreboot.c               | 5 -----
>>>  arch/x86/cpu/efi/efi.c                         | 5 -----
>>>  board/advantech/som-db5800-som-6867/Kconfig    | 1 +
>>>  board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 +
>>>  board/dfi/dfi-bt700/Kconfig                    | 1 +
>>>  board/google/chromebook_link/link.c            | 5 -----
>>>  board/google/chromebook_samus/samus.c          | 5 -----
>>>  board/google/chromebox_panther/panther.c       | 5 -----
>>>  board/intel/cougarcanyon2/Kconfig              | 1 +
>>>  board/intel/crownbay/Kconfig                   | 1 +
>>>  board/intel/galileo/galileo.c                  | 5 -----
>>>  common/Kconfig                                 | 1 -
>>>  configs/bayleybay_defconfig                    | 1 -
>>>  configs/coreboot-x86_defconfig                 | 1 -
>>>  configs/edison_defconfig                       | 1 -
>>>  configs/efi-x86_defconfig                      | 1 -
>>>  configs/minnowmax_defconfig                    | 1 -
>>>  configs/qemu-x86_64_defconfig                  | 1 -
>>>  configs/qemu-x86_defconfig                     | 1 -
>>>  configs/qemu-x86_efi_payload32_defconfig       | 1 -
>>>  configs/qemu-x86_efi_payload64_defconfig       | 1 -
>>>  21 files changed, 5 insertions(+), 40 deletions(-)
>>>
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig
  2017-08-01  9:11   ` Simon Glass
  2017-08-01  9:18     ` Bin Meng
@ 2017-08-01 12:22     ` Bin Meng
  1 sibling, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> arch_misc_init() is intended to do architecture-dependent stuff.
>> This is required by each platform.
>
> It looks like some platforms don't require it?
>
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>>  arch/x86/cpu/coreboot/coreboot.c                        | 5 -----
>>  arch/x86/cpu/efi/efi.c                                  | 5 -----
>>  arch/x86/cpu/quark/Kconfig                              | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  10 files changed, 2 insertions(+), 16 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R in the platform Kconfig
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:22     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:22 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> This is architecture-dependent early initialization hence should
>> be put in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/broadwell/Kconfig                          |  1 +
>>  arch/x86/cpu/broadwell/refcode.c                        | 17 ++++++++++++++++-
>>  arch/x86/cpu/qemu/Kconfig                               |  1 +
>>  arch/x86/cpu/quark/Kconfig                              |  1 +
>>  arch/x86/cpu/queensbay/Kconfig                          |  1 +
>>  arch/x86/include/asm/cpu.h                              | 12 ------------
>>  .../advantech/som-db5800-som-6867/som-db5800-som-6867.c |  5 -----
>>  .../conga-qeval20-qa3-e3845/conga-qeval20-qa3.c         |  5 -----
>>  board/coreboot/coreboot/Makefile                        |  2 +-
>>  board/coreboot/coreboot/coreboot.c                      | 14 --------------
>>  board/efi/efi-x86/efi.c                                 |  6 ------
>>  board/google/chromebook_link/link.c                     | 11 -----------
>>  board/google/chromebook_samus/samus.c                   |  6 ------
>>  board/google/chromebox_panther/panther.c                |  6 ------
>>  board/intel/minnowmax/minnowmax.c                       |  5 -----
>>  common/Kconfig                                          |  1 -
>>  configs/bayleybay_defconfig                             |  1 -
>>  configs/cougarcanyon2_defconfig                         |  1 -
>>  configs/dfi-bt700-q7x-151_defconfig                     |  1 -
>>  configs/edison_defconfig                                |  1 -
>>  configs/efi-x86_defconfig                               |  1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             |  1 -
>>  22 files changed, 21 insertions(+), 79 deletions(-)
>>  delete mode 100644 board/coreboot/coreboot/coreboot.c
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE in the platform Kconfig
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Platform knows whether MRC cache is implemented, but using it can
>> be a choice of a specific board.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/baytrail/Kconfig                           | 1 +
>>  arch/x86/cpu/broadwell/Kconfig                          | 1 +
>>  arch/x86/cpu/ivybridge/Kconfig                          | 1 +
>>  arch/x86/cpu/quark/Kconfig                              | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/chromebook_link64_defconfig                     | 1 -
>>  configs/chromebook_link_defconfig                       | 1 -
>>  configs/chromebook_samus_defconfig                      | 1 -
>>  configs/chromebox_panther_defconfig                     | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/cougarcanyon2_defconfig                         | 1 +
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  17 files changed, 5 insertions(+), 12 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL
  2017-08-01  9:11   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:11 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> This is a must have for all x86 boards.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/Kconfig                                            | 1 +
>>  configs/bayleybay_defconfig                             | 1 -
>>  configs/chromebook_link64_defconfig                     | 1 -
>>  configs/chromebook_link_defconfig                       | 1 -
>>  configs/chromebook_samus_defconfig                      | 1 -
>>  configs/chromebox_panther_defconfig                     | 1 -
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
>>  configs/conga-qeval20-qa3-e3845_defconfig               | 1 -
>>  configs/coreboot-x86_defconfig                          | 1 -
>>  configs/cougarcanyon2_defconfig                         | 1 -
>>  configs/crownbay_defconfig                              | 1 -
>>  configs/dfi-bt700-q7x-151_defconfig                     | 1 -
>>  configs/edison_defconfig                                | 1 -
>>  configs/efi-x86_defconfig                               | 1 -
>>  configs/galileo_defconfig                               | 1 -
>>  configs/minnowmax_defconfig                             | 1 -
>>  configs/qemu-x86_64_defconfig                           | 1 -
>>  configs/qemu-x86_defconfig                              | 1 -
>>  configs/qemu-x86_efi_payload32_defconfig                | 1 -
>>  configs/qemu-x86_efi_payload64_defconfig                | 1 -
>>  configs/som-db5800-som-6867_defconfig                   | 1 -
>>  configs/theadorable-x86-dfi-bt700_defconfig             | 1 -
>>  22 files changed, 1 insertion(+), 21 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Now that all x86 boards have been converted to use DM, we can imply
>> these uclass drivers (DM_ETH, DM_RTC, DM_USB, DM_VIDEO) from the
>> top level.
>>
>> Previously DM_GPIO, DM_KEYBOARD, DM_SERIAL, DM_SPI, DM_SPI_FLASH
>> are selected. Change to use 'imply' to allow them to be removed.
>>
>> Note with this change, chromebook_link64 build fails:
>>
>> common/built-in.o:(.data.env_htab+0xc): undefined reference to 'env_flags_validate'
>> lib/built-in.o: In function `hsearch_r':
>> lib/hashtable.c:380: undefined reference to 'env_callback_init'
>> lib/hashtable.c:382: undefined reference to 'env_flags_init'
>> make[1]: *** [spl/u-boot-spl] Error 1
>>
>> CONFIG_SPL_ENV_SUPPORT is required for chromebook_link64 to build
>> again. This is just a workaround as it is not needed at all. See
>> commit bda40d5 "x86: qemu: Add a config for 64-bit U-Boot" for
>> the same issue seen on QEMU 64-bit target.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/Kconfig                                            | 16 ++++++++++------
>>  configs/bayleybay_defconfig                             |  4 ----
>>  configs/chromebook_link64_defconfig                     |  4 +---
>>  configs/chromebook_link_defconfig                       |  3 ---
>>  configs/chromebook_samus_defconfig                      |  3 ---
>>  configs/chromebox_panther_defconfig                     |  4 ----
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
>>  configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
>>  configs/coreboot-x86_defconfig                          |  4 ----
>>  configs/cougarcanyon2_defconfig                         |  3 ---
>>  configs/crownbay_defconfig                              |  4 ----
>>  configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
>>  configs/edison_defconfig                                |  1 -
>>  configs/efi-x86_defconfig                               |  3 +--
>>  configs/galileo_defconfig                               |  4 ----
>>  configs/minnowmax_defconfig                             |  4 ----
>>  configs/qemu-x86_64_defconfig                           |  4 ----
>>  configs/qemu-x86_defconfig                              |  4 ----
>>  configs/qemu-x86_efi_payload32_defconfig                |  4 ----
>>  configs/qemu-x86_efi_payload64_defconfig                |  4 ----
>>  configs/som-db5800-som-6867_defconfig                   |  4 ----
>>  configs/theadorable-x86-dfi-bt700_defconfig             |  4 ----
>>  22 files changed, 12 insertions(+), 81 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> BayTrail integrates lots of peripherals that have U-Boot drivers.
>> Imply those in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/baytrail/Kconfig                           | 11 ++++++++++-
>>  configs/bayleybay_defconfig                             |  9 ---------
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  8 --------
>>  configs/conga-qeval20-qa3-e3845_defconfig               |  8 --------
>>  configs/dfi-bt700-q7x-151_defconfig                     |  8 --------
>>  configs/minnowmax_defconfig                             |  9 ---------
>>  configs/som-db5800-som-6867_defconfig                   |  5 -----
>>  configs/theadorable-x86-dfi-bt700_defconfig             |  8 --------
>>  8 files changed, 10 insertions(+), 56 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 12/22] x86: ivybridge: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply drivers that are working with Ivybridge platform in the
>> platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply ENV_IS_IN_SPI_FLASH for ivybridge
>>
>>  arch/x86/cpu/ivybridge/Kconfig      | 5 +++++
>>  configs/chromebook_link64_defconfig | 5 -----
>>  configs/chromebook_link_defconfig   | 5 -----
>>  configs/chromebox_panther_defconfig | 5 -----
>>  configs/cougarcanyon2_defconfig     | 5 +----
>>  5 files changed, 6 insertions(+), 19 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 13/22] x86: broadwell: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply Broadwell-specific drivers in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply ENV_IS_IN_SPI_FLASH for broadwell
>>
>>  arch/x86/cpu/broadwell/Kconfig     | 6 ++++++
>>  configs/chromebook_samus_defconfig | 6 ------
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> U-Boot as coreboot payload can run on any x86 hardware ideally.
>> Let's imply some common drivers that are useful.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply more common drivers for coreboot
>>
>>  arch/x86/cpu/coreboot/Kconfig  | 10 ++++++++++
>>  configs/coreboot-x86_defconfig |  5 -----
>>  2 files changed, 10 insertions(+), 5 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply drivers that work with Intel Queensbay platform.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply ENV_IS_IN_SPI_FLASH for queensbay
>>
>>  arch/x86/cpu/queensbay/Kconfig | 11 +++++++++++
>>  configs/crownbay_defconfig     | 11 -----------
>>  2 files changed, 11 insertions(+), 11 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 16/22] x86: tangier: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply Tangier-specific drivers in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/tangier/Kconfig | 7 +++++++
>>  configs/edison_defconfig     | 7 -------
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 17/22] x86: quark: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply Quark-specific drivers in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply ENV_IS_IN_SPI_FLASH for quark
>>
>>  arch/x86/cpu/quark/Kconfig | 9 +++++++++
>>  configs/galileo_defconfig  | 9 ---------
>>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 18/22] x86: qemu: kconfig: Imply platform specific drivers
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:23     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:23 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Imply Qemu-specific drivers in the platform Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - imply ENV_IS_NOWHERE for qemu
>>
>>  arch/x86/cpu/qemu/Kconfig                | 4 ++++
>>  configs/qemu-x86_64_defconfig            | 4 ----
>>  configs/qemu-x86_defconfig               | 4 ----
>>  configs/qemu-x86_efi_payload32_defconfig | 4 ----
>>  configs/qemu-x86_efi_payload64_defconfig | 4 ----
>>  5 files changed, 4 insertions(+), 16 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:24     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:24 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> QEMU does not support ICH SPI controller yet. It's meaningless to
>> include SPI flash support.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  configs/qemu-x86_64_defconfig            | 5 -----
>>  configs/qemu-x86_defconfig               | 4 ----
>>  configs/qemu-x86_efi_payload32_defconfig | 4 ----
>>  configs/qemu-x86_efi_payload64_defconfig | 4 ----
>>  4 files changed, 17 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:24     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:24 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Only a specific type of SPI flash exists on a board, having board
>> Kconfig to select the SPI flash seems to make more sense. Other
>> flash types are not necessary except coreboot, which implies all
>> available flash drivers there.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  board/advantech/som-db5800-som-6867/Kconfig             |  1 +
>>  board/congatec/conga-qeval20-qa3-e3845/Kconfig          |  1 +
>>  board/coreboot/coreboot/Kconfig                         | 11 +++++++++++
>>  board/dfi/dfi-bt700/Kconfig                             |  1 +
>>  board/google/chromebook_link/Kconfig                    |  1 +
>>  board/google/chromebook_samus/Kconfig                   |  1 +
>>  board/google/chromebox_panther/Kconfig                  |  1 +
>>  board/intel/bayleybay/Kconfig                           |  1 +
>>  board/intel/cougarcanyon2/Kconfig                       |  1 +
>>  board/intel/crownbay/Kconfig                            |  1 +
>>  board/intel/galileo/Kconfig                             |  1 +
>>  board/intel/minnowmax/Kconfig                           |  1 +
>>  configs/bayleybay_defconfig                             |  3 ---
>>  configs/chromebook_link64_defconfig                     |  3 ---
>>  configs/chromebook_link_defconfig                       |  3 ---
>>  configs/chromebook_samus_defconfig                      |  3 ---
>>  configs/chromebox_panther_defconfig                     |  3 ---
>>  configs/conga-qeval20-qa3-e3845-internal-uart_defconfig |  4 ----
>>  configs/conga-qeval20-qa3-e3845_defconfig               |  4 ----
>>  configs/coreboot-x86_defconfig                          |  3 ---
>>  configs/cougarcanyon2_defconfig                         |  1 -
>>  configs/crownbay_defconfig                              |  4 ----
>>  configs/dfi-bt700-q7x-151_defconfig                     |  4 ----
>>  configs/galileo_defconfig                               |  3 ---
>>  configs/minnowmax_defconfig                             |  4 ----
>>  configs/som-db5800-som-6867_defconfig                   |  4 ----
>>  configs/theadorable-x86-dfi-bt700_defconfig             |  5 -----
>>  27 files changed, 22 insertions(+), 51 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:24     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:24 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Like other peripheral drivers, move USB related drivers to platform
>> Kconfig as well.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/Kconfig                   | 2 --
>>  arch/x86/cpu/baytrail/Kconfig  | 3 +++
>>  arch/x86/cpu/broadwell/Kconfig | 2 ++
>>  arch/x86/cpu/coreboot/Kconfig  | 3 +++
>>  arch/x86/cpu/ivybridge/Kconfig | 2 ++
>>  arch/x86/cpu/qemu/Kconfig      | 2 ++
>>  arch/x86/cpu/quark/Kconfig     | 2 ++
>>  arch/x86/cpu/queensbay/Kconfig | 2 ++
>>  arch/x86/cpu/tangier/Kconfig   | 1 +
>>  configs/efi-x86_defconfig      | 2 --
>>  configs/minnowmax_defconfig    | 1 -
>>  11 files changed, 17 insertions(+), 5 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

* [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig
  2017-08-01  9:12   ` Simon Glass
@ 2017-08-01 12:24     ` Bin Meng
  0 siblings, 0 replies; 69+ messages in thread
From: Bin Meng @ 2017-08-01 12:24 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg@chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn@gmail.com> wrote:
>> This converts Intel ICH6 GPIO driver to Kconfig, and add it to the
>> imply list of platform drivers.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - rebase on top of u-boot/master
>>
>>  arch/x86/cpu/baytrail/Kconfig  | 1 +
>>  arch/x86/cpu/ivybridge/Kconfig | 1 +
>>  arch/x86/cpu/quark/Kconfig     | 1 +
>>  arch/x86/cpu/queensbay/Kconfig | 1 +
>>  drivers/gpio/Kconfig           | 6 ++++++
>>  include/configs/efi-x86.h      | 1 -
>>  include/configs/qemu-x86.h     | 3 ---
>>  include/configs/x86-common.h   | 3 ---
>>  scripts/config_whitelist.txt   | 1 -
>>  9 files changed, 10 insertions(+), 8 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 69+ messages in thread

end of thread, other threads:[~2017-08-01 12:24 UTC | newest]

Thread overview: 69+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-30 13:23 [U-Boot] [PATCH v2 00/22] x86: kconfig clean up Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 01/22] x86: kconfig: Select TIMER and X86_TSC_TIMER Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 02/22] x86: kconfig: Select USE_PRIVATE_LIBGCC Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 03/22] x86: kconfig: Select PCI and DM_PCI Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 04/22] x86: kconfig: Imply HAVE_INTEL_ME in the platform Kconfig Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 05/22] x86: kconfig: Let board select BOARD_EARLY_INIT_F Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01  9:17     ` Bin Meng
2017-08-01 12:22       ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 06/22] x86: kconfig: Select ARCH_MISC_INIT in the platform Kconfig Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01  9:18     ` Bin Meng
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 07/22] x86: kconfig: Select ARCH_EARLY_INIT_R " Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:22     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 08/22] x86: kconfig: Imply ENABLE_MRC_CACHE " Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 09/22] x86: kconfig: Select OF_CONTROL Bin Meng
2017-08-01  9:11   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 11/22] x86: baytrail: kconfig: Imply platform specific drivers Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 12/22] x86: ivybridge: " Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 13/22] x86: broadwell: " Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 14/22] x86: coreboot: kconfig: Imply drivers that are useful Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 15/22] x86: queensbay: kconfig: Imply platform specific drivers Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 16/22] x86: tangier: " Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 17/22] x86: quark: " Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 18/22] x86: qemu: " Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:23     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 19/22] x86: qemu: Remove SPI flash from defconfigs Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:24     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 20/22] x86: kconfig: Let board select SPI flash Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:24     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 21/22] x86: kconfig: Move USB to platform Kconfig Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:24     ` Bin Meng
2017-07-30 13:23 ` [U-Boot] [PATCH v2 22/22] x86: Convert INTEL_ICH6_GPIO to Kconfig Bin Meng
2017-08-01  9:12   ` Simon Glass
2017-08-01 12:24     ` Bin Meng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.