From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B02C433DB for ; Tue, 22 Dec 2020 05:36:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BCEE23122 for ; Tue, 22 Dec 2020 05:36:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BCEE23122 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kraL7-0005Js-R5 for qemu-devel@archiver.kernel.org; Tue, 22 Dec 2020 00:36:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kraKV-0004py-2M; Tue, 22 Dec 2020 00:35:27 -0500 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]:34993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kraKS-0001xi-T7; Tue, 22 Dec 2020 00:35:26 -0500 Received: by mail-yb1-xb32.google.com with SMTP id u203so10783793ybb.2; Mon, 21 Dec 2020 21:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hl6m/lrjFo2SlIRoqiMxwpRnPz3wYhxiwmpmnwYUSRM=; b=ffnPgRpnPdoKcqdTtwMDTZzdyaNe+26tlBhCByj4m3vnyTKCCAWrFWNxz27DHZ8zM2 A/XsZAlAfpVvvbi/LDjkiE/uOldWlNBFHk0TK9jYVGbmxdoPhsuzwL0yioPrkVs6JVsf ASXg4Kgr5dMDGTJ7nvmPAw+KOkwdAJdH3JyCcZUT0jK/Ek6qFhunNkLQkPB5EqddaoKp 86iLN5zJnhWCixgSd23LUEFoKp8Xw2eRMAfp4F0Jc6ue2k1VZW98qTiBAbpLAe4TUxfF Lswy0XNGy+66Ybhs/1Nu2XypfyHyGk5ScjV98t7gIEwReCL8Apncq2OUvD4WYz/DfWc4 zU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hl6m/lrjFo2SlIRoqiMxwpRnPz3wYhxiwmpmnwYUSRM=; b=o/FX5OQfIF9zn52eE7MSrptKbd5GJVm4GSQGucNAk/vY6mOEJlPigWw5VpRqkp1HKC dbQD5s4rplYXP6bI6iK9924jR9KhbDmJ4FWKzZHm9P7nYLLgkampLAl8LcE2h9+H1uSJ H0gR+cCF5tqchVUN2qMQZgNwKxVa3rcqbXTpvbM1QXZF0WQm3mOUKV+aPQL32P6bpf4K vRFlHruND8ZLauVQjkRnugA1EVFj7C03ouQlsnYoi0vPJPBLTnY6i/AnH7MgvrCsdUTH y6qwTX/fVQM4gecSRM8SMGRrbXqa8oBeSpt6uNO605lKyhsSuuxYPoI0A3XlY0fYyiMJ 3jHA== X-Gm-Message-State: AOAM531t16F2d/wQWRSxbr0J+PZWKHst5l1BdX7JsDVydU8LeF9MQ0QL 62zUafe9sT0iDEiLpPj/v8w7Av7qJwptLZ6202c= X-Google-Smtp-Source: ABdhPJwq3Ayv6W9kX9up82P8bqim/Ku4JYAtR46O60gJuRBZ5oDP1KCZYWAOvb1T6lpOs8JBCvPJ6j+hh4ERoJE4kNw= X-Received: by 2002:a25:be87:: with SMTP id i7mr26725046ybk.332.1608615323061; Mon, 21 Dec 2020 21:35:23 -0800 (PST) MIME-Version: 1.0 References: <20201217214826.2094617-1-atish.patra@wdc.com> <4f09804c0e35a45fcf3fa78b3f3ed55276d6e10f.camel@wdc.com> <67cbbde886c3ae6e57e837e79f466f4156a910f8.camel@wdc.com> In-Reply-To: From: Bin Meng Date: Tue, 22 Dec 2020 13:35:11 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB To: Atish Patra Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-riscv@nongnu.org" , "sagark@eecs.berkeley.edu" , "kbastian@mail.uni-paderborn.de" , Anup Patel , "qemu-devel@nongnu.org" , Alistair Francis , "palmer@dabbelt.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Atish, On Sat, Dec 19, 2020 at 3:46 AM Atish Patra wrote: > > On Fri, 2020-12-18 at 16:42 +0800, Bin Meng wrote: > > Hi Atish, > > > > On Fri, Dec 18, 2020 at 4:00 PM Atish Patra > > wrote: > > > > > > On Fri, 2020-12-18 at 15:33 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > > On Fri, Dec 18, 2020 at 3:27 PM Atish Patra > > > > wrote: > > > > > > > > > > On Fri, 2020-12-18 at 15:21 +0800, Bin Meng wrote: > > > > > > Hi Atish, > > > > > > > > > > > > On Fri, Dec 18, 2020 at 5:48 AM Atish Patra > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > Currently, we place the DTB at 2MB from 4GB or end of DRAM > > > > > > > which > > > > > > > ever is > > > > > > > lesser. However, Linux kernel can address only 1GB of > > > > > > > memory > > > > > > > for > > > > > > > RV32. > > > > > > > Thus, it can not map anything beyond 3GB (assuming 2GB is > > > > > > > the > > > > > > > starting address). > > > > > > > As a result, it can not process DT and panic if opensbi > > > > > > > dynamic > > > > > > > firmware > > > > > > > is used. > > > > > > > > > > > > > > Fix this by placing the DTB at 2MB from 3GB or end of DRAM > > > > > > > whichever is lower. > > > > > > > > > > > > > > Signed-off-by: Atish Patra > > > > > > > --- > > > > > > > hw/riscv/boot.c | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > With this patch, 32-bit sifive_u still does not boot kernel > > > > > > with > > > > > > the > > > > > > following patch applied on 5.10: > > > > > > https://patchwork.kernel.org/project/linux-riscv/patch/20201217074855.1948743-1-atish.patra@wdc.com/ > > > > > > > > > > > > Command I used: > > > > > > $ qemu-system-riscv32 -nographic -M sifive_u -m 1G -smp 5 - > > > > > > kernel > > > > > > arch/riscv/boot/Image > > > > > > > > > > > > 32-bit virt cannot boot the same kernel image with memory set > > > > > > to > > > > > > 2G > > > > > > either: > > > > > > $ qemu-system-riscv32 -nographic -M virt -m 2G -smp 4 -kernel > > > > > > arch/riscv/boot/Image > > > > > > > > > > > > > > > > Hi Bin, > > > > > As mentioned in the email on the linux mailing list, this patch > > > > > only > > > > > solves 2GB problem. sifive_u problem is solved by Alistair's > > > > > patch[1]. > > > > > > > > > > He is planning to send the PR soon. The issue with sifive_u > > > > > boot > > > > > was it > > > > > was failing the 32 bit test earlier resulting a 2MB aligned > > > > > address > > > > > instead of 4MB. > > > > > > > > Ah, I see. However my testing shows that virt with 2G still does > > > > not > > > > boot with this patch. > > > > > > > > > > Strange. I verified again with following combination with -bios and > > > without bios parameter. > > > > > > 1. virt 32/64 with 1GB/2GB memory > > > 2. sifive_u 32/64 bit with 1GB/2GB memory (Alistair's patch > > > included) > > > > > > Can you share the boot log along with the head commit of Qemu and > > > commandline ? I am using 5.10 kernel with my kernel fix. > > > > > > > I was using Alistair's QEMU repo for testing and 5.10 kernel with > > your > > kernel fix: > > > > $ git checkout -b testing pull-riscv-to-apply-20201217-1 > > $ apply this patch > > $ mkdir build;cd build;../configure > > --target-list=riscv64-softmmu,riscv32-softmmu;make -j > > > > $ ./qemu-system-riscv32 -nographic -M virt -m 2G -smp 4 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : riscv-virtio,qemu > > Platform Features : timer,mfdeleg > > Platform HART Count : 4 > > Boot HART ID : 3 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren,time > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 104 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > > > > > $ ./qemu-system-riscv32 -nographic -M sifive_u -m 2G -smp 5 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : SiFive HiFive Unleashed A00 > > Platform Features : timer,mfdeleg > > Platform HART Count : 5 > > Boot HART ID : 4 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 112 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > > > > > The following is sifive_u with 1G: > > > > $ ./qemu-system-riscv32 -nographic -M sifive_u -m 1G -smp 5 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : SiFive HiFive Unleashed A00 > > Platform Features : timer,mfdeleg > > Platform HART Count : 5 > > Boot HART ID : 3 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 112 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > [ 0.000000] Linux version 5.10.0-00001-gbf0dad61896d > > (bmeng@pek-vx-bsp2) (riscv64-linux-gcc (GCC) 8.1.0, GNU ld (GNU > > Binutils) 2.30) #1 SMP Thu Dec 17 16:48:13 CST 2020 > > [ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80400000 > > [ 0.000000] efi: UEFI not found. > > [ 0.000000] Zone ranges: > > [ 0.000000] Normal [mem 0x0000000080400000-0x00000000bfffffff] > > [ 0.000000] Movable zone start for each node > > [ 0.000000] Early memory node ranges > > [ 0.000000] node 0: [mem 0x0000000080400000- > > 0x00000000bfffffff] > > [ 0.000000] Initmem setup node 0 [mem 0x0000000080400000- > > 0x00000000bfffffff] > > [ 0.000000] SBI specification v0.2 detected > > [ 0.000000] SBI implementation ID=0x1 Version=0x8 > > [ 0.000000] SBI v0.2 TIME extension detected > > [ 0.000000] SBI v0.2 IPI extension detected > > [ 0.000000] SBI v0.2 RFENCE extension detected > > [ 0.000000] SBI v0.2 HSM extension detected > > [ 0.000000] CPU with hartid=0 is not available > > [ 0.000000] CPU with hartid=0 is not available > > > > Regards, > > Bin > > May be you forgot to apply this patch for 2GB case on top of Alistair's > tree? I don't see any issues with exact same setup. That's really weird. I have: $ git log --oneline 3ced2fb RISC-V: Place DTB at 3GB boundary instead of 4GB d31e970 riscv/opentitan: Update the OpenTitan memory layout 3ed2b8a hw/riscv: Use the CPU to determine if 32-bit 094b072 target/riscv: cpu: Set XLEN independently from target 8987cdc4 target/riscv: csr: Remove compile time XLEN checks I just rebuilt the QEMU binaries but still have the same result. 2G does not boot on either 'virt' or 'sifive_u'. $ ./qemu-system-riscv32 -version QEMU emulator version 5.2.50 (v5.2.0-551-g3ced2fb) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers Maybe it's toolchain related? I am using kernel.org toolchain riscv64-linux-gcc (GCC) 8.1.0. I see you were using riscv64-unknown-linux-gnu-gcc (GCC) 10.2.0. > > Qemu git log > ------ > 851966c92cf5 (HEAD) RISC-V: Place DTB at 3GB boundary instead of 4GB > d31e970a01e7 (tag: pull-riscv-to-apply-20201217-1, alistair/riscv-to- > apply.next, alistair/riscv-to-apply.for-upstream) riscv/opentitan: > Update the OpenTitan memory layout > 3ed2b8ac2dac hw/riscv: Use the CPU to determine if 32-bit > 094b072c6819 target/riscv: cpu: Set XLEN independently from target > ------- Regards, Bin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kraKW-0004qL-H9 for mharc-qemu-riscv@gnu.org; Tue, 22 Dec 2020 00:35:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kraKV-0004py-2M; Tue, 22 Dec 2020 00:35:27 -0500 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]:34993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kraKS-0001xi-T7; Tue, 22 Dec 2020 00:35:26 -0500 Received: by mail-yb1-xb32.google.com with SMTP id u203so10783793ybb.2; Mon, 21 Dec 2020 21:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hl6m/lrjFo2SlIRoqiMxwpRnPz3wYhxiwmpmnwYUSRM=; b=ffnPgRpnPdoKcqdTtwMDTZzdyaNe+26tlBhCByj4m3vnyTKCCAWrFWNxz27DHZ8zM2 A/XsZAlAfpVvvbi/LDjkiE/uOldWlNBFHk0TK9jYVGbmxdoPhsuzwL0yioPrkVs6JVsf ASXg4Kgr5dMDGTJ7nvmPAw+KOkwdAJdH3JyCcZUT0jK/Ek6qFhunNkLQkPB5EqddaoKp 86iLN5zJnhWCixgSd23LUEFoKp8Xw2eRMAfp4F0Jc6ue2k1VZW98qTiBAbpLAe4TUxfF Lswy0XNGy+66Ybhs/1Nu2XypfyHyGk5ScjV98t7gIEwReCL8Apncq2OUvD4WYz/DfWc4 zU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hl6m/lrjFo2SlIRoqiMxwpRnPz3wYhxiwmpmnwYUSRM=; b=o/FX5OQfIF9zn52eE7MSrptKbd5GJVm4GSQGucNAk/vY6mOEJlPigWw5VpRqkp1HKC dbQD5s4rplYXP6bI6iK9924jR9KhbDmJ4FWKzZHm9P7nYLLgkampLAl8LcE2h9+H1uSJ H0gR+cCF5tqchVUN2qMQZgNwKxVa3rcqbXTpvbM1QXZF0WQm3mOUKV+aPQL32P6bpf4K vRFlHruND8ZLauVQjkRnugA1EVFj7C03ouQlsnYoi0vPJPBLTnY6i/AnH7MgvrCsdUTH y6qwTX/fVQM4gecSRM8SMGRrbXqa8oBeSpt6uNO605lKyhsSuuxYPoI0A3XlY0fYyiMJ 3jHA== X-Gm-Message-State: AOAM531t16F2d/wQWRSxbr0J+PZWKHst5l1BdX7JsDVydU8LeF9MQ0QL 62zUafe9sT0iDEiLpPj/v8w7Av7qJwptLZ6202c= X-Google-Smtp-Source: ABdhPJwq3Ayv6W9kX9up82P8bqim/Ku4JYAtR46O60gJuRBZ5oDP1KCZYWAOvb1T6lpOs8JBCvPJ6j+hh4ERoJE4kNw= X-Received: by 2002:a25:be87:: with SMTP id i7mr26725046ybk.332.1608615323061; Mon, 21 Dec 2020 21:35:23 -0800 (PST) MIME-Version: 1.0 References: <20201217214826.2094617-1-atish.patra@wdc.com> <4f09804c0e35a45fcf3fa78b3f3ed55276d6e10f.camel@wdc.com> <67cbbde886c3ae6e57e837e79f466f4156a910f8.camel@wdc.com> In-Reply-To: From: Bin Meng Date: Tue, 22 Dec 2020 13:35:11 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB To: Atish Patra Cc: "qemu-riscv@nongnu.org" , "kbastian@mail.uni-paderborn.de" , "sagark@eecs.berkeley.edu" , Alistair Francis , Anup Patel , "qemu-devel@nongnu.org" , "palmer@dabbelt.com" Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 05:35:27 -0000 Hi Atish, On Sat, Dec 19, 2020 at 3:46 AM Atish Patra wrote: > > On Fri, 2020-12-18 at 16:42 +0800, Bin Meng wrote: > > Hi Atish, > > > > On Fri, Dec 18, 2020 at 4:00 PM Atish Patra > > wrote: > > > > > > On Fri, 2020-12-18 at 15:33 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > > On Fri, Dec 18, 2020 at 3:27 PM Atish Patra > > > > wrote: > > > > > > > > > > On Fri, 2020-12-18 at 15:21 +0800, Bin Meng wrote: > > > > > > Hi Atish, > > > > > > > > > > > > On Fri, Dec 18, 2020 at 5:48 AM Atish Patra > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > Currently, we place the DTB at 2MB from 4GB or end of DRAM > > > > > > > which > > > > > > > ever is > > > > > > > lesser. However, Linux kernel can address only 1GB of > > > > > > > memory > > > > > > > for > > > > > > > RV32. > > > > > > > Thus, it can not map anything beyond 3GB (assuming 2GB is > > > > > > > the > > > > > > > starting address). > > > > > > > As a result, it can not process DT and panic if opensbi > > > > > > > dynamic > > > > > > > firmware > > > > > > > is used. > > > > > > > > > > > > > > Fix this by placing the DTB at 2MB from 3GB or end of DRAM > > > > > > > whichever is lower. > > > > > > > > > > > > > > Signed-off-by: Atish Patra > > > > > > > --- > > > > > > > hw/riscv/boot.c | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > With this patch, 32-bit sifive_u still does not boot kernel > > > > > > with > > > > > > the > > > > > > following patch applied on 5.10: > > > > > > https://patchwork.kernel.org/project/linux-riscv/patch/20201217074855.1948743-1-atish.patra@wdc.com/ > > > > > > > > > > > > Command I used: > > > > > > $ qemu-system-riscv32 -nographic -M sifive_u -m 1G -smp 5 - > > > > > > kernel > > > > > > arch/riscv/boot/Image > > > > > > > > > > > > 32-bit virt cannot boot the same kernel image with memory set > > > > > > to > > > > > > 2G > > > > > > either: > > > > > > $ qemu-system-riscv32 -nographic -M virt -m 2G -smp 4 -kernel > > > > > > arch/riscv/boot/Image > > > > > > > > > > > > > > > > Hi Bin, > > > > > As mentioned in the email on the linux mailing list, this patch > > > > > only > > > > > solves 2GB problem. sifive_u problem is solved by Alistair's > > > > > patch[1]. > > > > > > > > > > He is planning to send the PR soon. The issue with sifive_u > > > > > boot > > > > > was it > > > > > was failing the 32 bit test earlier resulting a 2MB aligned > > > > > address > > > > > instead of 4MB. > > > > > > > > Ah, I see. However my testing shows that virt with 2G still does > > > > not > > > > boot with this patch. > > > > > > > > > > Strange. I verified again with following combination with -bios and > > > without bios parameter. > > > > > > 1. virt 32/64 with 1GB/2GB memory > > > 2. sifive_u 32/64 bit with 1GB/2GB memory (Alistair's patch > > > included) > > > > > > Can you share the boot log along with the head commit of Qemu and > > > commandline ? I am using 5.10 kernel with my kernel fix. > > > > > > > I was using Alistair's QEMU repo for testing and 5.10 kernel with > > your > > kernel fix: > > > > $ git checkout -b testing pull-riscv-to-apply-20201217-1 > > $ apply this patch > > $ mkdir build;cd build;../configure > > --target-list=riscv64-softmmu,riscv32-softmmu;make -j > > > > $ ./qemu-system-riscv32 -nographic -M virt -m 2G -smp 4 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : riscv-virtio,qemu > > Platform Features : timer,mfdeleg > > Platform HART Count : 4 > > Boot HART ID : 3 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren,time > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 104 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > > > > > $ ./qemu-system-riscv32 -nographic -M sifive_u -m 2G -smp 5 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : SiFive HiFive Unleashed A00 > > Platform Features : timer,mfdeleg > > Platform HART Count : 5 > > Boot HART ID : 4 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 112 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > > > > > The following is sifive_u with 1G: > > > > $ ./qemu-system-riscv32 -nographic -M sifive_u -m 1G -smp 5 -kernel > > ~/work/git/linux/arch/riscv/boot/Image > > > > OpenSBI v0.8 > > ____ _____ ____ _____ > > / __ \ / ____| _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |____) | |_) || |_ > > \____/| .__/ \___|_| |_|_____/|____/_____| > > | | > > |_| > > > > Platform Name : SiFive HiFive Unleashed A00 > > Platform Features : timer,mfdeleg > > Platform HART Count : 5 > > Boot HART ID : 3 > > Boot HART ISA : rv32imafdcsu > > BOOT HART Features : pmp,scounteren,mcounteren > > BOOT HART PMP Count : 16 > > Firmware Base : 0x80000000 > > Firmware Size : 112 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x00000222 > > MEDELEG : 0x0000b109 > > PMP0 : 0x80000000-0x8001ffff (A) > > PMP1 : 0x00000000-0xffffffff (A,R,W,X) > > [ 0.000000] Linux version 5.10.0-00001-gbf0dad61896d > > (bmeng@pek-vx-bsp2) (riscv64-linux-gcc (GCC) 8.1.0, GNU ld (GNU > > Binutils) 2.30) #1 SMP Thu Dec 17 16:48:13 CST 2020 > > [ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80400000 > > [ 0.000000] efi: UEFI not found. > > [ 0.000000] Zone ranges: > > [ 0.000000] Normal [mem 0x0000000080400000-0x00000000bfffffff] > > [ 0.000000] Movable zone start for each node > > [ 0.000000] Early memory node ranges > > [ 0.000000] node 0: [mem 0x0000000080400000- > > 0x00000000bfffffff] > > [ 0.000000] Initmem setup node 0 [mem 0x0000000080400000- > > 0x00000000bfffffff] > > [ 0.000000] SBI specification v0.2 detected > > [ 0.000000] SBI implementation ID=0x1 Version=0x8 > > [ 0.000000] SBI v0.2 TIME extension detected > > [ 0.000000] SBI v0.2 IPI extension detected > > [ 0.000000] SBI v0.2 RFENCE extension detected > > [ 0.000000] SBI v0.2 HSM extension detected > > [ 0.000000] CPU with hartid=0 is not available > > [ 0.000000] CPU with hartid=0 is not available > > > > Regards, > > Bin > > May be you forgot to apply this patch for 2GB case on top of Alistair's > tree? I don't see any issues with exact same setup. That's really weird. I have: $ git log --oneline 3ced2fb RISC-V: Place DTB at 3GB boundary instead of 4GB d31e970 riscv/opentitan: Update the OpenTitan memory layout 3ed2b8a hw/riscv: Use the CPU to determine if 32-bit 094b072 target/riscv: cpu: Set XLEN independently from target 8987cdc4 target/riscv: csr: Remove compile time XLEN checks I just rebuilt the QEMU binaries but still have the same result. 2G does not boot on either 'virt' or 'sifive_u'. $ ./qemu-system-riscv32 -version QEMU emulator version 5.2.50 (v5.2.0-551-g3ced2fb) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers Maybe it's toolchain related? I am using kernel.org toolchain riscv64-linux-gcc (GCC) 8.1.0. I see you were using riscv64-unknown-linux-gnu-gcc (GCC) 10.2.0. > > Qemu git log > ------ > 851966c92cf5 (HEAD) RISC-V: Place DTB at 3GB boundary instead of 4GB > d31e970a01e7 (tag: pull-riscv-to-apply-20201217-1, alistair/riscv-to- > apply.next, alistair/riscv-to-apply.for-upstream) riscv/opentitan: > Update the OpenTitan memory layout > 3ed2b8ac2dac hw/riscv: Use the CPU to determine if 32-bit > 094b072c6819 target/riscv: cpu: Set XLEN independently from target > ------- Regards, Bin