From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Thu, 21 Mar 2019 18:12:02 +0800 Subject: [U-Boot] [PATCH 8/9] riscv: dts: ae350 support SMP. In-Reply-To: References: <20190319090750.8923-1-uboot@andestech.com> <20190319090750.8923-9-uboot@andestech.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Rick, On Thu, Mar 21, 2019 at 5:37 PM Rick Chen wrote: > > Bin Meng 於 2019年3月21日 週四 下午5:15寫道: > > > > Hi Rick, > > > > On Thu, Mar 21, 2019 at 4:51 PM Rick Chen wrote: > > > > > > Hi Bin > > > > > > Bin Meng 於 2019年3月20日 週三 下午3:22寫道: > > > > > > > > Hi Rick, > > > > > > > > On Tue, Mar 19, 2019 at 5:13 PM Andes wrote: > > > > > > > > > > From: Rick Chen > > > > > > > > > > > > > nits: remove the ending period in the commit title. > > > > > > OK. > > > I will remove it. > > > > > > > > > > > > Signed-off-by: Rick Chen > > > > > Cc: Greentime Hu > > > > > --- > > > > > arch/riscv/dts/ae350_32.dts | 81 +++++++++++++++++++++++++++++++++------------ > > > > > arch/riscv/dts/ae350_64.dts | 47 +++++++++++++++++++++++--- > > > > > 2 files changed, 101 insertions(+), 27 deletions(-) > > > > > > > > > > diff --git a/arch/riscv/dts/ae350_32.dts b/arch/riscv/dts/ae350_32.dts > > > > > index 0679827..0b4d966 100644 > > > > > --- a/arch/riscv/dts/ae350_32.dts > > > > > +++ b/arch/riscv/dts/ae350_32.dts > > > > > @@ -25,17 +25,50 @@ > > > > > reg = <0>; > > > > > status = "okay"; > > > > > compatible = "riscv"; > > > > > - riscv,isa = "rv32imafdc"; > > > > > + riscv,isa = "rv32i2p0m2p0a2p0f2p0d2p0c2p0xv5-0p0"; > > > > > > > > I am not sure what is this. Is this something approved? > > > > > > It is about elf checking (attribute) and seem has been upstream to GCC. > > > https://patchwork.ozlabs.org/cover/1040998/ > > > > > > > So that patch affects GCC's "-march" string? But why do we need adjust > > the "riscv,isa" string in DT? > > > > We will use this to check user program (binutils will assign this > string) when it run in kernel at run time. Do you have details about this binutils checks? Is this new string approved by the DT upstream? At least I see latest QEMU still generates the old string. Regards, Bin