All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] Revert "riscv: Allow use of reset drivers"
Date: Thu, 16 Jul 2020 15:15:58 +0800	[thread overview]
Message-ID: <CAEUhbmULzZRre44dAshjJ29G9wBW6QH51g6x0Xryi_b4HM1vVQ@mail.gmail.com> (raw)
In-Reply-To: <CAN5B=eKuDECGZ+6YOMQOfEp7MY0vzkaaMRUKCwBbqSbRRUoU9Q@mail.gmail.com>

Hi Rick,

On Thu, Jul 16, 2020 at 3:06 PM Rick Chen <rickchen36@gmail.com> wrote:
>
> Hi Bin
>
> > From: Bin Meng [mailto:bmeng.cn at gmail.com]
> > Sent: Thursday, July 16, 2020 9:36 AM
> > To: Sean Anderson
> > Cc: Rick Jian-Zhi Chen(???); Tom Rini; U-Boot Mailing List; Bin Meng
> > Subject: Re: [PATCH 1/2] Revert "riscv: Allow use of reset drivers"
> >
> > Hi Rick,
> >
> > On Wed, Jul 8, 2020 at 3:04 PM Sean Anderson <seanga2@gmail.com> wrote:
> > >
> > > On 7/8/20 2:44 AM, Bin Meng wrote:
> > > > From: Bin Meng <bin.meng@windriver.com>
> > > >
> > > > This reverts commit 958a3f464c7f8ef7e10db9feb663e9e80445ce2f.
> > > >
> > > > A more appropriate change below is already in mainline.
> > > > Commit fd31e4fd184f ("riscv: Do not build reset.c if SYSRESET is
> > > > on")
> > > >
> > > > Revert this patch, so that U-Boot can be built successfully for
> > > > SiFive Fu540 board.
> > > >
> > > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > > > ---
> > > >
> > > >  arch/riscv/lib/reset.c | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/arch/riscv/lib/reset.c b/arch/riscv/lib/reset.c index
> > > > 6008bbe..8779c61 100644
> > > > --- a/arch/riscv/lib/reset.c
> > > > +++ b/arch/riscv/lib/reset.c
> > > > @@ -7,7 +7,6 @@
> > > >  #include <command.h>
> > > >  #include <hang.h>
> > > >
> > > > -#ifndef CONFIG_SYSRESET
> > > >  int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const
> > > > argv[])  {
> > > >       printf("resetting ...\n");
> > > > @@ -17,4 +16,3 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int
> > > > argc, char *const argv[])
> > > >
> > > >       return 0;
> > > >  }
> > > > -#endif
> > > >
> > >
> > > Reviewed-by: Sean Anderson <seanga2@gmail.com>
> >
> > Could we get this series applied soon? thanks!
> >
>
> OK.
>
> But [PATCH 2/2] Revert "Revert "riscv: sifive: fu540: Add gpio-restart
> support"" seem conflict with Pragnesh's [PATCH 2/2] riscv: sifive:
> fu540: Enable SiFive PWM driver.
>
> Would you please rebase with u-boot-riscv/master and send again ?
>

Sure will rebase.

Regards,
Bin

  reply	other threads:[~2020-07-16  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  6:44 [PATCH 1/2] Revert "riscv: Allow use of reset drivers" Bin Meng
2020-07-08  6:44 ` [PATCH 2/2] Revert "Revert "riscv: sifive: fu540: Add gpio-restart support"" Bin Meng
2020-07-08  7:04 ` [PATCH 1/2] Revert "riscv: Allow use of reset drivers" Sean Anderson
2020-07-16  1:36   ` Bin Meng
     [not found]     ` <752D002CFF5D0F4FA35C0100F1D73F3FA472787E@ATCPCS16.andestech.com>
2020-07-16  7:06       ` Rick Chen
2020-07-16  7:15         ` Bin Meng [this message]
2020-07-16  4:10   ` Leo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmULzZRre44dAshjJ29G9wBW6QH51g6x0Xryi_b4HM1vVQ@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.