All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sifive: riscv: update Hifive Unleashed configuration infrastructure
Date: Mon, 29 Jul 2019 21:45:06 +0800	[thread overview]
Message-ID: <CAEUhbmUS9UDSzUsXXTTQ6g-iaNyChX8ZnEUYgFfWkh_g6eoc=Q@mail.gmail.com> (raw)
In-Reply-To: <1564404146-8903-2-git-send-email-sagar.kadam@sifive.com>

Hi,

On Mon, Jul 29, 2019 at 8:42 PM Sagar Shrikant Kadam
<sagar.kadam@sifive.com> wrote:
>
> This patch aligns the current implementation of HiFive Unleashed
> board configuration framework with the one described in doc/README.kconfig.
>

Can you please explain why these changes are needed? It looks that the
changes are only to rename the "generic" cpu name to "u54-mc", and
rename the board name "fu540" to "hifive_unleashed"?

This breaks the QEMU virt boards.

> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
>  arch/riscv/Kconfig                           |   6 +-
>  arch/riscv/cpu/generic/Kconfig               |  12 ---
>  arch/riscv/cpu/generic/Makefile              |   6 --
>  arch/riscv/cpu/generic/cpu.c                 |  35 -------
>  arch/riscv/cpu/generic/dram.c                |  37 -------
>  arch/riscv/cpu/u54-mc/Kconfig                |  12 +++
>  arch/riscv/cpu/u54-mc/Makefile               |   6 ++
>  arch/riscv/cpu/u54-mc/cpu.c                  |  35 +++++++
>  arch/riscv/cpu/u54-mc/dram.c                 |  37 +++++++
>  arch/riscv/include/asm/arch-fu540-c000/clk.h |  14 +++
>  arch/riscv/include/asm/arch-generic/clk.h    |  14 ---
>  board/sifive/fu540/Kconfig                   |  49 ----------
>  board/sifive/fu540/MAINTAINERS               |   9 --
>  board/sifive/fu540/Makefile                  |   5 -
>  board/sifive/fu540/fu540.c                   | 139 ---------------------------
>  board/sifive/hifive_unleashed/Kconfig        |  52 ++++++++++
>  board/sifive/hifive_unleashed/MAINTAINERS    |   9 ++
>  board/sifive/hifive_unleashed/Makefile       |   5 +
>  board/sifive/hifive_unleashed/fu540.c        | 139 +++++++++++++++++++++++++++
>  configs/hifive_unleashed_defconfig           |  11 +++
>  configs/sifive_fu540_defconfig               |  11 ---
>  include/configs/hifive_unleashed.h           |  47 +++++++++
>  include/configs/sifive-fu540.h               |  47 ---------
>  23 files changed, 370 insertions(+), 367 deletions(-)
>  delete mode 100644 arch/riscv/cpu/generic/Kconfig
>  delete mode 100644 arch/riscv/cpu/generic/Makefile
>  delete mode 100644 arch/riscv/cpu/generic/cpu.c
>  delete mode 100644 arch/riscv/cpu/generic/dram.c

It looks that you did not use "git mv" command.

>  create mode 100644 arch/riscv/cpu/u54-mc/Kconfig
>  create mode 100644 arch/riscv/cpu/u54-mc/Makefile
>  create mode 100644 arch/riscv/cpu/u54-mc/cpu.c
>  create mode 100644 arch/riscv/cpu/u54-mc/dram.c
>  create mode 100644 arch/riscv/include/asm/arch-fu540-c000/clk.h
>  delete mode 100644 arch/riscv/include/asm/arch-generic/clk.h
>  delete mode 100644 board/sifive/fu540/Kconfig
>  delete mode 100644 board/sifive/fu540/MAINTAINERS
>  delete mode 100644 board/sifive/fu540/Makefile
>  delete mode 100644 board/sifive/fu540/fu540.c
>  create mode 100644 board/sifive/hifive_unleashed/Kconfig
>  create mode 100644 board/sifive/hifive_unleashed/MAINTAINERS
>  create mode 100644 board/sifive/hifive_unleashed/Makefile
>  create mode 100644 board/sifive/hifive_unleashed/fu540.c
>  create mode 100644 configs/hifive_unleashed_defconfig
>  delete mode 100644 configs/sifive_fu540_defconfig
>  create mode 100644 include/configs/hifive_unleashed.h
>  delete mode 100644 include/configs/sifive-fu540.h
>

Regards,
Bin

  reply	other threads:[~2019-07-29 13:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 12:42 [U-Boot] [PATCH] sifive: riscv: streamline HiFive Unleashed configuration infrastructure Sagar Shrikant Kadam
2019-07-29 12:42 ` [U-Boot] [PATCH] sifive: riscv: update Hifive " Sagar Shrikant Kadam
2019-07-29 13:45   ` Bin Meng [this message]
2019-07-30 17:10     ` Sagar Kadam
2019-07-31  8:32       ` Andreas Schwab
2019-08-01 15:00         ` Sagar Kadam
2019-07-30  3:42   ` Anup Patel
2019-07-30 17:31     ` Sagar Kadam
2019-07-31  8:20       ` Anup Patel
2019-08-01 14:56         ` Sagar Kadam
2019-08-01 15:56           ` Anup Patel
2019-08-01 17:01             ` Sagar Kadam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmUS9UDSzUsXXTTQ6g-iaNyChX8ZnEUYgFfWkh_g6eoc=Q@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.