From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Thu, 31 Oct 2019 11:01:59 +0800 Subject: [U-Boot] [PATCH 6/8] spl: cache: Allow cache drivers in SPL In-Reply-To: References: <20191025061027.20962-1-uboot@andestech.com> <20191025061027.20962-7-uboot@andestech.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Rick, On Thu, Oct 31, 2019 at 10:53 AM Rick Chen wrote: > > Hi Bin > > > > > Hi Rick, > > > > On Fri, Oct 25, 2019 at 2:18 PM Andes wrote: > > > > > > From: Rick Chen > > > > > > When ax25-ae350 try to enable v5l2 cache > > > driver in SPL configuration, it need this > > > option for cache support in SPL. > > > > > > Signed-off-by: Rick Chen > > > Cc: KC Lin > > > Cc: Alan Kao > > > --- > > > common/spl/Kconfig | 7 +++++++ > > > drivers/Makefile | 1 + > > > 2 files changed, 8 insertions(+) > > > > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > > > index 86d7edf..4c4023a 100644 > > > --- a/common/spl/Kconfig > > > +++ b/common/spl/Kconfig > > > @@ -456,6 +456,13 @@ config SPL_CRYPTO_SUPPORT > > > this option to build the drivers in drivers/crypto as part of an > > > SPL build. > > > > > > +config SPL_CACHE_SUPPORT > > > > nits: please insert this option per alphabetical order, so it should > > come before SPL_CPU > > OK > > > > > > + bool "Support CACHE drivers" > > > + help > > > + Enable CACHE drivers in SPL. These drivers can store data so that > > > + future requests for that data can be served faster. Enable this option > > > > The description here "store data so that ..." does not apply to cache drivers > > Do you have any suggestions about how to describe it more precisely ? > The descriptions says drivers can store data, but cache driver does not store data at all. I think you enabled it just for boot time performance? Regards, Bin