From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Sun, 29 Nov 2015 17:34:33 +0800
Subject: [U-Boot] [PATCH 3/4] qbman_portal.c: Update BUG_ON() call in
	qbman_swp_mc_submit
In-Reply-To: <1448715883-14099-3-git-send-email-trini@konsulko.com>
References: <1448715883-14099-1-git-send-email-trini@konsulko.com>
 <1448715883-14099-3-git-send-email-trini@konsulko.com>
Message-ID: <CAEUhbmUVW=YR5HAvB_TLyyha+cbQ3hPUVgYCCUQYVSvZmo233Q@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, Nov 28, 2015 at 9:04 PM, Tom Rini <trini@konsulko.com> wrote:
> With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and
> becomes BUG_ON((!a) != b).  In this case reading of the function leads to
> us wanting to rewrite this as BUG_ON(a != b).
>
> Cc: Prabhakar Kushwaha <prabhakar@freescale.com>
> Cc: Geoff Thorpe <Geoff.Thorpe@freescale.com>
> Cc: Haiying Wang <Haiying.Wang@freescale.com>
> Cc: Roy Pledge <Roy.Pledge@freescale.com>
> Cc: York Sun <yorksun@freescale.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  drivers/net/fsl-mc/dpio/qbman_portal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c
> index 5fa8d95..449ff8a 100644
> --- a/drivers/net/fsl-mc/dpio/qbman_portal.c
> +++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
> @@ -117,7 +117,7 @@ void qbman_swp_mc_submit(struct qbman_swp *p, void *cmd, uint32_t cmd_verb)
>  {
>         uint32_t *v = cmd;
>  #ifdef QBMAN_CHECKING
> -       BUG_ON(!p->mc.check != swp_mc_can_submit);
> +       BUG_ON(p->mc.check != swp_mc_can_submit);
>  #endif
>         lwsync();
>         /* TBD: "|=" is going to hurt performance. Need to move as many fields
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>