All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] x86: baytrail: pci region 3 is not always mapped to end of ram
Date: Thu, 4 Jun 2015 08:15:51 +0800	[thread overview]
Message-ID: <CAEUhbmU_n8Qm6TYZGMx08co7KSkGFv_8ZJR0iDhSbhh1kFr_pg@mail.gmail.com> (raw)
In-Reply-To: <1433349459-32093-1-git-send-email-andrew@bradfordembedded.com>

On Thu, Jun 4, 2015 at 12:37 AM,  <andrew@bradfordembedded.com> wrote:
> From: Andrew Bradford <andrew.bradford@kodakalaris.com>
>
> Baytrail physically maps the first 2 GB of SDRAM from 0x0 to 0x7FFFFFFF
> and additional SDRAM is mapped from 0x100000000 and up.  There is a
> physical memory hole from 0x80000000 to 0xFFFFFFFF for other uses.
> Because of this, PCI region 3 should only try to use up to the amount of
> SDRAM or 0x80000000, which ever is less.
>
> Signed-off-by: Andrew Bradford <andrew.bradford@kodakalaris.com>
> ---
> v3: Fix build breakage due to semicolon
> v2: limit maximum size to lesser of SDRAM or 0x80000000
> ---
>  arch/x86/cpu/baytrail/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/cpu/baytrail/pci.c b/arch/x86/cpu/baytrail/pci.c
> index 6c291f9..48409de 100644
> --- a/arch/x86/cpu/baytrail/pci.c
> +++ b/arch/x86/cpu/baytrail/pci.c
> @@ -39,7 +39,7 @@ void board_pci_setup_hose(struct pci_controller *hose)
>         pci_set_region(hose->regions + 3,
>                        0,
>                        0,
> -                      gd->ram_size,
> +                      gd->ram_size < 0x80000000 ? gd->ram_size : 0x80000000,
>                        PCI_REGION_MEM | PCI_REGION_SYS_MEMORY);
>
>         hose->region_count = 4;
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

  reply	other threads:[~2015-06-04  0:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 19:09 [U-Boot] [PATCH] x86: baytrail: PCI is not always mapped to end of ram andrew at bradfordembedded.com
2015-05-23 15:50 ` Bin Meng
2015-05-26 12:17   ` Andrew Bradford
2015-05-27  4:21     ` Bin Meng
2015-05-27 11:53       ` Andrew Bradford
2015-05-29  5:00         ` Bin Meng
2015-05-29 18:27           ` Andrew Bradford
2015-05-31  6:10             ` Bin Meng
2015-06-01 12:24               ` Andrew Bradford
2015-06-01 12:58                 ` Bin Meng
2015-06-01 13:44                   ` Andrew Bradford
2015-06-03 16:18 ` [U-Boot] [PATCH v2] x86: baytrail: pci region 3 " andrew at bradfordembedded.com
2015-06-03 16:23   ` Andrew Bradford
2015-06-03 16:37 ` [U-Boot] [PATCH v3] " andrew at bradfordembedded.com
2015-06-04  0:15   ` Bin Meng [this message]
2015-06-04  8:47     ` Simon Glass
2015-06-04 15:16       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmU_n8Qm6TYZGMx08co7KSkGFv_8ZJR0iDhSbhh1kFr_pg@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.