All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] x86: Add SCU IPC driver for Intel MID platforms
Date: Mon, 10 Apr 2017 10:01:19 +0800	[thread overview]
Message-ID: <CAEUhbmUd1-nzihSoS0WiTxXq8D2Ggx9NZjKk5szG0-TnHhetag@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0PriKESdA8kgz=-6yz2EYtA9mcLut=W8bVAyTQr2AqZw@mail.gmail.com>

On Thu, Apr 6, 2017 at 11:44 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Andy,
>
> On 1 April 2017 at 07:21, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> From: Felipe Balbi <felipe.balbi@linux.intel.com>
>>
>> Intel MID platforms have few microcontrollers inside SoC, one of them
>> is so called System Controller Unit (SCU).
>>
>> Here is the driver to communicate with microcontroller.
>>
>> Signed-off-by: Vincent Tinelli <vincent.tinelli@intel.com>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> If you can it is better to put the change log in each patch. Patman can help.
>
> BTW if you end up resending, please use lower-case hex.
>

Fixed the lower-case hex, and one checkpatch warning:

WARNING: line over 80 characters
#82: FILE: arch/x86/include/asm/scu.h:15:
+#define IPCMSG_WATCHDOG_TIMER          0xF8    /* Set Kernel Watchdog
Threshold */

and, applied to u-boot-x86, thanks!

  reply	other threads:[~2017-04-10  2:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 13:21 [U-Boot] [PATCH v3 0/2] x86: SCU and PMU drivers for Intel MID Andy Shevchenko
2017-04-01 13:21 ` [U-Boot] [PATCH v3 1/2] x86: Add SCU IPC driver for Intel MID platforms Andy Shevchenko
2017-04-06  3:44   ` Simon Glass
2017-04-10  2:01     ` Bin Meng [this message]
2017-04-01 13:21 ` [U-Boot] [PATCH v3 2/2] x86: Introduce minimal PMU " Andy Shevchenko
2017-04-06  3:44   ` Simon Glass
2017-04-10  2:01     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmUd1-nzihSoS0WiTxXq8D2Ggx9NZjKk5szG0-TnHhetag@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.